Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/63723/?format=api
{ "id": 63723, "url": "http://patches.dpdk.org/api/patches/63723/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20191210150529.27922-7-kalesh-anakkur.purayil@broadcom.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20191210150529.27922-7-kalesh-anakkur.purayil@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20191210150529.27922-7-kalesh-anakkur.purayil@broadcom.com", "date": "2019-12-10T15:05:29", "name": "[6/6] net/bnxt: add a field for fw capabilities", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "adf6efc63cf07c817e634f58426d1d1b6f0cad69", "submitter": { "id": 1479, "url": "http://patches.dpdk.org/api/people/1479/?format=api", "name": "Kalesh A P", "email": "kalesh-anakkur.purayil@broadcom.com" }, "delegate": { "id": 1766, "url": "http://patches.dpdk.org/api/users/1766/?format=api", "username": "ajitkhaparde", "first_name": "Ajit", "last_name": "Khaparde", "email": "ajit.khaparde@broadcom.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20191210150529.27922-7-kalesh-anakkur.purayil@broadcom.com/mbox/", "series": [ { "id": 7771, "url": "http://patches.dpdk.org/api/series/7771/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=7771", "date": "2019-12-10T15:05:23", "name": "bnxt patchset", "version": 1, "mbox": "http://patches.dpdk.org/series/7771/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/63723/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/63723/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 8E450A04F0;\n\tTue, 10 Dec 2019 15:49:04 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 4F1C21BF82;\n\tTue, 10 Dec 2019 15:48:16 +0100 (CET)", "from relay.smtp.broadcom.com (relay.smtp.broadcom.com\n [192.19.232.149]) by dpdk.org (Postfix) with ESMTP id BF1C91BF70\n for <dev@dpdk.org>; Tue, 10 Dec 2019 15:48:11 +0100 (CET)", "from dhcp-10-123-153-22.dhcp.broadcom.net\n (bgccx-dev-host-lnx2.bec.broadcom.net [10.123.153.22])\n by relay.smtp.broadcom.com (Postfix) with ESMTP id 679231BD7AD;\n Tue, 10 Dec 2019 06:48:10 -0800 (PST)" ], "DKIM-Filter": "OpenDKIM Filter v2.10.3 relay.smtp.broadcom.com 679231BD7AD", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n s=dkimrelay; t=1575989291;\n bh=b3UNlwIk5jUgbMMN0QG//tBj9wGe/NCsTxY5f0QfNvA=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=LNlBzX57jB2oSimcPEoQ5K4ZwKsXrqPsEXFESvQA8D+n7Bm0RQUKG/TDCA5Hmpu42\n KdDQHWmSPNYGjL+WqbLxoVomMZFhSthySDmmU6oZYaH8IKQ1DJDTVJ7d79N44OyvvA\n 5eyPJdhVbUYPesV+IWTCKLGfaBGdLR88bFi9ZnbU=", "From": "Kalesh A P <kalesh-anakkur.purayil@broadcom.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com,\n\tajit.khaparde@broadcom.com", "Date": "Tue, 10 Dec 2019 20:35:29 +0530", "Message-Id": "<20191210150529.27922-7-kalesh-anakkur.purayil@broadcom.com>", "X-Mailer": "git-send-email 2.10.1", "In-Reply-To": "<20191210150529.27922-1-kalesh-anakkur.purayil@broadcom.com>", "References": "<20191210150529.27922-1-kalesh-anakkur.purayil@broadcom.com>", "Subject": "[dpdk-dev] [PATCH 6/6] net/bnxt: add a field for fw capabilities", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>\n\nThe purpose of this patch is used to add a new field \"fw_cap\"\nin bnxt structure. The new \"fw_cap\" field store all the capabilities\nreported by the FW. This information will help us to determine\nthe device capablities when registering feature support with FW.\n\nSigned-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>\nReviewed-by: Ajit Kumar Khaparde <ajit.khaparde@broadcom.com>\n---\n drivers/net/bnxt/bnxt.h | 24 +++++++++++++-----------\n drivers/net/bnxt/bnxt_cpr.c | 2 +-\n drivers/net/bnxt/bnxt_ethdev.c | 4 +++-\n drivers/net/bnxt/bnxt_hwrm.c | 24 +++++++++---------------\n 4 files changed, 26 insertions(+), 28 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt.h b/drivers/net/bnxt/bnxt.h\nindex f9e4d76..ab18e8a 100644\n--- a/drivers/net/bnxt/bnxt.h\n+++ b/drivers/net/bnxt/bnxt.h\n@@ -507,17 +507,13 @@ struct bnxt {\n #define BNXT_FLAG_STINGRAY\t\tBIT(14)\n #define BNXT_FLAG_FW_RESET\t\tBIT(15)\n #define BNXT_FLAG_FATAL_ERROR\t\tBIT(16)\n-#define BNXT_FLAG_FW_CAP_IF_CHANGE\t\tBIT(17)\n-#define BNXT_FLAG_IF_CHANGE_HOT_FW_RESET_DONE\tBIT(18)\n-#define BNXT_FLAG_FW_CAP_ERROR_RECOVERY\t\tBIT(19)\n-#define BNXT_FLAG_FW_HEALTH_CHECK_SCHEDULED\tBIT(20)\n-#define BNXT_FLAG_FW_CAP_ERR_RECOVER_RELOAD\tBIT(21)\n-#define BNXT_FLAG_EXT_STATS_SUPPORTED\t\tBIT(22)\n-#define BNXT_FLAG_NEW_RM\t\t\tBIT(23)\n-#define BNXT_FLAG_INIT_DONE\t\t\tBIT(24)\n-#define BNXT_FLAG_FW_CAP_ONE_STEP_TX_TS\t\tBIT(25)\n-#define BNXT_FLAG_ADV_FLOW_MGMT\t\t\tBIT(26)\n-#define BNXT_FLAG_FW_CAP_HOT_RESET\t\tBIT(27)\n+#define BNXT_FLAG_IF_CHANGE_HOT_FW_RESET_DONE\tBIT(17)\n+#define BNXT_FLAG_FW_HEALTH_CHECK_SCHEDULED\tBIT(18)\n+#define BNXT_FLAG_EXT_STATS_SUPPORTED\t\tBIT(19)\n+#define BNXT_FLAG_NEW_RM\t\t\tBIT(20)\n+#define BNXT_FLAG_INIT_DONE\t\t\tBIT(21)\n+#define BNXT_FLAG_FW_CAP_ONE_STEP_TX_TS\t\tBIT(22)\n+#define BNXT_FLAG_ADV_FLOW_MGMT\t\t\tBIT(23)\n #define BNXT_PF(bp)\t\t(!((bp)->flags & BNXT_FLAG_VF))\n #define BNXT_VF(bp)\t\t((bp)->flags & BNXT_FLAG_VF)\n #define BNXT_NPAR(bp)\t\t((bp)->port_partition_type)\n@@ -531,6 +527,12 @@ struct bnxt {\n #define BNXT_HAS_NQ(bp)\t\tBNXT_CHIP_THOR(bp)\n #define BNXT_HAS_RING_GRPS(bp)\t(!BNXT_CHIP_THOR(bp))\n \n+\tuint32_t\t\tfw_cap;\n+#define BNXT_FW_CAP_HOT_RESET\t\tBIT(0)\n+#define BNXT_FW_CAP_IF_CHANGE\t\tBIT(1)\n+#define BNXT_FW_CAP_ERROR_RECOVERY\tBIT(2)\n+#define BNXT_FW_CAP_ERR_RECOVER_RELOAD\tBIT(3)\n+\n \tuint32_t\t\tflow_flags;\n #define BNXT_FLOW_FLAG_L2_HDR_SRC_FILTER_EN\tBIT(0)\n \tpthread_mutex_t flow_lock;\ndiff --git a/drivers/net/bnxt/bnxt_cpr.c b/drivers/net/bnxt/bnxt_cpr.c\nindex e6f30fe..2c3129f 100644\n--- a/drivers/net/bnxt/bnxt_cpr.c\n+++ b/drivers/net/bnxt/bnxt_cpr.c\n@@ -21,7 +21,7 @@ void bnxt_wait_for_device_shutdown(struct bnxt *bp)\n \t * the SHUTDOWN bit in health register\n \t */\n \tif (!(bp->recovery_info &&\n-\t (bp->flags & BNXT_FLAG_FW_CAP_ERR_RECOVER_RELOAD)))\n+\t (bp->fw_cap & BNXT_FW_CAP_ERR_RECOVER_RELOAD)))\n \t\treturn;\n \n \t/* Driver has to wait for fw_reset_max_msecs or shutdown bit which comes\ndiff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c\nindex 146f04b..1b4ed29 100644\n--- a/drivers/net/bnxt/bnxt_ethdev.c\n+++ b/drivers/net/bnxt/bnxt_ethdev.c\n@@ -4617,6 +4617,8 @@ static int bnxt_init_fw(struct bnxt *bp)\n \tuint16_t mtu;\n \tint rc = 0;\n \n+\tbp->fw_cap = 0;\n+\n \trc = bnxt_hwrm_ver_get(bp);\n \tif (rc)\n \t\treturn rc;\n@@ -4652,7 +4654,7 @@ static int bnxt_init_fw(struct bnxt *bp)\n \t/* Get the adapter error recovery support info */\n \trc = bnxt_hwrm_error_recovery_qcfg(bp);\n \tif (rc)\n-\t\tbp->flags &= ~BNXT_FLAG_FW_CAP_ERROR_RECOVERY;\n+\t\tbp->fw_cap &= ~BNXT_FW_CAP_ERROR_RECOVERY;\n \n \tbnxt_hwrm_port_led_qcaps(bp);\n \ndiff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c\nindex d30da9b..d0dcd56 100644\n--- a/drivers/net/bnxt/bnxt_hwrm.c\n+++ b/drivers/net/bnxt/bnxt_hwrm.c\n@@ -661,21 +661,15 @@ static int __bnxt_hwrm_func_qcaps(struct bnxt *bp)\n \t\tbp->flags |= BNXT_FLAG_EXT_STATS_SUPPORTED;\n \n \tif (flags & HWRM_FUNC_QCAPS_OUTPUT_FLAGS_ERROR_RECOVERY_CAPABLE) {\n-\t\tbp->flags |= BNXT_FLAG_FW_CAP_ERROR_RECOVERY;\n+\t\tbp->fw_cap |= BNXT_FW_CAP_ERROR_RECOVERY;\n \t\tPMD_DRV_LOG(DEBUG, \"Adapter Error recovery SUPPORTED\\n\");\n-\t} else {\n-\t\tbp->flags &= ~BNXT_FLAG_FW_CAP_ERROR_RECOVERY;\n \t}\n \n \tif (flags & HWRM_FUNC_QCAPS_OUTPUT_FLAGS_ERR_RECOVER_RELOAD)\n-\t\tbp->flags |= BNXT_FLAG_FW_CAP_ERR_RECOVER_RELOAD;\n-\telse\n-\t\tbp->flags &= ~BNXT_FLAG_FW_CAP_ERR_RECOVER_RELOAD;\n+\t\tbp->fw_cap |= BNXT_FW_CAP_ERR_RECOVER_RELOAD;\n \n \tif (flags & HWRM_FUNC_QCAPS_OUTPUT_FLAGS_HOT_RESET_CAPABLE)\n-\t\tbp->flags |= BNXT_FLAG_FW_CAP_HOT_RESET;\n-\telse\n-\t\tbp->flags &= ~BNXT_FLAG_FW_CAP_HOT_RESET;\n+\t\tbp->fw_cap |= BNXT_FW_CAP_HOT_RESET;\n \n \tHWRM_UNLOCK();\n \n@@ -761,9 +755,9 @@ int bnxt_hwrm_func_driver_register(struct bnxt *bp)\n \tif (bp->flags & BNXT_FLAG_REGISTERED)\n \t\treturn 0;\n \n-\tif (bp->flags & BNXT_FLAG_FW_CAP_HOT_RESET)\n+\tif (bp->fw_cap & BNXT_FW_CAP_HOT_RESET)\n \t\tflags = HWRM_FUNC_DRV_RGTR_INPUT_FLAGS_HOT_RESET_SUPPORT;\n-\tif (bp->flags & BNXT_FLAG_FW_CAP_ERROR_RECOVERY)\n+\tif (bp->fw_cap & BNXT_FW_CAP_ERROR_RECOVERY)\n \t\tflags |= HWRM_FUNC_DRV_RGTR_INPUT_FLAGS_ERROR_RECOVERY_SUPPORT;\n \n \t/* PFs and trusted VFs should indicate the support of the\n@@ -803,7 +797,7 @@ int bnxt_hwrm_func_driver_register(struct bnxt *bp)\n \t\t\t\t ASYNC_CMPL_EVENT_ID_LINK_SPEED_CFG_CHANGE |\n \t\t\t\t ASYNC_CMPL_EVENT_ID_LINK_SPEED_CHANGE |\n \t\t\t\t ASYNC_CMPL_EVENT_ID_RESET_NOTIFY);\n-\tif (bp->flags & BNXT_FLAG_FW_CAP_ERROR_RECOVERY)\n+\tif (bp->fw_cap & BNXT_FW_CAP_ERROR_RECOVERY)\n \t\treq.async_event_fwd[0] |=\n \t\t\trte_cpu_to_le_32(ASYNC_CMPL_EVENT_ID_ERROR_RECOVERY);\n \treq.async_event_fwd[1] |=\n@@ -816,7 +810,7 @@ int bnxt_hwrm_func_driver_register(struct bnxt *bp)\n \n \tflags = rte_le_to_cpu_32(resp->flags);\n \tif (flags & HWRM_FUNC_DRV_RGTR_OUTPUT_FLAGS_IF_CHANGE_SUPPORTED)\n-\t\tbp->flags |= BNXT_FLAG_FW_CAP_IF_CHANGE;\n+\t\tbp->fw_cap |= BNXT_FW_CAP_IF_CHANGE;\n \n \tHWRM_UNLOCK();\n \n@@ -4849,7 +4843,7 @@ int bnxt_hwrm_if_change(struct bnxt *bp, bool up)\n \tuint32_t flags;\n \tint rc;\n \n-\tif (!(bp->flags & BNXT_FLAG_FW_CAP_IF_CHANGE))\n+\tif (!(bp->fw_cap & BNXT_FW_CAP_IF_CHANGE))\n \t\treturn 0;\n \n \t/* Do not issue FUNC_DRV_IF_CHANGE during reset recovery.\n@@ -4892,7 +4886,7 @@ int bnxt_hwrm_error_recovery_qcfg(struct bnxt *bp)\n \tint rc;\n \n \t/* Older FW does not have error recovery support */\n-\tif (!(bp->flags & BNXT_FLAG_FW_CAP_ERROR_RECOVERY))\n+\tif (!(bp->fw_cap & BNXT_FW_CAP_ERROR_RECOVERY))\n \t\treturn 0;\n \n \tif (!info) {\n", "prefixes": [ "6/6" ] }