Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/63722/?format=api
{ "id": 63722, "url": "http://patches.dpdk.org/api/patches/63722/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20191210150529.27922-6-kalesh-anakkur.purayil@broadcom.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20191210150529.27922-6-kalesh-anakkur.purayil@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20191210150529.27922-6-kalesh-anakkur.purayil@broadcom.com", "date": "2019-12-10T15:05:28", "name": "[5/6] net/bnxt: reset filter indices on free", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "19bc24ef36bb9f379d0736873280dc94814171c8", "submitter": { "id": 1479, "url": "http://patches.dpdk.org/api/people/1479/?format=api", "name": "Kalesh A P", "email": "kalesh-anakkur.purayil@broadcom.com" }, "delegate": { "id": 1766, "url": "http://patches.dpdk.org/api/users/1766/?format=api", "username": "ajitkhaparde", "first_name": "Ajit", "last_name": "Khaparde", "email": "ajit.khaparde@broadcom.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20191210150529.27922-6-kalesh-anakkur.purayil@broadcom.com/mbox/", "series": [ { "id": 7771, "url": "http://patches.dpdk.org/api/series/7771/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=7771", "date": "2019-12-10T15:05:23", "name": "bnxt patchset", "version": 1, "mbox": "http://patches.dpdk.org/series/7771/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/63722/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/63722/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 5B5E5A04F0;\n\tTue, 10 Dec 2019 15:48:54 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id AE6221BF7B;\n\tTue, 10 Dec 2019 15:48:14 +0100 (CET)", "from relay.smtp.broadcom.com (unknown [192.19.232.149])\n by dpdk.org (Postfix) with ESMTP id 1F4D81BEDE\n for <dev@dpdk.org>; Tue, 10 Dec 2019 15:48:10 +0100 (CET)", "from dhcp-10-123-153-22.dhcp.broadcom.net\n (bgccx-dev-host-lnx2.bec.broadcom.net [10.123.153.22])\n by relay.smtp.broadcom.com (Postfix) with ESMTP id B71AD1BD7CE;\n Tue, 10 Dec 2019 06:48:08 -0800 (PST)" ], "DKIM-Filter": "OpenDKIM Filter v2.10.3 relay.smtp.broadcom.com B71AD1BD7CE", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n s=dkimrelay; t=1575989289;\n bh=B/aKql08vICQd72fPZG5afrhepCKmhYJAMMIYQfpoog=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=Ov+E3xuWyvYGCQFrUv3usYYIZ2EXh0b5gP76Isj3/vNBBW0ov9DS31vlysRBkTd49\n oCy0j1cIrQ0pbAhp6+b8jM22T21jgSFbh2xk06QcHZLlH9Pe7cH2yPZcWA2RAkBVc0\n IMW+Svfvvi7f7NI+9nktME00vxc8CPsY4O0pty+Q=", "From": "Kalesh A P <kalesh-anakkur.purayil@broadcom.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com,\n\tajit.khaparde@broadcom.com", "Date": "Tue, 10 Dec 2019 20:35:28 +0530", "Message-Id": "<20191210150529.27922-6-kalesh-anakkur.purayil@broadcom.com>", "X-Mailer": "git-send-email 2.10.1", "In-Reply-To": "<20191210150529.27922-1-kalesh-anakkur.purayil@broadcom.com>", "References": "<20191210150529.27922-1-kalesh-anakkur.purayil@broadcom.com>", "Subject": "[dpdk-dev] [PATCH 5/6] net/bnxt: reset filter indices on free", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>\n\nFix bnxt_free_filter() to ensure that the filter indices\nare reset correctly when a filter is freed.\n\nThis change helps in avoiding few duplicate code as well.\n\nSigned-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>\nReviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>\nReviewed-by: Ajit Kumar Khaparde <ajit.khaparde@broadcom.com>\n---\n drivers/net/bnxt/bnxt_ethdev.c | 10 ----------\n drivers/net/bnxt/bnxt_filter.c | 5 +++++\n drivers/net/bnxt/bnxt_flow.c | 1 -\n 3 files changed, 5 insertions(+), 11 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c\nindex 2f84794..146f04b 100644\n--- a/drivers/net/bnxt/bnxt_ethdev.c\n+++ b/drivers/net/bnxt/bnxt_ethdev.c\n@@ -1007,8 +1007,6 @@ static void bnxt_mac_addr_remove_op(struct rte_eth_dev *eth_dev,\n \t\t\t\tSTAILQ_REMOVE(&vnic->filter, filter,\n \t\t\t\t\t\tbnxt_filter_info, next);\n \t\t\t\tbnxt_hwrm_clear_l2_filter(bp, filter);\n-\t\t\t\tfilter->mac_index = INVALID_MAC_INDEX;\n-\t\t\t\tmemset(&filter->l2_addr, 0, RTE_ETHER_ADDR_LEN);\n \t\t\t\tbnxt_free_filter(bp, filter);\n \t\t\t}\n \t\t\tfilter = temp_filter;\n@@ -1055,7 +1053,6 @@ static int bnxt_add_mac_filter(struct bnxt *bp, struct bnxt_vnic_info *vnic,\n \t\telse\n \t\t\tSTAILQ_INSERT_TAIL(&vnic->filter, filter, next);\n \t} else {\n-\t\tmemset(&filter->l2_addr, 0, RTE_ETHER_ADDR_LEN);\n \t\tbnxt_free_filter(bp, filter);\n \t}\n \n@@ -1781,7 +1778,6 @@ static int bnxt_add_vlan_filter(struct bnxt *bp, uint16_t vlan_id)\n \t\t/* Free the newly allocated filter as we were\n \t\t * not able to create the filter in hardware.\n \t\t */\n-\t\tfilter->fw_l2_filter_id = UINT64_MAX;\n \t\tbnxt_free_filter(bp, filter);\n \t\treturn rc;\n \t}\n@@ -1831,7 +1827,6 @@ static int bnxt_del_dflt_mac_filter(struct bnxt *bp,\n \t\t\t\tSTAILQ_REMOVE(&vnic->filter, filter,\n \t\t\t\t\t bnxt_filter_info, next);\n \t\t\t\tbnxt_free_filter(bp, filter);\n-\t\t\t\tfilter->fw_l2_filter_id = UINT64_MAX;\n \t\t\t}\n \t\t\treturn rc;\n \t\t}\n@@ -2705,14 +2700,11 @@ bnxt_cfg_ntuple_filter(struct bnxt *bp,\n \n \t\tSTAILQ_REMOVE(&vnic->filter, mfilter, bnxt_filter_info, next);\n \t\tbnxt_free_filter(bp, mfilter);\n-\t\tmfilter->fw_l2_filter_id = -1;\n \t\tbnxt_free_filter(bp, bfilter);\n-\t\tbfilter->fw_l2_filter_id = -1;\n \t}\n \n \treturn 0;\n free_filter:\n-\tbfilter->fw_l2_filter_id = -1;\n \tbnxt_free_filter(bp, bfilter);\n \treturn ret;\n }\n@@ -3110,7 +3102,6 @@ bnxt_fdir_filter(struct rte_eth_dev *dev,\n \t\t\tSTAILQ_REMOVE(&vnic->filter, match,\n \t\t\t\t bnxt_filter_info, next);\n \t\t\tbnxt_free_filter(bp, match);\n-\t\t\tfilter->fw_l2_filter_id = -1;\n \t\t\tbnxt_free_filter(bp, filter);\n \t\t}\n \t\tbreak;\n@@ -3143,7 +3134,6 @@ bnxt_fdir_filter(struct rte_eth_dev *dev,\n \treturn ret;\n \n free_filter:\n-\tfilter->fw_l2_filter_id = -1;\n \tbnxt_free_filter(bp, filter);\n \treturn ret;\n }\ndiff --git a/drivers/net/bnxt/bnxt_filter.c b/drivers/net/bnxt/bnxt_filter.c\nindex da1a6c2..0c410f8 100644\n--- a/drivers/net/bnxt/bnxt_filter.c\n+++ b/drivers/net/bnxt/bnxt_filter.c\n@@ -192,5 +192,10 @@ struct bnxt_filter_info *bnxt_get_unused_filter(struct bnxt *bp)\n \n void bnxt_free_filter(struct bnxt *bp, struct bnxt_filter_info *filter)\n {\n+\tmemset(filter, 0, sizeof(*filter));\n+\tfilter->mac_index = INVALID_MAC_INDEX;\n+\tfilter->fw_l2_filter_id = UINT64_MAX;\n+\tfilter->fw_ntuple_filter_id = UINT64_MAX;\n+\tfilter->fw_em_filter_id = UINT64_MAX;\n \tSTAILQ_INSERT_TAIL(&bp->free_filter_list, filter, next);\n }\ndiff --git a/drivers/net/bnxt/bnxt_flow.c b/drivers/net/bnxt/bnxt_flow.c\nindex 447a51b..7bd6811 100644\n--- a/drivers/net/bnxt/bnxt_flow.c\n+++ b/drivers/net/bnxt/bnxt_flow.c\n@@ -1521,7 +1521,6 @@ bnxt_flow_validate(struct rte_eth_dev *dev,\n \n exit:\n \t/* No need to hold on to this filter if we are just validating flow */\n-\tfilter->fw_l2_filter_id = UINT64_MAX;\n \tbnxt_free_filter(bp, filter);\n \tbnxt_release_flow_lock(bp);\n \n", "prefixes": [ "5/6" ] }