Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/63662/?format=api
{ "id": 63662, "url": "http://patches.dpdk.org/api/patches/63662/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1575819342-20008-7-git-send-email-mchalla@marvell.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1575819342-20008-7-git-send-email-mchalla@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1575819342-20008-7-git-send-email-mchalla@marvell.com", "date": "2019-12-08T15:35:42", "name": "[v1,6/6] raw/octeontx2_ep: add driver self test", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "1aed2391b4f77e390d3e2216d212a20559dc9c37", "submitter": { "id": 1532, "url": "http://patches.dpdk.org/api/people/1532/?format=api", "name": "Mahipal Challa", "email": "mchalla@marvell.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1575819342-20008-7-git-send-email-mchalla@marvell.com/mbox/", "series": [ { "id": 7751, "url": "http://patches.dpdk.org/api/series/7751/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=7751", "date": "2019-12-08T15:35:36", "name": "OCTEON TX2 End Point Driver", "version": 1, "mbox": "http://patches.dpdk.org/series/7751/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/63662/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/63662/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 16AE9A04F1;\n\tSun, 8 Dec 2019 16:37:16 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 06FD61BFB6;\n\tSun, 8 Dec 2019 16:36:23 +0100 (CET)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 51FFB1BFA8\n for <dev@dpdk.org>; Sun, 8 Dec 2019 16:36:21 +0100 (CET)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id\n xB8FUjrU028954 for <dev@dpdk.org>; Sun, 8 Dec 2019 07:36:20 -0800", "from sc-exch02.marvell.com ([199.233.58.182])\n by mx0b-0016f401.pphosted.com with ESMTP id 2wrcfpts21-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT)\n for <dev@dpdk.org>; Sun, 08 Dec 2019 07:36:20 -0800", "from SC-EXCH03.marvell.com (10.93.176.83) by SC-EXCH02.marvell.com\n (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Sun, 8 Dec\n 2019 07:36:18 -0800", "from maili.marvell.com (10.93.176.43) by SC-EXCH03.marvell.com\n (10.93.176.83) with Microsoft SMTP Server id 15.0.1367.3 via Frontend\n Transport; Sun, 8 Dec 2019 07:36:19 -0800", "from hyd1244.marvell.com (hyd1244.marvell.com [10.29.20.28])\n by maili.marvell.com (Postfix) with ESMTP id 259AE3F7040;\n Sun, 8 Dec 2019 07:36:16 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-type; s=pfpt0818; bh=ASWKbjvOkaTnW1otNXMJmsHt/qnZh+y5JM6JgD4fAGs=;\n b=kEF97pcTZrGqktEE5F1xzgMbWBHTXc5b2tetJqBdBLpi0LdYBNjWplvV/tHxLjSpg1C4\n 7vg1lDCv5P1zkZVDUlJifP/VFf119RceEFxzv4VdLRSRaezID+1PUwisPCTw5QA0hTu/\n oQeH+inkUOYFIPFqf88VCuVWCitGn9bxW3SZMheg6kBaNU/yRnJAKCQpJ0UX5rIOvO47\n jtHVBrCGdMrAmMoMI4eOj7gy9mtI3+nmwnQVOwWaDjTssQ2LiJ9Qm7rk8kNsv8n5y9UE\n 6Hb4x99qkrvueR8zGg/qHbCZE5Svs4Ig9yi08bnbEaatxY1UprBj9a7FjErErklDTUrb YQ==", "From": "Mahipal Challa <mchalla@marvell.com>", "To": "<dev@dpdk.org>", "CC": "<jerinj@marvell.com>, <pathreya@marvell.com>, <snilla@marvell.com>,\n <venkatn@marvell.com>", "Date": "Sun, 8 Dec 2019 21:05:42 +0530", "Message-ID": "<1575819342-20008-7-git-send-email-mchalla@marvell.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1575819342-20008-1-git-send-email-mchalla@marvell.com>", "References": "<1575819342-20008-1-git-send-email-mchalla@marvell.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10434:6.0.95,18.0.572\n definitions=2019-12-08_04:2019-12-05,2019-12-08 signatures=0", "Subject": "[dpdk-dev] [PATCH v1 6/6] raw/octeontx2_ep: add driver self test", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Add rawdev's selftest feature in SDP VF driver, which\nverifies the EP mode functionality test.\n\nSigned-off-by: Mahipal Challa <mchalla@marvell.com>\n---\n doc/guides/rawdevs/octeontx2_ep.rst | 13 +++\n drivers/raw/octeontx2_ep/Makefile | 1 +\n drivers/raw/octeontx2_ep/meson.build | 1 +\n drivers/raw/octeontx2_ep/otx2_ep_rawdev.c | 1 +\n drivers/raw/octeontx2_ep/otx2_ep_rawdev.h | 2 +\n drivers/raw/octeontx2_ep/otx2_ep_test.c | 164 ++++++++++++++++++++++++++++++\n 6 files changed, 182 insertions(+)", "diff": "diff --git a/doc/guides/rawdevs/octeontx2_ep.rst b/doc/guides/rawdevs/octeontx2_ep.rst\nindex 39a7c29..bbcf530 100644\n--- a/doc/guides/rawdevs/octeontx2_ep.rst\n+++ b/doc/guides/rawdevs/octeontx2_ep.rst\n@@ -74,3 +74,16 @@ Performing Data Transfer\n To perform data transfer using SDP VF EP rawdev devices use standard\n ``rte_rawdev_enqueue_buffers()`` and ``rte_rawdev_dequeue_buffers()`` APIs.\n \n+Self test\n+---------\n+\n+On EAL initialization, SDP VF devices will be probed and populated into the\n+raw devices. The rawdev ID of the device can be obtained using\n+\n+* Invoke ``rte_rawdev_get_dev_id(\"SDPEP:x\")`` from the test application\n+ where x is the VF device's bus id specified in \"bus:device.func\"(BDF)\n+ format. Use this index for further rawdev function calls.\n+\n+* The driver's selftest rawdev API can be used to verify the SDP EP mode\n+ functional tests which can send/receive the raw data packets to/from the\n+ EP device.\ndiff --git a/drivers/raw/octeontx2_ep/Makefile b/drivers/raw/octeontx2_ep/Makefile\nindex 02853fb..44fdf89 100644\n--- a/drivers/raw/octeontx2_ep/Makefile\n+++ b/drivers/raw/octeontx2_ep/Makefile\n@@ -37,6 +37,7 @@ LIBABIVER := 1\n #\n SRCS-$(CONFIG_RTE_LIBRTE_PMD_OCTEONTX2_EP_RAWDEV) += otx2_ep_rawdev.c\n SRCS-$(CONFIG_RTE_LIBRTE_PMD_OCTEONTX2_EP_RAWDEV) += otx2_ep_enqdeq.c\n+SRCS-$(CONFIG_RTE_LIBRTE_PMD_OCTEONTX2_EP_RAWDEV) += otx2_ep_test.c\n SRCS-$(CONFIG_RTE_LIBRTE_PMD_OCTEONTX2_EP_RAWDEV) += otx2_ep_vf.c\n \n \ndiff --git a/drivers/raw/octeontx2_ep/meson.build b/drivers/raw/octeontx2_ep/meson.build\nindex 99e6c6d..0e6338f 100644\n--- a/drivers/raw/octeontx2_ep/meson.build\n+++ b/drivers/raw/octeontx2_ep/meson.build\n@@ -5,4 +5,5 @@\n deps += ['bus_pci', 'common_octeontx2', 'rawdev']\n sources = files('otx2_ep_rawdev.c',\n \t\t'otx2_ep_enqdeq.c',\n+\t\t'otx2_ep_test.c',\n \t\t'otx2_ep_vf.c')\ndiff --git a/drivers/raw/octeontx2_ep/otx2_ep_rawdev.c b/drivers/raw/octeontx2_ep/otx2_ep_rawdev.c\nindex ddb208d..c5c0cf3 100644\n--- a/drivers/raw/octeontx2_ep/otx2_ep_rawdev.c\n+++ b/drivers/raw/octeontx2_ep/otx2_ep_rawdev.c\n@@ -253,6 +253,7 @@\n \t.dev_close = sdp_rawdev_close,\n \t.enqueue_bufs = sdp_rawdev_enqueue,\n \t.dequeue_bufs = sdp_rawdev_dequeue,\n+\t.dev_selftest = sdp_rawdev_selftest,\n };\n \n static int\ndiff --git a/drivers/raw/octeontx2_ep/otx2_ep_rawdev.h b/drivers/raw/octeontx2_ep/otx2_ep_rawdev.h\nindex a77cbab..dab2fb7 100644\n--- a/drivers/raw/octeontx2_ep/otx2_ep_rawdev.h\n+++ b/drivers/raw/octeontx2_ep/otx2_ep_rawdev.h\n@@ -494,4 +494,6 @@ int sdp_rawdev_enqueue(struct rte_rawdev *dev, struct rte_rawdev_buf **buffers,\n int sdp_rawdev_dequeue(struct rte_rawdev *dev, struct rte_rawdev_buf **buffers,\n \t\t unsigned int count, rte_rawdev_obj_t context);\n \n+int sdp_rawdev_selftest(uint16_t dev_id);\n+\n #endif /* _OTX2_EP_RAWDEV_H_ */\ndiff --git a/drivers/raw/octeontx2_ep/otx2_ep_test.c b/drivers/raw/octeontx2_ep/otx2_ep_test.c\nnew file mode 100644\nindex 0000000..96fedb5\n--- /dev/null\n+++ b/drivers/raw/octeontx2_ep/otx2_ep_test.c\n@@ -0,0 +1,164 @@\n+/* SPDX-License-Identifier: BSD-3-Clause\n+ * Copyright(C) 2019 Marvell International Ltd.\n+ */\n+\n+#include <stdio.h>\n+#include <stdlib.h>\n+#include <string.h>\n+#include <unistd.h>\n+\n+#include <rte_common.h>\n+#include <rte_eal.h>\n+#include <rte_lcore.h>\n+#include <rte_mempool.h>\n+\n+#include <rte_rawdev.h>\n+#include <rte_rawdev_pmd.h>\n+\n+#include \"otx2_common.h\"\n+#include \"otx2_ep_rawdev.h\"\n+\n+#define SDP_IOQ_NUM_BUFS (4 * 1024)\n+#define SDP_IOQ_BUF_SIZE (2 * 1024)\n+\n+#define SDP_TEST_PKT_FSZ (0)\n+#define SDP_TEST_PKT_SIZE (1024)\n+\n+static int\n+sdp_validate_data(struct sdp_droq_pkt *oq_pkt, uint8_t *iq_pkt,\n+\t\t uint32_t pkt_len)\n+{\n+\tif (!oq_pkt)\n+\t\treturn -EINVAL;\n+\n+\tif (pkt_len != oq_pkt->len) {\n+\t\totx2_err(\"Invalid packet length\");\n+\t\treturn -EINVAL;\n+\t}\n+\n+\tif (memcmp(oq_pkt->data, iq_pkt, pkt_len) != 0) {\n+\t\totx2_err(\"Data validation failed\");\n+\t\treturn -EINVAL;\n+\t}\n+\totx2_sdp_dbg(\"Data validation successful\");\n+\n+\treturn 0;\n+}\n+\n+static void\n+sdp_ioq_buffer_fill(uint8_t *addr, uint32_t len)\n+{\n+\tuint32_t idx;\n+\n+\tmemset(addr, 0, len);\n+\n+\tfor (idx = 0; idx < len; idx++)\n+\t\taddr[idx] = idx;\n+}\n+\n+static struct rte_mempool*\n+sdp_ioq_mempool_create(void)\n+{\n+\tstruct rte_mempool *mpool;\n+\n+\tmpool = rte_mempool_create(\"ioqbuf_pool\",\n+\t\t\t\t SDP_IOQ_NUM_BUFS /*num elt*/,\n+\t\t\t\t SDP_IOQ_BUF_SIZE /*elt size*/,\n+\t\t\t\t 0 /*cache_size*/,\n+\t\t\t\t 0 /*private_data_size*/,\n+\t\t\t\t NULL /*mp_init*/,\n+\t\t\t\t NULL /*mp_init arg*/,\n+\t\t\t\t NULL /*obj_init*/,\n+\t\t\t\t NULL /*obj_init arg*/,\n+\t\t\t\t rte_socket_id() /*socket id*/,\n+\t\t\t\t (MEMPOOL_F_SP_PUT | MEMPOOL_F_SC_GET));\n+\n+\treturn mpool;\n+}\n+\n+\n+int\n+sdp_rawdev_selftest(uint16_t dev_id)\n+{\n+\tstruct sdp_rawdev_info app_info = {0};\n+\tstruct rte_rawdev_info dev_info = {0};\n+\n+\tstruct rte_rawdev_buf *d_buf[1];\n+\tstruct sdp_droq_pkt oq_pkt;\n+\tstruct sdp_soft_instr si;\n+\tstruct sdp_device sdpvf;\n+\n+\tuint32_t buf_size;\n+\tint ret = 0;\n+\tvoid *buf;\n+\n+\totx2_info(\"SDP RAWDEV Self Test: Started\");\n+\n+\tmemset(&oq_pkt, 0x00, sizeof(oq_pkt));\n+\td_buf[0] = (struct rte_rawdev_buf *)&oq_pkt;\n+\n+\tstruct rte_mempool *ioq_mpool = sdp_ioq_mempool_create();\n+\tif (!ioq_mpool) {\n+\t\totx2_err(\"IOQ mpool creation failed\");\n+\t\treturn -ENOMEM;\n+\t}\n+\n+\tapp_info.enqdeq_mpool = ioq_mpool;\n+\tapp_info.app_conf = NULL; /* Use default conf */\n+\n+\tdev_info.dev_private = &app_info;\n+\n+\tret = rte_rawdev_configure(dev_id, &dev_info);\n+\tif (ret) {\n+\t\totx2_err(\"Unable to configure SDP_VF %d\", dev_id);\n+\t\treturn -ENOMEM;\n+\t}\n+\totx2_info(\"SDP VF rawdev[%d] configured successfully\", dev_id);\n+\n+\tmemset(&si, 0x00, sizeof(si));\n+\tmemset(&sdpvf, 0x00, sizeof(sdpvf));\n+\n+\tbuf_size = SDP_TEST_PKT_SIZE;\n+\n+\tsi.q_no = 0;\n+\tsi.reqtype = SDP_REQTYPE_NORESP;\n+\tsi.rptr = NULL;\n+\n+\tsi.ih.fsz = SDP_TEST_PKT_FSZ;\n+\tsi.ih.tlen = buf_size;\n+\tsi.ih.gather = 0;\n+\n+\t/* Enqueue raw pkt data */\n+\trte_mempool_get(ioq_mpool, &buf);\n+\tif (!buf) {\n+\t\totx2_err(\"Buffer allocation failed\");\n+\t\treturn -ENOMEM;\n+\t}\n+\n+\tsdp_ioq_buffer_fill(buf, buf_size);\n+\tsi.dptr = (uint8_t *)buf;\n+\n+\trte_rawdev_enqueue_buffers(dev_id, NULL, 1, &si);\n+\tusleep(10000);\n+\n+\t/* Dequeue raw pkt data */\n+\tret = 0;\n+\twhile (ret < 1) {\n+\t\tret = rte_rawdev_dequeue_buffers(dev_id, &d_buf[0], 1, &si);\n+\t\trte_pause();\n+\t}\n+\n+\t/* Validate the dequeued raw pkt data */\n+\tif (sdp_validate_data((struct sdp_droq_pkt *)d_buf[0],\n+\t\t\t buf, buf_size) != 0) {\n+\t\totx2_err(\"Data invalid\");\n+\t\treturn -EINVAL;\n+\t}\n+\n+\trte_mempool_put(ioq_mpool, ((struct sdp_droq_pkt *)d_buf[0])->data);\n+\n+\totx2_info(\"SDP RAWDEV Self Test: Successful\");\n+\n+\treturn 0;\n+}\n+\n", "prefixes": [ "v1", "6/6" ] }