Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/63598/?format=api
{ "id": 63598, "url": "http://patches.dpdk.org/api/patches/63598/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1575560280-3261-3-git-send-email-anoobj@marvell.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1575560280-3261-3-git-send-email-anoobj@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1575560280-3261-3-git-send-email-anoobj@marvell.com", "date": "2019-12-05T15:37:58", "name": "[2/4] crypto/octeontx: add EC Point Mul support", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "917a511c1fd015560ee2dc0798aba4644fbdbb42", "submitter": { "id": 1205, "url": "http://patches.dpdk.org/api/people/1205/?format=api", "name": "Anoob Joseph", "email": "anoobj@marvell.com" }, "delegate": { "id": 6690, "url": "http://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1575560280-3261-3-git-send-email-anoobj@marvell.com/mbox/", "series": [ { "id": 7739, "url": "http://patches.dpdk.org/api/series/7739/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=7739", "date": "2019-12-05T15:37:56", "name": "add ECPM support", "version": 1, "mbox": "http://patches.dpdk.org/series/7739/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/63598/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/63598/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 83B48A04F2;\n\tThu, 5 Dec 2019 16:39:47 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 0B6D01BF97;\n\tThu, 5 Dec 2019 16:39:34 +0100 (CET)", "from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com\n [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 730871BF92\n for <dev@dpdk.org>; Thu, 5 Dec 2019 16:39:32 +0100 (CET)", "from pps.filterd (m0045849.ppops.net [127.0.0.1])\n by mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id\n xB5FaBmC028491; Thu, 5 Dec 2019 07:39:31 -0800", "from sc-exch01.marvell.com ([199.233.58.181])\n by mx0a-0016f401.pphosted.com with ESMTP id 2wpywp140t-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);\n Thu, 05 Dec 2019 07:39:31 -0800", "from SC-EXCH01.marvell.com (10.93.176.81) by SC-EXCH01.marvell.com\n (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Thu, 5 Dec\n 2019 07:39:30 -0800", "from maili.marvell.com (10.93.176.43) by SC-EXCH01.marvell.com\n (10.93.176.81) with Microsoft SMTP Server id 15.0.1367.3 via Frontend\n Transport; Thu, 5 Dec 2019 07:39:30 -0800", "from ajoseph83.caveonetworks.com.com (unknown [10.29.45.60])\n by maili.marvell.com (Postfix) with ESMTP id 3A0EA3F7041;\n Thu, 5 Dec 2019 07:39:25 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0818;\n bh=8L+i69wSfsb86NAv3c/UzrQqcLGZP8WfQZfpDZTtUYI=;\n b=m7hJ+IoZlDuCFLbt9yhZoJdfSaZzJRJiVef9ccptYoR7tejZGY3qGq1MyDlfe/DwzXaa\n zmRL/hl1RFR9Gk2s1dTsLT9q1UsQ2dfOU4vBoRkmLuxyKAuFcjAM68lQhGhXkAcVBQSz\n aX6xkovYoD4BT8UCaENBlmVon2wTNg6W3tjOwy0AcWY8bJ/7saY2huRjMwG54PLGcJhQ\n jAsUELSsoc+C0/rhXP7p2GZTZ2dCOEqwqwsrXYmy0fumiEu9vOWAcEfV+ASsZF0/Hzz+\n r3m0WpIUYJjwfGsE5ZU2N7nL//vTI+7+xlwcgf3pyQHK0gIf437LWMgMCMh2YUnl8IZj WA==", "From": "Anoob Joseph <anoobj@marvell.com>", "To": "Akhil Goyal <akhil.goyal@nxp.com>, Declan Doherty\n <declan.doherty@intel.com>, Pablo de Lara <pablo.de.lara.guarch@intel.com>", "CC": "Sunila Sahu <ssahu@marvell.com>, Fiona Trahe <fiona.trahe@intel.com>,\n \"Arek Kusztal\" <arkadiuszx.kusztal@intel.com>, Jerin Jacob\n <jerinj@marvell.com>, Narayana Prasad <pathreya@marvell.com>, Shally Verma\n <shallyv@marvell.com>,\n Ankur Dwivedi <adwivedi@marvell.com>, <dev@dpdk.org>,\n Anoob Joseph <anoobj@marvell.com>, Balakrishna Bhamidipati\n <bbhamidipati@marvell.com>", "Date": "Thu, 5 Dec 2019 21:07:58 +0530", "Message-ID": "<1575560280-3261-3-git-send-email-anoobj@marvell.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1575560280-3261-1-git-send-email-anoobj@marvell.com>", "References": "<1575560280-3261-1-git-send-email-anoobj@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10434:6.0.95,18.0.572\n definitions=2019-12-05_03:2019-12-04,2019-12-05 signatures=0", "Subject": "[dpdk-dev] [PATCH 2/4] crypto/octeontx: add EC Point Mul support", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Sunila Sahu <ssahu@marvell.com>\n\nAdding support for EC Point Multiplication operation in crypto_octeontx\nPMD.\n\nSigned-off-by: Anoob Joseph <anoobj@marvell.com>\nSigned-off-by: Balakrishna Bhamidipati <bbhamidipati@marvell.com>\nSigned-off-by: Sunila Sahu <ssahu@marvell.com>\n---\n doc/guides/cryptodevs/features/octeontx.ini | 1 +\n drivers/common/cpt/cpt_mcode_defines.h | 2 +\n drivers/common/cpt/cpt_ucode_asym.h | 85 ++++++++++++++++++++++\n .../crypto/octeontx/otx_cryptodev_capabilities.c | 11 +++\n drivers/crypto/octeontx/otx_cryptodev_ops.c | 23 ++++++\n 5 files changed, 122 insertions(+)", "diff": "diff --git a/doc/guides/cryptodevs/features/octeontx.ini b/doc/guides/cryptodevs/features/octeontx.ini\nindex 544bb46..3cc807a 100644\n--- a/doc/guides/cryptodevs/features/octeontx.ini\n+++ b/doc/guides/cryptodevs/features/octeontx.ini\n@@ -73,3 +73,4 @@ Modular Exponentiation = Y\n Modular Inversion =\n Diffie-hellman =\n ECDSA = Y\n+EC Point Multiplication = Y\ndiff --git a/drivers/common/cpt/cpt_mcode_defines.h b/drivers/common/cpt/cpt_mcode_defines.h\nindex 64d3e8c..d830bef 100644\n--- a/drivers/common/cpt/cpt_mcode_defines.h\n+++ b/drivers/common/cpt/cpt_mcode_defines.h\n@@ -24,6 +24,7 @@\n /* AE opcodes */\n #define CPT_MAJOR_OP_MODEX\t0x03\n #define CPT_MAJOR_OP_ECDSA\t0x04\n+#define CPT_MAJOR_OP_ECC\t0x05\n #define CPT_MINOR_OP_MODEX\t0x01\n #define CPT_MINOR_OP_PKCS_ENC\t0x02\n #define CPT_MINOR_OP_PKCS_ENC_CRT\t0x03\n@@ -32,6 +33,7 @@\n #define CPT_MINOR_OP_MODEX_CRT\t0x06\n #define CPT_MINOR_OP_ECDSA_SIGN\t0x01\n #define CPT_MINOR_OP_ECDSA_VERIFY\t0x02\n+#define CPT_MINOR_OP_ECC_UMP\t0x03\n \n #define CPT_BLOCK_TYPE1 0\n #define CPT_BLOCK_TYPE2 1\ndiff --git a/drivers/common/cpt/cpt_ucode_asym.h b/drivers/common/cpt/cpt_ucode_asym.h\nindex 1f76bd1..9a54d34 100644\n--- a/drivers/common/cpt/cpt_ucode_asym.h\n+++ b/drivers/common/cpt/cpt_ucode_asym.h\n@@ -172,6 +172,8 @@ cpt_fill_asym_session_parameters(struct cpt_asym_sess_misc *sess,\n \t\tret = cpt_fill_modex_params(sess, xform);\n \t\tbreak;\n \tcase RTE_CRYPTO_ASYM_XFORM_ECDSA:\n+\t\t/* Fall through */\n+\tcase RTE_CRYPTO_ASYM_XFORM_EC_POINT_MUL:\n \t\tret = cpt_fill_ec_params(sess, xform);\n \t\tbreak;\n \tdefault:\n@@ -199,6 +201,8 @@ cpt_free_asym_session_parameters(struct cpt_asym_sess_misc *sess)\n \t\t\trte_free(mod->modulus.data);\n \t\tbreak;\n \tcase RTE_CRYPTO_ASYM_XFORM_ECDSA:\n+\t\t/* Fall through */\n+\tcase RTE_CRYPTO_ASYM_XFORM_EC_POINT_MUL:\n \t\tbreak;\n \tdefault:\n \t\tCPT_LOG_DP_ERR(\"Invalid transform type\");\n@@ -828,4 +832,85 @@ cpt_enqueue_ecdsa_op(struct rte_crypto_op *op,\n \treturn 0;\n }\n \n+static __rte_always_inline int\n+cpt_ecpm_prep(struct rte_crypto_ec_point_mul_param *ecpm,\n+\t struct asym_op_params *asym_params,\n+\t uint8_t curveid)\n+{\n+\tstruct cpt_request_info *req = asym_params->req;\n+\tphys_addr_t mphys = asym_params->meta_buf;\n+\tuint16_t x1_len = ecpm->p.x.length;\n+\tuint16_t y1_len = ecpm->p.y.length;\n+\tuint16_t scalar_align, p_align;\n+\tuint16_t dlen, rlen, prime_len;\n+\tuint16_t x1_offset, y1_offset;\n+\tvq_cmd_word0_t vq_cmd_w0;\n+\topcode_info_t opcode;\n+\tbuf_ptr_t caddr;\n+\tuint8_t *dptr;\n+\n+\tprime_len = ec_grp[curveid].prime.length;\n+\n+\t/* Input buffer */\n+\tdptr = RTE_PTR_ADD(req, sizeof(struct cpt_request_info));\n+\n+\tp_align = ROUNDUP8(prime_len);\n+\tscalar_align = ROUNDUP8(ecpm->scalar.length);\n+\n+\t/*\n+\t * Set dlen = sum(ROUNDUP8(input point(x and y coordinates), prime,\n+\t * scalar length),\n+\t * Please note point length is equivalent to prime of the curve\n+\t */\n+\tdlen = 3 * p_align + scalar_align;\n+\n+\tx1_offset = prime_len - x1_len;\n+\ty1_offset = prime_len - y1_len;\n+\n+\tmemset(dptr, 0, dlen);\n+\n+\t/* Copy input point, scalar, prime */\n+\tmemcpy(dptr + x1_offset, ecpm->p.x.data, x1_len);\n+\tdptr += p_align;\n+\tmemcpy(dptr + y1_offset, ecpm->p.y.data, y1_len);\n+\tdptr += p_align;\n+\tmemcpy(dptr, ecpm->scalar.data, ecpm->scalar.length);\n+\tdptr += scalar_align;\n+\tmemcpy(dptr, ec_grp[curveid].prime.data, ec_grp[curveid].prime.length);\n+\tdptr += p_align;\n+\n+\t/* Setup opcodes */\n+\topcode.s.major = CPT_MAJOR_OP_ECC;\n+\topcode.s.minor = CPT_MINOR_OP_ECC_UMP;\n+\n+\t/* GP op header */\n+\tvq_cmd_w0.s.opcode = opcode.flags;\n+\tvq_cmd_w0.s.param1 = curveid;\n+\tvq_cmd_w0.s.param2 = ecpm->scalar.length;\n+\tvq_cmd_w0.s.dlen = dlen;\n+\tvq_cmd_w0.u64 = vq_cmd_w0.u64;\n+\n+\t/* Filling cpt_request_info structure */\n+\treq->ist.ei0 = vq_cmd_w0.u64;\n+\treq->ist.ei1 = mphys;\n+\treq->ist.ei2 = mphys + dlen;\n+\n+\t/* Result buffer will store output point where length of\n+\t * each coordinate will be of prime length, thus set\n+\t * rlen to twice of prime length.\n+\t */\n+\trlen = p_align << 1;\n+\treq->rptr = dptr;\n+\n+\t/* alternate_caddr to write completion status by the microcode */\n+\treq->alternate_caddr = (uint64_t *)(dptr + rlen);\n+\t*req->alternate_caddr = ~((uint64_t)COMPLETION_CODE_INIT);\n+\n+\t/* Preparing completion addr, +1 for completion code */\n+\tcaddr.vaddr = dptr + rlen + 1;\n+\tcaddr.dma_addr = mphys + dlen + rlen + 1;\n+\n+\tcpt_fill_req_comp_addr(req, caddr);\n+\treturn 0;\n+}\n #endif /* _CPT_UCODE_ASYM_H_ */\ndiff --git a/drivers/crypto/octeontx/otx_cryptodev_capabilities.c b/drivers/crypto/octeontx/otx_cryptodev_capabilities.c\nindex 6418ad2..22f34ad 100644\n--- a/drivers/crypto/octeontx/otx_cryptodev_capabilities.c\n+++ b/drivers/crypto/octeontx/otx_cryptodev_capabilities.c\n@@ -641,6 +641,17 @@ static const struct rte_cryptodev_capabilities otx_asym_capabilities[] = {\n \t\t\t},\n \t\t}\n \t},\n+\t{\t/* EC POINT MUL */\n+\t\t.op = RTE_CRYPTO_OP_TYPE_ASYMMETRIC,\n+\t\t{.asym = {\n+\t\t\t.xform_capa = {\n+\t\t\t\t.xform_type =\n+\t\t\t\t\tRTE_CRYPTO_ASYM_XFORM_EC_POINT_MUL,\n+\t\t\t\t.op_types = 0\n+\t\t\t\t}\n+\t\t\t},\n+\t\t}\n+\t},\n \t/* End of asymmetric capabilities */\n \tRTE_CRYPTODEV_END_OF_CAPABILITIES_LIST()\n };\ndiff --git a/drivers/crypto/octeontx/otx_cryptodev_ops.c b/drivers/crypto/octeontx/otx_cryptodev_ops.c\nindex f97ce3a..e7520d5 100644\n--- a/drivers/crypto/octeontx/otx_cryptodev_ops.c\n+++ b/drivers/crypto/octeontx/otx_cryptodev_ops.c\n@@ -443,6 +443,13 @@ otx_cpt_enq_single_asym(struct cpt_instance *instance,\n \t\tif (unlikely(ret))\n \t\t\tgoto req_fail;\n \t\tbreak;\n+\tcase RTE_CRYPTO_ASYM_XFORM_EC_POINT_MUL:\n+\t\tret = cpt_ecpm_prep(&asym_op->ecpm, ¶ms,\n+\t\t\t\t sess->ec_ctx.curveid);\n+\t\tif (unlikely(ret))\n+\t\t\tgoto req_fail;\n+\t\tbreak;\n+\n \tdefault:\n \t\top->status = RTE_CRYPTO_OP_STATUS_INVALID_ARGS;\n \t\tret = -EINVAL;\n@@ -704,6 +711,19 @@ otx_cpt_asym_dequeue_ecdsa_op(struct rte_crypto_ecdsa_op_param *ecdsa,\n \tecdsa->s.length = prime_len;\n }\n \n+static __rte_always_inline void\n+otx_cpt_asym_dequeue_ecpm_op(struct rte_crypto_ec_point_mul_param *ecpm,\n+\t\t\t struct cpt_request_info *req,\n+\t\t\t struct cpt_asym_ec_ctx *ec)\n+{\n+\tint prime_len = ec_grp[ec->curveid].prime.length;\n+\n+\tmemcpy(ecpm->r.x.data, req->rptr, prime_len);\n+\tmemcpy(ecpm->r.y.data, req->rptr + ROUNDUP8(prime_len), prime_len);\n+\tecpm->r.x.length = prime_len;\n+\tecpm->r.y.length = prime_len;\n+}\n+\n static __rte_always_inline void __hot\n otx_cpt_asym_post_process(struct rte_crypto_op *cop,\n \t\t\t struct cpt_request_info *req)\n@@ -726,6 +746,9 @@ otx_cpt_asym_post_process(struct rte_crypto_op *cop,\n \tcase RTE_CRYPTO_ASYM_XFORM_ECDSA:\n \t\totx_cpt_asym_dequeue_ecdsa_op(&op->ecdsa, req, &sess->ec_ctx);\n \t\tbreak;\n+\tcase RTE_CRYPTO_ASYM_XFORM_EC_POINT_MUL:\n+\t\totx_cpt_asym_dequeue_ecpm_op(&op->ecpm, req, &sess->ec_ctx);\n+\t\tbreak;\n \tdefault:\n \t\tCPT_LOG_DP_DEBUG(\"Invalid crypto xform type\");\n \t\tcop->status = RTE_CRYPTO_OP_STATUS_INVALID_ARGS;\n", "prefixes": [ "2/4" ] }