Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/63406/?format=api
{ "id": 63406, "url": "http://patches.dpdk.org/api/patches/63406/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20191129210905.1865-8-kevin.laatz@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20191129210905.1865-8-kevin.laatz@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20191129210905.1865-8-kevin.laatz@intel.com", "date": "2019-11-29T21:09:05", "name": "[v3,7/7] build: clean up experimental syms check", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "67b18c99958ddadf05d2b205c9b36f2f08851530", "submitter": { "id": 921, "url": "http://patches.dpdk.org/api/people/921/?format=api", "name": "Kevin Laatz", "email": "kevin.laatz@intel.com" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20191129210905.1865-8-kevin.laatz@intel.com/mbox/", "series": [ { "id": 7693, "url": "http://patches.dpdk.org/api/series/7693/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=7693", "date": "2019-11-29T21:08:58", "name": "Add ABI compatibility checks to the meson build", "version": 3, "mbox": "http://patches.dpdk.org/series/7693/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/63406/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/63406/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 03C1EA04E0;\n\tFri, 29 Nov 2019 22:10:15 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 177E61BF80;\n\tFri, 29 Nov 2019 22:09:36 +0100 (CET)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n by dpdk.org (Postfix) with ESMTP id ED0511E2B\n for <dev@dpdk.org>; Fri, 29 Nov 2019 22:09:31 +0100 (CET)", "from orsmga008.jf.intel.com ([10.7.209.65])\n by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n 29 Nov 2019 13:09:31 -0800", "from silpixa00399838.ir.intel.com (HELO\n silpixa00399838.ger.corp.intel.com) ([10.237.222.120])\n by orsmga008.jf.intel.com with ESMTP; 29 Nov 2019 13:09:29 -0800" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.69,258,1571727600\"; d=\"scan'208\";a=\"203832661\"", "From": "Kevin Laatz <kevin.laatz@intel.com>", "To": "dev@dpdk.org", "Cc": "david.marchand@redhat.com, thomas@monjalon.net,\n bruce.richardson@intel.com,\n ray.kinsella@intel.com, Kevin Laatz <kevin.laatz@intel.com>", "Date": "Fri, 29 Nov 2019 21:09:05 +0000", "Message-Id": "<20191129210905.1865-8-kevin.laatz@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20191129210905.1865-1-kevin.laatz@intel.com>", "References": "<20191129171024.56165-1-kevin.laatz@intel.com>\n <20191129210905.1865-1-kevin.laatz@intel.com>", "Subject": "[dpdk-dev] [PATCH v3 7/7] build: clean up experimental syms check", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This patch cleans up the meson build files in lib and drivers by moving the\ncustom target for checking the experimental syms next to the abi compat\nchecks. This also removes the dependency on the check for the shared build,\nwhich was not required by anything, but was only added to force the\nexperimental syms check run.\n\nSigned-off-by: Kevin Laatz <kevin.laatz@intel.com>\n---\n drivers/meson.build | 21 +++++++++++----------\n lib/meson.build | 21 +++++++++++----------\n 2 files changed, 22 insertions(+), 20 deletions(-)", "diff": "diff --git a/drivers/meson.build b/drivers/meson.build\nindex e19eed419..9b0955722 100644\n--- a/drivers/meson.build\n+++ b/drivers/meson.build\n@@ -163,15 +163,6 @@ foreach class:dpdk_driver_classes\n \t\t\t\t\t'-Wl,/implib:lib\\\\' + implib]\n \t\t\telse\n \t\t\t\tlk_args = ['-Wl,--version-script=' + version_map]\n-\t\t\t\t# on unix systems check the output of the\n-\t\t\t\t# experimental syms script, using it as a\n-\t\t\t\t# dependency of the .so build\n-\t\t\t\tlk_deps += custom_target(lib_name + '.exp_chk',\n-\t\t\t\t\tcommand: [check_experimental_syms,\n-\t\t\t\t\t\tversion_map, '@INPUT@'],\n-\t\t\t\t\tcapture: true,\n-\t\t\t\t\tinput: static_lib,\n-\t\t\t\t\toutput: lib_name + '.exp_chk')\n \t\t\tendif\n \n \t\t\tshared_lib = shared_library(lib_name,\n@@ -181,7 +172,6 @@ foreach class:dpdk_driver_classes\n \t\t\t\tdependencies: shared_deps,\n \t\t\t\tc_args: cflags,\n \t\t\t\tlink_args: lk_args,\n-\t\t\t\tlink_depends: lk_deps,\n \t\t\t\tversion: lib_version,\n \t\t\t\tsoversion: so_version,\n \t\t\t\tinstall: true,\n@@ -197,6 +187,17 @@ foreach class:dpdk_driver_classes\n \t\t\t\t\tdependencies: static_deps)\n \n \t\t\tif not is_windows and get_option('compat_checks')\n+\t\t\t\t# on unix systems check the output of the\n+\t\t\t\t# experimental syms script\n+\t\t\t\tcustom_target(lib_name + '.exp_chk',\n+\t\t\t\t\tcommand: [check_experimental_syms,\n+\t\t\t\t\t\tversion_map, '@INPUT@'],\n+\t\t\t\t\tcapture: true,\n+\t\t\t\t\tinput: static_lib,\n+\t\t\t\t\toutput: lib_name + '.exp_chk',\n+\t\t\t\t\tinstall: false,\n+\t\t\t\t\tbuild_by_default: true)\n+\n \t\t\t\tcustom_target('lib' + lib_name + '.abi_chk',\n \t\t\t\t\tcommand: [abidiff,\n \t\t\t\t\t\tmeson.source_root() + '/drivers/abi/lib'\ndiff --git a/lib/meson.build b/lib/meson.build\nindex 69ea3a2b0..c448d9dff 100644\n--- a/lib/meson.build\n+++ b/lib/meson.build\n@@ -154,15 +154,6 @@ foreach l:libraries\n \t\t\t\t\t'-Wl,/implib:lib\\\\' + implib]\n \t\t\telse\n \t\t\t\tlk_args = ['-Wl,--version-script=' + version_map]\n-\t\t\t\t# on unix systems check the output of the\n-\t\t\t\t# experimental syms script, using it as a\n-\t\t\t\t# dependency of the .so build\n-\t\t\t\tlk_deps += custom_target(name + '.exp_chk',\n-\t\t\t\t\tcommand: [check_experimental_syms,\n-\t\t\t\t\t\tversion_map, '@INPUT@'],\n-\t\t\t\t\tcapture: true,\n-\t\t\t\t\tinput: static_lib,\n-\t\t\t\t\toutput: name + '.exp_chk')\n \t\t\tendif\n \n \t\t\tshared_lib = shared_library(libname,\n@@ -172,7 +163,6 @@ foreach l:libraries\n \t\t\t\t\tdependencies: shared_deps,\n \t\t\t\t\tinclude_directories: includes,\n \t\t\t\t\tlink_args: lk_args,\n-\t\t\t\t\tlink_depends: lk_deps,\n \t\t\t\t\tversion: lib_version,\n \t\t\t\t\tsoversion: so_version,\n \t\t\t\t\tinstall: true)\n@@ -181,6 +171,17 @@ foreach l:libraries\n \t\t\t\t\tdependencies: shared_deps)\n \n \t\t\tif not is_windows and get_option('compat_checks')\n+\t\t\t\t# on unix systems check the output of the\n+\t\t\t\t# experimental syms script\n+\t\t\t\tcustom_target(name + '.exp_chk',\n+\t\t\t\t\tcommand: [check_experimental_syms,\n+\t\t\t\t\t\tversion_map, '@INPUT@'],\n+\t\t\t\t\tcapture: true,\n+\t\t\t\t\tinput: static_lib,\n+\t\t\t\t\toutput: name + '.exp_chk',\n+\t\t\t\t\tinstall: false,\n+\t\t\t\t\tbuild_by_default: true)\n+\n \t\t\t\tcustom_target(dir_name + '.abi_chk',\n \t\t\t\t\tcommand: [abidiff,\n \t\t\t\t\t\tmeson.source_root() + '/lib/abi/'\n", "prefixes": [ "v3", "7/7" ] }