Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/63396/?format=api
{ "id": 63396, "url": "http://patches.dpdk.org/api/patches/63396/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20191129171024.56165-6-kevin.laatz@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20191129171024.56165-6-kevin.laatz@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20191129171024.56165-6-kevin.laatz@intel.com", "date": "2019-11-29T17:10:22", "name": "[v2,5/7] build: add lib abi checks to meson", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "8f83280e435dea7b106d741343a2e1f678c7c035", "submitter": { "id": 921, "url": "http://patches.dpdk.org/api/people/921/?format=api", "name": "Kevin Laatz", "email": "kevin.laatz@intel.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20191129171024.56165-6-kevin.laatz@intel.com/mbox/", "series": [ { "id": 7692, "url": "http://patches.dpdk.org/api/series/7692/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=7692", "date": "2019-11-29T17:10:17", "name": "Add ABI compatibility checks to the meson build", "version": 2, "mbox": "http://patches.dpdk.org/series/7692/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/63396/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/63396/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 78B5FA04E0;\n\tFri, 29 Nov 2019 18:11:28 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 0E7301BF75;\n\tFri, 29 Nov 2019 18:10:51 +0100 (CET)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n by dpdk.org (Postfix) with ESMTP id 6341654AE\n for <dev@dpdk.org>; Fri, 29 Nov 2019 18:10:46 +0100 (CET)", "from fmsmga005.fm.intel.com ([10.253.24.32])\n by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n 29 Nov 2019 09:10:46 -0800", "from silpixa00399838.ir.intel.com (HELO\n silpixa00399838.ger.corp.intel.com) ([10.237.222.120])\n by fmsmga005.fm.intel.com with ESMTP; 29 Nov 2019 09:10:44 -0800" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.69,257,1571727600\"; d=\"scan'208\";a=\"409684870\"", "From": "Kevin Laatz <kevin.laatz@intel.com>", "To": "dev@dpdk.org", "Cc": "david.marchand@redhat.com, thomas@monjalon.net,\n bruce.richardson@intel.com,\n ray.kinsella@intel.com, Kevin Laatz <kevin.laatz@intel.com>", "Date": "Fri, 29 Nov 2019 17:10:22 +0000", "Message-Id": "<20191129171024.56165-6-kevin.laatz@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20191129171024.56165-1-kevin.laatz@intel.com>", "References": "<20191023010754.65172-1-kevin.laatz@intel.com>\n <20191129171024.56165-1-kevin.laatz@intel.com>", "Subject": "[dpdk-dev] [PATCH v2 5/7] build: add lib abi checks to meson", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This patch adds the ABI compatibility check for the lib directory to the\nmeson build. If enabled, the ABI compatibility checks will run for all\n.so's in the lib directory (provided a matching dump file exists). The\nbuild will fail if an ABI incompatibility is detected.\n\nSigned-off-by: Kevin Laatz <kevin.laatz@intel.com>\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n\n---\nv2:\n - fixed conditional around abi check custom target\n---\n buildtools/meson.build | 4 ++++\n lib/meson.build | 13 +++++++++++++\n 2 files changed, 17 insertions(+)", "diff": "diff --git a/buildtools/meson.build b/buildtools/meson.build\nindex 6ef2c5721..56a1e3dee 100644\n--- a/buildtools/meson.build\n+++ b/buildtools/meson.build\n@@ -7,6 +7,10 @@ pmdinfo = find_program('gen-pmdinfo-cfile.sh')\n \n check_experimental_syms = find_program('check-experimental-syms.sh')\n \n+if get_option('abi_compat_checks')\n+\tabidiff = find_program('abidiff')\n+endif\n+\n # set up map-to-def script using python, either built-in or external\n python3 = import('python').find_installation(required: false)\n if python3.found()\ndiff --git a/lib/meson.build b/lib/meson.build\nindex 6ceb5e756..69ea3a2b0 100644\n--- a/lib/meson.build\n+++ b/lib/meson.build\n@@ -180,6 +180,19 @@ foreach l:libraries\n \t\t\t\t\tinclude_directories: includes,\n \t\t\t\t\tdependencies: shared_deps)\n \n+\t\t\tif not is_windows and get_option('compat_checks')\n+\t\t\t\tcustom_target(dir_name + '.abi_chk',\n+\t\t\t\t\tcommand: [abidiff,\n+\t\t\t\t\t\tmeson.source_root() + '/lib/abi/'\n+\t\t\t\t\t\t+ dir_name + '.dump',\n+\t\t\t\t\t\t'@INPUT@'],\n+\t\t\t\t\tinput: shared_lib,\n+\t\t\t\t\toutput: dir_name + '.abi_chk',\n+\t\t\t\t\tcapture: true,\n+\t\t\t\t\tinstall: false,\n+\t\t\t\t\tbuild_by_default: is_experimental == 0)\n+\t\t\tendif\n+\n \t\t\tdpdk_libraries = [shared_lib] + dpdk_libraries\n \t\t\tdpdk_static_libraries = [static_lib] + dpdk_static_libraries\n \t\tendif # sources.length() > 0\n", "prefixes": [ "v2", "5/7" ] }