Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/63393/?format=api
{ "id": 63393, "url": "http://patches.dpdk.org/api/patches/63393/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20191129171024.56165-3-kevin.laatz@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20191129171024.56165-3-kevin.laatz@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20191129171024.56165-3-kevin.laatz@intel.com", "date": "2019-11-29T17:10:19", "name": "[v2,2/7] build: use meson warning levels", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "f88b855fcdca130a9c0f5d1792b92c247eb61684", "submitter": { "id": 921, "url": "http://patches.dpdk.org/api/people/921/?format=api", "name": "Kevin Laatz", "email": "kevin.laatz@intel.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20191129171024.56165-3-kevin.laatz@intel.com/mbox/", "series": [ { "id": 7692, "url": "http://patches.dpdk.org/api/series/7692/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=7692", "date": "2019-11-29T17:10:17", "name": "Add ABI compatibility checks to the meson build", "version": 2, "mbox": "http://patches.dpdk.org/series/7692/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/63393/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/63393/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C51EBA04E0;\n\tFri, 29 Nov 2019 18:11:00 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 9A0EA4C90;\n\tFri, 29 Nov 2019 18:10:45 +0100 (CET)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n by dpdk.org (Postfix) with ESMTP id 3056D293C\n for <dev@dpdk.org>; Fri, 29 Nov 2019 18:10:42 +0100 (CET)", "from fmsmga005.fm.intel.com ([10.253.24.32])\n by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n 29 Nov 2019 09:10:41 -0800", "from silpixa00399838.ir.intel.com (HELO\n silpixa00399838.ger.corp.intel.com) ([10.237.222.120])\n by fmsmga005.fm.intel.com with ESMTP; 29 Nov 2019 09:10:40 -0800" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.69,257,1571727600\"; d=\"scan'208\";a=\"409684850\"", "From": "Kevin Laatz <kevin.laatz@intel.com>", "To": "dev@dpdk.org", "Cc": "david.marchand@redhat.com, thomas@monjalon.net,\n bruce.richardson@intel.com,\n ray.kinsella@intel.com", "Date": "Fri, 29 Nov 2019 17:10:19 +0000", "Message-Id": "<20191129171024.56165-3-kevin.laatz@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20191129171024.56165-1-kevin.laatz@intel.com>", "References": "<20191023010754.65172-1-kevin.laatz@intel.com>\n <20191129171024.56165-1-kevin.laatz@intel.com>", "Subject": "[dpdk-dev] [PATCH v2 2/7] build: use meson warning levels", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Bruce Richardson <bruce.richardson@intel.com>\n\nRather than trying to manage all the cflags ourselves, we can use meson\nwarning levels to give the user more control. We remove the Wextra flag and\nrely on meson to add it, by bumping up our default warning level.\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n config/meson.build | 40 +++++++++++++++++++++-------------------\n meson.build | 3 ++-\n 2 files changed, 23 insertions(+), 20 deletions(-)", "diff": "diff --git a/config/meson.build b/config/meson.build\nindex 364a8d739..36a594970 100644\n--- a/config/meson.build\n+++ b/config/meson.build\n@@ -158,31 +158,33 @@ endif\n # add -include rte_config to cflags\n add_project_arguments('-include', 'rte_config.h', language: 'c')\n \n-# enable extra warnings and disable any unwanted warnings\n+# enable extra warnings and disable any unwanted warnings. \"-Wall\" is added\n+# by meson at warning level 1, and \"-Wextra\" at level 2, so we can omit\n+# those. Add extra warnings at level 2 or above. (2 is default level).\n warning_flags = [\n-\t# -Wall is added by meson by default, so add -Wextra only\n-\t'-Wextra',\n-\n-\t# additional warnings in alphabetical order\n-\t'-Wcast-qual',\n-\t'-Wdeprecated',\n-\t'-Wformat-nonliteral',\n-\t'-Wformat-security',\n-\t'-Wmissing-declarations',\n-\t'-Wmissing-prototypes',\n-\t'-Wnested-externs',\n-\t'-Wold-style-definition',\n-\t'-Wpointer-arith',\n-\t'-Wsign-compare',\n-\t'-Wstrict-prototypes',\n-\t'-Wundef',\n-\t'-Wwrite-strings',\n-\n \t# globally disabled warnings\n \t'-Wno-address-of-packed-member',\n \t'-Wno-packed-not-aligned',\n \t'-Wno-missing-field-initializers'\n ]\n+if get_option('warning_level').to_int() >= 2\n+\twarning_flags += [\n+\t\t# additional warnings in alphabetical order\n+\t\t'-Wcast-qual',\n+\t\t'-Wdeprecated',\n+\t\t'-Wformat-nonliteral',\n+\t\t'-Wformat-security',\n+\t\t'-Wmissing-declarations',\n+\t\t'-Wmissing-prototypes',\n+\t\t'-Wnested-externs',\n+\t\t'-Wold-style-definition',\n+\t\t'-Wpointer-arith',\n+\t\t'-Wsign-compare',\n+\t\t'-Wstrict-prototypes',\n+\t\t'-Wundef',\n+\t\t'-Wwrite-strings',\n+\t]\n+endif\n if not dpdk_conf.get('RTE_ARCH_64')\n # for 32-bit, don't warn about casting a 32-bit pointer to 64-bit int - it's fine!!\n \twarning_flags += '-Wno-pointer-to-int-cast'\ndiff --git a/meson.build b/meson.build\nindex 3b7a2e7de..7a8f97ad6 100644\n--- a/meson.build\n+++ b/meson.build\n@@ -8,7 +8,8 @@ project('DPDK', 'C',\n \t\tfiles('VERSION')).stdout().strip(),\n \tlicense: 'BSD',\n \tdefault_options: ['buildtype=debugoptimized',\n-\t\t\t'default_library=static'],\n+\t\t\t'default_library=static',\n+\t\t\t'warning_level=2'],\n \tmeson_version: '>= 0.47.1'\n )\n \n", "prefixes": [ "v2", "2/7" ] }