Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/63392/?format=api
{ "id": 63392, "url": "http://patches.dpdk.org/api/patches/63392/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20191129171024.56165-2-kevin.laatz@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20191129171024.56165-2-kevin.laatz@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20191129171024.56165-2-kevin.laatz@intel.com", "date": "2019-11-29T17:10:18", "name": "[v2,1/7] build: enable debug info by default in meson builds", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "b51831c919a3884301e7ca943a0c4dd9a03941b1", "submitter": { "id": 921, "url": "http://patches.dpdk.org/api/people/921/?format=api", "name": "Kevin Laatz", "email": "kevin.laatz@intel.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20191129171024.56165-2-kevin.laatz@intel.com/mbox/", "series": [ { "id": 7692, "url": "http://patches.dpdk.org/api/series/7692/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=7692", "date": "2019-11-29T17:10:17", "name": "Add ABI compatibility checks to the meson build", "version": 2, "mbox": "http://patches.dpdk.org/series/7692/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/63392/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/63392/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 7167EA04E0;\n\tFri, 29 Nov 2019 18:10:51 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 6427E2B9C;\n\tFri, 29 Nov 2019 18:10:43 +0100 (CET)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n by dpdk.org (Postfix) with ESMTP id AB339235\n for <dev@dpdk.org>; Fri, 29 Nov 2019 18:10:40 +0100 (CET)", "from fmsmga005.fm.intel.com ([10.253.24.32])\n by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n 29 Nov 2019 09:10:40 -0800", "from silpixa00399838.ir.intel.com (HELO\n silpixa00399838.ger.corp.intel.com) ([10.237.222.120])\n by fmsmga005.fm.intel.com with ESMTP; 29 Nov 2019 09:10:38 -0800" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.69,257,1571727600\"; d=\"scan'208\";a=\"409684844\"", "From": "Kevin Laatz <kevin.laatz@intel.com>", "To": "dev@dpdk.org", "Cc": "david.marchand@redhat.com, thomas@monjalon.net,\n bruce.richardson@intel.com,\n ray.kinsella@intel.com", "Date": "Fri, 29 Nov 2019 17:10:18 +0000", "Message-Id": "<20191129171024.56165-2-kevin.laatz@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20191129171024.56165-1-kevin.laatz@intel.com>", "References": "<20191023010754.65172-1-kevin.laatz@intel.com>\n <20191129171024.56165-1-kevin.laatz@intel.com>", "Subject": "[dpdk-dev] [PATCH v2 1/7] build: enable debug info by default in\n\tmeson builds", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Bruce Richardson <bruce.richardson@intel.com>\n\nWe can turn on debug info by default in meson builds, since it has no\nperformance penalty. This is done by changing the default build type from\n\"release\" to \"debugoptimized\". Since the latter using O2, we can using\nextra cflags to override that back to O3, which will make little real\ndifference for actual debugging.\n\nFor real debug builds, the user can still do \"meson --buildtype=debug ...\"\nand to remove the debug info \"meson --buildtype=release ...\" can be used.\nThese are all standard meson options.\n\nThe advantage of having debug builds by default using meson settings is\nthat we can then add checks for ABI compatibility into each build, and\ndisable them if we detect that the user has turned off the debug info.\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n meson.build | 8 +++++++-\n 1 file changed, 7 insertions(+), 1 deletion(-)", "diff": "diff --git a/meson.build b/meson.build\nindex b7ae9c8d9..3b7a2e7de 100644\n--- a/meson.build\n+++ b/meson.build\n@@ -7,10 +7,16 @@ project('DPDK', 'C',\n \tversion: run_command(find_program('cat', 'more'),\n \t\tfiles('VERSION')).stdout().strip(),\n \tlicense: 'BSD',\n-\tdefault_options: ['buildtype=release', 'default_library=static'],\n+\tdefault_options: ['buildtype=debugoptimized',\n+\t\t\t'default_library=static'],\n \tmeson_version: '>= 0.47.1'\n )\n \n+# for default \"debugoptimized\" builds override optimization level 2 with 3\n+if get_option('buildtype') == 'debugoptimized'\n+\tadd_project_arguments('-O3', language: 'c')\n+endif\n+\n # set up some global vars for compiler, platform, configuration, etc.\n cc = meson.get_compiler('c')\n dpdk_conf = configuration_data()\n", "prefixes": [ "v2", "1/7" ] }