Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/63237/?format=api
{ "id": 63237, "url": "http://patches.dpdk.org/api/patches/63237/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20191122120624.4963-6-xavier.huwei@tom.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20191122120624.4963-6-xavier.huwei@tom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20191122120624.4963-6-xavier.huwei@tom.com", "date": "2019-11-22T12:06:23", "name": "[5/6] net/hns3: fix the strategy of getting link status for VF", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "2f696198d0941a7c003aca61b07d9aa1528e919b", "submitter": { "id": 1459, "url": "http://patches.dpdk.org/api/people/1459/?format=api", "name": "Wei Hu (Xavier)", "email": "xavier.huwei@tom.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20191122120624.4963-6-xavier.huwei@tom.com/mbox/", "series": [ { "id": 7586, "url": "http://patches.dpdk.org/api/series/7586/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=7586", "date": "2019-11-22T12:06:18", "name": "Fixes for hns3 PMD driver", "version": 1, "mbox": "http://patches.dpdk.org/series/7586/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/63237/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/63237/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 1B66DA04C3;\n\tFri, 22 Nov 2019 15:16:41 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 08C1D5596;\n\tFri, 22 Nov 2019 15:16:01 +0100 (CET)", "from smtp.tom.com (smtprz15.163.net [106.3.154.248])\n by dpdk.org (Postfix) with ESMTP id 131BD374\n for <dev@dpdk.org>; Fri, 22 Nov 2019 13:06:35 +0100 (CET)", "from my-app01.tom.com (my-app01.tom.com [127.0.0.1])\n by freemail01.tom.com (Postfix) with ESMTP id 7A28A1C81A45\n for <dev@dpdk.org>; Fri, 22 Nov 2019 20:06:38 +0800 (CST)", "from my-app01.tom.com (HELO smtp.tom.com) ([127.0.0.1])\n by my-app01 (TOM SMTP Server) with SMTP ID -1777405614\n for <dev@dpdk.org>; Fri, 22 Nov 2019 20:06:38 +0800 (CST)", "from antispam1.tom.com (unknown [172.25.16.55])\n by freemail01.tom.com (Postfix) with ESMTP id 6B19C1C81A28\n for <dev@dpdk.org>; Fri, 22 Nov 2019 20:06:38 +0800 (CST)", "from antispam1.tom.com (antispam1.tom.com [127.0.0.1])\n by antispam1.tom.com (Postfix) with ESMTP id 6ACA410017C7\n for <dev@dpdk.org>; Fri, 22 Nov 2019 20:06:09 +0800 (CST)", "from antispam1.tom.com ([127.0.0.1])\n by antispam1.tom.com (antispam1.tom.com [127.0.0.1]) (amavisd-new,\n port 10024)\n with ESMTP id riq7xWla5FFh for <dev@dpdk.org>;\n Fri, 22 Nov 2019 20:06:09 +0800 (CST)", "from localhost.localdomain (unknown [203.160.91.226])\n by antispam1.tom.com (Postfix) with ESMTPA id B27E21001828;\n Fri, 22 Nov 2019 20:06:08 +0800 (CST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=tom.com; s=201807;\n t=1574424398; bh=gArXmcHvjfBZf3/zrlpv3xzicqJiLFS0WE/WH3chEq4=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=tDwdGWGBvRel0K5F8YUz8SKEYzfdw1HI1k4ZnVq/mnxiZfxN8Jkwg3FVhbIoK4Bn/\n zk4RTurag8SGDbgnO0Gykl9VURjXB51F48QxVdH978mmkbCjX3/7tvraiJAbaz1yfk\n slo0EoZuySPKmfpOrI318I5I6NCDF9bGl0CCfNaY=", "X-Virus-Scanned": "Debian amavisd-new at antispam1.tom.com", "From": "\"Wei Hu (Xavier)\" <xavier.huwei@tom.com>", "To": "dev@dpdk.org,\n\tstable@dpdk.org", "Cc": "xavier_huwei@163.com,\n\txavier.huwei@tom.com,\n\thuwei87@hisilicon.com", "Date": "Fri, 22 Nov 2019 20:06:23 +0800", "Message-Id": "<20191122120624.4963-6-xavier.huwei@tom.com>", "X-Mailer": "git-send-email 2.23.0", "In-Reply-To": "<20191122120624.4963-1-xavier.huwei@tom.com>", "References": "<20191122120624.4963-1-xavier.huwei@tom.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Mailman-Approved-At": "Fri, 22 Nov 2019 15:15:52 +0100", "Subject": "[dpdk-dev] [PATCH 5/6] net/hns3: fix the strategy of getting link\n\tstatus for VF", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Huisong Li <lihuisong@huawei.com>\n\nCurrently, port link status is \"up\" in VF driver after user calling the\nrte_eth_dev_stop API. This is unreasonable.\n\nTherefore, this patch adjusts the strategy of getting link status from\nPF driver for VF. VF drvier should stop getting link status from PF by\ncanceling the alarm that VF driver send mailbox message to PF driver,\nwhen the rte_eth_dev_stop API is called. And VF driver should restore\nthe alarm when the rte_eth_dev_start API is called.\n\nFixes: a5475d61fa34 (\"net/hns3: support VF\")\nCc: stable@dpdk.org\n\nSigned-off-by: Huisong Li <lihuisong@huawei.com>\nSigned-off-by: Wei Hu (Xavier) <xavier.huwei@huawei.com>\n---\n drivers/net/hns3/hns3_ethdev_vf.c | 8 +++-----\n 1 file changed, 3 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/net/hns3/hns3_ethdev_vf.c b/drivers/net/hns3/hns3_ethdev_vf.c\nindex 2274ac35e..b1736e73a 100644\n--- a/drivers/net/hns3/hns3_ethdev_vf.c\n+++ b/drivers/net/hns3/hns3_ethdev_vf.c\n@@ -1246,6 +1246,7 @@ hns3vf_dev_stop(struct rte_eth_dev *eth_dev)\n \t\thns3_dev_release_mbufs(hns);\n \t\thw->adapter_state = HNS3_NIC_CONFIGURED;\n \t}\n+\trte_eal_alarm_cancel(hns3vf_service_handler, eth_dev);\n \trte_spinlock_unlock(&hw->lock);\n }\n \n@@ -1265,7 +1266,6 @@ hns3vf_dev_close(struct rte_eth_dev *eth_dev)\n \thns3_reset_abort(hns);\n \thw->adapter_state = HNS3_NIC_CLOSED;\n \trte_eal_alarm_cancel(hns3vf_keep_alive_handler, eth_dev);\n-\trte_eal_alarm_cancel(hns3vf_service_handler, eth_dev);\n \thns3vf_configure_all_mc_mac_addr(hns, true);\n \thns3vf_remove_all_vlan_table(hns);\n \thns3vf_uninit_vf(eth_dev);\n@@ -1286,8 +1286,6 @@ hns3vf_dev_link_update(struct rte_eth_dev *eth_dev,\n \tstruct hns3_mac *mac = &hw->mac;\n \tstruct rte_eth_link new_link;\n \n-\thns3vf_request_link_info(hw);\n-\n \tmemset(&new_link, 0, sizeof(new_link));\n \tswitch (mac->link_speed) {\n \tcase ETH_SPEED_NUM_10M:\n@@ -1352,6 +1350,8 @@ hns3vf_dev_start(struct rte_eth_dev *eth_dev)\n \trte_spinlock_unlock(&hw->lock);\n \thns3_set_rxtx_function(eth_dev);\n \thns3_mp_req_start_rxtx(eth_dev);\n+\trte_eal_alarm_set(HNS3VF_SERVICE_INTERVAL, hns3vf_service_handler,\n+\t\t\t eth_dev);\n \treturn 0;\n }\n \n@@ -1789,8 +1789,6 @@ hns3vf_dev_init(struct rte_eth_dev *eth_dev)\n \t}\n \trte_eal_alarm_set(HNS3VF_KEEP_ALIVE_INTERVAL, hns3vf_keep_alive_handler,\n \t\t\t eth_dev);\n-\trte_eal_alarm_set(HNS3VF_SERVICE_INTERVAL, hns3vf_service_handler,\n-\t\t\t eth_dev);\n \treturn 0;\n \n err_rte_zmalloc:\n", "prefixes": [ "5/6" ] }