Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/63019/?format=api
{ "id": 63019, "url": "http://patches.dpdk.org/api/patches/63019/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/d541158e2c590c0d3e1a985e2bbea4c236da1f9f.1573739893.git.anatoly.burakov@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<d541158e2c590c0d3e1a985e2bbea4c236da1f9f.1573739893.git.anatoly.burakov@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/d541158e2c590c0d3e1a985e2bbea4c236da1f9f.1573739893.git.anatoly.burakov@intel.com", "date": "2019-11-14T13:58:21", "name": "[2/2] mempool: remove check for bad IOVA when populating", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "99580af0bde984edf15a40485dba29a13a8b8d79", "submitter": { "id": 4, "url": "http://patches.dpdk.org/api/people/4/?format=api", "name": "Anatoly Burakov", "email": "anatoly.burakov@intel.com" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/d541158e2c590c0d3e1a985e2bbea4c236da1f9f.1573739893.git.anatoly.burakov@intel.com/mbox/", "series": [ { "id": 7457, "url": "http://patches.dpdk.org/api/series/7457/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=7457", "date": "2019-11-14T13:58:20", "name": "[1/2] mempool: use actual IOVA addresses when populating", "version": 1, "mbox": "http://patches.dpdk.org/series/7457/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/63019/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/63019/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 083ECA04C6;\n\tThu, 14 Nov 2019 14:58:35 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 206052C27;\n\tThu, 14 Nov 2019 14:58:28 +0100 (CET)", "from mga18.intel.com (mga18.intel.com [134.134.136.126])\n by dpdk.org (Postfix) with ESMTP id 8AA34374;\n Thu, 14 Nov 2019 14:58:25 +0100 (CET)", "from fmsmga005.fm.intel.com ([10.253.24.32])\n by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n 14 Nov 2019 05:58:24 -0800", "from silpixa00399498.ir.intel.com (HELO\n silpixa00399498.ger.corp.intel.com) ([10.237.223.151])\n by fmsmga005.fm.intel.com with ESMTP; 14 Nov 2019 05:58:23 -0800" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.68,304,1569308400\"; d=\"scan'208\";a=\"404980525\"", "From": "Anatoly Burakov <anatoly.burakov@intel.com>", "To": "dev@dpdk.org", "Cc": "Olivier Matz <olivier.matz@6wind.com>,\n Andrew Rybchenko <arybchenko@solarflare.com>, david.marchand@redhat.com,\n stable@dpdk.org", "Date": "Thu, 14 Nov 2019 13:58:21 +0000", "Message-Id": "\n <d541158e2c590c0d3e1a985e2bbea4c236da1f9f.1573739893.git.anatoly.burakov@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": [ "\n <825d02ef7f7b6ab65a36d9fa4719847228537384.1573739893.git.anatoly.burakov@intel.com>", "\n <825d02ef7f7b6ab65a36d9fa4719847228537384.1573739893.git.anatoly.burakov@intel.com>" ], "References": [ "\n <825d02ef7f7b6ab65a36d9fa4719847228537384.1573739893.git.anatoly.burakov@intel.com>", "\n <825d02ef7f7b6ab65a36d9fa4719847228537384.1573739893.git.anatoly.burakov@intel.com>" ], "Subject": "[dpdk-dev] [PATCH 2/2] mempool: remove check for bad IOVA when\n\tpopulating", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Currently, mempool will check if IOVA is bad for a segment, and reject\nthe IOVA if hugepages are also enabled. This check is wrong because now\nthat we have external memory segments, they are allowed to have their\nIOVA's to be invalid. This check also doesn't make much sense in the\nfirst place, because the following code can handle bad IOVA's perfectly\nwell (and in fact, this check is not triggering a failure when\n--no-huge option is enabled), so there is not much sense to check for\nthis in the first place.\n\nFixes: 950e8fb4e194 (\"mem: allow registering external memory areas\")\nCc: stable@dpdk.org\n\nSigned-off-by: Anatoly Burakov <anatoly.burakov@intel.com>\n---\n\nNotes:\n An alternative implementation would be to add a socket ID check to see\n if the memory being allocated from belongs to an external segment.\n\n lib/librte_mempool/rte_mempool.c | 5 -----\n 1 file changed, 5 deletions(-)", "diff": "diff --git a/lib/librte_mempool/rte_mempool.c b/lib/librte_mempool/rte_mempool.c\nindex 8da2e471c7..78d8eb941e 100644\n--- a/lib/librte_mempool/rte_mempool.c\n+++ b/lib/librte_mempool/rte_mempool.c\n@@ -390,11 +390,6 @@ rte_mempool_populate_virt(struct rte_mempool *mp, char *addr,\n \n \t\tiova = get_iova(addr + off);\n \n-\t\tif (iova == RTE_BAD_IOVA && rte_eal_has_hugepages()) {\n-\t\t\tret = -EINVAL;\n-\t\t\tgoto fail;\n-\t\t}\n-\n \t\t/* populate with the largest group of contiguous pages */\n \t\tfor (phys_len = RTE_MIN(\n \t\t\t(size_t)(RTE_PTR_ALIGN_CEIL(addr + off + 1, pg_sz) -\n", "prefixes": [ "2/2" ] }