Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/62845/?format=api
{ "id": 62845, "url": "http://patches.dpdk.org/api/patches/62845/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/dd3373a03080ebb08d3270d99fd3147064a535d0.1573477096.git.dekelp@mellanox.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<dd3373a03080ebb08d3270d99fd3147064a535d0.1573477096.git.dekelp@mellanox.com>", "list_archive_url": "https://inbox.dpdk.org/dev/dd3373a03080ebb08d3270d99fd3147064a535d0.1573477096.git.dekelp@mellanox.com", "date": "2019-11-11T14:32:31", "name": "net/mlx5: fix RSS action validation of queue idx", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "f5b22ee979b3db3c75d72fbb5b8793d223dfb292", "submitter": { "id": 1082, "url": "http://patches.dpdk.org/api/people/1082/?format=api", "name": "Dekel Peled", "email": "dekelp@mellanox.com" }, "delegate": { "id": 3268, "url": "http://patches.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/dd3373a03080ebb08d3270d99fd3147064a535d0.1573477096.git.dekelp@mellanox.com/mbox/", "series": [ { "id": 7388, "url": "http://patches.dpdk.org/api/series/7388/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=7388", "date": "2019-11-11T14:32:31", "name": "net/mlx5: fix RSS action validation of queue idx", "version": 1, "mbox": "http://patches.dpdk.org/series/7388/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/62845/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/62845/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E03F3A04AB;\n\tMon, 11 Nov 2019 15:32:52 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 0A3D923D;\n\tMon, 11 Nov 2019 15:32:52 +0100 (CET)", "from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129])\n by dpdk.org (Postfix) with ESMTP id 9CCB7237\n for <dev@dpdk.org>; Mon, 11 Nov 2019 15:32:50 +0100 (CET)", "from Internal Mail-Server by MTLPINE1 (envelope-from\n dekelp@mellanox.com)\n with ESMTPS (AES256-SHA encrypted); 11 Nov 2019 16:32:45 +0200", "from mtl-vdi-280.wap.labs.mlnx. (mtl-vdi-280.wap.labs.mlnx\n [10.128.130.87])\n by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id xABEWjfG027447;\n Mon, 11 Nov 2019 16:32:45 +0200" ], "From": "Dekel Peled <dekelp@mellanox.com>", "To": "matan@mellanox.com, shahafs@mellanox.com, viacheslavo@mellanox.com", "Cc": "orika@mellanox.com, dev@dpdk.org, stable@dpdk.org", "Date": "Mon, 11 Nov 2019 16:32:31 +0200", "Message-Id": "\n <dd3373a03080ebb08d3270d99fd3147064a535d0.1573477096.git.dekelp@mellanox.com>", "X-Mailer": "git-send-email 1.7.1", "Subject": "[dpdk-dev] [PATCH] net/mlx5: fix RSS action validation of queue idx", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "RSS action validation function checks the queues included in RSS\nto make sure they are valid.\nA Queue is considered valid if the pointer to the queue (item at\nlocation queue-index of RxQ array) is not a null value.\nThe queue indices are not checked. If a large value is entered as\nqueue index, using it as an index in RxQ array will result in a\npointer to memory out of array bounds. If this memory contains a\nvalue which is not null, this queue will be wrongly considered valid.\n\nThis patch updates function mlx5_flow_validate_action_rss() with\ncheck of the input queue indices, as done in function\nmlx5_flow_validate_action_queue().\n\nFixes: 23c1d42c7138 (\"net/mlx5: split flow validation to dedicated function\")\nCc: stable@dpdk.org\n\nSigned-off-by: Dekel Peled <dekelp@mellanox.com>\n---\n drivers/net/mlx5/mlx5_flow.c | 5 +++++\n 1 file changed, 5 insertions(+)", "diff": "diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c\nindex 092f7b4..14a89e2 100644\n--- a/drivers/net/mlx5/mlx5_flow.c\n+++ b/drivers/net/mlx5/mlx5_flow.c\n@@ -1151,6 +1151,11 @@ uint32_t mlx5_flow_adjust_priority(struct rte_eth_dev *dev, int32_t priority,\n \t\t\t\t\t RTE_FLOW_ERROR_TYPE_ACTION_CONF,\n \t\t\t\t\t NULL, \"No queues configured\");\n \tfor (i = 0; i != rss->queue_num; ++i) {\n+\t\tif (rss->queue[i] >= priv->rxqs_n)\n+\t\t\treturn rte_flow_error_set\n+\t\t\t\t(error, EINVAL,\n+\t\t\t\t RTE_FLOW_ERROR_TYPE_ACTION_CONF,\n+\t\t\t\t &rss->queue[i], \"queue index out of range\");\n \t\tif (!(*priv->rxqs)[rss->queue[i]])\n \t\t\treturn rte_flow_error_set\n \t\t\t\t(error, EINVAL, RTE_FLOW_ERROR_TYPE_ACTION_CONF,\n", "prefixes": [] }