Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/62575/?format=api
{ "id": 62575, "url": "http://patches.dpdk.org/api/patches/62575/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/aeb44f43f5b7eefae37ffb70fee06042bf6281df.1573059201.git.anatoly.burakov@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<aeb44f43f5b7eefae37ffb70fee06042bf6281df.1573059201.git.anatoly.burakov@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/aeb44f43f5b7eefae37ffb70fee06042bf6281df.1573059201.git.anatoly.burakov@intel.com", "date": "2019-11-06T16:54:25", "name": "[v6,06/10] distributor: remove deprecated code", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "a9524db3b6bd03c0e8710381ed87e6c0f8faeb01", "submitter": { "id": 4, "url": "http://patches.dpdk.org/api/people/4/?format=api", "name": "Anatoly Burakov", "email": "anatoly.burakov@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/aeb44f43f5b7eefae37ffb70fee06042bf6281df.1573059201.git.anatoly.burakov@intel.com/mbox/", "series": [ { "id": 7299, "url": "http://patches.dpdk.org/api/series/7299/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=7299", "date": "2019-11-06T16:54:19", "name": "Implement the new ABI policy and add helper scripts", "version": 6, "mbox": "http://patches.dpdk.org/series/7299/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/62575/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/62575/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 6922AA04AC;\n\tWed, 6 Nov 2019 17:55:36 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id C1B3E1D440;\n\tWed, 6 Nov 2019 17:54:49 +0100 (CET)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n by dpdk.org (Postfix) with ESMTP id 385ED1D41F\n for <dev@dpdk.org>; Wed, 6 Nov 2019 17:54:47 +0100 (CET)", "from fmsmga008.fm.intel.com ([10.253.24.58])\n by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n 06 Nov 2019 08:54:46 -0800", "from silpixa00399498.ir.intel.com (HELO\n silpixa00399498.ger.corp.intel.com) ([10.237.223.151])\n by fmsmga008.fm.intel.com with ESMTP; 06 Nov 2019 08:54:44 -0800" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.68,275,1569308400\"; d=\"scan'208\";a=\"200764077\"", "From": "Anatoly Burakov <anatoly.burakov@intel.com>", "To": "dev@dpdk.org", "Cc": "Marcin Baran <marcinx.baran@intel.com>, David Hunt <david.hunt@intel.com>,\n john.mcnamara@intel.com, ray.kinsella@intel.com,\n bruce.richardson@intel.com, thomas@monjalon.net, david.marchand@redhat.com", "Date": "Wed, 6 Nov 2019 16:54:25 +0000", "Message-Id": "\n <aeb44f43f5b7eefae37ffb70fee06042bf6281df.1573059201.git.anatoly.burakov@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": [ "<cover.1573059201.git.anatoly.burakov@intel.com>", "<cover.1573059201.git.anatoly.burakov@intel.com>" ], "References": [ "<cover.1573059201.git.anatoly.burakov@intel.com>", "<cover.1571910363.git.anatoly.burakov@intel.com>\n <cover.1573059201.git.anatoly.burakov@intel.com>" ], "Subject": "[dpdk-dev] [PATCH v6 06/10] distributor: remove deprecated code", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Marcin Baran <marcinx.baran@intel.com>\n\nRemove code for old ABI versions ahead of ABI version bump.\n\nSigned-off-by: Marcin Baran <marcinx.baran@intel.com>\nSigned-off-by: Anatoly Burakov <anatoly.burakov@intel.com>\nAcked-by: David Hunt <david.hunt@intel.com>\n---\n\nNotes:\n v5:\n - Fixed shared library linking error due to versioning still enabled\n \n v2:\n - Moved this to before ABI version bump to avoid compile breakage\n \n v2:\n - Moved this to before ABI version bump to avoid compile breakage\n\n lib/librte_distributor/rte_distributor.c | 56 +++--------------\n .../rte_distributor_v1705.h | 61 -------------------\n lib/librte_distributor/rte_distributor_v20.c | 9 ---\n 3 files changed, 9 insertions(+), 117 deletions(-)\n delete mode 100644 lib/librte_distributor/rte_distributor_v1705.h", "diff": "diff --git a/lib/librte_distributor/rte_distributor.c b/lib/librte_distributor/rte_distributor.c\nindex 7df97df92d..a4c8ff6a96 100644\n--- a/lib/librte_distributor/rte_distributor.c\n+++ b/lib/librte_distributor/rte_distributor.c\n@@ -18,7 +18,6 @@\n \n #include \"rte_distributor.h\"\n #include \"rte_distributor_v20.h\"\n-#include \"rte_distributor_v1705.h\"\n #include \"distributor_private.h\"\n \n TAILQ_HEAD(rte_dist_burst_list, rte_distributor);\n@@ -33,7 +32,7 @@ EAL_REGISTER_TAILQ(rte_dist_burst_tailq)\n /**** Burst Packet APIs called by workers ****/\n \n void\n-rte_distributor_request_pkt_v1705(struct rte_distributor *d,\n+rte_distributor_request_pkt(struct rte_distributor *d,\n \t\tunsigned int worker_id, struct rte_mbuf **oldpkt,\n \t\tunsigned int count)\n {\n@@ -83,14 +82,9 @@ rte_distributor_request_pkt_v1705(struct rte_distributor *d,\n \t__atomic_store_n(retptr64, *retptr64 | RTE_DISTRIB_GET_BUF,\n \t\t\t__ATOMIC_RELEASE);\n }\n-BIND_DEFAULT_SYMBOL(rte_distributor_request_pkt, _v1705, 17.05);\n-MAP_STATIC_SYMBOL(void rte_distributor_request_pkt(struct rte_distributor *d,\n-\t\tunsigned int worker_id, struct rte_mbuf **oldpkt,\n-\t\tunsigned int count),\n-\t\trte_distributor_request_pkt_v1705);\n \n int\n-rte_distributor_poll_pkt_v1705(struct rte_distributor *d,\n+rte_distributor_poll_pkt(struct rte_distributor *d,\n \t\tunsigned int worker_id, struct rte_mbuf **pkts)\n {\n \tstruct rte_distributor_buffer *buf = &d->bufs[worker_id];\n@@ -129,13 +123,9 @@ rte_distributor_poll_pkt_v1705(struct rte_distributor *d,\n \n \treturn count;\n }\n-BIND_DEFAULT_SYMBOL(rte_distributor_poll_pkt, _v1705, 17.05);\n-MAP_STATIC_SYMBOL(int rte_distributor_poll_pkt(struct rte_distributor *d,\n-\t\tunsigned int worker_id, struct rte_mbuf **pkts),\n-\t\trte_distributor_poll_pkt_v1705);\n \n int\n-rte_distributor_get_pkt_v1705(struct rte_distributor *d,\n+rte_distributor_get_pkt(struct rte_distributor *d,\n \t\tunsigned int worker_id, struct rte_mbuf **pkts,\n \t\tstruct rte_mbuf **oldpkt, unsigned int return_count)\n {\n@@ -163,14 +153,9 @@ rte_distributor_get_pkt_v1705(struct rte_distributor *d,\n \t}\n \treturn count;\n }\n-BIND_DEFAULT_SYMBOL(rte_distributor_get_pkt, _v1705, 17.05);\n-MAP_STATIC_SYMBOL(int rte_distributor_get_pkt(struct rte_distributor *d,\n-\t\tunsigned int worker_id, struct rte_mbuf **pkts,\n-\t\tstruct rte_mbuf **oldpkt, unsigned int return_count),\n-\t\trte_distributor_get_pkt_v1705);\n \n int\n-rte_distributor_return_pkt_v1705(struct rte_distributor *d,\n+rte_distributor_return_pkt(struct rte_distributor *d,\n \t\tunsigned int worker_id, struct rte_mbuf **oldpkt, int num)\n {\n \tstruct rte_distributor_buffer *buf = &d->bufs[worker_id];\n@@ -202,10 +187,6 @@ rte_distributor_return_pkt_v1705(struct rte_distributor *d,\n \n \treturn 0;\n }\n-BIND_DEFAULT_SYMBOL(rte_distributor_return_pkt, _v1705, 17.05);\n-MAP_STATIC_SYMBOL(int rte_distributor_return_pkt(struct rte_distributor *d,\n-\t\tunsigned int worker_id, struct rte_mbuf **oldpkt, int num),\n-\t\trte_distributor_return_pkt_v1705);\n \n /**** APIs called on distributor core ***/\n \n@@ -360,7 +341,7 @@ release(struct rte_distributor *d, unsigned int wkr)\n \n /* process a set of packets to distribute them to workers */\n int\n-rte_distributor_process_v1705(struct rte_distributor *d,\n+rte_distributor_process(struct rte_distributor *d,\n \t\tstruct rte_mbuf **mbufs, unsigned int num_mbufs)\n {\n \tunsigned int next_idx = 0;\n@@ -500,14 +481,10 @@ rte_distributor_process_v1705(struct rte_distributor *d,\n \n \treturn num_mbufs;\n }\n-BIND_DEFAULT_SYMBOL(rte_distributor_process, _v1705, 17.05);\n-MAP_STATIC_SYMBOL(int rte_distributor_process(struct rte_distributor *d,\n-\t\tstruct rte_mbuf **mbufs, unsigned int num_mbufs),\n-\t\trte_distributor_process_v1705);\n \n /* return to the caller, packets returned from workers */\n int\n-rte_distributor_returned_pkts_v1705(struct rte_distributor *d,\n+rte_distributor_returned_pkts(struct rte_distributor *d,\n \t\tstruct rte_mbuf **mbufs, unsigned int max_mbufs)\n {\n \tstruct rte_distributor_returned_pkts *returns = &d->returns;\n@@ -532,10 +509,6 @@ rte_distributor_returned_pkts_v1705(struct rte_distributor *d,\n \n \treturn retval;\n }\n-BIND_DEFAULT_SYMBOL(rte_distributor_returned_pkts, _v1705, 17.05);\n-MAP_STATIC_SYMBOL(int rte_distributor_returned_pkts(struct rte_distributor *d,\n-\t\tstruct rte_mbuf **mbufs, unsigned int max_mbufs),\n-\t\trte_distributor_returned_pkts_v1705);\n \n /*\n * Return the number of packets in-flight in a distributor, i.e. packets\n@@ -557,7 +530,7 @@ total_outstanding(const struct rte_distributor *d)\n * queued up.\n */\n int\n-rte_distributor_flush_v1705(struct rte_distributor *d)\n+rte_distributor_flush(struct rte_distributor *d)\n {\n \tunsigned int flushed;\n \tunsigned int wkr;\n@@ -586,13 +559,10 @@ rte_distributor_flush_v1705(struct rte_distributor *d)\n \n \treturn flushed;\n }\n-BIND_DEFAULT_SYMBOL(rte_distributor_flush, _v1705, 17.05);\n-MAP_STATIC_SYMBOL(int rte_distributor_flush(struct rte_distributor *d),\n-\t\trte_distributor_flush_v1705);\n \n /* clears the internal returns array in the distributor */\n void\n-rte_distributor_clear_returns_v1705(struct rte_distributor *d)\n+rte_distributor_clear_returns(struct rte_distributor *d)\n {\n \tunsigned int wkr;\n \n@@ -608,13 +578,10 @@ rte_distributor_clear_returns_v1705(struct rte_distributor *d)\n \t\t__atomic_store_n(&(d->bufs[wkr].retptr64[0]), 0,\n \t\t\t\t__ATOMIC_RELEASE);\n }\n-BIND_DEFAULT_SYMBOL(rte_distributor_clear_returns, _v1705, 17.05);\n-MAP_STATIC_SYMBOL(void rte_distributor_clear_returns(struct rte_distributor *d),\n-\t\trte_distributor_clear_returns_v1705);\n \n /* creates a distributor instance */\n struct rte_distributor *\n-rte_distributor_create_v1705(const char *name,\n+rte_distributor_create(const char *name,\n \t\tunsigned int socket_id,\n \t\tunsigned int num_workers,\n \t\tunsigned int alg_type)\n@@ -688,8 +655,3 @@ rte_distributor_create_v1705(const char *name,\n \n \treturn d;\n }\n-BIND_DEFAULT_SYMBOL(rte_distributor_create, _v1705, 17.05);\n-MAP_STATIC_SYMBOL(struct rte_distributor *rte_distributor_create(\n-\t\tconst char *name, unsigned int socket_id,\n-\t\tunsigned int num_workers, unsigned int alg_type),\n-\t\trte_distributor_create_v1705);\ndiff --git a/lib/librte_distributor/rte_distributor_v1705.h b/lib/librte_distributor/rte_distributor_v1705.h\ndeleted file mode 100644\nindex df4d9e8150..0000000000\n--- a/lib/librte_distributor/rte_distributor_v1705.h\n+++ /dev/null\n@@ -1,61 +0,0 @@\n-/* SPDX-License-Identifier: BSD-3-Clause\n- * Copyright(c) 2017 Intel Corporation\n- */\n-\n-#ifndef _RTE_DISTRIB_V1705_H_\n-#define _RTE_DISTRIB_V1705_H_\n-\n-/**\n- * @file\n- * RTE distributor\n- *\n- * The distributor is a component which is designed to pass packets\n- * one-at-a-time to workers, with dynamic load balancing.\n- */\n-\n-#ifdef __cplusplus\n-extern \"C\" {\n-#endif\n-\n-struct rte_distributor *\n-rte_distributor_create_v1705(const char *name, unsigned int socket_id,\n-\t\tunsigned int num_workers,\n-\t\tunsigned int alg_type);\n-\n-int\n-rte_distributor_process_v1705(struct rte_distributor *d,\n-\t\tstruct rte_mbuf **mbufs, unsigned int num_mbufs);\n-\n-int\n-rte_distributor_returned_pkts_v1705(struct rte_distributor *d,\n-\t\tstruct rte_mbuf **mbufs, unsigned int max_mbufs);\n-\n-int\n-rte_distributor_flush_v1705(struct rte_distributor *d);\n-\n-void\n-rte_distributor_clear_returns_v1705(struct rte_distributor *d);\n-\n-int\n-rte_distributor_get_pkt_v1705(struct rte_distributor *d,\n-\tunsigned int worker_id, struct rte_mbuf **pkts,\n-\tstruct rte_mbuf **oldpkt, unsigned int retcount);\n-\n-int\n-rte_distributor_return_pkt_v1705(struct rte_distributor *d,\n-\tunsigned int worker_id, struct rte_mbuf **oldpkt, int num);\n-\n-void\n-rte_distributor_request_pkt_v1705(struct rte_distributor *d,\n-\t\tunsigned int worker_id, struct rte_mbuf **oldpkt,\n-\t\tunsigned int count);\n-\n-int\n-rte_distributor_poll_pkt_v1705(struct rte_distributor *d,\n-\t\tunsigned int worker_id, struct rte_mbuf **mbufs);\n-\n-#ifdef __cplusplus\n-}\n-#endif\n-\n-#endif\ndiff --git a/lib/librte_distributor/rte_distributor_v20.c b/lib/librte_distributor/rte_distributor_v20.c\nindex db6c49258a..53fa16d27d 100644\n--- a/lib/librte_distributor/rte_distributor_v20.c\n+++ b/lib/librte_distributor/rte_distributor_v20.c\n@@ -41,7 +41,6 @@ rte_distributor_request_pkt_v20(struct rte_distributor_v20 *d,\n \t/* Sync with distributor on GET_BUF flag. */\n \t__atomic_store_n(&(buf->bufptr64), req, __ATOMIC_RELEASE);\n }\n-VERSION_SYMBOL(rte_distributor_request_pkt, _v20, 2.0);\n \n struct rte_mbuf *\n rte_distributor_poll_pkt_v20(struct rte_distributor_v20 *d,\n@@ -57,7 +56,6 @@ rte_distributor_poll_pkt_v20(struct rte_distributor_v20 *d,\n \tint64_t ret = buf->bufptr64 >> RTE_DISTRIB_FLAG_BITS;\n \treturn (struct rte_mbuf *)((uintptr_t)ret);\n }\n-VERSION_SYMBOL(rte_distributor_poll_pkt, _v20, 2.0);\n \n struct rte_mbuf *\n rte_distributor_get_pkt_v20(struct rte_distributor_v20 *d,\n@@ -69,7 +67,6 @@ rte_distributor_get_pkt_v20(struct rte_distributor_v20 *d,\n \t\trte_pause();\n \treturn ret;\n }\n-VERSION_SYMBOL(rte_distributor_get_pkt, _v20, 2.0);\n \n int\n rte_distributor_return_pkt_v20(struct rte_distributor_v20 *d,\n@@ -82,7 +79,6 @@ rte_distributor_return_pkt_v20(struct rte_distributor_v20 *d,\n \t__atomic_store_n(&(buf->bufptr64), req, __ATOMIC_RELEASE);\n \treturn 0;\n }\n-VERSION_SYMBOL(rte_distributor_return_pkt, _v20, 2.0);\n \n /**** APIs called on distributor core ***/\n \n@@ -318,7 +314,6 @@ rte_distributor_process_v20(struct rte_distributor_v20 *d,\n \td->returns.count = ret_count;\n \treturn num_mbufs;\n }\n-VERSION_SYMBOL(rte_distributor_process, _v20, 2.0);\n \n /* return to the caller, packets returned from workers */\n int\n@@ -339,7 +334,6 @@ rte_distributor_returned_pkts_v20(struct rte_distributor_v20 *d,\n \n \treturn retval;\n }\n-VERSION_SYMBOL(rte_distributor_returned_pkts, _v20, 2.0);\n \n /* return the number of packets in-flight in a distributor, i.e. packets\n * being worked on or queued up in a backlog.\n@@ -369,7 +363,6 @@ rte_distributor_flush_v20(struct rte_distributor_v20 *d)\n \n \treturn flushed;\n }\n-VERSION_SYMBOL(rte_distributor_flush, _v20, 2.0);\n \n /* clears the internal returns array in the distributor */\n void\n@@ -380,7 +373,6 @@ rte_distributor_clear_returns_v20(struct rte_distributor_v20 *d)\n \tmemset(d->returns.mbufs, 0, sizeof(d->returns.mbufs));\n #endif\n }\n-VERSION_SYMBOL(rte_distributor_clear_returns, _v20, 2.0);\n \n /* creates a distributor instance */\n struct rte_distributor_v20 *\n@@ -424,4 +416,3 @@ rte_distributor_create_v20(const char *name,\n \n \treturn d;\n }\n-VERSION_SYMBOL(rte_distributor_create, _v20, 2.0);\n", "prefixes": [ "v6", "06/10" ] }