Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/62463/?format=api
{ "id": 62463, "url": "http://patches.dpdk.org/api/patches/62463/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20191105142321.7478-9-nipun.gupta@nxp.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20191105142321.7478-9-nipun.gupta@nxp.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20191105142321.7478-9-nipun.gupta@nxp.com", "date": "2019-11-05T14:23:20", "name": "[8/9,v4] bus/dpaa: moving qbman global init to bus", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "73ad0f6f41ffdd1eb2d8e0c70be39bf1b559adcf", "submitter": { "id": 471, "url": "http://patches.dpdk.org/api/people/471/?format=api", "name": "Nipun Gupta", "email": "nipun.gupta@nxp.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20191105142321.7478-9-nipun.gupta@nxp.com/mbox/", "series": [ { "id": 7253, "url": "http://patches.dpdk.org/api/series/7253/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=7253", "date": "2019-11-05T14:23:12", "name": "DPAA and FSLMC driver fixes and cleanup", "version": 4, "mbox": "http://patches.dpdk.org/series/7253/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/62463/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/62463/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 03BA5A04A2;\n\tTue, 5 Nov 2019 15:40:40 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 9B57B1BF49;\n\tTue, 5 Nov 2019 15:39:54 +0100 (CET)", "from inva021.nxp.com (inva021.nxp.com [92.121.34.21])\n by dpdk.org (Postfix) with ESMTP id 922491BF3E\n for <dev@dpdk.org>; Tue, 5 Nov 2019 15:39:52 +0100 (CET)", "from inva021.nxp.com (localhost [127.0.0.1])\n by inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id 30DC0200528;\n Tue, 5 Nov 2019 15:39:52 +0100 (CET)", "from invc005.ap-rdc01.nxp.com (invc005.ap-rdc01.nxp.com\n [165.114.16.14])\n by inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id 601D6200522;\n Tue, 5 Nov 2019 15:39:49 +0100 (CET)", "from GDB1.ap.freescale.net (gdb1.ap.freescale.net [10.232.132.179])\n by invc005.ap-rdc01.nxp.com (Postfix) with ESMTP id 54A6B40318;\n Tue, 5 Nov 2019 22:39:44 +0800 (SGT)" ], "From": "Nipun Gupta <nipun.gupta@nxp.com>", "To": "dev@dpdk.org", "Cc": "thomas@monjalon.net, ferruh.yigit@intel.com, hemant.agrawal@nxp.com,\n sachin.saxena@nxp.com", "Date": "Tue, 5 Nov 2019 19:53:20 +0530", "Message-Id": "<20191105142321.7478-9-nipun.gupta@nxp.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20191105142321.7478-1-nipun.gupta@nxp.com>", "References": "<20191011054657.21931-1-nipun.gupta@nxp.com>\n <20191105142321.7478-1-nipun.gupta@nxp.com>", "X-Virus-Scanned": "ClamAV using ClamSMTP", "Subject": "[dpdk-dev] [PATCH 8/9 v4] bus/dpaa: moving qbman global init to bus", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Hemant Agrawal <hemant.agrawal@nxp.com>\n\nDPAA SEC shall be able to work independent of DPAA ETH\ndriver.\nThis patch moves qbman init to bus, so that any driver\ncan use them even when no eth resources are present\nor none of the eth devices are probed.\n\nSigned-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>\nAcked-by: Akhil Goyal <akhil.goyal@nxp.com>\n---\n drivers/bus/dpaa/dpaa_bus.c | 21 +++++++++++++++++++--\n drivers/bus/dpaa/rte_bus_dpaa_version.map | 2 --\n drivers/crypto/dpaa_sec/dpaa_sec.c | 8 ++++++++\n drivers/net/dpaa/dpaa_ethdev.c | 14 --------------\n 4 files changed, 27 insertions(+), 18 deletions(-)", "diff": "diff --git a/drivers/bus/dpaa/dpaa_bus.c b/drivers/bus/dpaa/dpaa_bus.c\nindex d028ef3be..f27820db3 100644\n--- a/drivers/bus/dpaa/dpaa_bus.c\n+++ b/drivers/bus/dpaa/dpaa_bus.c\n@@ -561,8 +561,24 @@ rte_dpaa_bus_probe(void)\n \t\treturn 0;\n \n \t/* Device list creation is only done once */\n-\tif (!process_once)\n+\tif (!process_once) {\n \t\trte_dpaa_bus_dev_build();\n+\t\tif (rte_eal_process_type() == RTE_PROC_PRIMARY) {\n+\t\t\t/* One time load of Qman/Bman drivers */\n+\t\t\tret = qman_global_init();\n+\t\t\tif (ret) {\n+\t\t\t\tDPAA_PMD_ERR(\"QMAN initialization failed: %d\",\n+\t\t\t\t\t ret);\n+\t\t\t\treturn ret;\n+\t\t\t}\n+\t\t\tret = bman_global_init();\n+\t\t\tif (ret) {\n+\t\t\t\tDPAA_PMD_ERR(\"BMAN initialization failed: %d\",\n+\t\t\t\t\t ret);\n+\t\t\t\treturn ret;\n+\t\t\t}\n+\t\t}\n+\t}\n \tprocess_once = 1;\n \n \t/* If no device present on DPAA bus nothing needs to be done */\n@@ -600,7 +616,8 @@ rte_dpaa_bus_probe(void)\n \t\t\t RTE_DEV_WHITELISTED)) {\n \t\t\t\tret = drv->probe(drv, dev);\n \t\t\t\tif (ret) {\n-\t\t\t\t\tDPAA_BUS_ERR(\"Unable to probe.\\n\");\n+\t\t\t\t\tDPAA_BUS_ERR(\"unable to probe:%s\",\n+\t\t\t\t\t\t dev->name);\n \t\t\t\t} else {\n \t\t\t\t\tdev->driver = drv;\n \t\t\t\t\tdev->device.driver = &drv->driver;\ndiff --git a/drivers/bus/dpaa/rte_bus_dpaa_version.map b/drivers/bus/dpaa/rte_bus_dpaa_version.map\nindex 97f4f622d..cf428a54d 100644\n--- a/drivers/bus/dpaa/rte_bus_dpaa_version.map\n+++ b/drivers/bus/dpaa/rte_bus_dpaa_version.map\n@@ -4,7 +4,6 @@ DPDK_17.11 {\n \tbman_acquire;\n \tbman_free_pool;\n \tbman_get_params;\n-\tbman_global_init;\n \tbman_new_pool;\n \tbman_query_free_buffers;\n \tbman_release;\n@@ -48,7 +47,6 @@ DPDK_17.11 {\n \tqman_enqueue_multi;\n \tqman_fq_fqid;\n \tqman_fq_state;\n-\tqman_global_init;\n \tqman_init_fq;\n \tqman_poll_dqrr;\n \tqman_query_fq_np;\ndiff --git a/drivers/crypto/dpaa_sec/dpaa_sec.c b/drivers/crypto/dpaa_sec/dpaa_sec.c\nindex 6c186338f..ee59cf974 100644\n--- a/drivers/crypto/dpaa_sec/dpaa_sec.c\n+++ b/drivers/crypto/dpaa_sec/dpaa_sec.c\n@@ -3334,6 +3334,14 @@ cryptodev_dpaa_sec_probe(struct rte_dpaa_driver *dpaa_drv __rte_unused,\n \t\t}\n \t}\n \n+\tif (unlikely(!RTE_PER_LCORE(dpaa_io))) {\n+\t\tretval = rte_dpaa_portal_init((void *)1);\n+\t\tif (retval) {\n+\t\t\tDPAA_SEC_ERR(\"Unable to initialize portal\");\n+\t\t\treturn retval;\n+\t\t}\n+\t}\n+\n \t/* Invoke PMD device initialization function */\n \tretval = dpaa_sec_dev_init(cryptodev);\n \tif (retval == 0)\ndiff --git a/drivers/net/dpaa/dpaa_ethdev.c b/drivers/net/dpaa/dpaa_ethdev.c\nindex caf255d67..16b52b5e1 100644\n--- a/drivers/net/dpaa/dpaa_ethdev.c\n+++ b/drivers/net/dpaa/dpaa_ethdev.c\n@@ -1576,20 +1576,6 @@ rte_dpaa_probe(struct rte_dpaa_driver *dpaa_drv __rte_unused,\n \t}\n \n \tif (!is_global_init && (rte_eal_process_type() == RTE_PROC_PRIMARY)) {\n-\t\t/* One time load of Qman/Bman drivers */\n-\t\tret = qman_global_init();\n-\t\tif (ret) {\n-\t\t\tDPAA_PMD_ERR(\"QMAN initialization failed: %d\",\n-\t\t\t\t ret);\n-\t\t\treturn ret;\n-\t\t}\n-\t\tret = bman_global_init();\n-\t\tif (ret) {\n-\t\t\tDPAA_PMD_ERR(\"BMAN initialization failed: %d\",\n-\t\t\t\t ret);\n-\t\t\treturn ret;\n-\t\t}\n-\n \t\tif (access(\"/tmp/fmc.bin\", F_OK) == -1) {\n \t\t\tRTE_LOG(INFO, PMD,\n \t\t\t\t\"* FMC not configured.Enabling default mode\\n\");\n", "prefixes": [ "8/9", "v4" ] }