Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/62370/?format=api
{ "id": 62370, "url": "http://patches.dpdk.org/api/patches/62370/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20191104112112.10211-1-hemant.agrawal@nxp.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20191104112112.10211-1-hemant.agrawal@nxp.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20191104112112.10211-1-hemant.agrawal@nxp.com", "date": "2019-11-04T11:21:11", "name": "[1/2] config: remove redundant dpaa2 build", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "ce2cf62b16f0070bbdae816e7be2d868c0bbcd62", "submitter": { "id": 477, "url": "http://patches.dpdk.org/api/people/477/?format=api", "name": "Hemant Agrawal", "email": "hemant.agrawal@nxp.com" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20191104112112.10211-1-hemant.agrawal@nxp.com/mbox/", "series": [ { "id": 7220, "url": "http://patches.dpdk.org/api/series/7220/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=7220", "date": "2019-11-04T11:21:11", "name": "[1/2] config: remove redundant dpaa2 build", "version": 1, "mbox": "http://patches.dpdk.org/series/7220/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/62370/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/62370/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 5242AA0352;\n\tMon, 4 Nov 2019 12:24:23 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 738213576;\n\tMon, 4 Nov 2019 12:24:22 +0100 (CET)", "from inva021.nxp.com (inva021.nxp.com [92.121.34.21])\n by dpdk.org (Postfix) with ESMTP id 39AE234F0\n for <dev@dpdk.org>; Mon, 4 Nov 2019 12:24:21 +0100 (CET)", "from inva021.nxp.com (localhost [127.0.0.1])\n by inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id B4CE620043B;\n Mon, 4 Nov 2019 12:24:20 +0100 (CET)", "from invc005.ap-rdc01.nxp.com (invc005.ap-rdc01.nxp.com\n [165.114.16.14])\n by inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id 1F60D2000C5;\n Mon, 4 Nov 2019 12:24:19 +0100 (CET)", "from bf-netperf1.ap.freescale.net (bf-netperf1.ap.freescale.net\n [10.232.133.63])\n by invc005.ap-rdc01.nxp.com (Postfix) with ESMTP id C0B73402AD;\n Mon, 4 Nov 2019 19:24:16 +0800 (SGT)" ], "From": "Hemant Agrawal <hemant.agrawal@nxp.com>", "To": "dev@dpdk.org", "Cc": "sachin.saxena@nxp.com", "Date": "Mon, 4 Nov 2019 16:51:11 +0530", "Message-Id": "<20191104112112.10211-1-hemant.agrawal@nxp.com>", "X-Mailer": "git-send-email 2.17.1", "X-Virus-Scanned": "ClamAV using ClamSMTP", "Subject": "[dpdk-dev] [PATCH 1/2] config: remove redundant dpaa2 build", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "dpaa and dpaa2 config have evolved to be same. The same binaray\ncan now work across the platforms. So, there is no need to maintain\ntwo different build configs.\nThe dpaa config shall work for both generation of dpaa platforms.\n\nSigned-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>\n---\n config/arm/arm64_dpaa2_linux_gcc | 16 --------\n config/arm/meson.build | 7 ----\n config/defconfig_arm64-dpaa-linuxapp-gcc | 16 ++++++--\n config/defconfig_arm64-dpaa2-linux-gcc | 1 -\n doc/guides/cryptodevs/dpaa2_sec.rst | 4 +-\n doc/guides/eventdevs/dpaa2.rst | 2 +-\n .../linux_gsg/cross_build_dpdk_for_arm64.rst | 2 +-\n doc/guides/nics/build_and_test.rst | 2 +-\n doc/guides/nics/dpaa.rst | 12 +-----\n doc/guides/nics/dpaa2.rst | 8 ++--\n doc/guides/rawdevs/dpaa2_cmdif.rst | 2 +-\n doc/guides/rawdevs/dpaa2_qdma.rst | 2 +-\n doc/guides/rel_notes/release_19_11.rst | 2 +\n mk/machine/dpaa2/rte.vars.mk | 37 -------------------\n 14 files changed, 26 insertions(+), 87 deletions(-)\n delete mode 100644 config/arm/arm64_dpaa2_linux_gcc\n delete mode 120000 config/defconfig_arm64-dpaa2-linux-gcc\n delete mode 100644 mk/machine/dpaa2/rte.vars.mk", "diff": "diff --git a/config/arm/arm64_dpaa2_linux_gcc b/config/arm/arm64_dpaa2_linux_gcc\ndeleted file mode 100644\nindex 0df8c8f7d..000000000\n--- a/config/arm/arm64_dpaa2_linux_gcc\n+++ /dev/null\n@@ -1,16 +0,0 @@\n-[binaries]\n-c = 'aarch64-linux-gnu-gcc'\n-cpp = 'aarch64-linux-gnu-cpp'\n-ar = 'aarch64-linux-gnu-ar'\n-as = 'aarch64-linux-gnu-as'\n-strip = 'aarch64-linux-gnu-strip'\n-pcap-config = ''\n-\n-[host_machine]\n-system = 'linux'\n-cpu_family = 'aarch64'\n-cpu = 'armv8-a'\n-endian = 'little'\n-\n-[properties]\n-implementor_id = 'dpaa2'\ndiff --git a/config/arm/meson.build b/config/arm/meson.build\nindex d9f9811f7..f00aecd7e 100644\n--- a/config/arm/meson.build\n+++ b/config/arm/meson.build\n@@ -49,12 +49,6 @@ flags_dpaa = [\n \t['RTE_CACHE_LINE_SIZE', 64],\n \t['RTE_MAX_NUMA_NODES', 1],\n \t['RTE_MAX_LCORE', 16]]\n-flags_dpaa2 = [\n-\t['RTE_MACHINE', '\"dpaa2\"'],\n-\t['RTE_USE_C11_MEM_MODEL', true],\n-\t['RTE_CACHE_LINE_SIZE', 64],\n-\t['RTE_MAX_NUMA_NODES', 1],\n-\t['RTE_MAX_LCORE', 16],\n \t['RTE_LIBRTE_DPAA2_USE_PHYS_IOVA', false]]\n flags_armada = [\n \t['RTE_MACHINE', '\"armv8a\"'],\n@@ -115,7 +109,6 @@ impl_0x53 = ['Samsung', flags_generic, machine_args_generic]\n impl_0x56 = ['Marvell ARMADA', flags_armada, machine_args_generic]\n impl_0x69 = ['Intel', flags_generic, machine_args_generic]\n impl_dpaa = ['NXP DPAA', flags_dpaa, machine_args_generic]\n-impl_dpaa2 = ['NXP DPAA2', flags_dpaa2, machine_args_generic]\n \n dpdk_conf.set('RTE_FORCE_INTRINSICS', 1)\n \ndiff --git a/config/defconfig_arm64-dpaa-linuxapp-gcc b/config/defconfig_arm64-dpaa-linuxapp-gcc\nindex 19614fb01..4ae4cd850 100644\n--- a/config/defconfig_arm64-dpaa-linuxapp-gcc\n+++ b/config/defconfig_arm64-dpaa-linuxapp-gcc\n@@ -1,14 +1,15 @@\n # SPDX-License-Identifier: BSD-3-Clause\n # Copyright 2016 Freescale Semiconductor, Inc.\n-# Copyright 2017 NXP\n+# Copyright 2017-2019 NXP\n \n #include \"defconfig_arm64-armv8a-linux-gcc\"\n \n-# NXP (Freescale) - Soc Architecture with FMAN, QMAN & BMAN support\n+# NXP (Freescale) - Soc Architecture for DPAA or DPAA2 support\n+# DPAA - FMAN, QMAN & BMAN support (e.g. LS1043, LS1046)\n+# DPAA2 - WRIOP and QBMAN (e.g. LS1088, LS2088, LX2160 etc)\n+#\n CONFIG_RTE_MACHINE=\"dpaa\"\n CONFIG_RTE_ARCH_ARM_TUNE=\"cortex-a72\"\n-CONFIG_RTE_LIBRTE_VHOST_NUMA=n\n-CONFIG_RTE_EAL_NUMA_AWARE_HUGEPAGES=n\n \n #\n # Compile Environment Abstraction Layer\n@@ -18,6 +19,13 @@ CONFIG_RTE_MAX_NUMA_NODES=1\n CONFIG_RTE_CACHE_LINE_SIZE=64\n CONFIG_RTE_PKTMBUF_HEADROOM=128\n \n+# Doesn't support NUMA\n+CONFIG_RTE_EAL_NUMA_AWARE_HUGEPAGES=n\n+CONFIG_RTE_LIBRTE_VHOST_NUMA=n\n+\n+# Enable PHY mode when using VM-VFIO target\n+CONFIG_RTE_LIBRTE_DPAA2_USE_PHYS_IOVA=n\n+\n # NXP DPAA Bus\n CONFIG_RTE_LIBRTE_DPAA_DEBUG_DRIVER=n\n CONFIG_RTE_LIBRTE_DPAA_HWDEBUG=n\ndiff --git a/config/defconfig_arm64-dpaa2-linux-gcc b/config/defconfig_arm64-dpaa2-linux-gcc\ndeleted file mode 120000\nindex 9a6c6c4cb..000000000\n--- a/config/defconfig_arm64-dpaa2-linux-gcc\n+++ /dev/null\n@@ -1 +0,0 @@\n-defconfig_arm64-dpaa2-linuxapp-gcc\n\\ No newline at end of file\ndiff --git a/doc/guides/cryptodevs/dpaa2_sec.rst b/doc/guides/cryptodevs/dpaa2_sec.rst\nindex 9e21d3169..55f0d6856 100644\n--- a/doc/guides/cryptodevs/dpaa2_sec.rst\n+++ b/doc/guides/cryptodevs/dpaa2_sec.rst\n@@ -180,7 +180,7 @@ to enable DPAA2_SEC PMD.\n Please note that enabling debugging options may affect system performance.\n \n * ``CONFIG_RTE_LIBRTE_PMD_DPAA2_SEC`` (default ``n``)\n- By default it is only enabled in defconfig_arm64-dpaa2-* config.\n+ By default it is only enabled in defconfig_arm64-dpaa-* config.\n Toggle compilation of the ``librte_pmd_dpaa2_sec`` driver.\n \n Installations\n@@ -191,7 +191,7 @@ following ``make`` command:\n .. code-block:: console\n \n cd <DPDK-source-directory>\n- make config T=arm64-dpaa2-linux-gcc install\n+ make config T=arm64-dpaa-linux-gcc install\n \n Enabling logs\n -------------\ndiff --git a/doc/guides/eventdevs/dpaa2.rst b/doc/guides/eventdevs/dpaa2.rst\nindex a24a43c15..dd8ebbcd0 100644\n--- a/doc/guides/eventdevs/dpaa2.rst\n+++ b/doc/guides/eventdevs/dpaa2.rst\n@@ -71,7 +71,7 @@ following ``make`` command:\n .. code-block:: console\n \n cd <DPDK-source-directory>\n- make config T=arm64-dpaa2-linux-gcc install\n+ make config T=arm64-dpaa-linux-gcc install\n \n Initialization\n --------------\ndiff --git a/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst b/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst\nindex 28a8e0920..e799b0ba4 100644\n--- a/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst\n+++ b/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst\n@@ -79,7 +79,7 @@ Copy the NUMA header files and lib to the cross compiler's directories:\n \n Configure and cross compile DPDK Build\n --------------------------------------\n-To configure a build, choose one of the target configurations, like arm64-dpaa2-linux-gcc and arm64-thunderx-linux-gcc.\n+To configure a build, choose one of the target configurations, like arm64-dpaa-linux-gcc and arm64-thunderx-linux-gcc.\n \n .. code-block:: console\n \ndiff --git a/doc/guides/nics/build_and_test.rst b/doc/guides/nics/build_and_test.rst\nindex aae5c111d..f99e019ff 100644\n--- a/doc/guides/nics/build_and_test.rst\n+++ b/doc/guides/nics/build_and_test.rst\n@@ -35,7 +35,7 @@ Example output:\n \n arm-armv7a-linux-gcc\n arm64-armv8a-linux-gcc\n- arm64-dpaa2-linux-gcc\n+ arm64-dpaa-linux-gcc\n arm64-thunderx-linux-gcc\n arm64-xgene1-linux-gcc\n i686-native-linux-gcc\ndiff --git a/doc/guides/nics/dpaa.rst b/doc/guides/nics/dpaa.rst\nindex f85920012..17839a920 100644\n--- a/doc/guides/nics/dpaa.rst\n+++ b/doc/guides/nics/dpaa.rst\n@@ -201,14 +201,12 @@ Config File Options\n The following options can be modified in the ``config`` file.\n Please note that enabling debugging options may affect system performance.\n \n-- ``CONFIG_RTE_LIBRTE_DPAA_BUS`` (default ``n``)\n+- ``CONFIG_RTE_LIBRTE_DPAA_BUS`` (default ``y``)\n \n- By default it is enabled only for defconfig_arm64-dpaa-* config.\n Toggle compilation of the ``librte_bus_dpaa`` driver.\n \n-- ``CONFIG_RTE_LIBRTE_DPAA_PMD`` (default ``n``)\n+- ``CONFIG_RTE_LIBRTE_DPAA_PMD`` (default ``y``)\n \n- By default it is enabled only for defconfig_arm64-dpaa-* config.\n Toggle compilation of the ``librte_pmd_dpaa`` driver.\n \n - ``CONFIG_RTE_LIBRTE_DPAA_DEBUG_DRIVER`` (default ``n``)\n@@ -222,12 +220,6 @@ Please note that enabling debugging options may affect system performance.\n Enables debugging of the Queue and Buffer Manager layer which interacts\n with the DPAA hardware.\n \n-- ``CONFIG_RTE_MBUF_DEFAULT_MEMPOOL_OPS`` (default ``dpaa``)\n-\n- This is not a DPAA specific configuration - it is a generic RTE config.\n- For optimal performance and hardware utilization, it is expected that DPAA\n- Mempool driver is used for mempools. For that, this configuration needs to\n- enabled.\n \n Environment Variables\n ~~~~~~~~~~~~~~~~~~~~~\ndiff --git a/doc/guides/nics/dpaa2.rst b/doc/guides/nics/dpaa2.rst\nindex 99e4c8d72..b6d9e2129 100644\n--- a/doc/guides/nics/dpaa2.rst\n+++ b/doc/guides/nics/dpaa2.rst\n@@ -441,21 +441,19 @@ Config File Options\n The following options can be modified in the ``config`` file.\n Please note that enabling debugging options may affect system performance.\n \n-- ``CONFIG_RTE_LIBRTE_FSLMC_BUS`` (default ``n``)\n+- ``CONFIG_RTE_LIBRTE_FSLMC_BUS`` (default ``y``)\n \n- By default it is enabled only for defconfig_arm64-dpaa2-* config.\n Toggle compilation of the ``librte_bus_fslmc`` driver.\n \n-- ``CONFIG_RTE_LIBRTE_DPAA2_PMD`` (default ``n``)\n+- ``CONFIG_RTE_LIBRTE_DPAA2_PMD`` (default ``y``)\n \n- By default it is enabled only for defconfig_arm64-dpaa2-* config.\n Toggle compilation of the ``librte_pmd_dpaa2`` driver.\n \n - ``CONFIG_RTE_LIBRTE_DPAA2_DEBUG_DRIVER`` (default ``n``)\n \n Toggle display of debugging messages/logic\n \n-- ``CONFIG_RTE_LIBRTE_DPAA2_USE_PHYS_IOVA`` (default ``y``)\n+- ``CONFIG_RTE_LIBRTE_DPAA2_USE_PHYS_IOVA`` (default ``n``)\n \n Toggle to use physical address vs virtual address for hardware accelerators.\n \ndiff --git a/doc/guides/rawdevs/dpaa2_cmdif.rst b/doc/guides/rawdevs/dpaa2_cmdif.rst\nindex ac5f0f137..bcd603c81 100644\n--- a/doc/guides/rawdevs/dpaa2_cmdif.rst\n+++ b/doc/guides/rawdevs/dpaa2_cmdif.rst\n@@ -77,7 +77,7 @@ following ``make`` command:\n .. code-block:: console\n \n cd <DPDK-source-directory>\n- make config T=arm64-dpaa2-linux-gcc install\n+ make config T=arm64-dpaa-linux-gcc install\n \n Initialization\n --------------\ndiff --git a/doc/guides/rawdevs/dpaa2_qdma.rst b/doc/guides/rawdevs/dpaa2_qdma.rst\nindex 1550ca5ba..a5085c2c0 100644\n--- a/doc/guides/rawdevs/dpaa2_qdma.rst\n+++ b/doc/guides/rawdevs/dpaa2_qdma.rst\n@@ -81,7 +81,7 @@ following ``make`` command:\n .. code-block:: console\n \n cd <DPDK-source-directory>\n- make config T=arm64-dpaa2-linux-gcc install\n+ make config T=arm64-dpaa-linux-gcc install\n \n Initialization\n --------------\ndiff --git a/doc/guides/rel_notes/release_19_11.rst b/doc/guides/rel_notes/release_19_11.rst\nindex ae8e7b2f0..27a17ede5 100644\n--- a/doc/guides/rel_notes/release_19_11.rst\n+++ b/doc/guides/rel_notes/release_19_11.rst\n@@ -267,6 +267,8 @@ Removed Items\n * Quota and Watermark\n * vhost-scsi\n \n+* Removed arm64-dpaa2-* build config. arm64-dpaa-* can now build for both\n+ dpaa and dpaa2 platforms.\n \n API Changes\n -----------\ndiff --git a/mk/machine/dpaa2/rte.vars.mk b/mk/machine/dpaa2/rte.vars.mk\ndeleted file mode 100644\nindex aaa03c424..000000000\n--- a/mk/machine/dpaa2/rte.vars.mk\n+++ /dev/null\n@@ -1,37 +0,0 @@\n-# SPDX-License-Identifier: BSD-3-Clause\n-# Copyright (c) 2016 Freescale Semiconductor, Inc. All rights reserved.\n-# Copyright 2016 NXP\n-\n-#\n-# machine:\n-#\n-# - can define ARCH variable (overridden by cmdline value)\n-# - can define CROSS variable (overridden by cmdline value)\n-# - define MACHINE_CFLAGS variable (overridden by cmdline value)\n-# - define MACHINE_LDFLAGS variable (overridden by cmdline value)\n-# - define MACHINE_ASFLAGS variable (overridden by cmdline value)\n-# - can define CPU_CFLAGS variable (overridden by cmdline value) that\n-# overrides the one defined in arch.\n-# - can define CPU_LDFLAGS variable (overridden by cmdline value) that\n-# overrides the one defined in arch.\n-# - can define CPU_ASFLAGS variable (overridden by cmdline value) that\n-# overrides the one defined in arch.\n-# - may override any previously defined variable\n-#\n-\n-# ARCH =\n-# CROSS =\n-# MACHINE_CFLAGS =\n-# MACHINE_LDFLAGS =\n-# MACHINE_ASFLAGS =\n-# CPU_CFLAGS =\n-# CPU_LDFLAGS =\n-# CPU_ASFLAGS =\n-MACHINE_CFLAGS += -march=armv8-a+crc\n-\n-ifdef CONFIG_RTE_ARCH_ARM_TUNE\n-MACHINE_CFLAGS += -mtune=$(CONFIG_RTE_ARCH_ARM_TUNE:\"%\"=%)\n-endif\n-\n-# To avoid TLS corruption issue.\n-MACHINE_CFLAGS += -mtls-dialect=trad\n", "prefixes": [ "1/2" ] }