Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/61980/?format=api
{ "id": 61980, "url": "http://patches.dpdk.org/api/patches/61980/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20191025125118.47189-1-ferruh.yigit@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20191025125118.47189-1-ferruh.yigit@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20191025125118.47189-1-ferruh.yigit@intel.com", "date": "2019-10-25T12:51:17", "name": "[1/2] doc: add PMD filtering features back", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "1807e647420e1174ebf1eff499d8eda3e5587c87", "submitter": { "id": 324, "url": "http://patches.dpdk.org/api/people/324/?format=api", "name": "Ferruh Yigit", "email": "ferruh.yigit@intel.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20191025125118.47189-1-ferruh.yigit@intel.com/mbox/", "series": [ { "id": 7071, "url": "http://patches.dpdk.org/api/series/7071/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=7071", "date": "2019-10-25T12:51:17", "name": "[1/2] doc: add PMD filtering features back", "version": 1, "mbox": "http://patches.dpdk.org/series/7071/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/61980/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/61980/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 9C1BB1C1DB;\n\tFri, 25 Oct 2019 14:51:25 +0200 (CEST)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n\tby dpdk.org (Postfix) with ESMTP id 0B1491C195;\n\tFri, 25 Oct 2019 14:51:23 +0200 (CEST)", "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t25 Oct 2019 05:51:23 -0700", "from silpixa00399752.ir.intel.com (HELO\n\tsilpixa00399752.ger.corp.intel.com) ([10.237.223.78])\n\tby orsmga001.jf.intel.com with ESMTP; 25 Oct 2019 05:51:20 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.68,228,1569308400\"; d=\"scan'208\";a=\"282252448\"", "From": "Ferruh Yigit <ferruh.yigit@intel.com>", "To": "John McNamara <john.mcnamara@intel.com>,\n\tMarko Kovacevic <marko.kovacevic@intel.com>", "Cc": "dev@dpdk.org, stable@dpdk.org, Thomas Monjalon <thomas@monjalon.net>,\n\tAndrew Rybchenko <arybchenko@solarflare.com>,\n\tAdrien Mazarguil <adrien.mazarguil@6wind.com>,\n\tAjit Khaparde <ajit.khaparde@broadcom.com>,\n\tJerin Jacob <jerinj@marvell.com>", "Date": "Fri, 25 Oct 2019 13:51:17 +0100", "Message-Id": "<20191025125118.47189-1-ferruh.yigit@intel.com>", "X-Mailer": "git-send-email 2.21.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 1/2] doc: add PMD filtering features back", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "What has been deprecated is enabling filtering support using the\n'filter_ctrl' APIs [1], now same filtering features can be implemented\nusing rte_flow APIs and this is the preferred way for DPDK.\n\nSince those filtering features can be enabled via rte_flow too, better\nto keep them in the feature list, and mark them enabled for the PMDs\nthat enabled features via rte_flow API.\nThat is why PMD feature announcements not added back, they can announce\nthe feature again when 'filter_ctrl' implementation replaced with\n'rte_flow\" ones.\n\nAlso filter definitions should be clarified more in the features\ndocumentation so that all PMDs can easily figure out to announce or\nnot these filtering features, also users can understand better what to\nexpect from this feature.\n\nFixes: 030febb6642c (\"doc: remove deprecated ethdev features\")\nCc: stable@dpdk.org\n\n[1]\nrte_eth_dev_filter_ctrl()\nrte_eth_dev_filter_supported()\nThese APIs were passing using input related to the filtering by\n'filter_type' and type specific structs.\n\nSigned-off-by: Ferruh Yigit <ferruh.yigit@intel.com>\n---\nCc: Thomas Monjalon <thomas@monjalon.net>\nCc: Andrew Rybchenko <arybchenko@solarflare.com>\nCc: Adrien Mazarguil <adrien.mazarguil@6wind.com>\nCc: Ajit Khaparde <ajit.khaparde@broadcom.com>\nCc: Jerin Jacob <jerinj@marvell.com>\n---\n doc/guides/nics/features.rst | 78 ++++++++++++++++++++++++++++\n doc/guides/nics/features/default.ini | 7 +++\n 2 files changed, 85 insertions(+)", "diff": "diff --git a/doc/guides/nics/features.rst b/doc/guides/nics/features.rst\nindex d96696801..4fcb37e4b 100644\n--- a/doc/guides/nics/features.rst\n+++ b/doc/guides/nics/features.rst\n@@ -366,6 +366,84 @@ Supports filtering of a VLAN Tag identifier.\n * **[related] API**: ``rte_eth_dev_vlan_filter()``.\n \n \n+.. _nic_features_ethertype_filter:\n+\n+Ethertype filter\n+----------------\n+\n+Supports filtering on Ethernet type.\n+\n+* **[implements] eth_dev_ops**: ``filter_ctrl:RTE_ETH_FILTER_ETHERTYPE``.\n+* **[related] API**: ``rte_eth_dev_filter_ctrl()``, ``rte_eth_dev_filter_supported()``.\n+\n+.. _nic_features_ntuple_filter:\n+\n+N-tuple filter\n+--------------\n+\n+Supports filtering on N-tuple values.\n+\n+* **[implements] eth_dev_ops**: ``filter_ctrl:RTE_ETH_FILTER_NTUPLE``.\n+* **[related] API**: ``rte_eth_dev_filter_ctrl()``, ``rte_eth_dev_filter_supported()``.\n+\n+\n+.. _nic_features_syn_filter:\n+\n+SYN filter\n+----------\n+\n+Supports TCP syn filtering.\n+\n+* **[implements] eth_dev_ops**: ``filter_ctrl:RTE_ETH_FILTER_SYN``.\n+* **[related] API**: ``rte_eth_dev_filter_ctrl()``, ``rte_eth_dev_filter_supported()``.\n+\n+\n+.. _nic_features_tunnel_filter:\n+\n+Tunnel filter\n+-------------\n+\n+Supports tunnel filtering.\n+\n+* **[implements] eth_dev_ops**: ``filter_ctrl:RTE_ETH_FILTER_TUNNEL``.\n+* **[related] API**: ``rte_eth_dev_filter_ctrl()``, ``rte_eth_dev_filter_supported()``.\n+\n+\n+.. _nic_features_flexible_filter:\n+\n+Flexible filter\n+---------------\n+\n+Supports a flexible (non-tuple or Ethertype) filter.\n+\n+* **[implements] eth_dev_ops**: ``filter_ctrl:RTE_ETH_FILTER_FLEXIBLE``.\n+* **[related] API**: ``rte_eth_dev_filter_ctrl()``, ``rte_eth_dev_filter_supported()``.\n+\n+\n+.. _nic_features_hash_filter:\n+\n+Hash filter\n+-----------\n+\n+Supports Hash filtering.\n+\n+* **[implements] eth_dev_ops**: ``filter_ctrl:RTE_ETH_FILTER_HASH``.\n+* **[related] API**: ``rte_eth_dev_filter_ctrl()``, ``rte_eth_dev_filter_supported()``.\n+\n+\n+.. _nic_features_flow_director:\n+\n+Flow director\n+-------------\n+\n+Supports Flow Director style filtering to queues.\n+\n+* **[implements] eth_dev_ops**: ``filter_ctrl:RTE_ETH_FILTER_FDIR``.\n+* **[provides] mbuf**: ``mbuf.ol_flags:`` ``PKT_RX_FDIR``, ``PKT_RX_FDIR_ID``,\n+ ``PKT_RX_FDIR_FLX``.\n+* **[related] API**: ``rte_eth_dev_filter_ctrl()``, ``rte_eth_dev_filter_supported()``.\n+\n+\n .. _nic_features_flow_control:\n \n Flow control\ndiff --git a/doc/guides/nics/features/default.ini b/doc/guides/nics/features/default.ini\nindex 91ec61901..ca3b738ea 100644\n--- a/doc/guides/nics/features/default.ini\n+++ b/doc/guides/nics/features/default.ini\n@@ -37,6 +37,13 @@ VMDq =\n SR-IOV =\n DCB =\n VLAN filter =\n+Ethertype filter =\n+N-tuple filter =\n+SYN filter =\n+Tunnel filter =\n+Flexible filter =\n+Hash filter =\n+Flow director =\n Flow control =\n Flow API =\n Rate limitation =\n", "prefixes": [ "1/2" ] }