Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/61917/?format=api
{ "id": 61917, "url": "http://patches.dpdk.org/api/patches/61917/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1571939170-19998-1-git-send-email-arybchenko@solarflare.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1571939170-19998-1-git-send-email-arybchenko@solarflare.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1571939170-19998-1-git-send-email-arybchenko@solarflare.com", "date": "2019-10-24T17:46:09", "name": "net/virtio: fix broken Tx checksum offloads", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "56365a0b50f22518ee63f6ca8d3db97141ae0b93", "submitter": { "id": 607, "url": "http://patches.dpdk.org/api/people/607/?format=api", "name": "Andrew Rybchenko", "email": "arybchenko@solarflare.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1571939170-19998-1-git-send-email-arybchenko@solarflare.com/mbox/", "series": [ { "id": 7055, "url": "http://patches.dpdk.org/api/series/7055/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=7055", "date": "2019-10-24T17:46:09", "name": "net/virtio: fix broken Tx checksum offloads", "version": 1, "mbox": "http://patches.dpdk.org/series/7055/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/61917/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/61917/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id F2DB01EBBC;\n\tThu, 24 Oct 2019 19:46:23 +0200 (CEST)", "from dispatchb-us1.ppe-hosted.com (dispatchb-us1.ppe-hosted.com\n\t[148.163.129.53]) by dpdk.org (Postfix) with ESMTP id 9FF5F1EBBB;\n\tThu, 24 Oct 2019 19:46:22 +0200 (CEST)", "from webmail.solarflare.com (webmail.solarflare.com\n\t[12.187.104.26])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby mx1-us5.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id\n\t5424A180050; Thu, 24 Oct 2019 17:46:21 +0000 (UTC)", "from ocex03.SolarFlarecom.com (10.20.40.36) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id 15.0.1395.4; Thu, 24 Oct 2019 10:46:18 -0700", "from opal.uk.solarflarecom.com (10.17.10.1) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id\n\t15.0.1395.4 via Frontend Transport; Thu, 24 Oct 2019 10:46:18 -0700", "from ukv-loginhost.uk.solarflarecom.com\n\t(ukv-loginhost.uk.solarflarecom.com [10.17.10.39])\n\tby opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id\n\tx9OHkGdh014574; Thu, 24 Oct 2019 18:46:16 +0100", "from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1])\n\tby ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id\n\tB03991613D1; Thu, 24 Oct 2019 18:46:16 +0100 (BST)" ], "X-Virus-Scanned": "Proofpoint Essentials engine", "From": "Andrew Rybchenko <arybchenko@solarflare.com>", "To": "Maxime Coquelin <maxime.coquelin@redhat.com>, Tiwei Bie\n\t<tiwei.bie@intel.com>, Zhihong Wang <zhihong.wang@intel.com>", "CC": "<dev@dpdk.org>, <stable@dpdk.org>", "Date": "Thu, 24 Oct 2019 18:46:09 +0100", "Message-ID": "<1571939170-19998-1-git-send-email-arybchenko@solarflare.com>", "X-Mailer": "git-send-email 1.8.3.1", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-TM-AS-Product-Ver": "SMEX-12.5.0.1300-8.5.1010-24998.005", "X-TM-AS-Result": "No-7.702800-4.000000-10", "X-TMASE-MatchedRID": "gSeCwy/7g6NIQkQ+2Oh2tfFanwH6mNosnsHnxXScx4rM/0sSqPZieKf4\n\tO0AyJYLdeaa+M+QbKhVkCWxjv0fR2sdfzbqBQzMUqJSK+HSPY+9LXPA26IG0hN9RlPzeVuQQ224\n\tueXqtKLtqw8n+WZoVEA9DaENdC/KWzh3sldLAd86SvRb8EMdYRVBijjE0XjY+mrP6dWYCNJSjxY\n\tyRBa/qJcFwgTvxipFajoczmuoPCq0+QFNkg1/kJyxd+EPiGj7Dn3J9oDo9biFH38hg4SvZe9Dnl\n\tDf89NBI", "X-TM-AS-User-Approved-Sender": "No", "X-TM-AS-User-Blocked-Sender": "No", "X-TMASE-Result": "10--7.702800-4.000000", "X-TMASE-Version": "SMEX-12.5.0.1300-8.5.1010-24998.005", "X-MDID": "1571939181-R2CFXVMKzL-H", "Subject": "[dpdk-dev] [PATCH] net/virtio: fix broken Tx checksum offloads", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Missing parenthesis around expression before type cast to struct\nvirtio_net_hdr pointer makes the arithmetic to be in\nsizeof(struct virtio_net_hdr) units.\n\nUse rte_pktmbuf_mtod_offset() to fix the problem.\n\nType of head_size is changed to signed since some compilers bark\non unary minus applied to unsigned.\n\nFixes: 1ae55ad38e5e (\"net/virtio: fix mbuf data and packet length mismatch\")\nCc: stable@dpdk.org\n\nSigned-off-by: Andrew Rybchenko <arybchenko@solarflare.com>\n---\n drivers/net/virtio/virtio_rxtx.c | 24 ++++++++++++------------\n 1 file changed, 12 insertions(+), 12 deletions(-)", "diff": "diff --git a/drivers/net/virtio/virtio_rxtx.c b/drivers/net/virtio/virtio_rxtx.c\nindex b5fc4ecbe1..274b778d84 100644\n--- a/drivers/net/virtio/virtio_rxtx.c\n+++ b/drivers/net/virtio/virtio_rxtx.c\n@@ -635,7 +635,7 @@ virtqueue_enqueue_xmit_inorder(struct virtnet_tx *txvq,\n \tstruct vring_desc *start_dp;\n \tstruct virtio_net_hdr *hdr;\n \tuint16_t idx;\n-\tuint16_t head_size = vq->hw->vtnet_hdr_size;\n+\tint16_t head_size = vq->hw->vtnet_hdr_size;\n \tuint16_t i = 0;\n \n \tidx = vq->vq_desc_head_idx;\n@@ -648,8 +648,8 @@ virtqueue_enqueue_xmit_inorder(struct virtnet_tx *txvq,\n \t\tdxp->ndescs = 1;\n \t\tvirtio_update_packet_stats(&txvq->stats, cookies[i]);\n \n-\t\thdr = (struct virtio_net_hdr *)(char *)cookies[i]->buf_addr +\n-\t\t\tcookies[i]->data_off - head_size;\n+\t\thdr = rte_pktmbuf_mtod_offset(cookies[i],\n+\t\t\t\tstruct virtio_net_hdr *, -head_size);\n \n \t\t/* if offload disabled, hdr is not zeroed yet, do it now */\n \t\tif (!vq->hw->has_tx_offload)\n@@ -682,7 +682,7 @@ virtqueue_enqueue_xmit_packed_fast(struct virtnet_tx *txvq,\n \tstruct vring_packed_desc *dp;\n \tstruct vq_desc_extra *dxp;\n \tuint16_t idx, id, flags;\n-\tuint16_t head_size = vq->hw->vtnet_hdr_size;\n+\tint16_t head_size = vq->hw->vtnet_hdr_size;\n \tstruct virtio_net_hdr *hdr;\n \n \tid = in_order ? vq->vq_avail_idx : vq->vq_desc_head_idx;\n@@ -696,8 +696,8 @@ virtqueue_enqueue_xmit_packed_fast(struct virtnet_tx *txvq,\n \tflags = vq->vq_packed.cached_flags;\n \n \t/* prepend cannot fail, checked by caller */\n-\thdr = (struct virtio_net_hdr *)(char *)cookie->buf_addr +\n-\t\tcookie->data_off - head_size;\n+\thdr = rte_pktmbuf_mtod_offset(cookie, struct virtio_net_hdr *,\n+\t\t\t\t -head_size);\n \n \t/* if offload disabled, hdr is not zeroed yet, do it now */\n \tif (!vq->hw->has_tx_offload)\n@@ -734,7 +734,7 @@ virtqueue_enqueue_xmit_packed(struct virtnet_tx *txvq, struct rte_mbuf *cookie,\n \tstruct virtqueue *vq = txvq->vq;\n \tstruct vring_packed_desc *start_dp, *head_dp;\n \tuint16_t idx, id, head_idx, head_flags;\n-\tuint16_t head_size = vq->hw->vtnet_hdr_size;\n+\tint16_t head_size = vq->hw->vtnet_hdr_size;\n \tstruct virtio_net_hdr *hdr;\n \tuint16_t prev;\n \tbool prepend_header = false;\n@@ -756,8 +756,8 @@ virtqueue_enqueue_xmit_packed(struct virtnet_tx *txvq, struct rte_mbuf *cookie,\n \n \tif (can_push) {\n \t\t/* prepend cannot fail, checked by caller */\n-\t\thdr = (struct virtio_net_hdr *)(char *)cookie->buf_addr +\n-\t\t\tcookie->data_off - head_size;\n+\t\thdr = rte_pktmbuf_mtod_offset(cookie, struct virtio_net_hdr *,\n+\t\t\t\t\t -head_size);\n \t\tprepend_header = true;\n \n \t\t/* if offload disabled, it is not zeroed below, do it now */\n@@ -832,7 +832,7 @@ virtqueue_enqueue_xmit(struct virtnet_tx *txvq, struct rte_mbuf *cookie,\n \tstruct vring_desc *start_dp;\n \tuint16_t seg_num = cookie->nb_segs;\n \tuint16_t head_idx, idx;\n-\tuint16_t head_size = vq->hw->vtnet_hdr_size;\n+\tint16_t head_size = vq->hw->vtnet_hdr_size;\n \tbool prepend_header = false;\n \tstruct virtio_net_hdr *hdr;\n \n@@ -849,8 +849,8 @@ virtqueue_enqueue_xmit(struct virtnet_tx *txvq, struct rte_mbuf *cookie,\n \n \tif (can_push) {\n \t\t/* prepend cannot fail, checked by caller */\n-\t\thdr = (struct virtio_net_hdr *)(char *)cookie->buf_addr +\n-\t\t\tcookie->data_off - head_size;\n+\t\thdr = rte_pktmbuf_mtod_offset(cookie, struct virtio_net_hdr *,\n+\t\t\t\t\t -head_size);\n \t\tprepend_header = true;\n \n \t\t/* if offload disabled, it is not zeroed below, do it now */\n", "prefixes": [] }