Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/61833/?format=api
{ "id": 61833, "url": "http://patches.dpdk.org/api/patches/61833/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20191024074432.30705-14-somnath.kotur@broadcom.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20191024074432.30705-14-somnath.kotur@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20191024074432.30705-14-somnath.kotur@broadcom.com", "date": "2019-10-24T07:44:28", "name": "[13/17] net/bnxt: add more checks for fw reset", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "1be61c0b075d68d9dc737f42126a8d2cbd6eb794", "submitter": { "id": 908, "url": "http://patches.dpdk.org/api/people/908/?format=api", "name": "Somnath Kotur", "email": "somnath.kotur@broadcom.com" }, "delegate": { "id": 1766, "url": "http://patches.dpdk.org/api/users/1766/?format=api", "username": "ajitkhaparde", "first_name": "Ajit", "last_name": "Khaparde", "email": "ajit.khaparde@broadcom.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20191024074432.30705-14-somnath.kotur@broadcom.com/mbox/", "series": [ { "id": 7031, "url": "http://patches.dpdk.org/api/series/7031/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=7031", "date": "2019-10-24T07:44:16", "name": "bnxt patchset with bug fixes", "version": 1, "mbox": "http://patches.dpdk.org/series/7031/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/61833/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/61833/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 5438E1E4EB;\n\tThu, 24 Oct 2019 09:53:05 +0200 (CEST)", "from relay.smtp.broadcom.com (unknown [192.19.232.149])\n\tby dpdk.org (Postfix) with ESMTP id A694F1D422\n\tfor <dev@dpdk.org>; Thu, 24 Oct 2019 09:52:35 +0200 (CEST)", "from dhcp-10-123-153-55.dhcp.broadcom.net\n\t(dhcp-10-123-153-55.dhcp.broadcom.net [10.123.153.55])\n\tby relay.smtp.broadcom.com (Postfix) with ESMTP id 8D1741B729C;\n\tThu, 24 Oct 2019 00:52:34 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.10.3 relay.smtp.broadcom.com 8D1741B729C", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n\ts=dkimrelay; t=1571903555;\n\tbh=lenC6Y5sZV6NU97PGscAb1N8CsiYfpYsfVoIwidSPCk=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=MTvpBlNlajyI3BTOIJq2v9XW63zeU2A02qGqlxdFRC8t6+bqDOBWyh9neg3XEL/jQ\n\t0GOpd88XgPLhsUNNYH8nchj/k5y6xu0CZCk/H1H1lqJ7SLjtJVsitXn2XGEn7DQDQP\n\tBcrtBrDIgvNCgP+mIf2CxOoiHHUNT4M/rR4cHaTk=", "From": "Somnath Kotur <somnath.kotur@broadcom.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com", "Date": "Thu, 24 Oct 2019 13:14:28 +0530", "Message-Id": "<20191024074432.30705-14-somnath.kotur@broadcom.com>", "X-Mailer": "git-send-email 2.10.1.613.g2cc2e70", "In-Reply-To": "<20191024074432.30705-1-somnath.kotur@broadcom.com>", "References": "<20191024074432.30705-1-somnath.kotur@broadcom.com>", "Subject": "[dpdk-dev] [PATCH 13/17] net/bnxt: add more checks for fw reset", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>\n\nAdded check for fw reset or fw errors in few more routines.\nWhile processing the events, if it is fw fatal or non-fatal\nevent, there is no need to process the remaining events as\ndriver triggers recovery mechanism.\n\nAlso added a check for fw reset or fatal error in bnxt_disable_int()\nto avoid bar access in case of fatal error.\n\nSigned-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>\nReviewed-by: Rahul Gupta <rahul.gupta@broadcom.com>\nReviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>\nReviewed-by: Ajit Kumar Khaparde <ajit.khaparde@broadcom.com>\nSigned-off-by: Somnath Kotur <somnath.kotur@broadcom.com>\n---\n drivers/net/bnxt/bnxt_irq.c | 8 ++++++++\n drivers/net/bnxt/bnxt_rxr.c | 3 +++\n 2 files changed, 11 insertions(+)", "diff": "diff --git a/drivers/net/bnxt/bnxt_irq.c b/drivers/net/bnxt/bnxt_irq.c\nindex 4feb637..846325e 100644\n--- a/drivers/net/bnxt/bnxt_irq.c\n+++ b/drivers/net/bnxt/bnxt_irq.c\n@@ -37,6 +37,11 @@ void bnxt_int_handler(void *param)\n \t\t\treturn;\n \t\t}\n \n+\t\tif (is_bnxt_in_error(bp)) {\n+\t\t\tpthread_mutex_unlock(&bp->def_cp_lock);\n+\t\t\treturn;\n+\t\t}\n+\n \t\tcons = RING_CMP(cpr->cp_ring_struct, raw_cons);\n \t\tcmp = &cpr->cp_desc_ring[cons];\n \n@@ -104,6 +109,9 @@ void bnxt_disable_int(struct bnxt *bp)\n \tif (BNXT_NUM_ASYNC_CPR(bp) == 0)\n \t\treturn;\n \n+\tif (is_bnxt_in_error(bp))\n+\t\treturn;\n+\n \tif (!cpr || !cpr->cp_db.doorbell)\n \t\treturn;\n \ndiff --git a/drivers/net/bnxt/bnxt_rxr.c b/drivers/net/bnxt/bnxt_rxr.c\nindex 03dae57..ee1444c 100644\n--- a/drivers/net/bnxt/bnxt_rxr.c\n+++ b/drivers/net/bnxt/bnxt_rxr.c\n@@ -639,6 +639,9 @@ uint16_t bnxt_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts,\n \t\t\tevt =\n \t\t\tbnxt_event_hwrm_resp_handler(rxq->bp,\n \t\t\t\t\t\t (struct cmpl_base *)rxcmp);\n+\t\t\t/* If the async event is Fatal error, return */\n+\t\t\tif (unlikely(is_bnxt_in_error(rxq->bp)))\n+\t\t\t\tgoto done;\n \t\t}\n \n \t\traw_cons = NEXT_RAW_CMP(raw_cons);\n", "prefixes": [ "13/17" ] }