Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/61832/?format=api
{ "id": 61832, "url": "http://patches.dpdk.org/api/patches/61832/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20191024074432.30705-13-somnath.kotur@broadcom.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20191024074432.30705-13-somnath.kotur@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20191024074432.30705-13-somnath.kotur@broadcom.com", "date": "2019-10-24T07:44:27", "name": "[12/17] net/bnxt: fix segfault after removing and adding the slaves", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "9a4172982b146c92ebb9839dd6c536de945df6a5", "submitter": { "id": 908, "url": "http://patches.dpdk.org/api/people/908/?format=api", "name": "Somnath Kotur", "email": "somnath.kotur@broadcom.com" }, "delegate": { "id": 1766, "url": "http://patches.dpdk.org/api/users/1766/?format=api", "username": "ajitkhaparde", "first_name": "Ajit", "last_name": "Khaparde", "email": "ajit.khaparde@broadcom.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20191024074432.30705-13-somnath.kotur@broadcom.com/mbox/", "series": [ { "id": 7031, "url": "http://patches.dpdk.org/api/series/7031/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=7031", "date": "2019-10-24T07:44:16", "name": "bnxt patchset with bug fixes", "version": 1, "mbox": "http://patches.dpdk.org/series/7031/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/61832/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/61832/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id BBB7B1E4E0;\n\tThu, 24 Oct 2019 09:53:02 +0200 (CEST)", "from relay.smtp.broadcom.com (relay.smtp.broadcom.com\n\t[192.19.232.149]) by dpdk.org (Postfix) with ESMTP id 47A631D41E\n\tfor <dev@dpdk.org>; Thu, 24 Oct 2019 09:52:34 +0200 (CEST)", "from dhcp-10-123-153-55.dhcp.broadcom.net\n\t(dhcp-10-123-153-55.dhcp.broadcom.net [10.123.153.55])\n\tby relay.smtp.broadcom.com (Postfix) with ESMTP id 2C98B1B6D5E;\n\tThu, 24 Oct 2019 00:52:32 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.10.3 relay.smtp.broadcom.com 2C98B1B6D5E", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n\ts=dkimrelay; t=1571903554;\n\tbh=Jg6MNwGPgjQtA6Pdn5/U+rT02T2ryacASRd2MQQwdHo=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=HY+GEXVeAVZCMP6xzeiE0cvWnXBIFqDLI78CGsGL3DO6HiN5F5yeGE9KCpDVFzpDd\n\tR6VYtA2ci6ZEXTylamAe3IyjfeAAfRnEBmZTEIMP6KlbOCAD10Rg8jpMpVEwAPuaVm\n\tySWaC91b9xiFW8wrwPlzyUDZ9hYVwhWGkLR24QVY=", "From": "Somnath Kotur <somnath.kotur@broadcom.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com", "Date": "Thu, 24 Oct 2019 13:14:27 +0530", "Message-Id": "<20191024074432.30705-13-somnath.kotur@broadcom.com>", "X-Mailer": "git-send-email 2.10.1.613.g2cc2e70", "In-Reply-To": "<20191024074432.30705-1-somnath.kotur@broadcom.com>", "References": "<20191024074432.30705-1-somnath.kotur@broadcom.com>", "Subject": "[dpdk-dev] [PATCH 12/17] net/bnxt: fix segfault after removing and\n\tadding the slaves", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Santoshkumar Karanappa Rastapur <santosh.rastapur@broadcom.com>\n\nOn removing the slave interface, slave_remove in bonding module calls\n_rte_eth_dev_reset which in turn frees both Tx and Rx queues.\n1. segfault is seen after removing/adding the slave interface and starting\nbond interface.\nIn this below path, when mtu is set for the slave interface, queues are\nnot created yet and driver reference to queue[0] causes the segfault.\nslave_configure:\n\trte_eth_dev_set_mtu\n\trte_eth_dev_configure\n\trte_eth_rx_queue_setup\n\n2. segfault is seen on starting the port after removing from bond device.\nThis is a testpmd bug where in, on starting the port, testpmd is supposed\nto recreate the queues before starting the port.\n\nFixed these by adding check for queues created before accessing them.\n\nSigned-off-by: Santoshkumar Karanappa Rastapur <santosh.rastapur@broadcom.com>\nReviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>\nSigned-off-by: Somnath Kotur <somnath.kotur@broadcom.com>\n---\n drivers/net/bnxt/bnxt.h | 1 +\n drivers/net/bnxt/bnxt_ethdev.c | 19 ++++++++++++++++---\n drivers/net/bnxt/bnxt_rxq.c | 4 ++++\n 3 files changed, 21 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt.h b/drivers/net/bnxt/bnxt.h\nindex 975bcf9..ffc37ea 100644\n--- a/drivers/net/bnxt/bnxt.h\n+++ b/drivers/net/bnxt/bnxt.h\n@@ -639,6 +639,7 @@ struct bnxt {\n \tstruct bnxt_error_recovery_info *recovery_info;\n };\n \n+int bnxt_mtu_set_op(struct rte_eth_dev *eth_dev, uint16_t new_mtu);\n int bnxt_link_update_op(struct rte_eth_dev *eth_dev, int wait_to_complete);\n int bnxt_rcv_msg_from_vf(struct bnxt *bp, uint16_t vf_id, void *msg);\n int is_bnxt_in_error(struct bnxt *bp);\ndiff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c\nindex e24fd41..4187247 100644\n--- a/drivers/net/bnxt/bnxt_ethdev.c\n+++ b/drivers/net/bnxt/bnxt_ethdev.c\n@@ -121,7 +121,6 @@ static const struct rte_pci_id bnxt_pci_id_map[] = {\n \n static int bnxt_vlan_offload_set_op(struct rte_eth_dev *dev, int mask);\n static void bnxt_print_link_info(struct rte_eth_dev *eth_dev);\n-static int bnxt_mtu_set_op(struct rte_eth_dev *eth_dev, uint16_t new_mtu);\n static int bnxt_dev_uninit(struct rte_eth_dev *eth_dev);\n static int bnxt_init_resources(struct bnxt *bp, bool reconfig_dev);\n static int bnxt_uninit_resources(struct bnxt *bp, bool reconfig_dev);\n@@ -831,6 +830,11 @@ static int bnxt_dev_start_op(struct rte_eth_dev *eth_dev)\n \tint vlan_mask = 0;\n \tint rc;\n \n+\tif (!eth_dev->data->nb_tx_queues || !eth_dev->data->nb_rx_queues) {\n+\t\tPMD_DRV_LOG(ERR, \"Queues are not configured yet!\\n\");\n+\t\treturn -EINVAL;\n+\t}\n+\n \tif (bp->rx_cp_nr_rings > RTE_ETHDEV_QUEUE_STAT_CNTRS) {\n \t\tPMD_DRV_LOG(ERR,\n \t\t\t\"RxQ cnt %d > CONFIG_RTE_ETHDEV_QUEUE_STAT_CNTRS %d\\n\",\n@@ -2126,7 +2130,7 @@ bnxt_txq_info_get_op(struct rte_eth_dev *dev, uint16_t queue_id,\n \tqinfo->conf.tx_deferred_start = txq->tx_deferred_start;\n }\n \n-static int bnxt_mtu_set_op(struct rte_eth_dev *eth_dev, uint16_t new_mtu)\n+int bnxt_mtu_set_op(struct rte_eth_dev *eth_dev, uint16_t new_mtu)\n {\n \tstruct bnxt *bp = eth_dev->data->dev_private;\n \tuint32_t new_pkt_size;\n@@ -2137,6 +2141,10 @@ static int bnxt_mtu_set_op(struct rte_eth_dev *eth_dev, uint16_t new_mtu)\n \tif (rc)\n \t\treturn rc;\n \n+\t/* Exit if receive queues are not configured yet */\n+\tif (!eth_dev->data->nb_rx_queues)\n+\t\treturn rc;\n+\n \tnew_pkt_size = new_mtu + RTE_ETHER_HDR_LEN + RTE_ETHER_CRC_LEN +\n \t\t VLAN_TAG_SIZE * BNXT_NUM_VLANS;\n \n@@ -2167,7 +2175,9 @@ static int bnxt_mtu_set_op(struct rte_eth_dev *eth_dev, uint16_t new_mtu)\n \t\tbp->flags &= ~BNXT_FLAG_JUMBO;\n \t}\n \n-\teth_dev->data->dev_conf.rxmode.max_rx_pkt_len = new_pkt_size;\n+\t/* Is there a change in mtu setting? */\n+\tif (eth_dev->data->dev_conf.rxmode.max_rx_pkt_len == new_pkt_size)\n+\t\treturn rc;\n \n \tfor (i = 0; i < bp->nr_vnics; i++) {\n \t\tstruct bnxt_vnic_info *vnic = &bp->vnic_info[i];\n@@ -2188,6 +2198,9 @@ static int bnxt_mtu_set_op(struct rte_eth_dev *eth_dev, uint16_t new_mtu)\n \t\t}\n \t}\n \n+\tif (!rc)\n+\t\teth_dev->data->dev_conf.rxmode.max_rx_pkt_len = new_pkt_size;\n+\n \tPMD_DRV_LOG(INFO, \"New MTU is %d\\n\", new_mtu);\n \n \treturn rc;\ndiff --git a/drivers/net/bnxt/bnxt_rxq.c b/drivers/net/bnxt/bnxt_rxq.c\nindex e1ed360..d55adc3 100644\n--- a/drivers/net/bnxt/bnxt_rxq.c\n+++ b/drivers/net/bnxt/bnxt_rxq.c\n@@ -366,6 +366,10 @@ int bnxt_rx_queue_setup_op(struct rte_eth_dev *eth_dev,\n \teth_dev->data->rx_queue_state[queue_idx] = queue_state;\n \trte_spinlock_init(&rxq->lock);\n \n+\t/* Configure mtu if it is different from what was configured before */\n+\tif (!queue_idx)\n+\t\tbnxt_mtu_set_op(eth_dev, eth_dev->data->mtu);\n+\n out:\n \treturn rc;\n }\n", "prefixes": [ "12/17" ] }