Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/61817/?format=api
{ "id": 61817, "url": "http://patches.dpdk.org/api/patches/61817/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20191024055913.28817-17-somnath.kotur@broadcom.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20191024055913.28817-17-somnath.kotur@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20191024055913.28817-17-somnath.kotur@broadcom.com", "date": "2019-10-24T05:59:11", "name": "[16/16] net/bnxt: fix a possible memory leak", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "88b016bc3afe2cf7c6c13beff42be0d167efc85e", "submitter": { "id": 908, "url": "http://patches.dpdk.org/api/people/908/?format=api", "name": "Somnath Kotur", "email": "somnath.kotur@broadcom.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20191024055913.28817-17-somnath.kotur@broadcom.com/mbox/", "series": [ { "id": 7030, "url": "http://patches.dpdk.org/api/series/7030/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=7030", "date": "2019-10-24T05:58:56", "name": "bnxt patchset with bug fixes", "version": 1, "mbox": "http://patches.dpdk.org/series/7030/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/61817/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/61817/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 897621C2B5;\n\tThu, 24 Oct 2019 08:08:15 +0200 (CEST)", "from relay.smtp.broadcom.com (relay.smtp.broadcom.com\n\t[192.19.211.62]) by dpdk.org (Postfix) with ESMTP id A9F2A1C190\n\tfor <dev@dpdk.org>; Thu, 24 Oct 2019 08:07:01 +0200 (CEST)", "from dhcp-10-123-153-55.dhcp.broadcom.net\n\t(bgccx-dev-host-lnx35.bec.broadcom.net [10.123.153.55])\n\tby relay.smtp.broadcom.com (Postfix) with ESMTP id 3300E28FAC5;\n\tWed, 23 Oct 2019 23:07:01 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.10.3 relay.smtp.broadcom.com 3300E28FAC5", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n\ts=dkimrelay; t=1571897221;\n\tbh=JvmRPx2aeQSY8jooCeBPKI++BsMEOzDm2GnMz3hdTf0=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=kN3r3ABGlH3J/fxk7sjv+X+NAX009N1gUhCM5uhWoJA0gXV0e9+lfYVWdZfVPLDEJ\n\tPMLEmkZd+21mzOHrlT/rLSR/2BtXq74ch6+ddkGqrVH5qAT73FDhtWzx4CJa3T2VOd\n\tDyR30VB+EHHDgPwBA8Ky3GpisYvOoRmPZZcsoGys=", "From": "Somnath Kotur <somnath.kotur@broadcom.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com", "Date": "Thu, 24 Oct 2019 11:29:11 +0530", "Message-Id": "<20191024055913.28817-17-somnath.kotur@broadcom.com>", "X-Mailer": "git-send-email 2.10.1.613.g2cc2e70", "In-Reply-To": "<20191024055913.28817-1-somnath.kotur@broadcom.com>", "References": "<20191024055913.28817-1-somnath.kotur@broadcom.com>", "Subject": "[dpdk-dev] [PATCH 16/16] net/bnxt: fix a possible memory leak", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>\n\nDuring hot fw upgrade or error recovery, driver does cleanup and\nreallocation of resources. But driver reallocates memory for ring\ngroup info table without freeing the allocated memory during\ndevice init.\n\nFix this memory leak by moving the freeing of ring group info table\nto bnxt_free_mem() in bnxt_uninit_resources().\n\nFixes: 4617e2125c7f (\"net/bnxt: refactor init and uninit functions\")\n\nSigned-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>\nReviewed-by: Santoshkumar Karanappa Rastapur <santosh.rastapur@broadcom.com>\nSigned-off-by: Somnath Kotur <somnath.kotur@broadcom.com>\n---\n drivers/net/bnxt/bnxt_ethdev.c | 8 +++-----\n 1 file changed, 3 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c\nindex 013b968..9642796 100644\n--- a/drivers/net/bnxt/bnxt_ethdev.c\n+++ b/drivers/net/bnxt/bnxt_ethdev.c\n@@ -183,6 +183,9 @@ static void bnxt_free_mem(struct bnxt *bp, bool reconfig)\n \t}\n \tbnxt_free_async_cp_ring(bp);\n \tbnxt_free_rxtx_nq_ring(bp);\n+\n+\trte_free(bp->grp_info);\n+\tbp->grp_info = NULL;\n }\n \n static int bnxt_alloc_mem(struct bnxt *bp, bool reconfig)\n@@ -4821,11 +4824,6 @@ static int bnxt_init_resources(struct bnxt *bp, bool reconfig_dev)\n \n \trc = bnxt_uninit_resources(bp, false);\n \n-\tif (bp->grp_info != NULL) {\n-\t\trte_free(bp->grp_info);\n-\t\tbp->grp_info = NULL;\n-\t}\n-\n \tif (bp->tx_mem_zone) {\n \t\trte_memzone_free((const struct rte_memzone *)bp->tx_mem_zone);\n \t\tbp->tx_mem_zone = NULL;\n", "prefixes": [ "16/16" ] }