Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/61811/?format=api
{ "id": 61811, "url": "http://patches.dpdk.org/api/patches/61811/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20191024055913.28817-12-somnath.kotur@broadcom.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20191024055913.28817-12-somnath.kotur@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20191024055913.28817-12-somnath.kotur@broadcom.com", "date": "2019-10-24T05:59:06", "name": "[11/16] net/bnxt: fix to check for zero mac address while parsing flow arguments", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "8d63c2cef1e062b1e845c86c7258334ce72a9256", "submitter": { "id": 908, "url": "http://patches.dpdk.org/api/people/908/?format=api", "name": "Somnath Kotur", "email": "somnath.kotur@broadcom.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20191024055913.28817-12-somnath.kotur@broadcom.com/mbox/", "series": [ { "id": 7030, "url": "http://patches.dpdk.org/api/series/7030/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=7030", "date": "2019-10-24T05:58:56", "name": "bnxt patchset with bug fixes", "version": 1, "mbox": "http://patches.dpdk.org/series/7030/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/61811/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/61811/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 9F1681C231;\n\tThu, 24 Oct 2019 08:07:34 +0200 (CEST)", "from relay.smtp.broadcom.com (relay.smtp.broadcom.com\n\t[192.19.211.62]) by dpdk.org (Postfix) with ESMTP id 246E61C195\n\tfor <dev@dpdk.org>; Thu, 24 Oct 2019 08:07:00 +0200 (CEST)", "from dhcp-10-123-153-55.dhcp.broadcom.net\n\t(bgccx-dev-host-lnx35.bec.broadcom.net [10.123.153.55])\n\tby relay.smtp.broadcom.com (Postfix) with ESMTP id 982D328FA8D;\n\tWed, 23 Oct 2019 23:06:59 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.10.3 relay.smtp.broadcom.com 982D328FA8D", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n\ts=dkimrelay; t=1571897219;\n\tbh=D0rIyCJhqgFP7qi2XI+iGznK+HOoZaIPoRY+aWhqong=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=mtCPmqPpnSSz8E+zFRlCp14vjeFak+2PYv95BirTZ6xtNYphrdBOGdW+NR+y2twuo\n\txP5WgtLbzeQUTSYAckSudmg3snLDU0S6kMi7aCNBZZR9RzTK4UlPuSBFdHNEET4nbv\n\tDkqFS3U17oYXjptRucQv8okHKI+y2X2Usis9OGQI=", "From": "Somnath Kotur <somnath.kotur@broadcom.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com", "Date": "Thu, 24 Oct 2019 11:29:06 +0530", "Message-Id": "<20191024055913.28817-12-somnath.kotur@broadcom.com>", "X-Mailer": "git-send-email 2.10.1.613.g2cc2e70", "In-Reply-To": "<20191024055913.28817-1-somnath.kotur@broadcom.com>", "References": "<20191024055913.28817-1-somnath.kotur@broadcom.com>", "Subject": "[dpdk-dev] [PATCH 11/16] net/bnxt: fix to check for zero mac\n\taddress while parsing flow arguments", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Add another check to flag zero mac address while validating/parsing\nthe flow arguments\n\nFixes: 74defda79 (\"net/bnxt: allow only unicast MAC address filter creation\")\n\nReviewed-by: Venkat Duvvuru <venkatkumar.duvvuru@broadcom.com>\nSigned-off-by: Somnath Kotur <somnath.kotur@broadcom.com>\n---\n drivers/net/bnxt/bnxt_flow.c | 12 +++++++++---\n 1 file changed, 9 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt_flow.c b/drivers/net/bnxt/bnxt_flow.c\nindex 2bde6f7..cad232a 100644\n--- a/drivers/net/bnxt/bnxt_flow.c\n+++ b/drivers/net/bnxt/bnxt_flow.c\n@@ -136,6 +136,7 @@\n \tconst struct rte_flow_item_tcp *tcp_spec, *tcp_mask;\n \tconst struct rte_flow_item_udp *udp_spec, *udp_mask;\n \tconst struct rte_flow_item_eth *eth_spec, *eth_mask;\n+\tconst struct rte_ether_addr *dst, *src;\n \tconst struct rte_flow_item_nvgre *nvgre_spec;\n \tconst struct rte_flow_item_nvgre *nvgre_mask;\n \tconst struct rte_flow_item_gre *gre_spec;\n@@ -226,12 +227,15 @@\n \t\t\t}\n \n \t\t\tif (rte_is_broadcast_ether_addr(ð_mask->dst)) {\n-\t\t\t\tif (!rte_is_unicast_ether_addr(ð_spec->dst)) {\n+\t\t\t\tdst = ð_spec->dst;\n+\t\t\t\tif (!rte_is_valid_assigned_ether_addr(dst)) {\n \t\t\t\t\trte_flow_error_set(error,\n \t\t\t\t\t\t\t EINVAL,\n \t\t\t\t\t\t\t RTE_FLOW_ERROR_TYPE_ITEM,\n \t\t\t\t\t\t\t item,\n \t\t\t\t\t\t\t \"DMAC is invalid\");\n+\t\t\t\t\tPMD_DRV_LOG(ERR,\n+\t\t\t\t\t\t \"DMAC is invalid!\\n\");\n \t\t\t\t\treturn -rte_errno;\n \t\t\t\t}\n \t\t\t\trte_memcpy(filter->dst_macaddr,\n@@ -246,14 +250,16 @@\n \t\t\t\tPMD_DRV_LOG(DEBUG,\n \t\t\t\t\t \"Creating a priority flow\\n\");\n \t\t\t}\n-\n \t\t\tif (rte_is_broadcast_ether_addr(ð_mask->src)) {\n-\t\t\t\tif (!rte_is_unicast_ether_addr(ð_spec->src)) {\n+\t\t\t\tsrc = ð_spec->src;\n+\t\t\t\tif (!rte_is_valid_assigned_ether_addr(src)) {\n \t\t\t\t\trte_flow_error_set(error,\n \t\t\t\t\t\t\t EINVAL,\n \t\t\t\t\t\t\t RTE_FLOW_ERROR_TYPE_ITEM,\n \t\t\t\t\t\t\t item,\n \t\t\t\t\t\t\t \"SMAC is invalid\");\n+\t\t\t\t\tPMD_DRV_LOG(ERR,\n+\t\t\t\t\t\t \"SMAC is invalid!\\n\");\n \t\t\t\t\treturn -rte_errno;\n \t\t\t\t}\n \t\t\t\trte_memcpy(filter->src_macaddr,\n", "prefixes": [ "11/16" ] }