Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/61803/?format=api
{ "id": 61803, "url": "http://patches.dpdk.org/api/patches/61803/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20191024055913.28817-3-somnath.kotur@broadcom.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20191024055913.28817-3-somnath.kotur@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20191024055913.28817-3-somnath.kotur@broadcom.com", "date": "2019-10-24T05:58:57", "name": "[02/16] net/bnxt: fix ping failure with MTU change", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "fadf4747927341617b5d5f8a661b3830ac46b904", "submitter": { "id": 908, "url": "http://patches.dpdk.org/api/people/908/?format=api", "name": "Somnath Kotur", "email": "somnath.kotur@broadcom.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20191024055913.28817-3-somnath.kotur@broadcom.com/mbox/", "series": [ { "id": 7030, "url": "http://patches.dpdk.org/api/series/7030/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=7030", "date": "2019-10-24T05:58:56", "name": "bnxt patchset with bug fixes", "version": 1, "mbox": "http://patches.dpdk.org/series/7030/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/61803/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/61803/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 2A1731C19E;\n\tThu, 24 Oct 2019 08:07:06 +0200 (CEST)", "from relay.smtp.broadcom.com (unknown [192.19.211.62])\n\tby dpdk.org (Postfix) with ESMTP id 46E4D1C02E\n\tfor <dev@dpdk.org>; Thu, 24 Oct 2019 08:06:57 +0200 (CEST)", "from dhcp-10-123-153-55.dhcp.broadcom.net\n\t(bgccx-dev-host-lnx35.bec.broadcom.net [10.123.153.55])\n\tby relay.smtp.broadcom.com (Postfix) with ESMTP id 6230B28FA88;\n\tWed, 23 Oct 2019 23:06:56 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.10.3 relay.smtp.broadcom.com 6230B28FA88", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n\ts=dkimrelay; t=1571897216;\n\tbh=Dljq8sUZiBCWwgDOuhTQNRkNUMZezizYGGFT7tENNmA=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=inydwewe3H39JFCL5/JwHXUwhe1Odf8FhLFDmcSqz12P2HaPZ6q5aAWj7aI1zeQTC\n\tEWZAL71fw6USaVhrnfTAMw62HrLNp8MhOoX5usAuS4UROtxP1Sn+Fpp982HMjJWwzL\n\tLDUXHmnbRljOeaZiYCaWW2cPKiai2hCM7oXC03p4=", "From": "Somnath Kotur <somnath.kotur@broadcom.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com", "Date": "Thu, 24 Oct 2019 11:28:57 +0530", "Message-Id": "<20191024055913.28817-3-somnath.kotur@broadcom.com>", "X-Mailer": "git-send-email 2.10.1.613.g2cc2e70", "In-Reply-To": "<20191024055913.28817-1-somnath.kotur@broadcom.com>", "References": "<20191024055913.28817-1-somnath.kotur@broadcom.com>", "Subject": "[dpdk-dev] [PATCH 02/16] net/bnxt: fix ping failure with MTU change", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Santoshkumar Karanappa Rastapur <santosh.rastapur@broadcom.com>\n\nDriver was setting maximum receive unit differently in bnxt_mtu_set_op\nand bnxt_hwrm_vnic_alloc. Moreover firmware adds the 4 bytes for FCS.\nFixed it by setting correct maximum receive unit value.\n\nReviewed-by: Ajit Kumar Khaparde <ajit.khaparde@broadcom.com>\nSigned-off-by: Santoshkumar Karanappa Rastapur <santosh.rastapur@broadcom.com>\nSigned-off-by: Somnath Kotur <somnath.kotur@broadcom.com>\n---\n drivers/net/bnxt/bnxt.h | 3 +++\n drivers/net/bnxt/bnxt_ethdev.c | 3 +--\n drivers/net/bnxt/bnxt_hwrm.c | 11 +++--------\n 3 files changed, 7 insertions(+), 10 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt.h b/drivers/net/bnxt/bnxt.h\nindex e5bdf63..975bcf9 100644\n--- a/drivers/net/bnxt/bnxt.h\n+++ b/drivers/net/bnxt/bnxt.h\n@@ -77,6 +77,9 @@\n #define BNXT_MAX_PKT_LEN\t(BNXT_MAX_MTU + RTE_ETHER_HDR_LEN +\\\n \t\t\t\t RTE_ETHER_CRC_LEN +\\\n \t\t\t\t (BNXT_NUM_VLANS * VLAN_TAG_SIZE))\n+/* FW adds extra 4 bytes for FCS */\n+#define BNXT_VNIC_MRU(mtu)\\\n+\t((mtu) + RTE_ETHER_HDR_LEN + VLAN_TAG_SIZE * BNXT_NUM_VLANS)\n #define BNXT_VF_RSV_NUM_RSS_CTX\t1\n #define BNXT_VF_RSV_NUM_L2_CTX\t4\n /* TODO: For now, do not support VMDq/RFS on VFs. */\ndiff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c\nindex e7ec99e..c97fcac 100644\n--- a/drivers/net/bnxt/bnxt_ethdev.c\n+++ b/drivers/net/bnxt/bnxt_ethdev.c\n@@ -2174,8 +2174,7 @@ static int bnxt_mtu_set_op(struct rte_eth_dev *eth_dev, uint16_t new_mtu)\n \t\tstruct bnxt_vnic_info *vnic = &bp->vnic_info[i];\n \t\tuint16_t size = 0;\n \n-\t\tvnic->mru = new_mtu + RTE_ETHER_HDR_LEN +\n-\t\t\t\tRTE_ETHER_CRC_LEN + VLAN_TAG_SIZE * 2;\n+\t\tvnic->mru = BNXT_VNIC_MRU(new_mtu);\n \t\trc = bnxt_hwrm_vnic_cfg(bp, vnic);\n \t\tif (rc)\n \t\t\tbreak;\ndiff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c\nindex 18e7429..018113c 100644\n--- a/drivers/net/bnxt/bnxt_hwrm.c\n+++ b/drivers/net/bnxt/bnxt_hwrm.c\n@@ -1592,8 +1592,7 @@ int bnxt_hwrm_vnic_alloc(struct bnxt *bp, struct bnxt_vnic_info *vnic)\n \tvnic->lb_rule = (uint16_t)HWRM_NA_SIGNATURE;\n \n skip_ring_grps:\n-\tvnic->mru = bp->eth_dev->data->mtu + RTE_ETHER_HDR_LEN +\n-\t\t\t\tRTE_ETHER_CRC_LEN + VLAN_TAG_SIZE;\n+\tvnic->mru = BNXT_VNIC_MRU(bp->eth_dev->data->mtu);\n \tHWRM_PREP(req, VNIC_ALLOC, BNXT_USE_CHIMP_MB);\n \n \tif (vnic->func_default)\n@@ -2954,9 +2953,7 @@ static int bnxt_hwrm_pf_func_cfg(struct bnxt *bp, int tx_rings)\n \n \treq.flags = rte_cpu_to_le_32(bp->pf.func_cfg_flags);\n \treq.mtu = rte_cpu_to_le_16(BNXT_MAX_MTU);\n-\treq.mru = rte_cpu_to_le_16(bp->eth_dev->data->mtu + RTE_ETHER_HDR_LEN +\n-\t\t\t\t RTE_ETHER_CRC_LEN + VLAN_TAG_SIZE *\n-\t\t\t\t BNXT_NUM_VLANS);\n+\treq.mru = rte_cpu_to_le_16(BNXT_VNIC_MRU(bp->eth_dev->data->mtu));\n \treq.num_rsscos_ctxs = rte_cpu_to_le_16(bp->max_rsscos_ctx);\n \treq.num_stat_ctxs = rte_cpu_to_le_16(bp->max_stat_ctx);\n \treq.num_cmpl_rings = rte_cpu_to_le_16(bp->max_cp_rings);\n@@ -2995,9 +2992,7 @@ static void populate_vf_func_cfg_req(struct bnxt *bp,\n \treq->mtu = rte_cpu_to_le_16(bp->eth_dev->data->mtu + RTE_ETHER_HDR_LEN +\n \t\t\t\t RTE_ETHER_CRC_LEN + VLAN_TAG_SIZE *\n \t\t\t\t BNXT_NUM_VLANS);\n-\treq->mru = rte_cpu_to_le_16(bp->eth_dev->data->mtu + RTE_ETHER_HDR_LEN +\n-\t\t\t\t RTE_ETHER_CRC_LEN + VLAN_TAG_SIZE *\n-\t\t\t\t BNXT_NUM_VLANS);\n+\treq->mru = rte_cpu_to_le_16(BNXT_VNIC_MRU(bp->eth_dev->data->mtu));\n \treq->num_rsscos_ctxs = rte_cpu_to_le_16(bp->max_rsscos_ctx /\n \t\t\t\t\t\t(num_vfs + 1));\n \treq->num_stat_ctxs = rte_cpu_to_le_16(bp->max_stat_ctx / (num_vfs + 1));\n", "prefixes": [ "02/16" ] }