Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/61667/?format=api
{ "id": 61667, "url": "http://patches.dpdk.org/api/patches/61667/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20191022154310.41238-3-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20191022154310.41238-3-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20191022154310.41238-3-bruce.richardson@intel.com", "date": "2019-10-22T15:43:03", "name": "[v3,2/9] examples/ethtool: allow building as part of meson build", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "71000f18e9983aecd65cc49ceafb14072baba107", "submitter": { "id": 20, "url": "http://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20191022154310.41238-3-bruce.richardson@intel.com/mbox/", "series": [ { "id": 6989, "url": "http://patches.dpdk.org/api/series/6989/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=6989", "date": "2019-10-22T15:43:01", "name": "support all examples in a meson build", "version": 3, "mbox": "http://patches.dpdk.org/series/6989/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/61667/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/61667/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 0D8D51BEEB;\n\tTue, 22 Oct 2019 17:43:24 +0200 (CEST)", "from mga12.intel.com (mga12.intel.com [192.55.52.136])\n\tby dpdk.org (Postfix) with ESMTP id 82F0D1BE96\n\tfor <dev@dpdk.org>; Tue, 22 Oct 2019 17:43:16 +0200 (CEST)", "from orsmga003.jf.intel.com ([10.7.209.27])\n\tby fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t22 Oct 2019 08:43:16 -0700", "from silpixa00399126.ir.intel.com (HELO\n\tsilpixa00399126.ger.corp.intel.com) ([10.237.223.2])\n\tby orsmga003.jf.intel.com with ESMTP; 22 Oct 2019 08:43:15 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.68,216,1569308400\"; d=\"scan'208\";a=\"200824076\"", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "Bruce Richardson <bruce.richardson@intel.com>,\n\tLuca Boccassi <bluca@debian.org>", "Date": "Tue, 22 Oct 2019 16:43:03 +0100", "Message-Id": "<20191022154310.41238-3-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.21.0", "In-Reply-To": "<20191022154310.41238-1-bruce.richardson@intel.com>", "References": "<20191014113448.7442-1-bruce.richardson@intel.com>\n\t<20191022154310.41238-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v3 2/9] examples/ethtool: allow building as part\n\tof meson build", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Since the code for the ethtool example was contained in subdirectories the\ncompilation of this example is different from most of the other apps, and\nit had not been abled when the user requests a build with \"-Dexamples=all\".\n\nTo simplify the build with meson, the separate ethtool library is not build\nseparately, rather the app is built as a single entity.\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\nAcked-by: Luca Boccassi <bluca@debian.org>\n---\nV3: disable on non-linux\n---\n examples/ethtool/meson.build | 14 ++++++++++++--\n 1 file changed, 12 insertions(+), 2 deletions(-)", "diff": "diff --git a/examples/ethtool/meson.build b/examples/ethtool/meson.build\nindex c370d7476..bc7a35514 100644\n--- a/examples/ethtool/meson.build\n+++ b/examples/ethtool/meson.build\n@@ -6,5 +6,15 @@\n # To build this example as a standalone application with an already-installed\n # DPDK instance, use 'make'\n \n-# Example app currently unsupported by meson build\n-build = false\n+build = is_linux\n+sources = files('lib/rte_ethtool.c',\n+\t'ethtool-app/ethapp.c',\n+\t'ethtool-app/main.c')\n+includes = include_directories('lib', 'ethtool-app')\n+\n+deps += 'bus_pci'\n+if dpdk_conf.has('RTE_LIBRTE_IXGBE_PMD')\n+\tdeps += 'pmd_ixgbe'\n+endif\n+\n+allow_experimental_apis = true\n", "prefixes": [ "v3", "2/9" ] }