Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/61402/?format=api
{ "id": 61402, "url": "http://patches.dpdk.org/api/patches/61402/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/7eba69a7c008f5ab62fd3a207430ef6a182e1622.1571322634.git.anatoly.burakov@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<7eba69a7c008f5ab62fd3a207430ef6a182e1622.1571322634.git.anatoly.burakov@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/7eba69a7c008f5ab62fd3a207430ef6a182e1622.1571322634.git.anatoly.burakov@intel.com", "date": "2019-10-17T14:31:54", "name": "[v4,04/10] timer: remove deprecated code", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "dcf5ce15ca73bdb8f340bf9abb7f938378cb75f3", "submitter": { "id": 4, "url": "http://patches.dpdk.org/api/people/4/?format=api", "name": "Anatoly Burakov", "email": "anatoly.burakov@intel.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/7eba69a7c008f5ab62fd3a207430ef6a182e1622.1571322634.git.anatoly.burakov@intel.com/mbox/", "series": [ { "id": 6913, "url": "http://patches.dpdk.org/api/series/6913/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=6913", "date": "2019-10-17T14:31:50", "name": "Implement the new ABI policy and add helper scripts", "version": 4, "mbox": "http://patches.dpdk.org/series/6913/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/61402/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/61402/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id C6F521E998;\n\tThu, 17 Oct 2019 16:32:15 +0200 (CEST)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby dpdk.org (Postfix) with ESMTP id 87AA61E960\n\tfor <dev@dpdk.org>; Thu, 17 Oct 2019 16:32:09 +0200 (CEST)", "from fmsmga005.fm.intel.com ([10.253.24.32])\n\tby orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t17 Oct 2019 07:32:08 -0700", "from silpixa00399498.ir.intel.com (HELO\n\tsilpixa00399498.ger.corp.intel.com) ([10.237.223.151])\n\tby fmsmga005.fm.intel.com with ESMTP; 17 Oct 2019 07:32:06 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.67,308,1566889200\"; d=\"scan'208\";a=\"396282143\"", "From": "Anatoly Burakov <anatoly.burakov@intel.com>", "To": "dev@dpdk.org", "Cc": "Marcin Baran <marcinx.baran@intel.com>,\n\tRobert Sanford <rsanford@akamai.com>,\n\tErik Gabriel Carrillo <erik.g.carrillo@intel.com>,\n\tjohn.mcnamara@intel.com, \n\tbruce.richardson@intel.com, thomas@monjalon.net,\n\tdavid.marchand@redhat.com", "Date": "Thu, 17 Oct 2019 15:31:54 +0100", "Message-Id": "<7eba69a7c008f5ab62fd3a207430ef6a182e1622.1571322634.git.anatoly.burakov@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": [ "<cover.1571322634.git.anatoly.burakov@intel.com>", "<cover.1571322634.git.anatoly.burakov@intel.com>" ], "References": [ "<cover.1571322634.git.anatoly.burakov@intel.com>", "<cover.1571245316.git.anatoly.burakov@intel.com>\n\t<cover.1571322634.git.anatoly.burakov@intel.com>" ], "Subject": "[dpdk-dev] [PATCH v4 04/10] timer: remove deprecated code", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Marcin Baran <marcinx.baran@intel.com>\n\nRemove code for old ABI versions ahead of ABI version bump.\n\nSigned-off-by: Marcin Baran <marcinx.baran@intel.com>\nSigned-off-by: Anatoly Burakov <anatoly.burakov@intel.com>\nAcked-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n\nNotes:\n v2:\n - Moved this to before ABI version bump to avoid compile breakage\n\n lib/librte_timer/rte_timer.c | 90 ++----------------------------------\n lib/librte_timer/rte_timer.h | 15 ------\n 2 files changed, 5 insertions(+), 100 deletions(-)", "diff": "diff --git a/lib/librte_timer/rte_timer.c b/lib/librte_timer/rte_timer.c\nindex bdcf05d06b..de6959b809 100644\n--- a/lib/librte_timer/rte_timer.c\n+++ b/lib/librte_timer/rte_timer.c\n@@ -68,9 +68,6 @@ static struct rte_timer_data *rte_timer_data_arr;\n static const uint32_t default_data_id;\n static uint32_t rte_timer_subsystem_initialized;\n \n-/* For maintaining older interfaces for a period */\n-static struct rte_timer_data default_timer_data;\n-\n /* when debug is enabled, store some statistics */\n #ifdef RTE_LIBRTE_TIMER_DEBUG\n #define __TIMER_STAT_ADD(priv_timer, name, n) do {\t\t\t\\\n@@ -131,22 +128,6 @@ rte_timer_data_dealloc(uint32_t id)\n \treturn 0;\n }\n \n-void\n-rte_timer_subsystem_init_v20(void)\n-{\n-\tunsigned lcore_id;\n-\tstruct priv_timer *priv_timer = default_timer_data.priv_timer;\n-\n-\t/* since priv_timer is static, it's zeroed by default, so only init some\n-\t * fields.\n-\t */\n-\tfor (lcore_id = 0; lcore_id < RTE_MAX_LCORE; lcore_id ++) {\n-\t\trte_spinlock_init(&priv_timer[lcore_id].list_lock);\n-\t\tpriv_timer[lcore_id].prev_lcore = lcore_id;\n-\t}\n-}\n-VERSION_SYMBOL(rte_timer_subsystem_init, _v20, 2.0);\n-\n /* Init the timer library. Allocate an array of timer data structs in shared\n * memory, and allocate the zeroth entry for use with original timer\n * APIs. Since the intersection of the sets of lcore ids in primary and\n@@ -154,7 +135,7 @@ VERSION_SYMBOL(rte_timer_subsystem_init, _v20, 2.0);\n * multiple processes.\n */\n int\n-rte_timer_subsystem_init_v1905(void)\n+rte_timer_subsystem_init(void)\n {\n \tconst struct rte_memzone *mz;\n \tstruct rte_timer_data *data;\n@@ -209,9 +190,6 @@ rte_timer_subsystem_init_v1905(void)\n \n \treturn 0;\n }\n-MAP_STATIC_SYMBOL(int rte_timer_subsystem_init(void),\n-\t\t rte_timer_subsystem_init_v1905);\n-BIND_DEFAULT_SYMBOL(rte_timer_subsystem_init, _v1905, 19.05);\n \n void\n rte_timer_subsystem_finalize(void)\n@@ -552,42 +530,13 @@ __rte_timer_reset(struct rte_timer *tim, uint64_t expire,\n \n /* Reset and start the timer associated with the timer handle tim */\n int\n-rte_timer_reset_v20(struct rte_timer *tim, uint64_t ticks,\n-\t\t enum rte_timer_type type, unsigned int tim_lcore,\n-\t\t rte_timer_cb_t fct, void *arg)\n-{\n-\tuint64_t cur_time = rte_get_timer_cycles();\n-\tuint64_t period;\n-\n-\tif (unlikely((tim_lcore != (unsigned)LCORE_ID_ANY) &&\n-\t\t\t!(rte_lcore_is_enabled(tim_lcore) ||\n-\t\t\t rte_lcore_has_role(tim_lcore, ROLE_SERVICE))))\n-\t\treturn -1;\n-\n-\tif (type == PERIODICAL)\n-\t\tperiod = ticks;\n-\telse\n-\t\tperiod = 0;\n-\n-\treturn __rte_timer_reset(tim, cur_time + ticks, period, tim_lcore,\n-\t\t\t fct, arg, 0, &default_timer_data);\n-}\n-VERSION_SYMBOL(rte_timer_reset, _v20, 2.0);\n-\n-int\n-rte_timer_reset_v1905(struct rte_timer *tim, uint64_t ticks,\n+rte_timer_reset(struct rte_timer *tim, uint64_t ticks,\n \t\t enum rte_timer_type type, unsigned int tim_lcore,\n \t\t rte_timer_cb_t fct, void *arg)\n {\n \treturn rte_timer_alt_reset(default_data_id, tim, ticks, type,\n \t\t\t\t tim_lcore, fct, arg);\n }\n-MAP_STATIC_SYMBOL(int rte_timer_reset(struct rte_timer *tim, uint64_t ticks,\n-\t\t\t\t enum rte_timer_type type,\n-\t\t\t\t unsigned int tim_lcore,\n-\t\t\t\t rte_timer_cb_t fct, void *arg),\n-\t\t rte_timer_reset_v1905);\n-BIND_DEFAULT_SYMBOL(rte_timer_reset, _v1905, 19.05);\n \n int\n rte_timer_alt_reset(uint32_t timer_data_id, struct rte_timer *tim,\n@@ -658,20 +607,10 @@ __rte_timer_stop(struct rte_timer *tim, int local_is_locked,\n \n /* Stop the timer associated with the timer handle tim */\n int\n-rte_timer_stop_v20(struct rte_timer *tim)\n-{\n-\treturn __rte_timer_stop(tim, 0, &default_timer_data);\n-}\n-VERSION_SYMBOL(rte_timer_stop, _v20, 2.0);\n-\n-int\n-rte_timer_stop_v1905(struct rte_timer *tim)\n+rte_timer_stop(struct rte_timer *tim)\n {\n \treturn rte_timer_alt_stop(default_data_id, tim);\n }\n-MAP_STATIC_SYMBOL(int rte_timer_stop(struct rte_timer *tim),\n-\t\t rte_timer_stop_v1905);\n-BIND_DEFAULT_SYMBOL(rte_timer_stop, _v1905, 19.05);\n \n int\n rte_timer_alt_stop(uint32_t timer_data_id, struct rte_timer *tim)\n@@ -817,15 +756,8 @@ __rte_timer_manage(struct rte_timer_data *timer_data)\n \tpriv_timer[lcore_id].running_tim = NULL;\n }\n \n-void\n-rte_timer_manage_v20(void)\n-{\n-\t__rte_timer_manage(&default_timer_data);\n-}\n-VERSION_SYMBOL(rte_timer_manage, _v20, 2.0);\n-\n int\n-rte_timer_manage_v1905(void)\n+rte_timer_manage(void)\n {\n \tstruct rte_timer_data *timer_data;\n \n@@ -835,8 +767,6 @@ rte_timer_manage_v1905(void)\n \n \treturn 0;\n }\n-MAP_STATIC_SYMBOL(int rte_timer_manage(void), rte_timer_manage_v1905);\n-BIND_DEFAULT_SYMBOL(rte_timer_manage, _v1905, 19.05);\n \n int\n rte_timer_alt_manage(uint32_t timer_data_id,\n@@ -1074,21 +1004,11 @@ __rte_timer_dump_stats(struct rte_timer_data *timer_data __rte_unused, FILE *f)\n #endif\n }\n \n-void\n-rte_timer_dump_stats_v20(FILE *f)\n-{\n-\t__rte_timer_dump_stats(&default_timer_data, f);\n-}\n-VERSION_SYMBOL(rte_timer_dump_stats, _v20, 2.0);\n-\n int\n-rte_timer_dump_stats_v1905(FILE *f)\n+rte_timer_dump_stats(FILE *f)\n {\n \treturn rte_timer_alt_dump_stats(default_data_id, f);\n }\n-MAP_STATIC_SYMBOL(int rte_timer_dump_stats(FILE *f),\n-\t\t rte_timer_dump_stats_v1905);\n-BIND_DEFAULT_SYMBOL(rte_timer_dump_stats, _v1905, 19.05);\n \n int\n rte_timer_alt_dump_stats(uint32_t timer_data_id __rte_unused, FILE *f)\ndiff --git a/lib/librte_timer/rte_timer.h b/lib/librte_timer/rte_timer.h\nindex 05d287d8f2..9dc5fc3092 100644\n--- a/lib/librte_timer/rte_timer.h\n+++ b/lib/librte_timer/rte_timer.h\n@@ -181,8 +181,6 @@ int rte_timer_data_dealloc(uint32_t id);\n * subsystem\n */\n int rte_timer_subsystem_init(void);\n-int rte_timer_subsystem_init_v1905(void);\n-void rte_timer_subsystem_init_v20(void);\n \n /**\n * @warning\n@@ -250,13 +248,6 @@ void rte_timer_init(struct rte_timer *tim);\n int rte_timer_reset(struct rte_timer *tim, uint64_t ticks,\n \t\t enum rte_timer_type type, unsigned tim_lcore,\n \t\t rte_timer_cb_t fct, void *arg);\n-int rte_timer_reset_v1905(struct rte_timer *tim, uint64_t ticks,\n-\t\t\t enum rte_timer_type type, unsigned int tim_lcore,\n-\t\t\t rte_timer_cb_t fct, void *arg);\n-int rte_timer_reset_v20(struct rte_timer *tim, uint64_t ticks,\n-\t\t\tenum rte_timer_type type, unsigned int tim_lcore,\n-\t\t\trte_timer_cb_t fct, void *arg);\n-\n \n /**\n * Loop until rte_timer_reset() succeeds.\n@@ -313,8 +304,6 @@ rte_timer_reset_sync(struct rte_timer *tim, uint64_t ticks,\n * - (-1): The timer is in the RUNNING or CONFIG state.\n */\n int rte_timer_stop(struct rte_timer *tim);\n-int rte_timer_stop_v1905(struct rte_timer *tim);\n-int rte_timer_stop_v20(struct rte_timer *tim);\n \n /**\n * Loop until rte_timer_stop() succeeds.\n@@ -358,8 +347,6 @@ int rte_timer_pending(struct rte_timer *tim);\n * - -EINVAL: timer subsystem not yet initialized\n */\n int rte_timer_manage(void);\n-int rte_timer_manage_v1905(void);\n-void rte_timer_manage_v20(void);\n \n /**\n * Dump statistics about timers.\n@@ -371,8 +358,6 @@ void rte_timer_manage_v20(void);\n * - -EINVAL: timer subsystem not yet initialized\n */\n int rte_timer_dump_stats(FILE *f);\n-int rte_timer_dump_stats_v1905(FILE *f);\n-void rte_timer_dump_stats_v20(FILE *f);\n \n /**\n * @warning\n", "prefixes": [ "v4", "04/10" ] }