Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/61364/?format=api
{ "id": 61364, "url": "http://patches.dpdk.org/api/patches/61364/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20191017094124.16725-1-reshma.pattan@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20191017094124.16725-1-reshma.pattan@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20191017094124.16725-1-reshma.pattan@intel.com", "date": "2019-10-17T09:41:23", "name": "[1/2] app/test: fix make build when ring PMD is disabled", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "564225e5e03d12baef9fca8ff73b4868361b7529", "submitter": { "id": 70, "url": "http://patches.dpdk.org/api/people/70/?format=api", "name": "Pattan, Reshma", "email": "reshma.pattan@intel.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20191017094124.16725-1-reshma.pattan@intel.com/mbox/", "series": [ { "id": 6901, "url": "http://patches.dpdk.org/api/series/6901/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=6901", "date": "2019-10-17T09:41:23", "name": "[1/2] app/test: fix make build when ring PMD is disabled", "version": 1, "mbox": "http://patches.dpdk.org/series/6901/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/61364/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/61364/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id D3EB11E8F3;\n\tThu, 17 Oct 2019 11:41:32 +0200 (CEST)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n\tby dpdk.org (Postfix) with ESMTP id 3B7121E8BC;\n\tThu, 17 Oct 2019 11:41:30 +0200 (CEST)", "from fmsmga008.fm.intel.com ([10.253.24.58])\n\tby fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t17 Oct 2019 02:41:30 -0700", "from silpixa00400214.ir.intel.com (HELO\n\tsilpixa00400214.ger.corp.intel.com) ([10.237.222.119])\n\tby fmsmga008.fm.intel.com with ESMTP; 17 Oct 2019 02:41:27 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.67,307,1566889200\"; d=\"scan'208\";a=\"195109928\"", "From": "Reshma Pattan <reshma.pattan@intel.com>", "To": "dev@dpdk.org", "Cc": "Reshma Pattan <reshma.pattan@intel.com>, stable@dpdk.org,\n\tNikhil Rao <nikhil.rao@intel.com>, Chas Williams <chas3@att.com>,\n\tBruce Richardson <bruce.richardson@intel.com>,\n\tStephen Hemminger <stephen@networkplumber.org>", "Date": "Thu, 17 Oct 2019 10:41:23 +0100", "Message-Id": "<20191017094124.16725-1-reshma.pattan@intel.com>", "X-Mailer": "git-send-email 2.21.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 1/2] app/test: fix make build when ring PMD is\n\tdisabled", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "1)pdump, latency, bitrate and test_event_eth_tx_adapter\nunit tests are dependent on ring PMD, so compile those\ntests only when ring PMD is enabled else ignore.\n\n2)get rid of make file error which was added by bond unit test\nfor ring PMD disabled case which is not necessary.\n\nFixes: 086eb64db3 (\"test/pdump: add unit test for pdump library\")\nFixes: fdeb30fa71 (\"test/bitrate: add unit tests for bitrate library\")\nFixes: 1e3676a06e (\"test/latency: add unit tests for latencystats library\")\nFixes: 46cf97e4bb (\"eventdev: add test for eth Tx adapter\")\nFixes: d23e09e0ef (\"app/test: link with ring pmd when needed\")\n\nCC: stable@dpdk.org\nCC: Nikhil Rao <nikhil.rao@intel.com>\nCC: Chas Williams <chas3@att.com>\nCC: Bruce Richardson <bruce.richardson@intel.com>\nCC: Stephen Hemminger <stephen@networkplumber.org>\n\nReported-by: Stephen Hemminger <stephen@networkplumber.org>\nSigned-off-by: Reshma Pattan <reshma.pattan@intel.com>\n---\n app/test/Makefile | 16 ++++++----------\n app/test/process.h | 8 ++++++++\n app/test/test.c | 2 ++\n 3 files changed, 16 insertions(+), 10 deletions(-)", "diff": "diff --git a/app/test/Makefile b/app/test/Makefile\nindex df7f77f44..30ecaf8fb 100644\n--- a/app/test/Makefile\n+++ b/app/test/Makefile\n@@ -144,8 +144,12 @@ SRCS-y += test_func_reentrancy.c\n \n SRCS-y += test_service_cores.c\n \n+ifeq ($(CONFIG_RTE_LIBRTE_PMD_RING),y)\n+SRCS-y += sample_packet_forward.c\n SRCS-$(CONFIG_RTE_LIBRTE_BITRATE) += test_bitratestats.c\n SRCS-$(CONFIG_RTE_LIBRTE_LATENCY_STATS) += test_latencystats.c\n+SRCS-$(CONFIG_RTE_LIBRTE_PDUMP) += test_pdump.c\n+endif\n \n SRCS-$(CONFIG_RTE_LIBRTE_CMDLINE) += test_cmdline.c\n SRCS-$(CONFIG_RTE_LIBRTE_CMDLINE) += test_cmdline_num.c\n@@ -174,11 +178,8 @@ SRCS-$(CONFIG_RTE_LIBRTE_DISTRIBUTOR) += test_distributor_perf.c\n \n SRCS-$(CONFIG_RTE_LIBRTE_REORDER) += test_reorder.c\n \n-SRCS-$(CONFIG_RTE_LIBRTE_PDUMP) += test_pdump.c\n-\n SRCS-y += virtual_pmd.c\n SRCS-y += packet_burst_generator.c\n-SRCS-y += sample_packet_forward.c\n SRCS-$(CONFIG_RTE_LIBRTE_ACL) += test_acl.c\n \n ifeq ($(CONFIG_RTE_LIBRTE_PMD_RING),y)\n@@ -208,7 +209,9 @@ ifeq ($(CONFIG_RTE_LIBRTE_EVENTDEV),y)\n SRCS-y += test_eventdev.c\n SRCS-y += test_event_ring.c\n SRCS-y += test_event_eth_rx_adapter.c\n+ifeq ($(CONFIG_RTE_LIBRTE_RING_PMD),y)\n SRCS-y += test_event_eth_tx_adapter.c\n+endif\n SRCS-y += test_event_timer_adapter.c\n SRCS-y += test_event_crypto_adapter.c\n endif\n@@ -260,13 +263,6 @@ endif\n endif\n endif\n \n-# Link against shared libraries when needed\n-ifeq ($(CONFIG_RTE_LIBRTE_PMD_BOND),y)\n-ifneq ($(CONFIG_RTE_LIBRTE_PMD_RING),y)\n-$(error Link bonding tests require CONFIG_RTE_LIBRTE_PMD_RING=y)\n-endif\n-endif\n-\n ifeq ($(CONFIG_RTE_BUILD_SHARED_LIB),y)\n \n ifeq ($(CONFIG_RTE_LIBRTE_PMD_BOND),y)\ndiff --git a/app/test/process.h b/app/test/process.h\nindex 128ce4121..69c358e02 100644\n--- a/app/test/process.h\n+++ b/app/test/process.h\n@@ -24,10 +24,12 @@\n #endif\n \n #ifdef RTE_LIBRTE_PDUMP\n+#ifdef RTE_LIBRTE_RING_PMD\n #include <pthread.h>\n extern void *send_pkts(void *empty);\n extern uint16_t flag_for_send_pkts;\n #endif\n+#endif\n \n /*\n * launches a second copy of the test process using the given argv parameters,\n@@ -43,7 +45,9 @@ process_dup(const char *const argv[], int numargs, const char *env_value)\n \tint i, fd, status;\n \tchar path[32];\n #ifdef RTE_LIBRTE_PDUMP\n+#ifdef RTE_LIBRTE_RING_PMD\n \tpthread_t thread;\n+#endif\n #endif\n \n \tpid_t pid = fork();\n@@ -83,17 +87,21 @@ process_dup(const char *const argv[], int numargs, const char *env_value)\n \t}\n \t/* parent process does a wait */\n #ifdef RTE_LIBRTE_PDUMP\n+#ifdef RTE_LIBRTE_RING_PMD\n \tif ((strcmp(env_value, \"run_pdump_server_tests\") == 0))\n \t\tpthread_create(&thread, NULL, &send_pkts, NULL);\n+#endif\n #endif\n \n \twhile (wait(&status) != pid)\n \t\t;\n #ifdef RTE_LIBRTE_PDUMP\n+#ifdef RTE_LIBRTE_RING_PMD\n \tif ((strcmp(env_value, \"run_pdump_server_tests\") == 0)) {\n \t\tflag_for_send_pkts = 0;\n \t\tpthread_join(thread, NULL);\n \t}\n+#endif\n #endif\n \treturn status;\n }\ndiff --git a/app/test/test.c b/app/test/test.c\nindex cd7aaf645..d0826ca69 100644\n--- a/app/test/test.c\n+++ b/app/test/test.c\n@@ -53,7 +53,9 @@ do_recursive_call(void)\n \t} actions[] = {\n \t\t\t{ \"run_secondary_instances\", test_mp_secondary },\n #ifdef RTE_LIBRTE_PDUMP\n+#ifdef RTE_LIBRTE_RING_PMD\n \t\t\t{ \"run_pdump_server_tests\", test_pdump },\n+#endif\n #endif\n \t\t\t{ \"test_missing_c_flag\", no_action },\n \t\t\t{ \"test_master_lcore_flag\", no_action },\n", "prefixes": [ "1/2" ] }