Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 60704,
    "url": "http://patches.dpdk.org/api/patches/60704/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20191008143628.46054-4-bruce.richardson@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20191008143628.46054-4-bruce.richardson@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20191008143628.46054-4-bruce.richardson@intel.com",
    "date": "2019-10-08T14:36:28",
    "name": "[3/3] drivers: process shared lib link dependencies as for libs",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "df25e096360b14a7dab2649496cbf2e7b1bfb0a1",
    "submitter": {
        "id": 20,
        "url": "http://patches.dpdk.org/api/people/20/?format=api",
        "name": "Bruce Richardson",
        "email": "bruce.richardson@intel.com"
    },
    "delegate": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/users/1/?format=api",
        "username": "tmonjalo",
        "first_name": "Thomas",
        "last_name": "Monjalon",
        "email": "thomas@monjalon.net"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20191008143628.46054-4-bruce.richardson@intel.com/mbox/",
    "series": [
        {
            "id": 6744,
            "url": "http://patches.dpdk.org/api/series/6744/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=6744",
            "date": "2019-10-08T14:36:25",
            "name": "Add scanning for experimental symbols to meson",
            "version": 1,
            "mbox": "http://patches.dpdk.org/series/6744/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/60704/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/60704/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 34F3C1D44B;\n\tTue,  8 Oct 2019 16:36:49 +0200 (CEST)",
            "from mga18.intel.com (mga18.intel.com [134.134.136.126])\n\tby dpdk.org (Postfix) with ESMTP id B803C1D424\n\tfor <dev@dpdk.org>; Tue,  8 Oct 2019 16:36:44 +0200 (CEST)",
            "from fmsmga007.fm.intel.com ([10.253.24.52])\n\tby orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t08 Oct 2019 07:36:43 -0700",
            "from silpixa00399126.ir.intel.com (HELO\n\tsilpixa00399126.ger.corp.intel.com) ([10.237.223.2])\n\tby fmsmga007.fm.intel.com with ESMTP; 08 Oct 2019 07:36:42 -0700"
        ],
        "X-Amp-Result": "SKIPPED(no attachment in message)",
        "X-Amp-File-Uploaded": "False",
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.67,270,1566889200\"; d=\"scan'208\";a=\"193394098\"",
        "From": "Bruce Richardson <bruce.richardson@intel.com>",
        "To": "dev@dpdk.org",
        "Cc": "thomas@monjalon.net, Neil Horman <nhorman@tuxdriver.com>,\n\tbluca@debian.org, \n\tray.kinsella@intel.com, Bruce Richardson <bruce.richardson@intel.com>",
        "Date": "Tue,  8 Oct 2019 15:36:28 +0100",
        "Message-Id": "<20191008143628.46054-4-bruce.richardson@intel.com>",
        "X-Mailer": "git-send-email 2.21.0",
        "In-Reply-To": "<20191008143628.46054-1-bruce.richardson@intel.com>",
        "References": "<20191008143628.46054-1-bruce.richardson@intel.com>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "Subject": "[dpdk-dev] [PATCH 3/3] drivers: process shared lib link\n\tdependencies as for libs",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "For the public APIs of DPDK libraries we run checks for correct use of\nexperimental tags, and also do dynamic generation of the version file to\nits window's equivalent. Although must drivers don't export APIs, some do,\nso these checks are relevant and should be copied from lib/meson.build to\ndrivers/meson.build.\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n drivers/meson.build | 27 +++++++++++++++++++++++++--\n 1 file changed, 25 insertions(+), 2 deletions(-)",
    "diff": "diff --git a/drivers/meson.build b/drivers/meson.build\nindex 2ed2e9541..fd5a8aa59 100644\n--- a/drivers/meson.build\n+++ b/drivers/meson.build\n@@ -131,14 +131,37 @@ foreach class:dpdk_driver_classes\n \t\t\tversion_map = '@0@/@1@/@2@_version.map'.format(\n \t\t\t\t\tmeson.current_source_dir(),\n \t\t\t\t\tdrv_path, lib_name)\n+\t\t\timplib = dir_name + '.dll.a'\n+\n+\t\t\tdef_file = custom_target(lib_name + '_def',\n+\t\t\t\tcommand: [map_to_def_cmd, '@INPUT@', '@OUTPUT@'],\n+\t\t\t\tinput: version_map,\n+\t\t\t\toutput: '@0@_exports.def'.format(lib_name))\n+\t\t\tlk_deps = [version_map, def_file]\n+\t\t\tif is_windows\n+\t\t\t\tlk_args = ['-Wl,/def:' + def_file.full_path(),\n+\t\t\t\t\t'-Wl,/implib:lib\\\\' + implib]\n+\t\t\telse\n+\t\t\t\tlk_args = ['-Wl,--version-script=' + version_map]\n+\t\t\t\t# on unix systems check the output of the\n+\t\t\t\t# experimental syms script, using it as a\n+\t\t\t\t# dependency of the .so build\n+\t\t\t\tlk_deps += custom_target(lib_name + '.exp_chk',\n+\t\t\t\t\tcommand: [check_experimental_syms,\n+\t\t\t\t\t\tversion_map, '@INPUT@'],\n+\t\t\t\t\tcapture: true,\n+\t\t\t\t\tinput: static_lib,\n+\t\t\t\t\toutput: lib_name + '.exp_chk')\n+\t\t\tendif\n+\n \t\t\tshared_lib = shared_library(lib_name,\n \t\t\t\tsources,\n \t\t\t\tobjects: objs,\n \t\t\t\tinclude_directories: includes,\n \t\t\t\tdependencies: shared_objs,\n \t\t\t\tc_args: cflags,\n-\t\t\t\tlink_args: '-Wl,--version-script=' + version_map,\n-\t\t\t\tlink_depends: version_map,\n+\t\t\t\tlink_args: lk_args,\n+\t\t\t\tlink_depends: lk_deps,\n \t\t\t\tversion: lib_version,\n \t\t\t\tsoversion: so_version,\n \t\t\t\tinstall: true,\n",
    "prefixes": [
        "3/3"
    ]
}