Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/60198/?format=api
{ "id": 60198, "url": "http://patches.dpdk.org/api/patches/60198/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/5af3e8a1552e9a2fb23522255c72ca02ca60df95.1569850827.git.cloud.wangxiaoyun@huawei.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<5af3e8a1552e9a2fb23522255c72ca02ca60df95.1569850827.git.cloud.wangxiaoyun@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/5af3e8a1552e9a2fb23522255c72ca02ca60df95.1569850827.git.cloud.wangxiaoyun@huawei.com", "date": "2019-09-30T14:00:49", "name": "[v3,11/19] net/hinic: flush fdir filter", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "741dffc0b7c312abebe0a1e0eef823feed8a5ce7", "submitter": { "id": 1446, "url": "http://patches.dpdk.org/api/people/1446/?format=api", "name": "Wangxiaoyun (Cloud)", "email": "cloud.wangxiaoyun@huawei.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/5af3e8a1552e9a2fb23522255c72ca02ca60df95.1569850827.git.cloud.wangxiaoyun@huawei.com/mbox/", "series": [ { "id": 6622, "url": "http://patches.dpdk.org/api/series/6622/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=6622", "date": "2019-09-30T14:00:38", "name": "Add advanced features for Huawei hinic pmd", "version": 3, "mbox": "http://patches.dpdk.org/series/6622/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/60198/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/60198/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 8AF231BE9D;\n\tMon, 30 Sep 2019 15:49:12 +0200 (CEST)", "from huawei.com (szxga05-in.huawei.com [45.249.212.191])\n\tby dpdk.org (Postfix) with ESMTP id 807E51BE96\n\tfor <dev@dpdk.org>; Mon, 30 Sep 2019 15:49:09 +0200 (CEST)", "from DGGEMS413-HUB.china.huawei.com (unknown [172.30.72.58])\n\tby Forcepoint Email with ESMTP id 85CEC8F211783D5E231B\n\tfor <dev@dpdk.org>; Mon, 30 Sep 2019 21:49:08 +0800 (CST)", "from tester.localdomain (10.175.119.39) by\n\tDGGEMS413-HUB.china.huawei.com (10.3.19.213) with Microsoft SMTP\n\tServer id 14.3.439.0; Mon, 30 Sep 2019 21:49:00 +0800" ], "From": "Xiaoyun wang <cloud.wangxiaoyun@huawei.com>", "To": "<ferruh.yigit@intel.com>", "CC": "<dev@dpdk.org>, <xuanziyang2@huawei.com>, <shahar.belkar@huawei.com>,\n\t<luoxianjun@huawei.com>, <tanya.brokhman@huawei.com>,\n\t<zhouguoyang@huawei.com>, <wulike1@huawei.com>, Xiaoyun wang\n\t<cloud.wangxiaoyun@huawei.com>", "Date": "Mon, 30 Sep 2019 22:00:49 +0800", "Message-ID": "<5af3e8a1552e9a2fb23522255c72ca02ca60df95.1569850827.git.cloud.wangxiaoyun@huawei.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<cover.1569850826.git.cloud.wangxiaoyun@huawei.com>", "References": "<cover.1569850826.git.cloud.wangxiaoyun@huawei.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[10.175.119.39]", "X-CFilter-Loop": "Reflected", "Subject": "[dpdk-dev] [PATCH v3 11/19] net/hinic: flush fdir filter", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Supports to flush fdir filter.\nDestroy all flow rules associated with a port on hinic.\n\nSigned-off-by: Xiaoyun wang <cloud.wangxiaoyun@huawei.com>\n---\n drivers/net/hinic/hinic_pmd_ethdev.c | 16 ++++\n drivers/net/hinic/hinic_pmd_ethdev.h | 3 +-\n drivers/net/hinic/hinic_pmd_flow.c | 140 +++++++++++++++++++++++++++++++++++\n 3 files changed, 158 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/hinic/hinic_pmd_ethdev.c b/drivers/net/hinic/hinic_pmd_ethdev.c\nindex f2f0fa9..d0bcbe5 100644\n--- a/drivers/net/hinic/hinic_pmd_ethdev.c\n+++ b/drivers/net/hinic/hinic_pmd_ethdev.c\n@@ -341,6 +341,9 @@ static int hinic_dev_configure(struct rte_eth_dev *dev)\n \t\treturn err;\n \t}\n \n+\t/*clear fdir filter flag in function table*/\n+\thinic_free_fdir_filter(nic_dev);\n+\n \treturn HINIC_OK;\n }\n \n@@ -1115,6 +1118,8 @@ static void hinic_dev_stop(struct rte_eth_dev *dev)\n \t/* clean root context */\n \thinic_free_qp_ctxts(nic_dev->hwdev);\n \n+\thinic_free_fdir_filter(nic_dev);\n+\n \t/* free mbuf */\n \thinic_free_all_rx_mbuf(dev);\n \thinic_free_all_tx_mbuf(dev);\n@@ -2816,6 +2821,7 @@ static int hinic_func_init(struct rte_eth_dev *eth_dev)\n \tstruct rte_pci_device *pci_dev;\n \tstruct rte_ether_addr *eth_addr;\n \tstruct hinic_nic_dev *nic_dev;\n+\tstruct hinic_filter_info *filter_info;\n \tu32 mac_size;\n \tint rc;\n \n@@ -2907,6 +2913,16 @@ static int hinic_func_init(struct rte_eth_dev *eth_dev)\n \t}\n \thinic_set_bit(HINIC_DEV_INTR_EN, &nic_dev->dev_status);\n \n+\t/* initialize filter info */\n+\tfilter_info = &nic_dev->filter;\n+\tmemset(filter_info, 0, sizeof(struct hinic_filter_info));\n+\t/* initialize 5tuple filter list */\n+\tTAILQ_INIT(&filter_info->fivetuple_list);\n+\tTAILQ_INIT(&nic_dev->filter_ntuple_list);\n+\tTAILQ_INIT(&nic_dev->filter_ethertype_list);\n+\tTAILQ_INIT(&nic_dev->filter_fdir_rule_list);\n+\tTAILQ_INIT(&nic_dev->hinic_flow_list);\n+\n \thinic_set_bit(HINIC_DEV_INIT, &nic_dev->dev_status);\n \tPMD_DRV_LOG(INFO, \"Initialize %s in primary successfully\",\n \t\t eth_dev->data->name);\ndiff --git a/drivers/net/hinic/hinic_pmd_ethdev.h b/drivers/net/hinic/hinic_pmd_ethdev.h\nindex b7fcef6..dd96667 100644\n--- a/drivers/net/hinic/hinic_pmd_ethdev.h\n+++ b/drivers/net/hinic/hinic_pmd_ethdev.h\n@@ -173,7 +173,6 @@ struct hinic_nic_dev {\n \tu32 rx_mode_status;\t/* promisc or allmulticast */\n \tunsigned long dev_status;\n \n-\t/* dpdk only */\n \tchar proc_dev_name[HINIC_DEV_NAME_LEN];\n \t/* PF0->COS4, PF1->COS5, PF2->COS6, PF3->COS7,\n \t * vf: the same with associate pf\n@@ -187,4 +186,6 @@ struct hinic_nic_dev {\n \tstruct hinic_flow_mem_list hinic_flow_list;\n };\n \n+void hinic_free_fdir_filter(struct hinic_nic_dev *nic_dev);\n+\n #endif /* _HINIC_PMD_ETHDEV_H_ */\ndiff --git a/drivers/net/hinic/hinic_pmd_flow.c b/drivers/net/hinic/hinic_pmd_flow.c\nindex b2eff2e..49c9d87 100644\n--- a/drivers/net/hinic/hinic_pmd_flow.c\n+++ b/drivers/net/hinic/hinic_pmd_flow.c\n@@ -1456,6 +1456,40 @@ static int hinic_set_vrrp_tcam(struct hinic_nic_dev *nic_dev)\n \t\t\t\t\t&vrrp_rule, &vrrp_action);\n }\n \n+/**\n+ * Clear all fdir configuration.\n+ *\n+ * @param nic_dev\n+ * The hardware interface of a Ethernet device.\n+ *\n+ * @return\n+ * 0 on success,\n+ * negative error value otherwise.\n+ */\n+void hinic_free_fdir_filter(struct hinic_nic_dev *nic_dev)\n+{\n+\tstruct hinic_filter_info *filter_info =\n+\t\tHINIC_DEV_PRIVATE_TO_FILTER_INFO(nic_dev);\n+\n+\tif (filter_info->type_mask &\n+\t (1 << HINIC_PKT_TYPE_FIND_ID(PKT_BGPD_DPORT_TYPE)))\n+\t\thinic_clear_fdir_tcam(nic_dev->hwdev, TCAM_PKT_BGP_DPORT);\n+\n+\tif (filter_info->type_mask &\n+\t (1 << HINIC_PKT_TYPE_FIND_ID(PKT_BGPD_SPORT_TYPE)))\n+\t\thinic_clear_fdir_tcam(nic_dev->hwdev, TCAM_PKT_BGP_SPORT);\n+\n+\tif (filter_info->type_mask &\n+\t (1 << HINIC_PKT_TYPE_FIND_ID(PKT_VRRP_TYPE)))\n+\t\thinic_clear_fdir_tcam(nic_dev->hwdev, TCAM_PKT_VRRP);\n+\n+\tif (filter_info->type_mask &\n+\t (1 << HINIC_PKT_TYPE_FIND_ID(PKT_LACP_TYPE)))\n+\t\thinic_clear_fdir_tcam(nic_dev->hwdev, TCAM_PKT_LACP);\n+\n+\thinic_set_fdir_filter(nic_dev->hwdev, 0, 0, 0, false);\n+}\n+\n static int\n hinic_filter_info_init(struct hinic_5tuple_filter *filter,\n \t\t struct hinic_filter_info *filter_info)\n@@ -2238,8 +2272,114 @@ static int hinic_flow_destroy(struct rte_eth_dev *dev,\n \treturn ret;\n }\n \n+/* Remove all the n-tuple filters */\n+static void hinic_clear_all_ntuple_filter(struct rte_eth_dev *dev)\n+{\n+\tstruct hinic_filter_info *filter_info =\n+\t\tHINIC_DEV_PRIVATE_TO_FILTER_INFO(dev->data->dev_private);\n+\tstruct hinic_5tuple_filter *p_5tuple;\n+\n+\twhile ((p_5tuple = TAILQ_FIRST(&filter_info->fivetuple_list)))\n+\t\thinic_remove_5tuple_filter(dev, p_5tuple);\n+}\n+\n+/* Remove all the ether type filters */\n+static void hinic_clear_all_ethertype_filter(struct rte_eth_dev *dev)\n+{\n+\tstruct hinic_nic_dev *nic_dev = HINIC_ETH_DEV_TO_PRIVATE_NIC_DEV(dev);\n+\tstruct hinic_filter_info *filter_info =\n+\t\tHINIC_DEV_PRIVATE_TO_FILTER_INFO(nic_dev);\n+\tint ret = 0;\n+\n+\tif (filter_info->type_mask &\n+\t\t(1 << HINIC_PKT_TYPE_FIND_ID(PKT_LACP_TYPE))) {\n+\t\thinic_ethertype_filter_remove(filter_info,\n+\t\t\tHINIC_PKT_TYPE_FIND_ID(PKT_LACP_TYPE));\n+\t\tret = hinic_set_fdir_filter(nic_dev->hwdev, PKT_LACP_TYPE,\n+\t\t\t\t\tfilter_info->qid, false, true);\n+\n+\t\t(void)hinic_clear_fdir_tcam(nic_dev->hwdev, TCAM_PKT_LACP);\n+\t}\n+\n+\tif (filter_info->type_mask &\n+\t\t(1 << HINIC_PKT_TYPE_FIND_ID(PKT_ARP_TYPE))) {\n+\t\thinic_ethertype_filter_remove(filter_info,\n+\t\t\tHINIC_PKT_TYPE_FIND_ID(PKT_ARP_TYPE));\n+\t\tret = hinic_set_fdir_filter(nic_dev->hwdev, PKT_ARP_TYPE,\n+\t\t\tfilter_info->qid, false, true);\n+\t}\n+\n+\tif (ret)\n+\t\tPMD_DRV_LOG(ERR, \"Clear ethertype failed, filter type: 0x%x\",\n+\t\t\t\tfilter_info->pkt_type);\n+}\n+\n+/* Remove all the ether type filters */\n+static void hinic_clear_all_fdir_filter(struct rte_eth_dev *dev)\n+{\n+\tstruct hinic_nic_dev *nic_dev = HINIC_ETH_DEV_TO_PRIVATE_NIC_DEV(dev);\n+\n+\t(void)hinic_set_fdir_filter(nic_dev->hwdev, 0, 0, 0, false);\n+}\n+\n+static void hinic_filterlist_flush(struct rte_eth_dev *dev)\n+{\n+\tstruct hinic_ntuple_filter_ele *ntuple_filter_ptr;\n+\tstruct hinic_ethertype_filter_ele *ethertype_filter_ptr;\n+\tstruct hinic_fdir_rule_ele *fdir_rule_ptr;\n+\tstruct hinic_flow_mem *hinic_flow_mem_ptr;\n+\tstruct hinic_nic_dev *nic_dev = HINIC_ETH_DEV_TO_PRIVATE_NIC_DEV(dev);\n+\n+\twhile ((ntuple_filter_ptr =\n+\t\t\tTAILQ_FIRST(&nic_dev->filter_ntuple_list))) {\n+\t\tTAILQ_REMOVE(&nic_dev->filter_ntuple_list, ntuple_filter_ptr,\n+\t\t\t\t entries);\n+\t\trte_free(ntuple_filter_ptr);\n+\t}\n+\n+\twhile ((ethertype_filter_ptr =\n+\t\t\tTAILQ_FIRST(&nic_dev->filter_ethertype_list))) {\n+\t\tTAILQ_REMOVE(&nic_dev->filter_ethertype_list,\n+\t\t\t\tethertype_filter_ptr,\n+\t\t\t\tentries);\n+\t\trte_free(ethertype_filter_ptr);\n+\t}\n+\n+\twhile ((fdir_rule_ptr =\n+\t\t\tTAILQ_FIRST(&nic_dev->filter_fdir_rule_list))) {\n+\t\tTAILQ_REMOVE(&nic_dev->filter_fdir_rule_list, fdir_rule_ptr,\n+\t\t\t\t entries);\n+\t\trte_free(fdir_rule_ptr);\n+\t}\n+\n+\twhile ((hinic_flow_mem_ptr =\n+\t\t\tTAILQ_FIRST(&nic_dev->hinic_flow_list))) {\n+\t\tTAILQ_REMOVE(&nic_dev->hinic_flow_list, hinic_flow_mem_ptr,\n+\t\t\t\t entries);\n+\t\trte_free(hinic_flow_mem_ptr->flow);\n+\t\trte_free(hinic_flow_mem_ptr);\n+\t}\n+}\n+\n+/* Destroy all flow rules associated with a port on hinic. */\n+static int hinic_flow_flush(struct rte_eth_dev *dev,\n+\t\t\t\t__rte_unused struct rte_flow_error *error)\n+{\n+\tstruct hinic_nic_dev *nic_dev = HINIC_ETH_DEV_TO_PRIVATE_NIC_DEV(dev);\n+\n+\thinic_clear_all_ntuple_filter(dev);\n+\thinic_clear_all_ethertype_filter(dev);\n+\thinic_clear_all_fdir_filter(dev);\n+\thinic_filterlist_flush(dev);\n+\n+\tPMD_DRV_LOG(INFO, \"Flush flow succeed, func_id: 0x%x\",\n+\t\t\thinic_global_func_id(nic_dev->hwdev));\n+\treturn 0;\n+}\n+\n const struct rte_flow_ops hinic_flow_ops = {\n \t.validate = hinic_flow_validate,\n \t.create = hinic_flow_create,\n \t.destroy = hinic_flow_destroy,\n+\t.flush = hinic_flow_flush,\n };\n", "prefixes": [ "v3", "11/19" ] }