Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/59307/?format=api
http://patches.dpdk.org/api/patches/59307/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190917075754.8310-2-amo@semihalf.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190917075754.8310-2-amo@semihalf.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190917075754.8310-2-amo@semihalf.com", "date": "2019-09-17T07:57:45", "name": "[v2,01/10] build: add an option to enable LTO build", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "03af4aeb797a54339d71432e559961e4262926df", "submitter": { "id": 1112, "url": "http://patches.dpdk.org/api/people/1112/?format=api", "name": "Andrzej Ostruszka", "email": "amo@semihalf.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190917075754.8310-2-amo@semihalf.com/mbox/", "series": [ { "id": 6422, "url": "http://patches.dpdk.org/api/series/6422/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=6422", "date": "2019-09-17T07:57:44", "name": "Add an option to use LTO for DPDK build", "version": 2, "mbox": "http://patches.dpdk.org/series/6422/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/59307/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/59307/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 60D7A1BFB1;\n\tTue, 17 Sep 2019 09:58:01 +0200 (CEST)", "from mail-lj1-f181.google.com (mail-lj1-f181.google.com\n\t[209.85.208.181]) by dpdk.org (Postfix) with ESMTP id 361771BEF6\n\tfor <dev@dpdk.org>; Tue, 17 Sep 2019 09:57:58 +0200 (CEST)", "by mail-lj1-f181.google.com with SMTP id v24so2478314ljj.3\n\tfor <dev@dpdk.org>; Tue, 17 Sep 2019 00:57:58 -0700 (PDT)", "from localhost.localdomain (31-172-191-173.noc.fibertech.net.pl.\n\t[31.172.191.173]) by smtp.googlemail.com with ESMTPSA id\n\tg1sm270659ljl.31.2019.09.17.00.57.56\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 17 Sep 2019 00:57:56 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=semihalf-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=ykPAefym3BtFAAk1jbBEoBlK8v18NTsHvYb9y8MhNcQ=;\n\tb=oLvG/QK2y6Wkg2Zv35L0WFt0hUBj9bszqEu2HwBRG7M4wVxCZL+F8y+UZsDnJhx2dt\n\tle9u8pdbKQykVBxaJpFIuCXSjm0DbrOdqwhOiqAtxEcK7uzotXrvunphmpONNySk635q\n\tmabGb2qhHehI6219l+gBMUZcxP4BEWA4rTPyRROE/8khQ7cPQQxqstGSzekGHSDRuvml\n\togIXNc6aJj89+afgBTHzkMGI/xogWwYcvP3OGvnHXVciQCmfaAyT7OC46AYzcTFo33Ia\n\thMDlN84n96hr2+7PddfYuWKNwUJ/LqgL7o/XH3amhEr8UCH2zpzt9qBtQ7Y9dfDNfhIJ\n\tlm4w==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=ykPAefym3BtFAAk1jbBEoBlK8v18NTsHvYb9y8MhNcQ=;\n\tb=Zp7UywJO43yaUTNWql7MKCIX8cmj0oW6i9+Kk78TJWa30r/CqCa5MAZrvVZvQC+8J9\n\tFg3ByMlm1J0sh4R7zY+vFt737QnMQo1ZQFXYMXc0kq9WYOrsB+lhnD4/W3O2pF4g7GcM\n\tkBjZ8l9MZ7K2KrYU6M8+Q849+mrB+QKltw3GHK3YhiFqORhQqTl8XiIQYvOrrcftoCMl\n\tbmY50+g+c6hzT4iUPYnI2oS0nmPlFAQqodWevQlemxvserR1GkyjqyqObo3PHgfq3/pi\n\t87J46UCO3lg4ytBPXdh6X1QHzt8rLDcmODyexpAmrhWa+vNM+cTCras/5QtRnotJv7/u\n\tlOuQ==", "X-Gm-Message-State": "APjAAAVqKO4Io3RvLhFsZm67bZD8TtxbfjYIO1uHeFNTj/feLChOjFTH\n\tGnXWR5ERsqzuLkEsIVGnNh5etYOQCKyKYA==", "X-Google-Smtp-Source": "APXvYqyIdMI4/PNeMkrPxTA22b/+fefFFHzTqewzUqckLIgDO2Y0qtI0ZGzSLKhTQhIKLQz8NPYDvA==", "X-Received": "by 2002:a2e:9f03:: with SMTP id u3mr1102694ljk.140.1568707077168;\n\tTue, 17 Sep 2019 00:57:57 -0700 (PDT)", "From": "Andrzej Ostruszka <amo@semihalf.com>", "To": "dev@dpdk.org, Aaron Conole <aconole@redhat.com>,\n\tMichael Santana <msantana@redhat.com>,\n\tThomas Monjalon <thomas@monjalon.net>,\n\tJohn McNamara <john.mcnamara@intel.com>,\n\tMarko Kovacevic <marko.kovacevic@intel.com>,\n\tDavid Hunt <david.hunt@intel.com>,\n\tBruce Richardson <bruce.richardson@intel.com>,\n\tVladimir Medvedkin <vladimir.medvedkin@intel.com>,\n\tRobert Sanford <rsanford@akamai.com>,\n\tErik Gabriel Carrillo <erik.g.carrillo@intel.com>", "Cc": "mattias.ronnblom@ericsson.com, stephen@networkplumber.org,\n\tAndrzej Ostruszka <aostruszka@marvell.com>", "Date": "Tue, 17 Sep 2019 09:57:45 +0200", "Message-Id": "<20190917075754.8310-2-amo@semihalf.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20190917075754.8310-1-amo@semihalf.com>", "References": "<20190917075754.8310-1-amo@semihalf.com>", "Subject": "[dpdk-dev] [PATCH v2 01/10] build: add an option to enable LTO build", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This patch adds an option to enable link time optimization. In addition\nto LTO option itself (-flto) fat-lto-objects are being used. This is\nbecause during the build pmdinfogen scans the generated ELF objects to\nfind this_pmd_name* symbol in symbol table. Without fat-lto-objects gcc\nproduces ELF only with extra symbols for internal use during linking and\nclang does not produce ELF at all (only LLVM IR bitcode).\n\nSigned-off-by: Andrzej Ostruszka <aostruszka@marvell.com>\n---\n .travis.yml | 7 ++++\n config/common_base | 5 +++\n config/meson.build | 15 ++++++++\n doc/guides/prog_guide/lto.rst | 37 ++++++++++++++++++++\n doc/guides/rel_notes/release_19_11.rst | 8 +++++\n lib/librte_distributor/rte_distributor.c | 18 +++++-----\n lib/librte_distributor/rte_distributor_v20.c | 18 +++++-----\n lib/librte_lpm/rte_lpm.c | 28 +++++++--------\n lib/librte_lpm/rte_lpm6.c | 16 ++++-----\n lib/librte_timer/rte_timer.c | 20 +++++------\n mk/toolchain/clang/rte.toolchain-compat.mk | 4 +++\n mk/toolchain/clang/rte.vars.mk | 8 +++++\n mk/toolchain/gcc/rte.toolchain-compat.mk | 4 +++\n mk/toolchain/gcc/rte.vars.mk | 12 +++++++\n mk/toolchain/icc/rte.vars.mk | 8 +++++\n 15 files changed, 158 insertions(+), 50 deletions(-)\n create mode 100644 doc/guides/prog_guide/lto.rst", "diff": "diff --git a/.travis.yml b/.travis.yml\nindex 781f9f666..70d221852 100644\n--- a/.travis.yml\n+++ b/.travis.yml\n@@ -31,6 +31,7 @@ env:\n - DEF_LIB=\"static\" OPTS=\"-Denable_kmods=false\"\n - DEF_LIB=\"shared\" OPTS=\"-Denable_kmods=false\"\n - DEF_LIB=\"shared\" RUN_TESTS=1 BUILD_DOCS=1\n+ - DEF_LIB=\"shared\" OPTS=\"-Db_lto=true\"\n \n matrix:\n include:\n@@ -100,6 +101,12 @@ matrix:\n apt:\n packages:\n - *extra_packages\n+ - env: DEF_LIB=\"shared\" OPTS=\"-Db_lto=true\" EXTRA_PACKAGES=1\n+ compiler: gcc\n+ addons:\n+ apt:\n+ packages:\n+ - *extra_packages\n \n \n script: ./.ci/${TRAVIS_OS_NAME}-build.sh\ndiff --git a/config/common_base b/config/common_base\nindex 8ef75c203..73a55fdec 100644\n--- a/config/common_base\n+++ b/config/common_base\n@@ -49,6 +49,11 @@ CONFIG_RTE_FORCE_INTRINSICS=n\n #\n CONFIG_RTE_ARCH_STRICT_ALIGN=n\n \n+#\n+# Enable link time optimization\n+#\n+CONFIG_RTE_ENABLE_LTO=n\n+\n #\n # Compile to share library\n #\ndiff --git a/config/meson.build b/config/meson.build\nindex 2bafea530..97bbc323b 100644\n--- a/config/meson.build\n+++ b/config/meson.build\n@@ -196,3 +196,18 @@ add_project_arguments('-D_GNU_SOURCE', language: 'c')\n if is_freebsd\n \tadd_project_arguments('-D__BSD_VISIBLE', language: 'c')\n endif\n+\n+if get_option('b_lto')\n+\tif cc.has_argument('-ffat-lto-objects')\n+\t\tadd_project_arguments('-ffat-lto-objects', language: 'c')\n+\telse\n+\t\terror('compiler does not support fat LTO objects - please turn LTO off')\n+\tendif\n+\tif cc.get_id() == 'gcc'\n+\t\t# workaround for bug 81440\n+\t\tif cc.version().version_compare('<8.0')\n+\t\t\tadd_project_arguments('-Wno-lto-type-mismatch', language: 'c')\n+\t\t\tadd_project_link_arguments('-Wno-lto-type-mismatch', language: 'c')\n+\t\tendif\n+\tendif\n+endif\ndiff --git a/doc/guides/prog_guide/lto.rst b/doc/guides/prog_guide/lto.rst\nnew file mode 100644\nindex 000000000..b2b36e51c\n--- /dev/null\n+++ b/doc/guides/prog_guide/lto.rst\n@@ -0,0 +1,37 @@\n+Link Time Optimization\n+======================\n+\n+The DPDK framework supports compilation with link time optimization\n+turned on. This depends obviously on the capabilities of the compiler\n+to do \"whole program\" optimization at link time and is available only\n+for compilers that support that feature (gcc, clang and icc). To be\n+more specific compiler have to support creation of ELF objects\n+containing both normal code and internal representation\n+(fat-lto-objects). This is required since during build some code is\n+generated by parsing produced ELF objects (pmdinfogen).\n+\n+The amount of performance gain that one can get from LTO depends on the\n+compiler and the code that is being compiled. However LTO is also\n+useful for additional code analysis done by the compiler. In particular\n+due to interprocedural analysis compiler can produce additional warnings\n+about variables that might be used uninitialized. Some of these\n+warnings might be \"false positives\" though and you might need to\n+explicitly initialize variable in order to silence the compiler.\n+\n+Link time optimization can be enabled for whole DPDK framework by\n+setting:\n+\n+.. code-block:: console\n+ CONFIG_ENABLE_LTO=y\n+\n+in config file for the case of make based build and by:\n+\n+.. code-block:: console\n+ meson build -Db_lto=true -Ddefault_library=shared\n+ ninja -C build\n+\n+for the case of meson based build (only shared libraries are supported\n+when building with meson and LTO enabled).\n+\n+Please note that turning LTO on causes considerable extension of\n+compilation time.\ndiff --git a/doc/guides/rel_notes/release_19_11.rst b/doc/guides/rel_notes/release_19_11.rst\nindex 8490d897c..97b4f4083 100644\n--- a/doc/guides/rel_notes/release_19_11.rst\n+++ b/doc/guides/rel_notes/release_19_11.rst\n@@ -56,6 +56,14 @@ New Features\n Also, make sure to start the actual text at the margin.\n =========================================================\n \n+**Added build support for Link Time Optimization.**\n+\n+ LTO is an optimization technique used by the compiler to perform whole\n+ program analysis and optimization at link time. In order to do that\n+ compilers store their internal representation of the source code that\n+ the linker uses at the final stage of compilation process.\n+\n+ See :doc:`../prog_guide/lto` for more information:\n \n Removed Items\n -------------\ndiff --git a/lib/librte_distributor/rte_distributor.c b/lib/librte_distributor/rte_distributor.c\nindex 21eb1fb0a..848250f4a 100644\n--- a/lib/librte_distributor/rte_distributor.c\n+++ b/lib/librte_distributor/rte_distributor.c\n@@ -32,7 +32,7 @@ EAL_REGISTER_TAILQ(rte_dist_burst_tailq)\n \n /**** Burst Packet APIs called by workers ****/\n \n-void\n+void __vsym\n rte_distributor_request_pkt_v1705(struct rte_distributor *d,\n \t\tunsigned int worker_id, struct rte_mbuf **oldpkt,\n \t\tunsigned int count)\n@@ -84,7 +84,7 @@ MAP_STATIC_SYMBOL(void rte_distributor_request_pkt(struct rte_distributor *d,\n \t\tunsigned int count),\n \t\trte_distributor_request_pkt_v1705);\n \n-int\n+int __vsym\n rte_distributor_poll_pkt_v1705(struct rte_distributor *d,\n \t\tunsigned int worker_id, struct rte_mbuf **pkts)\n {\n@@ -124,7 +124,7 @@ MAP_STATIC_SYMBOL(int rte_distributor_poll_pkt(struct rte_distributor *d,\n \t\tunsigned int worker_id, struct rte_mbuf **pkts),\n \t\trte_distributor_poll_pkt_v1705);\n \n-int\n+int __vsym\n rte_distributor_get_pkt_v1705(struct rte_distributor *d,\n \t\tunsigned int worker_id, struct rte_mbuf **pkts,\n \t\tstruct rte_mbuf **oldpkt, unsigned int return_count)\n@@ -159,7 +159,7 @@ MAP_STATIC_SYMBOL(int rte_distributor_get_pkt(struct rte_distributor *d,\n \t\tstruct rte_mbuf **oldpkt, unsigned int return_count),\n \t\trte_distributor_get_pkt_v1705);\n \n-int\n+int __vsym\n rte_distributor_return_pkt_v1705(struct rte_distributor *d,\n \t\tunsigned int worker_id, struct rte_mbuf **oldpkt, int num)\n {\n@@ -335,7 +335,7 @@ release(struct rte_distributor *d, unsigned int wkr)\n \n \n /* process a set of packets to distribute them to workers */\n-int\n+int __vsym\n rte_distributor_process_v1705(struct rte_distributor *d,\n \t\tstruct rte_mbuf **mbufs, unsigned int num_mbufs)\n {\n@@ -476,7 +476,7 @@ MAP_STATIC_SYMBOL(int rte_distributor_process(struct rte_distributor *d,\n \t\trte_distributor_process_v1705);\n \n /* return to the caller, packets returned from workers */\n-int\n+int __vsym\n rte_distributor_returned_pkts_v1705(struct rte_distributor *d,\n \t\tstruct rte_mbuf **mbufs, unsigned int max_mbufs)\n {\n@@ -526,7 +526,7 @@ total_outstanding(const struct rte_distributor *d)\n * Flush the distributor, so that there are no outstanding packets in flight or\n * queued up.\n */\n-int\n+int __vsym\n rte_distributor_flush_v1705(struct rte_distributor *d)\n {\n \tunsigned int flushed;\n@@ -561,7 +561,7 @@ MAP_STATIC_SYMBOL(int rte_distributor_flush(struct rte_distributor *d),\n \t\trte_distributor_flush_v1705);\n \n /* clears the internal returns array in the distributor */\n-void\n+void __vsym\n rte_distributor_clear_returns_v1705(struct rte_distributor *d)\n {\n \tunsigned int wkr;\n@@ -581,7 +581,7 @@ MAP_STATIC_SYMBOL(void rte_distributor_clear_returns(struct rte_distributor *d),\n \t\trte_distributor_clear_returns_v1705);\n \n /* creates a distributor instance */\n-struct rte_distributor *\n+struct rte_distributor * __vsym\n rte_distributor_create_v1705(const char *name,\n \t\tunsigned int socket_id,\n \t\tunsigned int num_workers,\ndiff --git a/lib/librte_distributor/rte_distributor_v20.c b/lib/librte_distributor/rte_distributor_v20.c\nindex cdc0969a8..31c766421 100644\n--- a/lib/librte_distributor/rte_distributor_v20.c\n+++ b/lib/librte_distributor/rte_distributor_v20.c\n@@ -27,7 +27,7 @@ EAL_REGISTER_TAILQ(rte_distributor_tailq)\n \n /**** APIs called by workers ****/\n \n-void\n+void __vsym\n rte_distributor_request_pkt_v20(struct rte_distributor_v20 *d,\n \t\tunsigned worker_id, struct rte_mbuf *oldpkt)\n {\n@@ -40,7 +40,7 @@ rte_distributor_request_pkt_v20(struct rte_distributor_v20 *d,\n }\n VERSION_SYMBOL(rte_distributor_request_pkt, _v20, 2.0);\n \n-struct rte_mbuf *\n+struct rte_mbuf * __vsym\n rte_distributor_poll_pkt_v20(struct rte_distributor_v20 *d,\n \t\tunsigned worker_id)\n {\n@@ -54,7 +54,7 @@ rte_distributor_poll_pkt_v20(struct rte_distributor_v20 *d,\n }\n VERSION_SYMBOL(rte_distributor_poll_pkt, _v20, 2.0);\n \n-struct rte_mbuf *\n+struct rte_mbuf * __vsym\n rte_distributor_get_pkt_v20(struct rte_distributor_v20 *d,\n \t\tunsigned worker_id, struct rte_mbuf *oldpkt)\n {\n@@ -66,7 +66,7 @@ rte_distributor_get_pkt_v20(struct rte_distributor_v20 *d,\n }\n VERSION_SYMBOL(rte_distributor_get_pkt, _v20, 2.0);\n \n-int\n+int __vsym\n rte_distributor_return_pkt_v20(struct rte_distributor_v20 *d,\n \t\tunsigned worker_id, struct rte_mbuf *oldpkt)\n {\n@@ -191,7 +191,7 @@ process_returns(struct rte_distributor_v20 *d)\n }\n \n /* process a set of packets to distribute them to workers */\n-int\n+int __vsym\n rte_distributor_process_v20(struct rte_distributor_v20 *d,\n \t\tstruct rte_mbuf **mbufs, unsigned num_mbufs)\n {\n@@ -296,7 +296,7 @@ rte_distributor_process_v20(struct rte_distributor_v20 *d,\n VERSION_SYMBOL(rte_distributor_process, _v20, 2.0);\n \n /* return to the caller, packets returned from workers */\n-int\n+int __vsym\n rte_distributor_returned_pkts_v20(struct rte_distributor_v20 *d,\n \t\tstruct rte_mbuf **mbufs, unsigned max_mbufs)\n {\n@@ -334,7 +334,7 @@ total_outstanding(const struct rte_distributor_v20 *d)\n \n /* flush the distributor, so that there are no outstanding packets in flight or\n * queued up. */\n-int\n+int __vsym\n rte_distributor_flush_v20(struct rte_distributor_v20 *d)\n {\n \tconst unsigned flushed = total_outstanding(d);\n@@ -347,7 +347,7 @@ rte_distributor_flush_v20(struct rte_distributor_v20 *d)\n VERSION_SYMBOL(rte_distributor_flush, _v20, 2.0);\n \n /* clears the internal returns array in the distributor */\n-void\n+void __vsym\n rte_distributor_clear_returns_v20(struct rte_distributor_v20 *d)\n {\n \td->returns.start = d->returns.count = 0;\n@@ -358,7 +358,7 @@ rte_distributor_clear_returns_v20(struct rte_distributor_v20 *d)\n VERSION_SYMBOL(rte_distributor_clear_returns, _v20, 2.0);\n \n /* creates a distributor instance */\n-struct rte_distributor_v20 *\n+struct rte_distributor_v20 * __vsym\n rte_distributor_create_v20(const char *name,\n \t\tunsigned socket_id,\n \t\tunsigned num_workers)\ndiff --git a/lib/librte_lpm/rte_lpm.c b/lib/librte_lpm/rte_lpm.c\nindex 3a929a1b1..a2fba8d61 100644\n--- a/lib/librte_lpm/rte_lpm.c\n+++ b/lib/librte_lpm/rte_lpm.c\n@@ -89,7 +89,7 @@ depth_to_range(uint8_t depth)\n /*\n * Find an existing lpm table and return a pointer to it.\n */\n-struct rte_lpm_v20 *\n+struct rte_lpm_v20 * __vsym\n rte_lpm_find_existing_v20(const char *name)\n {\n \tstruct rte_lpm_v20 *l = NULL;\n@@ -115,7 +115,7 @@ rte_lpm_find_existing_v20(const char *name)\n }\n VERSION_SYMBOL(rte_lpm_find_existing, _v20, 2.0);\n \n-struct rte_lpm *\n+struct rte_lpm * __vsym\n rte_lpm_find_existing_v1604(const char *name)\n {\n \tstruct rte_lpm *l = NULL;\n@@ -146,7 +146,7 @@ MAP_STATIC_SYMBOL(struct rte_lpm *rte_lpm_find_existing(const char *name),\n /*\n * Allocates memory for LPM object\n */\n-struct rte_lpm_v20 *\n+struct rte_lpm_v20 * __vsym\n rte_lpm_create_v20(const char *name, int socket_id, int max_rules,\n \t\t__rte_unused int flags)\n {\n@@ -219,7 +219,7 @@ rte_lpm_create_v20(const char *name, int socket_id, int max_rules,\n }\n VERSION_SYMBOL(rte_lpm_create, _v20, 2.0);\n \n-struct rte_lpm *\n+struct rte_lpm * __vsym\n rte_lpm_create_v1604(const char *name, int socket_id,\n \t\tconst struct rte_lpm_config *config)\n {\n@@ -328,7 +328,7 @@ MAP_STATIC_SYMBOL(\n /*\n * Deallocates memory for given LPM table.\n */\n-void\n+void __vsym\n rte_lpm_free_v20(struct rte_lpm_v20 *lpm)\n {\n \tstruct rte_lpm_list *lpm_list;\n@@ -357,7 +357,7 @@ rte_lpm_free_v20(struct rte_lpm_v20 *lpm)\n }\n VERSION_SYMBOL(rte_lpm_free, _v20, 2.0);\n \n-void\n+void __vsym\n rte_lpm_free_v1604(struct rte_lpm *lpm)\n {\n \tstruct rte_lpm_list *lpm_list;\n@@ -1176,7 +1176,7 @@ add_depth_big_v1604(struct rte_lpm *lpm, uint32_t ip_masked, uint8_t depth,\n /*\n * Add a route\n */\n-int\n+int __vsym\n rte_lpm_add_v20(struct rte_lpm_v20 *lpm, uint32_t ip, uint8_t depth,\n \t\tuint8_t next_hop)\n {\n@@ -1217,7 +1217,7 @@ rte_lpm_add_v20(struct rte_lpm_v20 *lpm, uint32_t ip, uint8_t depth,\n }\n VERSION_SYMBOL(rte_lpm_add, _v20, 2.0);\n \n-int\n+int __vsym\n rte_lpm_add_v1604(struct rte_lpm *lpm, uint32_t ip, uint8_t depth,\n \t\tuint32_t next_hop)\n {\n@@ -1263,7 +1263,7 @@ MAP_STATIC_SYMBOL(int rte_lpm_add(struct rte_lpm *lpm, uint32_t ip,\n /*\n * Look for a rule in the high-level rules table\n */\n-int\n+int __vsym\n rte_lpm_is_rule_present_v20(struct rte_lpm_v20 *lpm, uint32_t ip, uint8_t depth,\n uint8_t *next_hop)\n {\n@@ -1290,7 +1290,7 @@ uint8_t *next_hop)\n }\n VERSION_SYMBOL(rte_lpm_is_rule_present, _v20, 2.0);\n \n-int\n+int __vsym\n rte_lpm_is_rule_present_v1604(struct rte_lpm *lpm, uint32_t ip, uint8_t depth,\n uint32_t *next_hop)\n {\n@@ -1843,7 +1843,7 @@ delete_depth_big_v1604(struct rte_lpm *lpm, uint32_t ip_masked,\n /*\n * Deletes a rule\n */\n-int\n+int __vsym\n rte_lpm_delete_v20(struct rte_lpm_v20 *lpm, uint32_t ip, uint8_t depth)\n {\n \tint32_t rule_to_delete_index, sub_rule_index;\n@@ -1897,7 +1897,7 @@ rte_lpm_delete_v20(struct rte_lpm_v20 *lpm, uint32_t ip, uint8_t depth)\n }\n VERSION_SYMBOL(rte_lpm_delete, _v20, 2.0);\n \n-int\n+int __vsym\n rte_lpm_delete_v1604(struct rte_lpm *lpm, uint32_t ip, uint8_t depth)\n {\n \tint32_t rule_to_delete_index, sub_rule_index;\n@@ -1956,7 +1956,7 @@ MAP_STATIC_SYMBOL(int rte_lpm_delete(struct rte_lpm *lpm, uint32_t ip,\n /*\n * Delete all rules from the LPM table.\n */\n-void\n+void __vsym\n rte_lpm_delete_all_v20(struct rte_lpm_v20 *lpm)\n {\n \t/* Zero rule information. */\n@@ -1973,7 +1973,7 @@ rte_lpm_delete_all_v20(struct rte_lpm_v20 *lpm)\n }\n VERSION_SYMBOL(rte_lpm_delete_all, _v20, 2.0);\n \n-void\n+void __vsym\n rte_lpm_delete_all_v1604(struct rte_lpm *lpm)\n {\n \t/* Zero rule information. */\ndiff --git a/lib/librte_lpm/rte_lpm6.c b/lib/librte_lpm/rte_lpm6.c\nindex 9b8aeb972..49a7fea1d 100644\n--- a/lib/librte_lpm/rte_lpm6.c\n+++ b/lib/librte_lpm/rte_lpm6.c\n@@ -811,7 +811,7 @@ add_step(struct rte_lpm6 *lpm, struct rte_lpm6_tbl_entry *tbl,\n /*\n * Add a route\n */\n-int\n+int __vsym\n rte_lpm6_add_v20(struct rte_lpm6 *lpm, uint8_t *ip, uint8_t depth,\n \t\tuint8_t next_hop)\n {\n@@ -861,7 +861,7 @@ simulate_add(struct rte_lpm6 *lpm, const uint8_t *masked_ip, uint8_t depth)\n \treturn 0;\n }\n \n-int\n+int __vsym\n rte_lpm6_add_v1705(struct rte_lpm6 *lpm, uint8_t *ip, uint8_t depth,\n \t\tuint32_t next_hop)\n {\n@@ -954,7 +954,7 @@ lookup_step(const struct rte_lpm6 *lpm, const struct rte_lpm6_tbl_entry *tbl,\n /*\n * Looks up an IP\n */\n-int\n+int __vsym\n rte_lpm6_lookup_v20(const struct rte_lpm6 *lpm, uint8_t *ip, uint8_t *next_hop)\n {\n \tuint32_t next_hop32 = 0;\n@@ -972,7 +972,7 @@ rte_lpm6_lookup_v20(const struct rte_lpm6 *lpm, uint8_t *ip, uint8_t *next_hop)\n }\n VERSION_SYMBOL(rte_lpm6_lookup, _v20, 2.0);\n \n-int\n+int __vsym\n rte_lpm6_lookup_v1705(const struct rte_lpm6 *lpm, uint8_t *ip,\n \t\tuint32_t *next_hop)\n {\n@@ -1007,7 +1007,7 @@ MAP_STATIC_SYMBOL(int rte_lpm6_lookup(const struct rte_lpm6 *lpm, uint8_t *ip,\n /*\n * Looks up a group of IP addresses\n */\n-int\n+int __vsym\n rte_lpm6_lookup_bulk_func_v20(const struct rte_lpm6 *lpm,\n \t\tuint8_t ips[][RTE_LPM6_IPV6_ADDR_SIZE],\n \t\tint16_t * next_hops, unsigned n)\n@@ -1048,7 +1048,7 @@ rte_lpm6_lookup_bulk_func_v20(const struct rte_lpm6 *lpm,\n }\n VERSION_SYMBOL(rte_lpm6_lookup_bulk_func, _v20, 2.0);\n \n-int\n+int __vsym\n rte_lpm6_lookup_bulk_func_v1705(const struct rte_lpm6 *lpm,\n \t\tuint8_t ips[][RTE_LPM6_IPV6_ADDR_SIZE],\n \t\tint32_t *next_hops, unsigned int n)\n@@ -1098,7 +1098,7 @@ MAP_STATIC_SYMBOL(int rte_lpm6_lookup_bulk_func(const struct rte_lpm6 *lpm,\n /*\n * Look for a rule in the high-level rules table\n */\n-int\n+int __vsym\n rte_lpm6_is_rule_present_v20(struct rte_lpm6 *lpm, uint8_t *ip, uint8_t depth,\n \t\tuint8_t *next_hop)\n {\n@@ -1118,7 +1118,7 @@ rte_lpm6_is_rule_present_v20(struct rte_lpm6 *lpm, uint8_t *ip, uint8_t depth,\n }\n VERSION_SYMBOL(rte_lpm6_is_rule_present, _v20, 2.0);\n \n-int\n+int __vsym\n rte_lpm6_is_rule_present_v1705(struct rte_lpm6 *lpm, uint8_t *ip, uint8_t depth,\n \t\tuint32_t *next_hop)\n {\ndiff --git a/lib/librte_timer/rte_timer.c b/lib/librte_timer/rte_timer.c\nindex bdcf05d06..e560ace06 100644\n--- a/lib/librte_timer/rte_timer.c\n+++ b/lib/librte_timer/rte_timer.c\n@@ -131,7 +131,7 @@ rte_timer_data_dealloc(uint32_t id)\n \treturn 0;\n }\n \n-void\n+void __vsym\n rte_timer_subsystem_init_v20(void)\n {\n \tunsigned lcore_id;\n@@ -153,7 +153,7 @@ VERSION_SYMBOL(rte_timer_subsystem_init, _v20, 2.0);\n * secondary processes should be empty, the zeroth entry can be shared by\n * multiple processes.\n */\n-int\n+int __vsym\n rte_timer_subsystem_init_v1905(void)\n {\n \tconst struct rte_memzone *mz;\n@@ -551,7 +551,7 @@ __rte_timer_reset(struct rte_timer *tim, uint64_t expire,\n }\n \n /* Reset and start the timer associated with the timer handle tim */\n-int\n+int __vsym\n rte_timer_reset_v20(struct rte_timer *tim, uint64_t ticks,\n \t\t enum rte_timer_type type, unsigned int tim_lcore,\n \t\t rte_timer_cb_t fct, void *arg)\n@@ -574,7 +574,7 @@ rte_timer_reset_v20(struct rte_timer *tim, uint64_t ticks,\n }\n VERSION_SYMBOL(rte_timer_reset, _v20, 2.0);\n \n-int\n+int __vsym\n rte_timer_reset_v1905(struct rte_timer *tim, uint64_t ticks,\n \t\t enum rte_timer_type type, unsigned int tim_lcore,\n \t\t rte_timer_cb_t fct, void *arg)\n@@ -657,14 +657,14 @@ __rte_timer_stop(struct rte_timer *tim, int local_is_locked,\n }\n \n /* Stop the timer associated with the timer handle tim */\n-int\n+int __vsym\n rte_timer_stop_v20(struct rte_timer *tim)\n {\n \treturn __rte_timer_stop(tim, 0, &default_timer_data);\n }\n VERSION_SYMBOL(rte_timer_stop, _v20, 2.0);\n \n-int\n+int __vsym\n rte_timer_stop_v1905(struct rte_timer *tim)\n {\n \treturn rte_timer_alt_stop(default_data_id, tim);\n@@ -817,14 +817,14 @@ __rte_timer_manage(struct rte_timer_data *timer_data)\n \tpriv_timer[lcore_id].running_tim = NULL;\n }\n \n-void\n+void __vsym\n rte_timer_manage_v20(void)\n {\n \t__rte_timer_manage(&default_timer_data);\n }\n VERSION_SYMBOL(rte_timer_manage, _v20, 2.0);\n \n-int\n+int __vsym\n rte_timer_manage_v1905(void)\n {\n \tstruct rte_timer_data *timer_data;\n@@ -1074,14 +1074,14 @@ __rte_timer_dump_stats(struct rte_timer_data *timer_data __rte_unused, FILE *f)\n #endif\n }\n \n-void\n+void __vsym\n rte_timer_dump_stats_v20(FILE *f)\n {\n \t__rte_timer_dump_stats(&default_timer_data, f);\n }\n VERSION_SYMBOL(rte_timer_dump_stats, _v20, 2.0);\n \n-int\n+int __vsym\n rte_timer_dump_stats_v1905(FILE *f)\n {\n \treturn rte_timer_alt_dump_stats(default_data_id, f);\ndiff --git a/mk/toolchain/clang/rte.toolchain-compat.mk b/mk/toolchain/clang/rte.toolchain-compat.mk\nindex e6189b498..78f96c648 100644\n--- a/mk/toolchain/clang/rte.toolchain-compat.mk\n+++ b/mk/toolchain/clang/rte.toolchain-compat.mk\n@@ -20,3 +20,7 @@ CLANG_MINOR_VERSION := $(shell echo $(CLANG_VERSION) | cut -f2 -d.)\n ifeq ($(shell test $(CLANG_MAJOR_VERSION)$(CLANG_MINOR_VERSION) -lt 35 && echo 1), 1)\n \tCC_SUPPORTS_Z := false\n endif\n+\n+ifeq ($(shell test $(CLANG_MAJOR_VERSION)$(CLANG_MINOR_VERSION) -lt 60 && echo 1), 1)\n+\tCONFIG_RTE_ENABLE_LTO=n\n+endif\ndiff --git a/mk/toolchain/clang/rte.vars.mk b/mk/toolchain/clang/rte.vars.mk\nindex 3c49dc568..3b1fa05f9 100644\n--- a/mk/toolchain/clang/rte.vars.mk\n+++ b/mk/toolchain/clang/rte.vars.mk\n@@ -48,6 +48,14 @@ endif\n # process cpu flags\n include $(RTE_SDK)/mk/toolchain/$(RTE_TOOLCHAIN)/rte.toolchain-compat.mk\n \n+ifeq ($(CONFIG_RTE_ENABLE_LTO),y)\n+# 'fat-lto' is used since pmdinfogen needs to have 'this_pmd_nameX'\n+# exported in symbol table and without this option only internal\n+# representation is present.\n+TOOLCHAIN_CFLAGS += -flto -ffat-lto-objects\n+TOOLCHAIN_LDFLAGS += -flto\n+endif\n+\n # workaround clang bug with warning \"missing field initializer\" for \"= {0}\"\n WERROR_FLAGS += -Wno-missing-field-initializers\n \ndiff --git a/mk/toolchain/gcc/rte.toolchain-compat.mk b/mk/toolchain/gcc/rte.toolchain-compat.mk\nindex ea40a11c0..ad4fad83c 100644\n--- a/mk/toolchain/gcc/rte.toolchain-compat.mk\n+++ b/mk/toolchain/gcc/rte.toolchain-compat.mk\n@@ -88,6 +88,10 @@ else\n \t\tMACHINE_CFLAGS := $(filter-out -march% -mtune% -msse%,$(MACHINE_CFLAGS))\n \tendif\n \n+\tifeq ($(shell test $(GCC_VERSION) -lt 45 && echo 1), 1)\n+\t\tCONFIG_RTE_ENABLE_LTO=n\n+\tendif\n+\n \t# Disable thunderx PMD for gcc < 4.7\n \tifeq ($(shell test $(GCC_VERSION) -lt 47 && echo 1), 1)\n \t\tCONFIG_RTE_LIBRTE_THUNDERX_NICVF_PMD=d\ndiff --git a/mk/toolchain/gcc/rte.vars.mk b/mk/toolchain/gcc/rte.vars.mk\nindex b852fcfd7..9fc704193 100644\n--- a/mk/toolchain/gcc/rte.vars.mk\n+++ b/mk/toolchain/gcc/rte.vars.mk\n@@ -62,6 +62,18 @@ endif\n # process cpu flags\n include $(RTE_SDK)/mk/toolchain/$(RTE_TOOLCHAIN)/rte.toolchain-compat.mk\n \n+ifeq ($(CONFIG_RTE_ENABLE_LTO),y)\n+# 'fat-lto' is used since pmdinfogen needs to have 'this_pmd_nameX'\n+# exported in symbol table and without this option only internal\n+# representation is present.\n+TOOLCHAIN_CFLAGS += -flto -ffat-lto-objects\n+TOOLCHAIN_LDFLAGS += -flto\n+# workaround for GCC bug 81440\n+ifeq ($(shell test $(GCC_VERSION) -lt 80 && echo 1), 1)\n+WERROR_FLAGS += -Wno-lto-type-mismatch\n+endif\n+endif\n+\n # workaround GCC bug with warning \"missing initializer\" for \"= {0}\"\n ifeq ($(shell test $(GCC_VERSION) -lt 47 && echo 1), 1)\n WERROR_FLAGS += -Wno-missing-field-initializers\ndiff --git a/mk/toolchain/icc/rte.vars.mk b/mk/toolchain/icc/rte.vars.mk\nindex aa1422bf1..8aa87aa1e 100644\n--- a/mk/toolchain/icc/rte.vars.mk\n+++ b/mk/toolchain/icc/rte.vars.mk\n@@ -54,5 +54,13 @@ endif\n # process cpu flags\n include $(RTE_SDK)/mk/toolchain/$(RTE_TOOLCHAIN)/rte.toolchain-compat.mk\n \n+ifeq ($(CONFIG_RTE_ENABLE_LTO),y)\n+# 'fat-lto' is used since pmdinfogen needs to have 'this_pmd_nameX'\n+# exported in symbol table and without this option only internal\n+# representation is present.\n+TOOLCHAIN_CFLAGS += -flto -ffat-lto-objects\n+TOOLCHAIN_LDFLAGS += -flto\n+endif\n+\n export CC AS AR LD OBJCOPY OBJDUMP STRIP READELF\n export TOOLCHAIN_CFLAGS TOOLCHAIN_LDFLAGS TOOLCHAIN_ASFLAGS\n", "prefixes": [ "v2", "01/10" ] }{ "id": 59307, "url": "