Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/58436/?format=api
{ "id": 58436, "url": "http://patches.dpdk.org/api/patches/58436/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190903021901.25895-14-ajit.khaparde@broadcom.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190903021901.25895-14-ajit.khaparde@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190903021901.25895-14-ajit.khaparde@broadcom.com", "date": "2019-09-03T02:18:57", "name": "[13/17] net/bnxt: handle flow flush handling", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "b1a37fd77440e1d451414b51108355dae9616cdc", "submitter": { "id": 501, "url": "http://patches.dpdk.org/api/people/501/?format=api", "name": "Ajit Khaparde", "email": "ajit.khaparde@broadcom.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190903021901.25895-14-ajit.khaparde@broadcom.com/mbox/", "series": [ { "id": 6209, "url": "http://patches.dpdk.org/api/series/6209/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=6209", "date": "2019-09-03T02:18:44", "name": "bnxt patchset to improve rte flow support", "version": 1, "mbox": "http://patches.dpdk.org/series/6209/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/58436/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/58436/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id EF3331EB46;\n\tTue, 3 Sep 2019 04:19:36 +0200 (CEST)", "from rnd-relay.smtp.broadcom.com (rnd-relay.smtp.broadcom.com\n\t[192.19.229.170]) by dpdk.org (Postfix) with ESMTP id CB50D1E9B9\n\tfor <dev@dpdk.org>; Tue, 3 Sep 2019 04:19:09 +0200 (CEST)", "from nis-sj1-27.broadcom.com (nis-sj1-27.lvn.broadcom.net\n\t[10.75.144.136])\n\tby rnd-relay.smtp.broadcom.com (Postfix) with ESMTP id 9471F30C1EF;\n\tMon, 2 Sep 2019 19:19:02 -0700 (PDT)", "from localhost.localdomain (unknown [10.230.30.225])\n\tby nis-sj1-27.broadcom.com (Postfix) with ESMTP id 9EB33AC078A;\n\tMon, 2 Sep 2019 19:19:08 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.10.3 rnd-relay.smtp.broadcom.com 9471F30C1EF", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n\ts=dkimrelay; t=1567477142;\n\tbh=kMiFHc8Vt4VmnG9a0u/HEPJzLIp6mi4s/evyPUNfFM8=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=jZ7aBrnuzuEWTp7PDQE4fUJADO++24SnfEkjHNjWf8A4ZnENqzZ8KLxWZj1LAeL1X\n\tc+K6VlD3xRzLN4acZjWGqlEwcw9XQu8v+v2535l9uVRRs60YmtgUl1QFM5nW2lSjoU\n\tNF6aUQjJ9KRo+KHfhu1Tl5HEYrA7HJBZ48vzNMjM=", "From": "Ajit Khaparde <ajit.khaparde@broadcom.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com, Rahul Gupta <rahul.gupta@broadcom.com>,\n\tVenkat Duvvuru <venkatkumar.duvvuru@broadcom.com>,\n\tKalesh Anakkur Purayil <kalesh-anakkur.purayil@broadcom.com>", "Date": "Mon, 2 Sep 2019 19:18:57 -0700", "Message-Id": "<20190903021901.25895-14-ajit.khaparde@broadcom.com>", "X-Mailer": "git-send-email 2.20.1 (Apple Git-117)", "In-Reply-To": "<20190903021901.25895-1-ajit.khaparde@broadcom.com>", "References": "<20190903021901.25895-1-ajit.khaparde@broadcom.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 13/17] net/bnxt: handle flow flush handling", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "We are not freeing all the flows when a flow_flush is called.\nIterate through all the flows belonging to all the VNICs in use and\nfree the filters.\n\nSigned-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\nReviewed-by: Rahul Gupta <rahul.gupta@broadcom.com>\nReviewed-by: Venkat Duvvuru <venkatkumar.duvvuru@broadcom.com>\nReviewed-by: Kalesh Anakkur Purayil <kalesh-anakkur.purayil@broadcom.com>\n---\n drivers/net/bnxt/bnxt_flow.c | 56 ++++++++++++++++++------------------\n 1 file changed, 28 insertions(+), 28 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt_flow.c b/drivers/net/bnxt/bnxt_flow.c\nindex 71a5266ce..9d943cd14 100644\n--- a/drivers/net/bnxt/bnxt_flow.c\n+++ b/drivers/net/bnxt/bnxt_flow.c\n@@ -907,7 +907,6 @@ bnxt_validate_and_parse_flow(struct rte_eth_dev *dev,\n \tconst struct rte_flow_action *act =\n \t\tbnxt_flow_non_void_action(actions);\n \tstruct bnxt *bp = dev->data->dev_private;\n-\tstruct rte_eth_conf *dev_conf = &bp->eth_dev->data->dev_conf;\n \tconst struct rte_flow_action_queue *act_q;\n \tconst struct rte_flow_action_rss *rss;\n \tconst struct rte_flow_action_vf *act_vf;\n@@ -982,9 +981,6 @@ bnxt_validate_and_parse_flow(struct rte_eth_dev *dev,\n \n \t\trxq = bp->rx_queues[act_q->index];\n \n-\t\tif (!(dev_conf->rxmode.mq_mode & ETH_MQ_RX_RSS) && rxq)\n-\t\t\tgoto use_vnic;\n-\n \t\t//if (!rxq ||\n \t\t //bp->vnic_info[0].fw_grp_ids[act_q->index] !=\n \t\t //INVALID_HW_RING_ID ||\n@@ -1567,25 +1563,6 @@ bnxt_flow_create(struct rte_eth_dev *dev,\n \n \tvnic = find_matching_vnic(bp, filter);\n done:\n-\tif (!ret) {\n-\t\tflow->filter = filter;\n-\t\tflow->vnic = vnic;\n-\t\t/* VNIC is set only in case of queue or RSS action */\n-\t\tif (vnic) {\n-\t\t\t/*\n-\t\t\t * RxQ0 is not used for flow filters.\n-\t\t\t */\n-\n-\t\t\tif (update_flow) {\n-\t\t\t\tret = -EXDEV;\n-\t\t\t\tgoto free_flow;\n-\t\t\t}\n-\t\t\tSTAILQ_INSERT_TAIL(&vnic->filter, filter, next);\n-\t\t}\n-\t\tPMD_DRV_LOG(ERR, \"Successfully created flow.\\n\");\n-\t\tSTAILQ_INSERT_TAIL(&vnic->flow_list, flow, next);\n-\t\treturn flow;\n-\t}\n \tif (!ret) {\n \t\tflow->filter = filter;\n \t\tflow->vnic = vnic;\n@@ -1593,10 +1570,13 @@ bnxt_flow_create(struct rte_eth_dev *dev,\n \t\t\tret = -EXDEV;\n \t\t\tgoto free_flow;\n \t\t}\n+\n+\t\tSTAILQ_INSERT_TAIL(&vnic->filter, filter, next);\n \t\tPMD_DRV_LOG(ERR, \"Successfully created flow.\\n\");\n \t\tSTAILQ_INSERT_TAIL(&vnic->flow_list, flow, next);\n \t\treturn flow;\n \t}\n+\n free_filter:\n \tbnxt_free_filter(bp, filter);\n free_flow:\n@@ -1727,6 +1707,7 @@ static int\n bnxt_flow_flush(struct rte_eth_dev *dev, struct rte_flow_error *error)\n {\n \tstruct bnxt *bp = dev->data->dev_private;\n+\tstruct bnxt_filter_info *filter = NULL;\n \tstruct bnxt_vnic_info *vnic;\n \tstruct rte_flow *flow;\n \tunsigned int i;\n@@ -1734,11 +1715,12 @@ bnxt_flow_flush(struct rte_eth_dev *dev, struct rte_flow_error *error)\n \n \tfor (i = 0; i < bp->max_vnics; i++) {\n \t\tvnic = &bp->vnic_info[i];\n-\t\tif (vnic->fw_vnic_id == INVALID_VNIC_ID)\n+\t\tif (vnic && vnic->fw_vnic_id == INVALID_VNIC_ID)\n \t\t\tcontinue;\n \n-\t\tSTAILQ_FOREACH(flow, &vnic->flow_list, next) {\n-\t\t\tstruct bnxt_filter_info *filter = flow->filter;\n+\t\twhile (!STAILQ_EMPTY(&vnic->flow_list)) {\n+\t\t\tflow = STAILQ_FIRST(&vnic->flow_list);\n+\t\t\tfilter = flow->filter;\n \n \t\t\tif (filter->filter_type ==\n \t\t\t HWRM_CFA_TUNNEL_REDIRECT_FILTER &&\n@@ -1757,7 +1739,7 @@ bnxt_flow_flush(struct rte_eth_dev *dev, struct rte_flow_error *error)\n \t\t\t\tret = bnxt_hwrm_clear_em_filter(bp, filter);\n \t\t\tif (filter->filter_type == HWRM_CFA_NTUPLE_FILTER)\n \t\t\t\tret = bnxt_hwrm_clear_ntuple_filter(bp, filter);\n-\t\t\telse if (!i)\n+\t\t\telse if (i)\n \t\t\t\tret = bnxt_hwrm_clear_l2_filter(bp, filter);\n \n \t\t\tif (ret) {\n@@ -1770,10 +1752,28 @@ bnxt_flow_flush(struct rte_eth_dev *dev, struct rte_flow_error *error)\n \t\t\t\treturn -rte_errno;\n \t\t\t}\n done:\n-\t\t\tbnxt_free_filter(bp, filter);\n \t\t\tSTAILQ_REMOVE(&vnic->flow_list, flow,\n \t\t\t\t rte_flow, next);\n+\n+\t\t\tSTAILQ_REMOVE(&vnic->filter,\n+\t\t\t\t filter,\n+\t\t\t\t bnxt_filter_info,\n+\t\t\t\t next);\n+\t\t\tbnxt_free_filter(bp, filter);\n+\n \t\t\trte_free(flow);\n+\n+\t\t\t/* If this was the last flow associated with this vnic,\n+\t\t\t * switch the queue back to RSS pool.\n+\t\t\t */\n+\t\t\tif (STAILQ_EMPTY(&vnic->flow_list)) {\n+\t\t\t\trte_free(vnic->fw_grp_ids);\n+\t\t\t\tif (vnic->rx_queue_cnt > 1)\n+\t\t\t\t\tbnxt_hwrm_vnic_ctx_free(bp, vnic);\n+\t\t\t\tbnxt_hwrm_vnic_free(bp, vnic);\n+\t\t\t\tvnic->rx_queue_cnt = 0;\n+\t\t\t\tbp->nr_vnics--;\n+\t\t\t}\n \t\t}\n \t}\n \n", "prefixes": [ "13/17" ] }