Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 58352,
    "url": "http://patches.dpdk.org/api/patches/58352/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190901221213.92149-10-ajit.khaparde@broadcom.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20190901221213.92149-10-ajit.khaparde@broadcom.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20190901221213.92149-10-ajit.khaparde@broadcom.com",
    "date": "2019-09-01T22:12:13",
    "name": "[09/15] net/bnxt: remove unnecessary return check",
    "commit_ref": null,
    "pull_url": null,
    "state": "changes-requested",
    "archived": true,
    "hash": "d0e02bd6afee5c3c107eb61230f646c08c26accf",
    "submitter": {
        "id": 501,
        "url": "http://patches.dpdk.org/api/people/501/?format=api",
        "name": "Ajit Khaparde",
        "email": "ajit.khaparde@broadcom.com"
    },
    "delegate": {
        "id": 319,
        "url": "http://patches.dpdk.org/api/users/319/?format=api",
        "username": "fyigit",
        "first_name": "Ferruh",
        "last_name": "Yigit",
        "email": "ferruh.yigit@amd.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190901221213.92149-10-ajit.khaparde@broadcom.com/mbox/",
    "series": [
        {
            "id": 6190,
            "url": "http://patches.dpdk.org/api/series/6190/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=6190",
            "date": "2019-09-01T22:12:00",
            "name": "bnxt patchset",
            "version": 1,
            "mbox": "http://patches.dpdk.org/series/6190/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/58352/comments/",
    "check": "fail",
    "checks": "http://patches.dpdk.org/api/patches/58352/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id D732D1C1F1;\n\tMon,  2 Sep 2019 00:16:55 +0200 (CEST)",
            "from rnd-relay.smtp.broadcom.com (rnd-relay.smtp.broadcom.com\n\t[192.19.229.170]) by dpdk.org (Postfix) with ESMTP id D8CE51C1F1\n\tfor <dev@dpdk.org>; Mon,  2 Sep 2019 00:16:54 +0200 (CEST)",
            "from nis-sj1-27.broadcom.com (nis-sj1-27.lvn.broadcom.net\n\t[10.75.144.136])\n\tby rnd-relay.smtp.broadcom.com (Postfix) with ESMTP id 14BF130D16E;\n\tSun,  1 Sep 2019 15:16:49 -0700 (PDT)",
            "from localhost.localdomain (unknown [10.230.30.225])\n\tby nis-sj1-27.broadcom.com (Postfix) with ESMTP id 75930AC071D;\n\tSun,  1 Sep 2019 15:16:53 -0700 (PDT)"
        ],
        "DKIM-Filter": "OpenDKIM Filter v2.10.3 rnd-relay.smtp.broadcom.com 14BF130D16E",
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n\ts=dkimrelay; t=1567376209;\n\tbh=E3r+zmeNFdsvUW9ZOqFx+8I+JLPnQGstQEdnepTzH9Q=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=N9zVqs/xZZ+OJzlE5RYyTpj4OudkB4tl0Tfwy/yWdEOnZsbnHOPKbfSCUu6cndggw\n\tIoG+kstmDrhGhCnaO4ZOqDLkdSY4Ap6FA3gA+sUsmuXCdG+MOrhGK4G3+KnKG1VU93\n\tJnwOtb4QB8Tds7P180lyS80OVZHzBrq6/UNu+R3k=",
        "From": "Ajit Khaparde <ajit.khaparde@broadcom.com>",
        "To": "dev@dpdk.org",
        "Cc": "ferruh.yigit@intel.com, Kalesh AP <kalesh-anakkur.purayil@broadcom.com>, \n\tLance Richardson <lance.richardson@broadcom.com>",
        "Date": "Sun,  1 Sep 2019 15:12:13 -0700",
        "Message-Id": "<20190901221213.92149-10-ajit.khaparde@broadcom.com>",
        "X-Mailer": "git-send-email 2.20.1 (Apple Git-117)",
        "In-Reply-To": "<20190901221213.92149-1-ajit.khaparde@broadcom.com>",
        "References": "<20190901221213.92149-1-ajit.khaparde@broadcom.com>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "Subject": "[dpdk-dev] [PATCH 09/15] net/bnxt: remove unnecessary return check",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>\n\nHWRM_CHECK_RESULT_SILENT() returns if the HWRM command fails.\nThere is no need to check the return value after this call.\n\nSigned-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>\nReviewed-by: Lance Richardson <lance.richardson@broadcom.com>\nSigned-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\n---\n drivers/net/bnxt/bnxt_hwrm.c | 119 +++++++++++++++++------------------\n 1 file changed, 56 insertions(+), 63 deletions(-)",
    "diff": "diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c\nindex 13aa4de24..1541dc3b6 100644\n--- a/drivers/net/bnxt/bnxt_hwrm.c\n+++ b/drivers/net/bnxt/bnxt_hwrm.c\n@@ -4377,7 +4377,10 @@ int bnxt_hwrm_func_backing_store_qcaps(struct bnxt *bp)\n \tstruct hwrm_func_backing_store_qcaps_input req = {0};\n \tstruct hwrm_func_backing_store_qcaps_output *resp =\n \t\tbp->hwrm_cmd_resp_addr;\n-\tint rc;\n+\tstruct bnxt_ctx_pg_info *ctx_pg;\n+\tstruct bnxt_ctx_mem_info *ctx;\n+\tint total_alloc_len;\n+\tint rc, i;\n \n \tif (!BNXT_CHIP_THOR(bp) ||\n \t    bp->hwrm_spec_code < HWRM_VERSION_1_9_2 ||\n@@ -4389,70 +4392,60 @@ int bnxt_hwrm_func_backing_store_qcaps(struct bnxt *bp)\n \trc = bnxt_hwrm_send_message(bp, &req, sizeof(req), BNXT_USE_CHIMP_MB);\n \tHWRM_CHECK_RESULT_SILENT();\n \n-\tif (!rc) {\n-\t\tstruct bnxt_ctx_pg_info *ctx_pg;\n-\t\tstruct bnxt_ctx_mem_info *ctx;\n-\t\tint total_alloc_len;\n-\t\tint i;\n-\n-\t\ttotal_alloc_len = sizeof(*ctx);\n-\t\tctx = rte_malloc(\"bnxt_ctx_mem\", total_alloc_len,\n-\t\t\t\t RTE_CACHE_LINE_SIZE);\n-\t\tif (!ctx) {\n-\t\t\trc = -ENOMEM;\n-\t\t\tgoto ctx_err;\n-\t\t}\n-\t\tmemset(ctx, 0, total_alloc_len);\n+\ttotal_alloc_len = sizeof(*ctx);\n+\tctx = rte_zmalloc(\"bnxt_ctx_mem\", total_alloc_len,\n+\t\t\t  RTE_CACHE_LINE_SIZE);\n+\tif (!ctx) {\n+\t\trc = -ENOMEM;\n+\t\tgoto ctx_err;\n+\t}\n \n-\t\tctx_pg = rte_malloc(\"bnxt_ctx_pg_mem\",\n-\t\t\t\t    sizeof(*ctx_pg) * BNXT_MAX_Q,\n-\t\t\t\t    RTE_CACHE_LINE_SIZE);\n-\t\tif (!ctx_pg) {\n-\t\t\trc = -ENOMEM;\n-\t\t\tgoto ctx_err;\n-\t\t}\n-\t\tfor (i = 0; i < BNXT_MAX_Q; i++, ctx_pg++)\n-\t\t\tctx->tqm_mem[i] = ctx_pg;\n-\n-\t\tbp->ctx = ctx;\n-\t\tctx->qp_max_entries = rte_le_to_cpu_32(resp->qp_max_entries);\n-\t\tctx->qp_min_qp1_entries =\n-\t\t\trte_le_to_cpu_16(resp->qp_min_qp1_entries);\n-\t\tctx->qp_max_l2_entries =\n-\t\t\trte_le_to_cpu_16(resp->qp_max_l2_entries);\n-\t\tctx->qp_entry_size = rte_le_to_cpu_16(resp->qp_entry_size);\n-\t\tctx->srq_max_l2_entries =\n-\t\t\trte_le_to_cpu_16(resp->srq_max_l2_entries);\n-\t\tctx->srq_max_entries = rte_le_to_cpu_32(resp->srq_max_entries);\n-\t\tctx->srq_entry_size = rte_le_to_cpu_16(resp->srq_entry_size);\n-\t\tctx->cq_max_l2_entries =\n-\t\t\trte_le_to_cpu_16(resp->cq_max_l2_entries);\n-\t\tctx->cq_max_entries = rte_le_to_cpu_32(resp->cq_max_entries);\n-\t\tctx->cq_entry_size = rte_le_to_cpu_16(resp->cq_entry_size);\n-\t\tctx->vnic_max_vnic_entries =\n-\t\t\trte_le_to_cpu_16(resp->vnic_max_vnic_entries);\n-\t\tctx->vnic_max_ring_table_entries =\n-\t\t\trte_le_to_cpu_16(resp->vnic_max_ring_table_entries);\n-\t\tctx->vnic_entry_size = rte_le_to_cpu_16(resp->vnic_entry_size);\n-\t\tctx->stat_max_entries =\n-\t\t\trte_le_to_cpu_32(resp->stat_max_entries);\n-\t\tctx->stat_entry_size = rte_le_to_cpu_16(resp->stat_entry_size);\n-\t\tctx->tqm_entry_size = rte_le_to_cpu_16(resp->tqm_entry_size);\n-\t\tctx->tqm_min_entries_per_ring =\n-\t\t\trte_le_to_cpu_32(resp->tqm_min_entries_per_ring);\n-\t\tctx->tqm_max_entries_per_ring =\n-\t\t\trte_le_to_cpu_32(resp->tqm_max_entries_per_ring);\n-\t\tctx->tqm_entries_multiple = resp->tqm_entries_multiple;\n-\t\tif (!ctx->tqm_entries_multiple)\n-\t\t\tctx->tqm_entries_multiple = 1;\n-\t\tctx->mrav_max_entries =\n-\t\t\trte_le_to_cpu_32(resp->mrav_max_entries);\n-\t\tctx->mrav_entry_size = rte_le_to_cpu_16(resp->mrav_entry_size);\n-\t\tctx->tim_entry_size = rte_le_to_cpu_16(resp->tim_entry_size);\n-\t\tctx->tim_max_entries = rte_le_to_cpu_32(resp->tim_max_entries);\n-\t} else {\n-\t\trc = 0;\n+\tctx_pg = rte_malloc(\"bnxt_ctx_pg_mem\",\n+\t\t\t    sizeof(*ctx_pg) * BNXT_MAX_Q,\n+\t\t\t    RTE_CACHE_LINE_SIZE);\n+\tif (!ctx_pg) {\n+\t\trc = -ENOMEM;\n+\t\tgoto ctx_err;\n \t}\n+\tfor (i = 0; i < BNXT_MAX_Q; i++, ctx_pg++)\n+\t\tctx->tqm_mem[i] = ctx_pg;\n+\n+\tbp->ctx = ctx;\n+\tctx->qp_max_entries = rte_le_to_cpu_32(resp->qp_max_entries);\n+\tctx->qp_min_qp1_entries =\n+\t\trte_le_to_cpu_16(resp->qp_min_qp1_entries);\n+\tctx->qp_max_l2_entries =\n+\t\trte_le_to_cpu_16(resp->qp_max_l2_entries);\n+\tctx->qp_entry_size = rte_le_to_cpu_16(resp->qp_entry_size);\n+\tctx->srq_max_l2_entries =\n+\t\trte_le_to_cpu_16(resp->srq_max_l2_entries);\n+\tctx->srq_max_entries = rte_le_to_cpu_32(resp->srq_max_entries);\n+\tctx->srq_entry_size = rte_le_to_cpu_16(resp->srq_entry_size);\n+\tctx->cq_max_l2_entries =\n+\t\trte_le_to_cpu_16(resp->cq_max_l2_entries);\n+\tctx->cq_max_entries = rte_le_to_cpu_32(resp->cq_max_entries);\n+\tctx->cq_entry_size = rte_le_to_cpu_16(resp->cq_entry_size);\n+\tctx->vnic_max_vnic_entries =\n+\t\trte_le_to_cpu_16(resp->vnic_max_vnic_entries);\n+\tctx->vnic_max_ring_table_entries =\n+\t\trte_le_to_cpu_16(resp->vnic_max_ring_table_entries);\n+\tctx->vnic_entry_size = rte_le_to_cpu_16(resp->vnic_entry_size);\n+\tctx->stat_max_entries =\n+\t\trte_le_to_cpu_32(resp->stat_max_entries);\n+\tctx->stat_entry_size = rte_le_to_cpu_16(resp->stat_entry_size);\n+\tctx->tqm_entry_size = rte_le_to_cpu_16(resp->tqm_entry_size);\n+\tctx->tqm_min_entries_per_ring =\n+\t\trte_le_to_cpu_32(resp->tqm_min_entries_per_ring);\n+\tctx->tqm_max_entries_per_ring =\n+\t\trte_le_to_cpu_32(resp->tqm_max_entries_per_ring);\n+\tctx->tqm_entries_multiple = resp->tqm_entries_multiple;\n+\tif (!ctx->tqm_entries_multiple)\n+\t\tctx->tqm_entries_multiple = 1;\n+\tctx->mrav_max_entries =\n+\t\trte_le_to_cpu_32(resp->mrav_max_entries);\n+\tctx->mrav_entry_size = rte_le_to_cpu_16(resp->mrav_entry_size);\n+\tctx->tim_entry_size = rte_le_to_cpu_16(resp->tim_entry_size);\n+\tctx->tim_max_entries = rte_le_to_cpu_32(resp->tim_max_entries);\n ctx_err:\n \tHWRM_UNLOCK();\n \treturn rc;\n",
    "prefixes": [
        "09/15"
    ]
}