Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 5811,
    "url": "http://patches.dpdk.org/api/patches/5811/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/1435286246-22170-1-git-send-email-shaopeng.he@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1435286246-22170-1-git-send-email-shaopeng.he@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1435286246-22170-1-git-send-email-shaopeng.he@intel.com",
    "date": "2015-06-26T02:37:26",
    "name": "[dpdk-dev] fm10k: fix an error message when adding default VLAN",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "7435ee7fd24fd614a2efde1e130fd4aa4d7c87c0",
    "submitter": {
        "id": 226,
        "url": "http://patches.dpdk.org/api/people/226/?format=api",
        "name": "He, Shaopeng",
        "email": "shaopeng.he@intel.com"
    },
    "delegate": null,
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/1435286246-22170-1-git-send-email-shaopeng.he@intel.com/mbox/",
    "series": [],
    "comments": "http://patches.dpdk.org/api/patches/5811/comments/",
    "check": "pending",
    "checks": "http://patches.dpdk.org/api/patches/5811/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 57971C7A4;\n\tFri, 26 Jun 2015 04:37:38 +0200 (CEST)",
            "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n\tby dpdk.org (Postfix) with ESMTP id 18038C79C\n\tfor <dev@dpdk.org>; Fri, 26 Jun 2015 04:37:35 +0200 (CEST)",
            "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby orsmga101.jf.intel.com with ESMTP; 25 Jun 2015 19:37:35 -0700",
            "from shvmail01.sh.intel.com ([10.239.29.42])\n\tby orsmga001.jf.intel.com with ESMTP; 25 Jun 2015 19:37:34 -0700",
            "from shecgisg004.sh.intel.com (shecgisg004.sh.intel.com\n\t[10.239.29.89])\n\tby shvmail01.sh.intel.com with ESMTP id t5Q2bWrw020857;\n\tFri, 26 Jun 2015 10:37:32 +0800",
            "from shecgisg004.sh.intel.com (localhost [127.0.0.1])\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/SuSE Linux 0.8) with ESMTP\n\tid t5Q2bTgD022204; Fri, 26 Jun 2015 10:37:31 +0800",
            "(from heshaope@localhost)\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/Submit) id t5Q2bSwO022200; \n\tFri, 26 Jun 2015 10:37:28 +0800"
        ],
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.13,681,1427785200\"; d=\"scan'208\";a=\"717906337\"",
        "From": "Shaopeng He <shaopeng.he@intel.com>",
        "To": "dev@dpdk.org",
        "Date": "Fri, 26 Jun 2015 10:37:26 +0800",
        "Message-Id": "<1435286246-22170-1-git-send-email-shaopeng.he@intel.com>",
        "X-Mailer": "git-send-email 1.7.4.1",
        "Cc": "Shaopeng He <shaopeng.he@intel.com>",
        "Subject": "[dpdk-dev] [PATCH] fm10k: fix an error message when adding default\n\tVLAN",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "The default MAC address is directly copied to Device Ethernet\nLink address array in the device initialize phase, which\nbypasses fm10k MAC address number check mechanism, and will\ncause an error message when adding default VLAN. Fix it by\nmoving default MAC address registration to device\ninitialize phase.\n\nSigned-off-by: Shaopeng He <shaopeng.he@intel.com>\n---\n drivers/net/fm10k/fm10k_ethdev.c | 10 ++++------\n 1 file changed, 4 insertions(+), 6 deletions(-)",
    "diff": "diff --git a/drivers/net/fm10k/fm10k_ethdev.c b/drivers/net/fm10k/fm10k_ethdev.c\nindex 406c350..df32665 100644\n--- a/drivers/net/fm10k/fm10k_ethdev.c\n+++ b/drivers/net/fm10k/fm10k_ethdev.c\n@@ -791,14 +791,10 @@ fm10k_dev_start(struct rte_eth_dev *dev)\n \t\t}\n \t}\n \n-\tif (hw->mac.default_vid && hw->mac.default_vid <= ETHER_MAX_VLAN_ID) {\n-\t\t/* Update default vlan */\n+\t/* Update default vlan */\n+\tif (hw->mac.default_vid && hw->mac.default_vid <= ETHER_MAX_VLAN_ID)\n \t\tfm10k_vlan_filter_set(dev, hw->mac.default_vid, true);\n \n-\t\t/* Add default mac/vlan filter to PF/Switch manager */\n-\t\tfm10k_MAC_filter_set(dev, hw->mac.addr, true);\n-\t}\n-\n \treturn 0;\n }\n \n@@ -2144,6 +2140,8 @@ eth_fm10k_dev_init(struct rte_eth_dev *dev)\n \n \tfm10k_mbx_unlock(hw);\n \n+\t/* Add default mac address */\n+\tfm10k_MAC_filter_set(dev, hw->mac.addr, true);\n \n \treturn 0;\n }\n",
    "prefixes": [
        "dpdk-dev"
    ]
}