Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/58001/?format=api
{ "id": 58001, "url": "http://patches.dpdk.org/api/patches/58001/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190827070730.11206-7-sachin.saxena@nxp.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190827070730.11206-7-sachin.saxena@nxp.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190827070730.11206-7-sachin.saxena@nxp.com", "date": "2019-08-27T07:07:06", "name": "[v1,06/30] net/dpaa: support for Rx interrupt enable and disable", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "1bac3c67e14434877d3a7b39cd87bfc968cca4d9", "submitter": { "id": 1054, "url": "http://patches.dpdk.org/api/people/1054/?format=api", "name": "Sachin Saxena", "email": "sachin.saxena@nxp.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190827070730.11206-7-sachin.saxena@nxp.com/mbox/", "series": [ { "id": 6130, "url": "http://patches.dpdk.org/api/series/6130/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=6130", "date": "2019-08-27T07:07:00", "name": "Enhancements and fixes in NXP dpaax drivers and fsl-mc bus", "version": 1, "mbox": "http://patches.dpdk.org/series/6130/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/58001/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/58001/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id BB5A71C025;\n\tTue, 27 Aug 2019 09:09:31 +0200 (CEST)", "from inva020.nxp.com (inva020.nxp.com [92.121.34.13])\n\tby dpdk.org (Postfix) with ESMTP id 47D131BEDE\n\tfor <dev@dpdk.org>; Tue, 27 Aug 2019 09:09:18 +0200 (CEST)", "from inva020.nxp.com (localhost [127.0.0.1])\n\tby inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id 257851A021C;\n\tTue, 27 Aug 2019 09:09:18 +0200 (CEST)", "from invc005.ap-rdc01.nxp.com (invc005.ap-rdc01.nxp.com\n\t[165.114.16.14])\n\tby inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id E13771A0049;\n\tTue, 27 Aug 2019 09:09:15 +0200 (CEST)", "from bf-netperf1.ap.freescale.net (bf-netperf1.ap.freescale.net\n\t[10.232.133.63])\n\tby invc005.ap-rdc01.nxp.com (Postfix) with ESMTP id 63DDA402A5;\n\tTue, 27 Aug 2019 15:09:12 +0800 (SGT)" ], "From": "Sachin Saxena <sachin.saxena@nxp.com>", "To": "dev@dpdk.org", "Cc": "thomas@monjalon.net,\n\tNipun Gupta <nipun.gupta@nxp.com>", "Date": "Tue, 27 Aug 2019 12:37:06 +0530", "Message-Id": "<20190827070730.11206-7-sachin.saxena@nxp.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20190827070730.11206-1-sachin.saxena@nxp.com>", "References": "<20190827070730.11206-1-sachin.saxena@nxp.com>", "X-Virus-Scanned": "ClamAV using ClamSMTP", "Subject": "[dpdk-dev] [PATCH v1 06/30] net/dpaa: support for Rx interrupt\n\tenable and disable", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Nipun Gupta <nipun.gupta@nxp.com>\n\nThis patch adds support for dpaa eth driver\ninterrupt enable and disable callback functions.\n\nSigned-off-by: Nipun Gupta <nipun.gupta@nxp.com>\n---\n drivers/bus/dpaa/base/qbman/qman.c | 45 +++++++++++++++++++++++\n drivers/bus/dpaa/base/qbman/qman_driver.c | 5 +++\n drivers/bus/dpaa/base/qbman/qman_priv.h | 2 +\n drivers/bus/dpaa/include/fsl_usd.h | 1 +\n drivers/bus/dpaa/rte_bus_dpaa_version.map | 3 ++\n drivers/net/dpaa/dpaa_ethdev.c | 39 +++++++++++++++++++-\n 6 files changed, 94 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/bus/dpaa/base/qbman/qman.c b/drivers/bus/dpaa/base/qbman/qman.c\nindex 79017f7f2..96208bc40 100644\n--- a/drivers/bus/dpaa/base/qbman/qman.c\n+++ b/drivers/bus/dpaa/base/qbman/qman.c\n@@ -664,6 +664,12 @@ qman_free_global_portal(struct qman_portal *portal)\n \treturn -1;\n }\n \n+void\n+qman_portal_uninhibit_isr(struct qman_portal *portal)\n+{\n+\tqm_isr_uninhibit(&portal->p);\n+}\n+\n struct qman_portal *qman_create_affine_portal(const struct qm_portal_config *c,\n \t\t\t\t\t const struct qman_cgrs *cgrs)\n {\n@@ -1053,6 +1059,20 @@ int qman_irqsource_add(u32 bits)\n \tdpaa_set_bits(bits, &p->irq_sources);\n \tqm_isr_enable_write(&p->p, p->irq_sources);\n \n+\treturn 0;\n+}\n+\n+int qman_fq_portal_irqsource_add(struct qman_portal *p, u32 bits)\n+{\n+\tbits = bits & QM_PIRQ_VISIBLE;\n+\n+\t/* Clear any previously remaining interrupt conditions in\n+\t * QCSP_ISR. This prevents raising a false interrupt when\n+\t * interrupt conditions are enabled in QCSP_IER.\n+\t */\n+\tqm_isr_status_clear(&p->p, bits);\n+\tdpaa_set_bits(bits, &p->irq_sources);\n+\tqm_isr_enable_write(&p->p, p->irq_sources);\n \n \treturn 0;\n }\n@@ -1083,6 +1103,31 @@ int qman_irqsource_remove(u32 bits)\n \treturn 0;\n }\n \n+int qman_fq_portal_irqsource_remove(struct qman_portal *p, u32 bits)\n+{\n+\tu32 ier;\n+\n+\t/* Our interrupt handler only processes+clears status register bits that\n+\t * are in p->irq_sources. As we're trimming that mask, if one of them\n+\t * were to assert in the status register just before we remove it from\n+\t * the enable register, there would be an interrupt-storm when we\n+\t * release the IRQ lock. So we wait for the enable register update to\n+\t * take effect in h/w (by reading it back) and then clear all other bits\n+\t * in the status register. Ie. we clear them from ISR once it's certain\n+\t * IER won't allow them to reassert.\n+\t */\n+\n+\tbits &= QM_PIRQ_VISIBLE;\n+\tdpaa_clear_bits(bits, &p->irq_sources);\n+\tqm_isr_enable_write(&p->p, p->irq_sources);\n+\tier = qm_isr_enable_read(&p->p);\n+\t/* Using \"~ier\" (rather than \"bits\" or \"~p->irq_sources\") creates a\n+\t * data-dependency, ie. to protect against re-ordering.\n+\t */\n+\tqm_isr_status_clear(&p->p, ~ier);\n+\treturn 0;\n+}\n+\n u16 qman_affine_channel(int cpu)\n {\n \tif (cpu < 0) {\ndiff --git a/drivers/bus/dpaa/base/qbman/qman_driver.c b/drivers/bus/dpaa/base/qbman/qman_driver.c\nindex acd003143..69244ef70 100644\n--- a/drivers/bus/dpaa/base/qbman/qman_driver.c\n+++ b/drivers/bus/dpaa/base/qbman/qman_driver.c\n@@ -121,6 +121,11 @@ void qman_thread_irq(void)\n \tout_be32(qpcfg.addr_virt[DPAA_PORTAL_CI] + 0x36C0, 0);\n }\n \n+void qman_fq_portal_thread_irq(struct qman_portal *qp)\n+{\n+\tqman_portal_uninhibit_isr(qp);\n+}\n+\n struct qman_portal *fsl_qman_fq_portal_create(int *fd)\n {\n \tstruct qman_portal *portal = NULL;\ndiff --git a/drivers/bus/dpaa/base/qbman/qman_priv.h b/drivers/bus/dpaa/base/qbman/qman_priv.h\nindex 97d5521a8..8254729e6 100644\n--- a/drivers/bus/dpaa/base/qbman/qman_priv.h\n+++ b/drivers/bus/dpaa/base/qbman/qman_priv.h\n@@ -157,6 +157,8 @@ qman_init_portal(struct qman_portal *portal,\n struct qman_portal *qman_alloc_global_portal(struct qm_portal_config *q_pcfg);\n int qman_free_global_portal(struct qman_portal *portal);\n \n+void qman_portal_uninhibit_isr(struct qman_portal *portal);\n+\n struct qm_portal_config *qm_get_unused_portal(void);\n struct qm_portal_config *qm_get_unused_portal_idx(uint32_t idx);\n \ndiff --git a/drivers/bus/dpaa/include/fsl_usd.h b/drivers/bus/dpaa/include/fsl_usd.h\nindex a407e2b22..3c26d6ccb 100644\n--- a/drivers/bus/dpaa/include/fsl_usd.h\n+++ b/drivers/bus/dpaa/include/fsl_usd.h\n@@ -67,6 +67,7 @@ int bman_thread_fd(void);\n */\n void qman_thread_irq(void);\n void bman_thread_irq(void);\n+void qman_fq_portal_thread_irq(struct qman_portal *qp);\n \n void qman_clear_irq(void);\n \ndiff --git a/drivers/bus/dpaa/rte_bus_dpaa_version.map b/drivers/bus/dpaa/rte_bus_dpaa_version.map\nindex f779469f9..962b952d3 100644\n--- a/drivers/bus/dpaa/rte_bus_dpaa_version.map\n+++ b/drivers/bus/dpaa/rte_bus_dpaa_version.map\n@@ -127,6 +127,9 @@ DPDK_19.05 {\n DPDK_19.11 {\n \tglobal:\n \tfsl_qman_fq_portal_create;\n+\tqman_fq_portal_irqsource_add;\n+\tqman_fq_portal_irqsource_remove;\n+\tqman_fq_portal_thread_irq;\n \n \tlocal: *;\n } DPDK_19.05;\ndiff --git a/drivers/net/dpaa/dpaa_ethdev.c b/drivers/net/dpaa/dpaa_ethdev.c\nindex 1934f85ae..42ab3d05f 100644\n--- a/drivers/net/dpaa/dpaa_ethdev.c\n+++ b/drivers/net/dpaa/dpaa_ethdev.c\n@@ -1,7 +1,7 @@\n /* SPDX-License-Identifier: BSD-3-Clause\n *\n * Copyright 2016 Freescale Semiconductor, Inc. All rights reserved.\n- * Copyright 2017 NXP\n+ * Copyright 2017-2019 NXP\n *\n */\n /* System headers */\n@@ -1013,6 +1013,40 @@ dpaa_dev_set_mac_addr(struct rte_eth_dev *dev,\n \treturn ret;\n }\n \n+static int dpaa_dev_queue_intr_enable(struct rte_eth_dev *dev,\n+\t\t\t\t uint16_t queue_id)\n+{\n+\tstruct dpaa_if *dpaa_intf = dev->data->dev_private;\n+\tstruct qman_fq *rxq = &dpaa_intf->rx_queues[queue_id];\n+\n+\tif (!rxq->is_static)\n+\t\treturn -EINVAL;\n+\n+\treturn qman_fq_portal_irqsource_add(rxq->qp, QM_PIRQ_DQRI);\n+}\n+\n+static int dpaa_dev_queue_intr_disable(struct rte_eth_dev *dev,\n+\t\t\t\t uint16_t queue_id)\n+{\n+\tstruct dpaa_if *dpaa_intf = dev->data->dev_private;\n+\tstruct qman_fq *rxq = &dpaa_intf->rx_queues[queue_id];\n+\tuint32_t temp;\n+\tssize_t temp1;\n+\n+\tif (!rxq->is_static)\n+\t\treturn -EINVAL;\n+\n+\tqman_fq_portal_irqsource_remove(rxq->qp, ~0);\n+\n+\ttemp1 = read(rxq->q_fd, &temp, sizeof(temp));\n+\tif (temp1 != sizeof(temp))\n+\t\tDPAA_EVENTDEV_ERR(\"irq read error\");\n+\n+\tqman_fq_portal_thread_irq(rxq->qp);\n+\n+\treturn 0;\n+}\n+\n static struct eth_dev_ops dpaa_devops = {\n \t.dev_configure\t\t = dpaa_eth_dev_configure,\n \t.dev_start\t\t = dpaa_eth_dev_start,\n@@ -1050,6 +1084,9 @@ static struct eth_dev_ops dpaa_devops = {\n \t.mac_addr_set\t\t = dpaa_dev_set_mac_addr,\n \n \t.fw_version_get\t\t = dpaa_fw_version_get,\n+\n+\t.rx_queue_intr_enable\t = dpaa_dev_queue_intr_enable,\n+\t.rx_queue_intr_disable\t = dpaa_dev_queue_intr_disable,\n };\n \n static bool\n", "prefixes": [ "v1", "06/30" ] }