Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/57854/?format=api
{ "id": 57854, "url": "http://patches.dpdk.org/api/patches/57854/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1566568031-45991-17-git-send-email-xavier.huwei@huawei.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1566568031-45991-17-git-send-email-xavier.huwei@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1566568031-45991-17-git-send-email-xavier.huwei@huawei.com", "date": "2019-08-23T13:47:05", "name": "[16/22] net/hns3: add start stop configure promiscuous ops", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "1b96ca307332049da62cef292e4c0ff7b93ee9d4", "submitter": { "id": 1405, "url": "http://patches.dpdk.org/api/people/1405/?format=api", "name": "Wei Hu (Xavier)", "email": "xavier.huwei@huawei.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1566568031-45991-17-git-send-email-xavier.huwei@huawei.com/mbox/", "series": [ { "id": 6114, "url": "http://patches.dpdk.org/api/series/6114/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=6114", "date": "2019-08-23T13:46:49", "name": "add hns3 ethernet PMD driver", "version": 1, "mbox": "http://patches.dpdk.org/series/6114/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/57854/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/57854/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 0EF271C029;\n\tFri, 23 Aug 2019 15:50:05 +0200 (CEST)", "from huawei.com (szxga07-in.huawei.com [45.249.212.35])\n\tby dpdk.org (Postfix) with ESMTP id 42D141BFCB\n\tfor <dev@dpdk.org>; Fri, 23 Aug 2019 15:49:39 +0200 (CEST)", "from DGGEMS406-HUB.china.huawei.com (unknown [172.30.72.59])\n\tby Forcepoint Email with ESMTP id F08DADC4BCE23C4BF43A;\n\tFri, 23 Aug 2019 21:49:36 +0800 (CST)", "from localhost.localdomain (10.67.212.132) by\n\tDGGEMS406-HUB.china.huawei.com (10.3.19.206) with Microsoft SMTP\n\tServer id 14.3.439.0; Fri, 23 Aug 2019 21:49:30 +0800" ], "From": "\"Wei Hu (Xavier)\" <xavier.huwei@huawei.com>", "To": "<dev@dpdk.org>", "CC": "<linuxarm@huawei.com>, <xavier_huwei@163.com>, <liudongdong3@huawei.com>,\n\t<forest.zhouchang@huawei.com>", "Date": "Fri, 23 Aug 2019 21:47:05 +0800", "Message-ID": "<1566568031-45991-17-git-send-email-xavier.huwei@huawei.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1566568031-45991-1-git-send-email-xavier.huwei@huawei.com>", "References": "<1566568031-45991-1-git-send-email-xavier.huwei@huawei.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[10.67.212.132]", "X-CFilter-Loop": "Reflected", "Subject": "[dpdk-dev] [PATCH 16/22] net/hns3: add start stop configure\n\tpromiscuous ops", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This patch adds dev_start, dev_stop, dev_configure, promiscuous_enable,\npromiscuous_disable, allmulticast_enable, allmulticast_disable,\ndev_infos_get related function codes.\n\nSigned-off-by: Wei Hu (Xavier) <xavier.huwei@huawei.com>\nSigned-off-by: Chunsong Feng <fengchunsong@huawei.com>\nSigned-off-by: Min Hu (Connor) <humin29@huawei.com>\nSigned-off-by: Hao Chen <chenhao164@huawei.com>\nSigned-off-by: Huisong Li <lihuisong@huawei.com>\n---\n drivers/net/hns3/hns3_ethdev.c | 406 ++++++++++++++++++++++++++++++++++++++\n drivers/net/hns3/hns3_ethdev_vf.c | 1 +\n 2 files changed, 407 insertions(+)", "diff": "diff --git a/drivers/net/hns3/hns3_ethdev.c b/drivers/net/hns3/hns3_ethdev.c\nindex 73b34d2..4a57474 100644\n--- a/drivers/net/hns3/hns3_ethdev.c\n+++ b/drivers/net/hns3/hns3_ethdev.c\n@@ -42,6 +42,7 @@\n #define HNS3_DEFAULT_PORT_CONF_BURST_SIZE\t32\n #define HNS3_DEFAULT_PORT_CONF_QUEUES_NUM\t1\n \n+#define HNS3_SERVICE_INTERVAL\t\t1000000 /* us */\n #define HNS3_PORT_BASE_VLAN_DISABLE\t0\n #define HNS3_PORT_BASE_VLAN_ENABLE\t1\n #define HNS3_INVLID_PVID\t\t0xFFFF\n@@ -134,6 +135,41 @@ hns3_add_dev_vlan_table(struct hns3_adapter *hns, uint16_t vlan_id,\n }\n \n static int\n+hns3_vlan_filter_configure(struct hns3_adapter *hns, uint16_t vlan_id, int on)\n+{\n+\tstruct hns3_pf *pf = &hns->pf;\n+\tbool writen_to_tbl = false;\n+\tint ret = 0;\n+\n+\t/*\n+\t * When vlan filter is enabled, hardware regards vlan id 0 as the entry\n+\t * for normal packet, deleting vlan id 0 is not allowed.\n+\t */\n+\tif (on == 0 && vlan_id == 0)\n+\t\treturn 0;\n+\n+\t/*\n+\t * When port base vlan enabled, we use port base vlan as the vlan\n+\t * filter condition. In this case, we don't update vlan filter table\n+\t * when user add new vlan or remove exist vlan, just update the\n+\t * vlan list. The vlan id in vlan list will be writen in vlan filter\n+\t * table until port base vlan disabled\n+\t */\n+\tif (pf->port_base_vlan_cfg.state == HNS3_PORT_BASE_VLAN_DISABLE) {\n+\t\tret = hns3_set_port_vlan_filter(hns, vlan_id, on);\n+\t\twriten_to_tbl = true;\n+\t}\n+\n+\tif (ret == 0 && vlan_id) {\n+\t\tif (on)\n+\t\t\thns3_add_dev_vlan_table(hns, vlan_id, writen_to_tbl);\n+\t\telse\n+\t\t\thns3_rm_dev_vlan_table(hns, vlan_id);\n+\t}\n+\treturn ret;\n+}\n+\n+static int\n hns3_vlan_filter_set(struct rte_eth_dev *dev, uint16_t vlan_id, int on)\n {\n \tstruct hns3_adapter *hns = dev->data->dev_private;\n@@ -1632,6 +1668,178 @@ hns3_configure_all_mc_mac_addr(struct hns3_adapter *hns, bool del)\n }\n \n static int\n+hns3_check_mq_mode(struct rte_eth_dev *dev)\n+{\n+\tenum rte_eth_rx_mq_mode rx_mq_mode = dev->data->dev_conf.rxmode.mq_mode;\n+\tenum rte_eth_tx_mq_mode tx_mq_mode = dev->data->dev_conf.txmode.mq_mode;\n+\tstruct hns3_hw *hw = HNS3_DEV_PRIVATE_TO_HW(dev->data->dev_private);\n+\tstruct hns3_pf *pf = HNS3_DEV_PRIVATE_TO_PF(dev->data->dev_private);\n+\tstruct rte_eth_dcb_rx_conf *dcb_rx_conf;\n+\tstruct rte_eth_dcb_tx_conf *dcb_tx_conf;\n+\tuint8_t num_tc;\n+\tint max_tc = 0;\n+\tint i;\n+\n+\tdcb_rx_conf = &dev->data->dev_conf.rx_adv_conf.dcb_rx_conf;\n+\tdcb_tx_conf = &dev->data->dev_conf.tx_adv_conf.dcb_tx_conf;\n+\n+\tif (rx_mq_mode == ETH_MQ_RX_VMDQ_DCB_RSS) {\n+\t\thns3_err(hw, \"ETH_MQ_RX_VMDQ_DCB_RSS is not supported. \"\n+\t\t\t \"rx_mq_mode = %d\", rx_mq_mode);\n+\t\treturn -EINVAL;\n+\t}\n+\n+\tif (rx_mq_mode == ETH_MQ_RX_VMDQ_DCB ||\n+\t tx_mq_mode == ETH_MQ_TX_VMDQ_DCB) {\n+\t\thns3_err(hw, \"ETH_MQ_RX_VMDQ_DCB and ETH_MQ_TX_VMDQ_DCB \"\n+\t\t\t \"is not supported. rx_mq_mode = %d, tx_mq_mode = %d\",\n+\t\t\t rx_mq_mode, tx_mq_mode);\n+\t\treturn -EINVAL;\n+\t}\n+\n+\tif (rx_mq_mode == ETH_MQ_RX_DCB_RSS) {\n+\t\tif (dcb_rx_conf->nb_tcs > pf->tc_max) {\n+\t\t\thns3_err(hw, \"nb_tcs(%u) > max_tc(%u) driver supported.\",\n+\t\t\t\t dcb_rx_conf->nb_tcs, pf->tc_max);\n+\t\t\treturn -EINVAL;\n+\t\t}\n+\n+\t\tif (!(dcb_rx_conf->nb_tcs == HNS3_4_TCS ||\n+\t\t dcb_rx_conf->nb_tcs == HNS3_8_TCS)) {\n+\t\t\thns3_err(hw, \"on ETH_MQ_RX_DCB_RSS mode, \"\n+\t\t\t\t \"nb_tcs(%d) != %d or %d in rx direction.\",\n+\t\t\t\t dcb_rx_conf->nb_tcs, HNS3_4_TCS, HNS3_8_TCS);\n+\t\t\treturn -EINVAL;\n+\t\t}\n+\n+\t\tif (dcb_rx_conf->nb_tcs != dcb_tx_conf->nb_tcs) {\n+\t\t\thns3_err(hw, \"num_tcs(%d) of tx is not equal to rx(%d)\",\n+\t\t\t\t dcb_tx_conf->nb_tcs, dcb_rx_conf->nb_tcs);\n+\t\t\treturn -EINVAL;\n+\t\t}\n+\n+\t\tfor (i = 0; i < HNS3_MAX_USER_PRIO; i++) {\n+\t\t\tif (dcb_rx_conf->dcb_tc[i] != dcb_tx_conf->dcb_tc[i]) {\n+\t\t\t\thns3_err(hw, \"dcb_tc[%d] = %d in rx direction, \"\n+\t\t\t\t\t \"is not equal to one in tx direction.\",\n+\t\t\t\t\t i, dcb_rx_conf->dcb_tc[i]);\n+\t\t\t\treturn -EINVAL;\n+\t\t\t}\n+\t\t\tif (dcb_rx_conf->dcb_tc[i] > max_tc)\n+\t\t\t\tmax_tc = dcb_rx_conf->dcb_tc[i];\n+\t\t}\n+\n+\t\tnum_tc = max_tc + 1;\n+\t\tif (num_tc > dcb_rx_conf->nb_tcs) {\n+\t\t\thns3_err(hw, \"max num_tc(%u) mapped > nb_tcs(%u)\",\n+\t\t\t\t num_tc, dcb_rx_conf->nb_tcs);\n+\t\t\treturn -EINVAL;\n+\t\t}\n+\t}\n+\n+\treturn 0;\n+}\n+\n+static int\n+hns3_check_dcb_cfg(struct rte_eth_dev *dev)\n+{\n+\tstruct hns3_hw *hw = HNS3_DEV_PRIVATE_TO_HW(dev->data->dev_private);\n+\n+\tif (!hns3_dev_dcb_supported(hw)) {\n+\t\thns3_err(hw, \"this port does not support dcb configurations.\");\n+\t\treturn -EOPNOTSUPP;\n+\t}\n+\n+\tif (hw->current_fc_status == HNS3_FC_STATUS_MAC_PAUSE) {\n+\t\thns3_err(hw, \"MAC pause enabled, cannot config dcb info.\");\n+\t\treturn -EOPNOTSUPP;\n+\t}\n+\n+\t/* Check multiple queue mode */\n+\treturn hns3_check_mq_mode(dev);\n+}\n+\n+static int\n+hns3_dev_configure(struct rte_eth_dev *dev)\n+{\n+\tstruct hns3_hw *hw = HNS3_DEV_PRIVATE_TO_HW(dev->data->dev_private);\n+\tstruct hns3_rss_conf *rss_cfg = &hw->rss_info;\n+\tstruct rte_eth_conf *conf = &dev->data->dev_conf;\n+\tenum rte_eth_rx_mq_mode mq_mode = conf->rxmode.mq_mode;\n+\tuint16_t nb_rx_q = dev->data->nb_rx_queues;\n+\tuint16_t nb_tx_q = dev->data->nb_tx_queues;\n+\tstruct rte_eth_rss_conf rss_conf;\n+\tuint16_t mtu;\n+\tint ret;\n+\n+\t/*\n+\t * Hardware does not support where the number of rx and tx queues is\n+\t * not equal in hip08.\n+\t */\n+\tif (nb_rx_q != nb_tx_q) {\n+\t\thns3_err(hw,\n+\t\t\t \"nb_rx_queues(%u) not equal with nb_tx_queues(%u)! \"\n+\t\t\t \"Hardware does not support this configuration!\",\n+\t\t\t nb_rx_q, nb_tx_q);\n+\t\treturn -EINVAL;\n+\t}\n+\n+\tif (conf->link_speeds & ETH_LINK_SPEED_FIXED) {\n+\t\thns3_err(hw, \"setting link speed/duplex not supported\");\n+\t\treturn -EINVAL;\n+\t}\n+\n+\thw->adapter_state = HNS3_NIC_CONFIGURING;\n+\tif ((uint32_t)mq_mode & ETH_MQ_RX_DCB_FLAG) {\n+\t\tret = hns3_check_dcb_cfg(dev);\n+\t\tif (ret)\n+\t\t\tgoto cfg_err;\n+\t}\n+\n+\t/* When RSS is not configured, redirect the packet queue 0 */\n+\tif ((uint32_t)mq_mode & ETH_MQ_RX_RSS_FLAG) {\n+\t\trss_conf = conf->rx_adv_conf.rss_conf;\n+\t\tif (rss_conf.rss_key == NULL) {\n+\t\t\trss_conf.rss_key = rss_cfg->key;\n+\t\t\trss_conf.rss_key_len = HNS3_RSS_KEY_SIZE;\n+\t\t}\n+\n+\t\tret = hns3_dev_rss_hash_update(dev, &rss_conf);\n+\t\tif (ret)\n+\t\t\tgoto cfg_err;\n+\t}\n+\n+\t/*\n+\t * If jumbo frames are enabled, MTU needs to be refreshed\n+\t * according to the maximum RX packet length.\n+\t */\n+\tif (conf->rxmode.offloads & DEV_RX_OFFLOAD_JUMBO_FRAME) {\n+\t\t/*\n+\t\t * Security of max_rx_pkt_len is guaranteed in dpdk frame.\n+\t\t * Maximum value of max_rx_pkt_len is HNS3_MAX_FRAME_LEN, so it\n+\t\t * can safely assign to \"uint16_t\" type variable.\n+\t\t */\n+\t\tmtu = (uint16_t)HNS3_PKTLEN_TO_MTU(conf->rxmode.max_rx_pkt_len);\n+\t\tret = hns3_dev_mtu_set(dev, mtu);\n+\t\tif (ret)\n+\t\t\tgoto cfg_err;\n+\t\tdev->data->mtu = mtu;\n+\t}\n+\n+\tret = hns3_dev_configure_vlan(dev);\n+\tif (ret)\n+\t\tgoto cfg_err;\n+\n+\thw->adapter_state = HNS3_NIC_CONFIGURED;\n+\n+\treturn 0;\n+\n+cfg_err:\n+\thw->adapter_state = HNS3_NIC_INITIALIZED;\n+\treturn ret;\n+}\n+\n+static int\n hns3_set_mac_mtu(struct hns3_hw *hw, uint16_t new_mps)\n {\n \tstruct hns3_config_max_frm_size_cmd *req;\n@@ -3080,6 +3288,71 @@ hns3_set_promisc_mode(struct hns3_hw *hw, bool en_uc_pmc, bool en_mc_pmc)\n \treturn 0;\n }\n \n+static void\n+hns3_dev_promiscuous_enable(struct rte_eth_dev *dev)\n+{\n+\tstruct hns3_adapter *hns = dev->data->dev_private;\n+\tstruct hns3_hw *hw = &hns->hw;\n+\tbool en_mc_pmc = (dev->data->all_multicast == 1) ? true : false;\n+\tint ret;\n+\n+\trte_spinlock_lock(&hw->lock);\n+\tret = hns3_set_promisc_mode(hw, true, en_mc_pmc);\n+\tif (ret)\n+\t\thns3_err(hw, \"Failed to enable promiscuous mode: %d\", ret);\n+\trte_spinlock_unlock(&hw->lock);\n+}\n+\n+static void\n+hns3_dev_promiscuous_disable(struct rte_eth_dev *dev)\n+{\n+\tstruct hns3_adapter *hns = dev->data->dev_private;\n+\tstruct hns3_hw *hw = &hns->hw;\n+\tbool en_mc_pmc = (dev->data->all_multicast == 1) ? true : false;\n+\tint ret;\n+\n+\t/* If now in all_multicast mode, must remain in all_multicast mode. */\n+\trte_spinlock_lock(&hw->lock);\n+\tret = hns3_set_promisc_mode(hw, false, en_mc_pmc);\n+\tif (ret)\n+\t\thns3_err(hw, \"Failed to disable promiscuous mode: %d\", ret);\n+\trte_spinlock_unlock(&hw->lock);\n+}\n+\n+static void\n+hns3_dev_allmulticast_enable(struct rte_eth_dev *dev)\n+{\n+\tstruct hns3_adapter *hns = dev->data->dev_private;\n+\tstruct hns3_hw *hw = &hns->hw;\n+\tbool en_uc_pmc = (dev->data->promiscuous == 1) ? true : false;\n+\tint ret;\n+\n+\trte_spinlock_lock(&hw->lock);\n+\tret = hns3_set_promisc_mode(hw, en_uc_pmc, true);\n+\tif (ret)\n+\t\thns3_err(hw, \"Failed to enable allmulticast mode: %d\", ret);\n+\trte_spinlock_unlock(&hw->lock);\n+}\n+\n+static void\n+hns3_dev_allmulticast_disable(struct rte_eth_dev *dev)\n+{\n+\tstruct hns3_adapter *hns = dev->data->dev_private;\n+\tstruct hns3_hw *hw = &hns->hw;\n+\tbool en_uc_pmc = (dev->data->promiscuous == 1) ? true : false;\n+\tint ret;\n+\n+\t/* If now in promiscuous mode, must remain in all_multicast mode. */\n+\tif (dev->data->promiscuous == 1)\n+\t\treturn;\n+\n+\trte_spinlock_lock(&hw->lock);\n+\tret = hns3_set_promisc_mode(hw, en_uc_pmc, false);\n+\tif (ret)\n+\t\thns3_err(hw, \"Failed to disable allmulticast mode: %d\", ret);\n+\trte_spinlock_unlock(&hw->lock);\n+}\n+\n static int\n hns3_get_sfp_speed(struct hns3_hw *hw, uint32_t *speed)\n {\n@@ -3345,6 +3618,18 @@ hns3_init_pf(struct rte_eth_dev *eth_dev)\n \t\tgoto err_cmd_init;\n \t}\n \n+\tret = rte_intr_callback_register(&pci_dev->intr_handle,\n+\t\t\t\t\t hns3_interrupt_handler,\n+\t\t\t\t\t eth_dev);\n+\tif (ret) {\n+\t\tPMD_INIT_LOG(ERR, \"Failed to register intr: %d\", ret);\n+\t\tgoto err_intr_callback_register;\n+\t}\n+\n+\t/* Enable interrupt */\n+\trte_intr_enable(&pci_dev->intr_handle);\n+\thns3_pf_enable_irq0(hw);\n+\n \t/* Get configuration */\n \tret = hns3_get_configuration(hw);\n \tif (ret) {\n@@ -3373,6 +3658,12 @@ hns3_init_pf(struct rte_eth_dev *eth_dev)\n \thns3_uninit_umv_space(hw);\n \n err_get_config:\n+\thns3_pf_disable_irq0(hw);\n+\trte_intr_disable(&pci_dev->intr_handle);\n+\thns3_intr_unregister(&pci_dev->intr_handle, hns3_interrupt_handler,\n+\t\t\t eth_dev);\n+\n+err_intr_callback_register:\n \thns3_cmd_uninit(hw);\n \n err_cmd_init:\n@@ -3397,19 +3688,126 @@ hns3_uninit_pf(struct rte_eth_dev *eth_dev)\n \thns3_rss_uninit(hns);\n \thns3_fdir_filter_uninit(hns);\n \thns3_uninit_umv_space(hw);\n+\thns3_pf_disable_irq0(hw);\n+\trte_intr_disable(&pci_dev->intr_handle);\n+\thns3_intr_unregister(&pci_dev->intr_handle, hns3_interrupt_handler,\n+\t\t\t eth_dev);\n \thns3_cmd_uninit(hw);\n \thns3_cmd_destroy_queue(hw);\n \thw->io_base = NULL;\n }\n \n+static int\n+hns3_do_start(struct hns3_adapter *hns, bool reset_queue)\n+{\n+\tstruct hns3_hw *hw = &hns->hw;\n+\tint ret;\n+\n+\tret = hns3_dcb_cfg_update(hns);\n+\tif (ret)\n+\t\treturn ret;\n+\n+\t/* Enable queues */\n+\tret = hns3_start_queues(hns, reset_queue);\n+\tif (ret) {\n+\t\tPMD_INIT_LOG(ERR, \"Failed to start queues: %d\", ret);\n+\t\treturn ret;\n+\t}\n+\n+\t/* Enable MAC */\n+\tret = hns3_cfg_mac_mode(hw, true);\n+\tif (ret) {\n+\t\tPMD_INIT_LOG(ERR, \"Failed to enable MAC: %d\", ret);\n+\t\tgoto err_config_mac_mode;\n+\t}\n+\treturn 0;\n+\n+err_config_mac_mode:\n+\thns3_stop_queues(hns, true);\n+\treturn ret;\n+}\n+\n+static int\n+hns3_dev_start(struct rte_eth_dev *eth_dev)\n+{\n+\tstruct hns3_adapter *hns = eth_dev->data->dev_private;\n+\tstruct hns3_hw *hw = &hns->hw;\n+\tint ret;\n+\n+\tPMD_INIT_FUNC_TRACE();\n+\trte_spinlock_lock(&hw->lock);\n+\thw->adapter_state = HNS3_NIC_STARTING;\n+\n+\tret = hns3_do_start(hns, true);\n+\tif (ret) {\n+\t\thw->adapter_state = HNS3_NIC_CONFIGURED;\n+\t\trte_spinlock_unlock(&hw->lock);\n+\t\treturn ret;\n+\t}\n+\n+\thw->adapter_state = HNS3_NIC_STARTED;\n+\trte_spinlock_unlock(&hw->lock);\n+\thns3_set_rxtx_function(eth_dev);\n+\thns3_mp_req_start_rxtx(eth_dev);\n+\n+\thns3_info(hw, \"hns3 dev start successful!\");\n+\treturn 0;\n+}\n+\n+static int\n+hns3_do_stop(struct hns3_adapter *hns)\n+{\n+\tstruct hns3_hw *hw = &hns->hw;\n+\tbool reset_queue;\n+\tint ret;\n+\n+\tret = hns3_cfg_mac_mode(hw, false);\n+\tif (ret)\n+\t\treturn ret;\n+\thw->mac.link_status = ETH_LINK_DOWN;\n+\n+\thns3_configure_all_mac_addr(hns, true);\n+\treset_queue = true;\n+\thw->mac.default_addr_setted = false;\n+\treturn hns3_stop_queues(hns, reset_queue);\n+}\n+\n+static void\n+hns3_dev_stop(struct rte_eth_dev *eth_dev)\n+{\n+\tstruct hns3_adapter *hns = eth_dev->data->dev_private;\n+\tstruct hns3_hw *hw = &hns->hw;\n+\n+\tPMD_INIT_FUNC_TRACE();\n+\n+\thw->adapter_state = HNS3_NIC_STOPPING;\n+\thns3_set_rxtx_function(eth_dev);\n+\trte_wmb();\n+\n+\trte_spinlock_lock(&hw->lock);\n+\thns3_do_stop(hns);\n+\thns3_dev_release_mbufs(hns);\n+\thw->adapter_state = HNS3_NIC_CONFIGURED;\n+\trte_spinlock_unlock(&hw->lock);\n+}\n+\n static void\n hns3_dev_close(struct rte_eth_dev *eth_dev)\n {\n \tstruct hns3_adapter *hns = eth_dev->data->dev_private;\n \tstruct hns3_hw *hw = &hns->hw;\n \n+\tif (hw->adapter_state == HNS3_NIC_STARTED)\n+\t\thns3_dev_stop(eth_dev);\n+\n \thw->adapter_state = HNS3_NIC_CLOSING;\n+\trte_eal_alarm_cancel(hns3_service_handler, eth_dev);\n+\n+\thns3_configure_all_mc_mac_addr(hns, true);\n+\thns3_remove_all_vlan_table(hns);\n+\thns3_vlan_txvlan_cfg(hns, HNS3_PORT_BASE_VLAN_DISABLE, 0);\n \thns3_uninit_pf(eth_dev);\n+\thns3_free_all_queues(eth_dev);\n \thw->adapter_state = HNS3_NIC_CLOSED;\n }\n \n@@ -3600,7 +3998,13 @@ hns3_get_dcb_info(struct rte_eth_dev *dev, struct rte_eth_dcb_info *dcb_info)\n }\n \n static const struct eth_dev_ops hns3_eth_dev_ops = {\n+\t.dev_start = hns3_dev_start,\n+\t.dev_stop = hns3_dev_stop,\n \t.dev_close = hns3_dev_close,\n+\t.promiscuous_enable = hns3_dev_promiscuous_enable,\n+\t.promiscuous_disable = hns3_dev_promiscuous_disable,\n+\t.allmulticast_enable = hns3_dev_allmulticast_enable,\n+\t.allmulticast_disable = hns3_dev_allmulticast_disable,\n \t.mtu_set = hns3_dev_mtu_set,\n \t.dev_infos_get = hns3_dev_infos_get,\n \t.fw_version_get = hns3_fw_version_get,\n@@ -3608,6 +4012,7 @@ static const struct eth_dev_ops hns3_eth_dev_ops = {\n \t.tx_queue_setup = hns3_tx_queue_setup,\n \t.rx_queue_release = hns3_dev_rx_queue_release,\n \t.tx_queue_release = hns3_dev_tx_queue_release,\n+\t.dev_configure = hns3_dev_configure,\n \t.flow_ctrl_get = hns3_flow_ctrl_get,\n \t.flow_ctrl_set = hns3_flow_ctrl_set,\n \t.priority_flow_ctrl_set = hns3_priority_flow_ctrl_set,\n@@ -3626,6 +4031,7 @@ static const struct eth_dev_ops hns3_eth_dev_ops = {\n \t.vlan_offload_set = hns3_vlan_offload_set,\n \t.vlan_pvid_set = hns3_vlan_pvid_set,\n \t.get_dcb_info = hns3_get_dcb_info,\n+\t.dev_supported_ptypes_get = hns3_dev_supported_ptypes_get,\n };\n \n static int\ndiff --git a/drivers/net/hns3/hns3_ethdev_vf.c b/drivers/net/hns3/hns3_ethdev_vf.c\nindex abab2b4..7e73845 100644\n--- a/drivers/net/hns3/hns3_ethdev_vf.c\n+++ b/drivers/net/hns3/hns3_ethdev_vf.c\n@@ -1161,6 +1161,7 @@ static const struct eth_dev_ops hns3vf_eth_dev_ops = {\n \t.filter_ctrl = hns3_dev_filter_ctrl,\n \t.vlan_filter_set = hns3vf_vlan_filter_set,\n \t.vlan_offload_set = hns3vf_vlan_offload_set,\n+\t.dev_supported_ptypes_get = hns3_dev_supported_ptypes_get,\n };\n \n static int\n", "prefixes": [ "16/22" ] }