Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 57847,
    "url": "http://patches.dpdk.org/api/patches/57847/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/1566568031-45991-9-git-send-email-xavier.huwei@huawei.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1566568031-45991-9-git-send-email-xavier.huwei@huawei.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1566568031-45991-9-git-send-email-xavier.huwei@huawei.com",
    "date": "2019-08-23T13:46:57",
    "name": "[08/22] net/hns3: add support for link update operation",
    "commit_ref": null,
    "pull_url": null,
    "state": "changes-requested",
    "archived": true,
    "hash": "dc5683ca953a183dff5afea269bb88670662559c",
    "submitter": {
        "id": 1405,
        "url": "http://patches.dpdk.org/api/people/1405/?format=api",
        "name": "Wei Hu (Xavier)",
        "email": "xavier.huwei@huawei.com"
    },
    "delegate": {
        "id": 319,
        "url": "http://patches.dpdk.org/api/users/319/?format=api",
        "username": "fyigit",
        "first_name": "Ferruh",
        "last_name": "Yigit",
        "email": "ferruh.yigit@amd.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/1566568031-45991-9-git-send-email-xavier.huwei@huawei.com/mbox/",
    "series": [
        {
            "id": 6114,
            "url": "http://patches.dpdk.org/api/series/6114/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=6114",
            "date": "2019-08-23T13:46:49",
            "name": "add hns3 ethernet PMD driver",
            "version": 1,
            "mbox": "http://patches.dpdk.org/series/6114/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/57847/comments/",
    "check": "fail",
    "checks": "http://patches.dpdk.org/api/patches/57847/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 5A47F1BFEE;\n\tFri, 23 Aug 2019 15:49:51 +0200 (CEST)",
            "from huawei.com (szxga07-in.huawei.com [45.249.212.35])\n\tby dpdk.org (Postfix) with ESMTP id A558D1BFC8\n\tfor <dev@dpdk.org>; Fri, 23 Aug 2019 15:49:37 +0200 (CEST)",
            "from DGGEMS406-HUB.china.huawei.com (unknown [172.30.72.59])\n\tby Forcepoint Email with ESMTP id C0483BB171B8A0CF24BC;\n\tFri, 23 Aug 2019 21:49:36 +0800 (CST)",
            "from localhost.localdomain (10.67.212.132) by\n\tDGGEMS406-HUB.china.huawei.com (10.3.19.206) with Microsoft SMTP\n\tServer id 14.3.439.0; Fri, 23 Aug 2019 21:49:27 +0800"
        ],
        "From": "\"Wei Hu (Xavier)\" <xavier.huwei@huawei.com>",
        "To": "<dev@dpdk.org>",
        "CC": "<linuxarm@huawei.com>, <xavier_huwei@163.com>, <liudongdong3@huawei.com>,\n\t<forest.zhouchang@huawei.com>",
        "Date": "Fri, 23 Aug 2019 21:46:57 +0800",
        "Message-ID": "<1566568031-45991-9-git-send-email-xavier.huwei@huawei.com>",
        "X-Mailer": "git-send-email 2.7.4",
        "In-Reply-To": "<1566568031-45991-1-git-send-email-xavier.huwei@huawei.com>",
        "References": "<1566568031-45991-1-git-send-email-xavier.huwei@huawei.com>",
        "MIME-Version": "1.0",
        "Content-Type": "text/plain",
        "X-Originating-IP": "[10.67.212.132]",
        "X-CFilter-Loop": "Reflected",
        "Subject": "[dpdk-dev] [PATCH 08/22] net/hns3: add support for link update\n\toperation",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "This patch adds link update operation to hns3 PMD driver.\n\nSigned-off-by: Wei Hu (Xavier) <xavier.huwei@huawei.com>\nSigned-off-by: Chunsong Feng <fengchunsong@huawei.com>\nSigned-off-by: Min Hu (Connor) <humin29@huawei.com>\nSigned-off-by: Hao Chen <chenhao164@huawei.com>\nSigned-off-by: Huisong Li <lihuisong@huawei.com>\n---\n drivers/net/hns3/hns3_ethdev.c | 199 +++++++++++++++++++++++++++++++++++++++++\n 1 file changed, 199 insertions(+)",
    "diff": "diff --git a/drivers/net/hns3/hns3_ethdev.c b/drivers/net/hns3/hns3_ethdev.c\nindex ced9348..a162d7f 100644\n--- a/drivers/net/hns3/hns3_ethdev.c\n+++ b/drivers/net/hns3/hns3_ethdev.c\n@@ -1127,6 +1127,40 @@ hns3_fw_version_get(struct rte_eth_dev *eth_dev, char *fw_version,\n }\n \n static int\n+hns3_dev_link_update(struct rte_eth_dev *eth_dev,\n+\t\t     __rte_unused int wait_to_complete)\n+{\n+\tstruct hns3_adapter *hns = eth_dev->data->dev_private;\n+\tstruct hns3_hw *hw = &hns->hw;\n+\tstruct hns3_mac *mac = &hw->mac;\n+\tstruct rte_eth_link new_link;\n+\n+\tmemset(&new_link, 0, sizeof(new_link));\n+\tswitch (mac->link_speed) {\n+\tcase ETH_SPEED_NUM_10M:\n+\tcase ETH_SPEED_NUM_100M:\n+\tcase ETH_SPEED_NUM_1G:\n+\tcase ETH_SPEED_NUM_10G:\n+\tcase ETH_SPEED_NUM_25G:\n+\tcase ETH_SPEED_NUM_40G:\n+\tcase ETH_SPEED_NUM_50G:\n+\tcase ETH_SPEED_NUM_100G:\n+\t\tnew_link.link_speed = mac->link_speed;\n+\t\tbreak;\n+\tdefault:\n+\t\tnew_link.link_speed = ETH_SPEED_NUM_100M;\n+\t\tbreak;\n+\t}\n+\n+\tnew_link.link_duplex = mac->link_duplex;\n+\tnew_link.link_status = mac->link_status ? ETH_LINK_UP : ETH_LINK_DOWN;\n+\tnew_link.link_autoneg =\n+\t    !(eth_dev->data->dev_conf.link_speeds & ETH_LINK_SPEED_FIXED);\n+\n+\treturn rte_eth_linkstatus_set(eth_dev, &new_link);\n+}\n+\n+static int\n hns3_parse_func_status(struct hns3_hw *hw, struct hns3_func_status_cmd *status)\n {\n \tstruct hns3_adapter *hns = HNS3_DEV_HW_TO_ADAPTER(hw);\n@@ -2382,6 +2416,169 @@ hns3_set_promisc_mode(struct hns3_hw *hw, bool en_uc_pmc, bool en_mc_pmc)\n }\n \n static int\n+hns3_get_sfp_speed(struct hns3_hw *hw, uint32_t *speed)\n+{\n+\tstruct hns3_sfp_speed_cmd *resp;\n+\tstruct hns3_cmd_desc desc;\n+\tint ret;\n+\n+\thns3_cmd_setup_basic_desc(&desc, HNS3_OPC_SFP_GET_SPEED, true);\n+\tresp = (struct hns3_sfp_speed_cmd *)desc.data;\n+\tret = hns3_cmd_send(hw, &desc, 1);\n+\tif (ret == -EOPNOTSUPP) {\n+\t\thns3_err(hw, \"IMP do not support get SFP speed %d\", ret);\n+\t\treturn ret;\n+\t} else if (ret) {\n+\t\thns3_err(hw, \"get sfp speed failed %d\", ret);\n+\t\treturn ret;\n+\t}\n+\n+\t*speed = resp->sfp_speed;\n+\n+\treturn 0;\n+}\n+\n+static uint8_t\n+hns3_check_speed_dup(uint8_t duplex, uint32_t speed)\n+{\n+\tif (!(speed == ETH_SPEED_NUM_10M || speed == ETH_SPEED_NUM_100M))\n+\t\tduplex = ETH_LINK_FULL_DUPLEX;\n+\n+\treturn duplex;\n+}\n+\n+static int\n+hns3_cfg_mac_speed_dup(struct hns3_hw *hw, uint32_t speed, uint8_t duplex)\n+{\n+\tstruct hns3_mac *mac = &hw->mac;\n+\tint ret;\n+\n+\tduplex = hns3_check_speed_dup(duplex, speed);\n+\tif (mac->link_speed == speed && mac->link_duplex == duplex)\n+\t\treturn 0;\n+\n+\tret = hns3_cfg_mac_speed_dup_hw(hw, speed, duplex);\n+\tif (ret)\n+\t\treturn ret;\n+\n+\tmac->link_speed = speed;\n+\tmac->link_duplex = duplex;\n+\n+\treturn 0;\n+}\n+\n+static int\n+hns3_update_speed_duplex(struct rte_eth_dev *eth_dev)\n+{\n+\tstruct hns3_adapter *hns = eth_dev->data->dev_private;\n+\tstruct hns3_hw *hw = &hns->hw;\n+\tstruct hns3_pf *pf = &hns->pf;\n+\tuint32_t speed;\n+\tint ret;\n+\n+\t/* If IMP do not support get SFP/qSFP speed, return directly */\n+\tif (!pf->support_sfp_query)\n+\t\treturn 0;\n+\n+\tret = hns3_get_sfp_speed(hw, &speed);\n+\tif (ret == -EOPNOTSUPP) {\n+\t\tpf->support_sfp_query = false;\n+\t\treturn ret;\n+\t} else if (ret)\n+\t\treturn ret;\n+\n+\tif (speed == ETH_SPEED_NUM_NONE)\n+\t\treturn 0; /* do nothing if no SFP */\n+\n+\t/* Config full duplex for SFP */\n+\treturn hns3_cfg_mac_speed_dup(hw, speed, ETH_LINK_FULL_DUPLEX);\n+}\n+\n+static int\n+hns3_cfg_mac_mode(struct hns3_hw *hw, bool enable)\n+{\n+\tstruct hns3_config_mac_mode_cmd *req;\n+\tstruct hns3_cmd_desc desc;\n+\tuint32_t loop_en = 0;\n+\tuint8_t val = 0;\n+\tint ret;\n+\n+\treq = (struct hns3_config_mac_mode_cmd *)desc.data;\n+\n+\thns3_cmd_setup_basic_desc(&desc, HNS3_OPC_CONFIG_MAC_MODE, false);\n+\tif (enable)\n+\t\tval = 1;\n+\thns3_set_bit(loop_en, HNS3_MAC_TX_EN_B, val);\n+\thns3_set_bit(loop_en, HNS3_MAC_RX_EN_B, val);\n+\thns3_set_bit(loop_en, HNS3_MAC_PAD_TX_B, val);\n+\thns3_set_bit(loop_en, HNS3_MAC_PAD_RX_B, val);\n+\thns3_set_bit(loop_en, HNS3_MAC_1588_TX_B, 0);\n+\thns3_set_bit(loop_en, HNS3_MAC_1588_RX_B, 0);\n+\thns3_set_bit(loop_en, HNS3_MAC_APP_LP_B, 0);\n+\thns3_set_bit(loop_en, HNS3_MAC_LINE_LP_B, 0);\n+\thns3_set_bit(loop_en, HNS3_MAC_FCS_TX_B, val);\n+\thns3_set_bit(loop_en, HNS3_MAC_RX_FCS_B, val);\n+\thns3_set_bit(loop_en, HNS3_MAC_RX_FCS_STRIP_B, val);\n+\thns3_set_bit(loop_en, HNS3_MAC_TX_OVERSIZE_TRUNCATE_B, val);\n+\thns3_set_bit(loop_en, HNS3_MAC_RX_OVERSIZE_TRUNCATE_B, val);\n+\thns3_set_bit(loop_en, HNS3_MAC_TX_UNDER_MIN_ERR_B, val);\n+\treq->txrx_pad_fcs_loop_en = rte_cpu_to_le_32(loop_en);\n+\n+\tret = hns3_cmd_send(hw, &desc, 1);\n+\tif (ret)\n+\t\tPMD_INIT_LOG(ERR, \"mac enable fail, ret =%d.\", ret);\n+\n+\treturn ret;\n+}\n+\n+static int\n+hns3_get_mac_link_status(struct hns3_hw *hw)\n+{\n+\tstruct hns3_link_status_cmd *req;\n+\tstruct hns3_cmd_desc desc;\n+\tint link_status;\n+\tint ret;\n+\n+\thns3_cmd_setup_basic_desc(&desc, HNS3_OPC_QUERY_LINK_STATUS, true);\n+\tret = hns3_cmd_send(hw, &desc, 1);\n+\tif (ret) {\n+\t\thns3_err(hw, \"get link status cmd failed %d\", ret);\n+\t\treturn ret;\n+\t}\n+\n+\treq = (struct hns3_link_status_cmd *)desc.data;\n+\tlink_status = req->status & HNS3_LINK_STATUS_UP_M;\n+\n+\treturn !!link_status;\n+}\n+\n+static void\n+hns3_update_link_status(struct hns3_hw *hw)\n+{\n+\tint state;\n+\n+\tstate = hns3_get_mac_link_status(hw);\n+\tif (state != hw->mac.link_status)\n+\t\thw->mac.link_status = state;\n+}\n+\n+static void\n+hns3_service_handler(void *param)\n+{\n+\tstruct rte_eth_dev *eth_dev = (struct rte_eth_dev *)param;\n+\tstruct hns3_adapter *hns = eth_dev->data->dev_private;\n+\tstruct hns3_hw *hw = &hns->hw;\n+\n+\tif (!hns3_is_reset_pending(hns)) {\n+\t\thns3_update_speed_duplex(eth_dev);\n+\t\thns3_update_link_status(hw);\n+\t} else\n+\t\thns3_warn(hw, \"Cancel the query when reset is pending\");\n+\n+\trte_eal_alarm_set(HNS3_SERVICE_INTERVAL, hns3_service_handler, eth_dev);\n+}\n+\n+static int\n hns3_init_hardware(struct hns3_adapter *hns)\n {\n \tstruct hns3_hw *hw = &hns->hw;\n@@ -2528,6 +2725,7 @@ static const struct eth_dev_ops hns3_eth_dev_ops = {\n \t.mac_addr_remove        = hns3_remove_mac_addr,\n \t.mac_addr_set           = hns3_set_default_mac_addr,\n \t.set_mc_addr_list       = hns3_set_mc_mac_addr_list,\n+\t.link_update            = hns3_dev_link_update,\n };\n \n static int\n@@ -2580,6 +2778,7 @@ hns3_dev_init(struct rte_eth_dev *eth_dev)\n \t\t\t    &eth_dev->data->mac_addrs[0]);\n \n \thw->adapter_state = HNS3_NIC_INITIALIZED;\n+\trte_eal_alarm_set(HNS3_SERVICE_INTERVAL, hns3_service_handler, eth_dev);\n \thns3_info(hw, \"hns3 dev initialization successful!\");\n \n \treturn 0;\n",
    "prefixes": [
        "08/22"
    ]
}