Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/57039/?format=api
{ "id": 57039, "url": "http://patches.dpdk.org/api/patches/57039/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1862ad94e15a61121aea75a2933dc8a44bb12623.1563982007.git.anatoly.burakov@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1862ad94e15a61121aea75a2933dc8a44bb12623.1563982007.git.anatoly.burakov@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1862ad94e15a61121aea75a2933dc8a44bb12623.1563982007.git.anatoly.burakov@intel.com", "date": "2019-07-24T15:34:44", "name": "[2/2] usertools/devbind: check if module is loaded before binding", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "37c754e4f8bb032fda75abff8b93a1f7d7a07ad2", "submitter": { "id": 4, "url": "http://patches.dpdk.org/api/people/4/?format=api", "name": "Anatoly Burakov", "email": "anatoly.burakov@intel.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1862ad94e15a61121aea75a2933dc8a44bb12623.1563982007.git.anatoly.burakov@intel.com/mbox/", "series": [ { "id": 5713, "url": "http://patches.dpdk.org/api/series/5713/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=5713", "date": "2019-07-24T15:34:42", "name": "Small usability improvements for devbind", "version": 1, "mbox": "http://patches.dpdk.org/series/5713/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/57039/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/57039/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 361901C21D;\n\tWed, 24 Jul 2019 17:34:55 +0200 (CEST)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby dpdk.org (Postfix) with ESMTP id 629CF1C21D\n\tfor <dev@dpdk.org>; Wed, 24 Jul 2019 17:34:50 +0200 (CEST)", "from orsmga008.jf.intel.com ([10.7.209.65])\n\tby fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t24 Jul 2019 08:34:49 -0700", "from silpixa00399498.ir.intel.com (HELO\n\tsilpixa00399498.ger.corp.intel.com) ([10.237.223.125])\n\tby orsmga008.jf.intel.com with ESMTP; 24 Jul 2019 08:34:48 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.64,303,1559545200\"; d=\"scan'208\";a=\"163880276\"", "From": "Anatoly Burakov <anatoly.burakov@intel.com>", "To": "dev@dpdk.org", "Cc": "john.mcnamara@intel.com,\n\tthomas@monjalon.net", "Date": "Wed, 24 Jul 2019 16:34:44 +0100", "Message-Id": "<1862ad94e15a61121aea75a2933dc8a44bb12623.1563982007.git.anatoly.burakov@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": [ "<cover.1563982007.git.anatoly.burakov@intel.com>", "<cover.1563982007.git.anatoly.burakov@intel.com>" ], "References": [ "<cover.1563982007.git.anatoly.burakov@intel.com>", "<cover.1563982007.git.anatoly.burakov@intel.com>" ], "Subject": "[dpdk-dev] [PATCH 2/2] usertools/devbind: check if module is loaded\n\tbefore binding", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Currently, if an attempt is made to bind a device to a driver that\nis not loaded, a confusing and misleading error message appears.\nFix it so that, before binding to the driver, we actually check if\nit is loaded in the kernel first.\n\nSigned-off-by: Anatoly Burakov <anatoly.burakov@intel.com>\n---\n usertools/dpdk-devbind.py | 48 ++++++++++++++++++++++-----------------\n 1 file changed, 27 insertions(+), 21 deletions(-)", "diff": "diff --git a/usertools/dpdk-devbind.py b/usertools/dpdk-devbind.py\nindex f7c4c6434..53112c999 100755\n--- a/usertools/dpdk-devbind.py\n+++ b/usertools/dpdk-devbind.py\n@@ -146,6 +146,25 @@ def check_output(args, stderr=None):\n return subprocess.Popen(args, stdout=subprocess.PIPE,\n stderr=stderr).communicate()[0]\n \n+# check if a specific kernel module is loaded\n+def module_is_loaded(module):\n+ # Get list of sysfs modules (both built-in and dynamically loaded)\n+ sysfs_path = '/sys/module/'\n+\n+ # Get the list of directories in sysfs_path\n+ sysfs_mods = [os.path.join(sysfs_path, o) for o\n+ in os.listdir(sysfs_path)\n+ if os.path.isdir(os.path.join(sysfs_path, o))]\n+\n+ # get module names\n+ sysfs_mods = [os.path.basename(a) for a in sysfs_mods]\n+\n+ # special case for vfio_pci (module is named vfio-pci,\n+ # but its .ko is named vfio_pci)\n+ sysfs_mods = [a if a != 'vfio_pci' else 'vfio-pci' for a in sysfs_mods]\n+\n+ return module in sysfs_mods\n+\n \n def check_modules():\n '''Checks that igb_uio is loaded'''\n@@ -155,27 +174,9 @@ def check_modules():\n mods = [{\"Name\": driver, \"Found\": False} for driver in dpdk_drivers]\n \n # first check if module is loaded\n- try:\n- # Get list of sysfs modules (both built-in and dynamically loaded)\n- sysfs_path = '/sys/module/'\n-\n- # Get the list of directories in sysfs_path\n- sysfs_mods = [os.path.join(sysfs_path, o) for o\n- in os.listdir(sysfs_path)\n- if os.path.isdir(os.path.join(sysfs_path, o))]\n-\n- # Extract the last element of '/sys/module/abc' in the array\n- sysfs_mods = [a.split('/')[-1] for a in sysfs_mods]\n-\n- # special case for vfio_pci (module is named vfio-pci,\n- # but its .ko is named vfio_pci)\n- sysfs_mods = [a if a != 'vfio_pci' else 'vfio-pci' for a in sysfs_mods]\n-\n- for mod in mods:\n- if mod[\"Name\"] in sysfs_mods:\n- mod[\"Found\"] = True\n- except:\n- pass\n+ for mod in mods:\n+ if module_is_loaded(mod[\"Name\"]):\n+ mod[\"Found\"] = True\n \n # check if we have at least one loaded module\n if True not in [mod[\"Found\"] for mod in mods] and b_flag is not None:\n@@ -521,6 +522,11 @@ def bind_all(dev_list, driver, force=False):\n # driver generated error - it's not a valid device ID, so all is well\n pass\n \n+ # check if we're attempting to bind to a driver that isn't loaded\n+ if not module_is_loaded(driver):\n+ print(\"ERROR: Driver '%s' is not loaded.\" % driver)\n+ sys.exit(1)\n+\n try:\n dev_list = map(dev_id_from_dev_name, dev_list)\n except ValueError as ex:\n", "prefixes": [ "2/2" ] }