Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/56480/?format=api
{ "id": 56480, "url": "http://patches.dpdk.org/api/patches/56480/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190716092826.54276-4-ajit.khaparde@broadcom.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190716092826.54276-4-ajit.khaparde@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190716092826.54276-4-ajit.khaparde@broadcom.com", "date": "2019-07-16T09:28:14", "name": "[v2,03/15] net/bnxt: do not fail VF probe when the MAC address is zero", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "dcfc3dad481f9b1c296d6d8758a818411eab7da0", "submitter": { "id": 501, "url": "http://patches.dpdk.org/api/people/501/?format=api", "name": "Ajit Khaparde", "email": "ajit.khaparde@broadcom.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190716092826.54276-4-ajit.khaparde@broadcom.com/mbox/", "series": [ { "id": 5518, "url": "http://patches.dpdk.org/api/series/5518/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=5518", "date": "2019-07-16T09:28:11", "name": "bnxt patch series", "version": 2, "mbox": "http://patches.dpdk.org/series/5518/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/56480/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/56480/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id BDA534CE4;\n\tTue, 16 Jul 2019 11:28:46 +0200 (CEST)", "from rnd-relay.smtp.broadcom.com (rnd-relay.smtp.broadcom.com\n\t[192.19.229.170]) by dpdk.org (Postfix) with ESMTP id 872EE324D\n\tfor <dev@dpdk.org>; Tue, 16 Jul 2019 11:28:38 +0200 (CEST)", "from nis-sj1-27.broadcom.com (nis-sj1-27.lvn.broadcom.net\n\t[10.75.144.136])\n\tby rnd-relay.smtp.broadcom.com (Postfix) with ESMTP id 5239E30C044;\n\tTue, 16 Jul 2019 02:28:37 -0700 (PDT)", "from C02VPB22HTD6.wifi.broadcom.net (c02vpb22htd6.wifi.broadcom.net\n\t[10.122.43.105])\n\tby nis-sj1-27.broadcom.com (Postfix) with ESMTP id B2436AC0749;\n\tTue, 16 Jul 2019 02:28:35 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.10.3 rnd-relay.smtp.broadcom.com 5239E30C044", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n\ts=dkimrelay; t=1563269317;\n\tbh=BLEboS5/wt/tjl4Xw8ta6veeLZFMV30vdCRGqgGLo7o=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=snR69DhYo9A38dqyz3jvF4KHBPP7DX0EKS9kpwvYdVgqUsLxclCy/uYyFBaTvPUJO\n\tKT39PUjCDvx+qDlylE7+vTz6NB8/EObVwHH3PBs5PaRtBSRt7trQ7GVI6xVKsSKAsf\n\t4e9qEOlGVzsfHk9eza2h62EAy6KN4tvn8xx+HUSY=", "From": "Ajit Khaparde <ajit.khaparde@broadcom.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com, Kalesh AP <kalesh-anakkur.purayil@broadcom.com>", "Date": "Tue, 16 Jul 2019 14:58:14 +0530", "Message-Id": "<20190716092826.54276-4-ajit.khaparde@broadcom.com>", "X-Mailer": "git-send-email 2.20.1 (Apple Git-117)", "In-Reply-To": "<20190716092826.54276-1-ajit.khaparde@broadcom.com>", "References": "<20190712060622.76975-1-ajit.khaparde@broadcom.com>\n\t<20190716092826.54276-1-ajit.khaparde@broadcom.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v2 03/15] net/bnxt: do not fail VF probe when the\n\tMAC address is zero", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>\n\nVF driver should not fail probe if the host PF driver has not assigned\nany MAC address for the VF. It should generate a random MAC address and\nconfigure the MAC and then continue probing the device.\n\nFixes: be160484a48d (\"net/bnxt: check if MAC address is all zeros\")\nSigned-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>\nReviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\nSigned-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\n---\n drivers/net/bnxt/bnxt_ethdev.c | 62 +++++++++++++++++++++++-----------\n drivers/net/bnxt/bnxt_hwrm.c | 25 ++++++++++++++\n drivers/net/bnxt/bnxt_hwrm.h | 1 +\n drivers/net/bnxt/bnxt_util.c | 11 ++++++\n drivers/net/bnxt/bnxt_util.h | 1 +\n 5 files changed, 80 insertions(+), 20 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c\nindex cb50572a6..40a57bb23 100644\n--- a/drivers/net/bnxt/bnxt_ethdev.c\n+++ b/drivers/net/bnxt/bnxt_ethdev.c\n@@ -3753,6 +3753,46 @@ static int bnxt_alloc_stats_mem(struct bnxt *bp)\n \treturn 0;\n }\n \n+static int bnxt_setup_mac_addr(struct rte_eth_dev *eth_dev)\n+{\n+\tstruct bnxt *bp = eth_dev->data->dev_private;\n+\tint rc = 0;\n+\n+\teth_dev->data->mac_addrs = rte_zmalloc(\"bnxt_mac_addr_tbl\",\n+\t\t\t\t\t RTE_ETHER_ADDR_LEN *\n+\t\t\t\t\t bp->max_l2_ctx,\n+\t\t\t\t\t 0);\n+\tif (eth_dev->data->mac_addrs == NULL) {\n+\t\tPMD_DRV_LOG(ERR, \"Failed to alloc MAC addr tbl\\n\");\n+\t\treturn -ENOMEM;\n+\t}\n+\n+\tif (bnxt_check_zero_bytes(bp->dflt_mac_addr, RTE_ETHER_ADDR_LEN)) {\n+\t\tif (BNXT_PF(bp))\n+\t\t\treturn -EINVAL;\n+\n+\t\t/* Generate a random MAC address, if none was assigned by PF */\n+\t\tPMD_DRV_LOG(INFO, \"VF MAC address not assigned by Host PF\\n\");\n+\t\tbnxt_eth_hw_addr_random(bp->mac_addr);\n+\t\tPMD_DRV_LOG(INFO,\n+\t\t\t \"Assign random MAC:%02X:%02X:%02X:%02X:%02X:%02X\\n\",\n+\t\t\t bp->mac_addr[0], bp->mac_addr[1], bp->mac_addr[2],\n+\t\t\t bp->mac_addr[3], bp->mac_addr[4], bp->mac_addr[5]);\n+\n+\t\trc = bnxt_hwrm_set_mac(bp);\n+\t\tif (!rc)\n+\t\t\tmemcpy(&bp->eth_dev->data->mac_addrs[0], bp->mac_addr,\n+\t\t\t RTE_ETHER_ADDR_LEN);\n+\t\treturn rc;\n+\t}\n+\n+\t/* Copy the permanent MAC from the FUNC_QCAPS response */\n+\tmemcpy(bp->mac_addr, bp->dflt_mac_addr, RTE_ETHER_ADDR_LEN);\n+\tmemcpy(ð_dev->data->mac_addrs[0], bp->mac_addr, RTE_ETHER_ADDR_LEN);\n+\n+\treturn rc;\n+}\n+\n #define ALLOW_FUNC(x)\t\\\n \t{ \\\n \t\tuint32_t arg = (x); \\\n@@ -3840,28 +3880,10 @@ bnxt_dev_init(struct rte_eth_dev *eth_dev)\n \t\trc = -EBUSY;\n \t\tgoto error_free;\n \t}\n-\teth_dev->data->mac_addrs = rte_zmalloc(\"bnxt_mac_addr_tbl\",\n-\t\t\t\t\tRTE_ETHER_ADDR_LEN * bp->max_l2_ctx, 0);\n-\tif (eth_dev->data->mac_addrs == NULL) {\n-\t\tPMD_DRV_LOG(ERR,\n-\t\t\t\"Failed to alloc %u bytes needed to store MAC addr tbl\",\n-\t\t\tRTE_ETHER_ADDR_LEN * bp->max_l2_ctx);\n-\t\trc = -ENOMEM;\n-\t\tgoto error_free;\n-\t}\n \n-\tif (bnxt_check_zero_bytes(bp->dflt_mac_addr, RTE_ETHER_ADDR_LEN)) {\n-\t\tPMD_DRV_LOG(ERR,\n-\t\t\t \"Invalid MAC addr %02X:%02X:%02X:%02X:%02X:%02X\\n\",\n-\t\t\t bp->dflt_mac_addr[0], bp->dflt_mac_addr[1],\n-\t\t\t bp->dflt_mac_addr[2], bp->dflt_mac_addr[3],\n-\t\t\t bp->dflt_mac_addr[4], bp->dflt_mac_addr[5]);\n-\t\trc = -EINVAL;\n+\trc = bnxt_setup_mac_addr(eth_dev);\n+\tif (rc)\n \t\tgoto error_free;\n-\t}\n-\t/* Copy the permanent MAC from the qcap response address now. */\n-\tmemcpy(bp->mac_addr, bp->dflt_mac_addr, sizeof(bp->mac_addr));\n-\tmemcpy(ð_dev->data->mac_addrs[0], bp->mac_addr, RTE_ETHER_ADDR_LEN);\n \n \t/* THOR does not support ring groups.\n \t * But we will use the array to save RSS context IDs.\ndiff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c\nindex f691922bd..a9356c6b8 100644\n--- a/drivers/net/bnxt/bnxt_hwrm.c\n+++ b/drivers/net/bnxt/bnxt_hwrm.c\n@@ -4607,3 +4607,28 @@ int bnxt_hwrm_tunnel_redirect_info(struct bnxt *bp, uint8_t tun_type,\n \n \treturn rc;\n }\n+\n+int bnxt_hwrm_set_mac(struct bnxt *bp)\n+{\n+\tstruct hwrm_func_vf_cfg_output *resp = bp->hwrm_cmd_resp_addr;\n+\tstruct hwrm_func_vf_cfg_input req = {0};\n+\tint rc = 0;\n+\n+\tif (!BNXT_VF(bp))\n+\t\treturn 0;\n+\n+\tHWRM_PREP(req, FUNC_VF_CFG, BNXT_USE_CHIMP_MB);\n+\n+\treq.enables =\n+\t\trte_cpu_to_le_32(HWRM_FUNC_VF_CFG_INPUT_ENABLES_DFLT_MAC_ADDR);\n+\tmemcpy(req.dflt_mac_addr, bp->mac_addr, RTE_ETHER_ADDR_LEN);\n+\n+\trc = bnxt_hwrm_send_message(bp, &req, sizeof(req), BNXT_USE_CHIMP_MB);\n+\n+\tHWRM_CHECK_RESULT();\n+\n+\tmemcpy(bp->dflt_mac_addr, bp->mac_addr, RTE_ETHER_ADDR_LEN);\n+\tHWRM_UNLOCK();\n+\n+\treturn rc;\n+}\ndiff --git a/drivers/net/bnxt/bnxt_hwrm.h b/drivers/net/bnxt/bnxt_hwrm.h\nindex e35462cb4..37aaa1a9e 100644\n--- a/drivers/net/bnxt/bnxt_hwrm.h\n+++ b/drivers/net/bnxt/bnxt_hwrm.h\n@@ -196,4 +196,5 @@ int bnxt_hwrm_tunnel_redirect_free(struct bnxt *bp, uint8_t type);\n int bnxt_hwrm_tunnel_redirect_query(struct bnxt *bp, uint32_t *type);\n int bnxt_hwrm_tunnel_redirect_info(struct bnxt *bp, uint8_t tun_type,\n \t\t\t\t uint16_t *dst_fid);\n+int bnxt_hwrm_set_mac(struct bnxt *bp);\n #endif\ndiff --git a/drivers/net/bnxt/bnxt_util.c b/drivers/net/bnxt/bnxt_util.c\nindex 7d3342719..dda40af28 100644\n--- a/drivers/net/bnxt/bnxt_util.c\n+++ b/drivers/net/bnxt/bnxt_util.c\n@@ -4,6 +4,7 @@\n */\n \n #include <inttypes.h>\n+#include <rte_ether.h>\n \n #include \"bnxt_util.h\"\n \n@@ -16,3 +17,13 @@ int bnxt_check_zero_bytes(const uint8_t *bytes, int len)\n \t\t\treturn 0;\n \treturn 1;\n }\n+\n+void bnxt_eth_hw_addr_random(uint8_t *mac_addr)\n+{\n+\trte_eth_random_addr(mac_addr);\n+\n+\t/* Set Organizationally Unique Identifier (OUI) prefix */\n+\tmac_addr[0] = 0x00;\n+\tmac_addr[1] = 0x0a;\n+\tmac_addr[2] = 0xf7;\n+}\ndiff --git a/drivers/net/bnxt/bnxt_util.h b/drivers/net/bnxt/bnxt_util.h\nindex 2378833cc..9f1868a78 100644\n--- a/drivers/net/bnxt/bnxt_util.h\n+++ b/drivers/net/bnxt/bnxt_util.h\n@@ -7,5 +7,6 @@\n #define _BNXT_UTIL_H_\n \n int bnxt_check_zero_bytes(const uint8_t *bytes, int len);\n+void bnxt_eth_hw_addr_random(uint8_t *mac_addr);\n \n #endif /* _BNXT_UTIL_H_ */\n", "prefixes": [ "v2", "03/15" ] }