Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/56428/?format=api
{ "id": 56428, "url": "http://patches.dpdk.org/api/patches/56428/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1563178677-16356-1-git-send-email-skori@marvell.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1563178677-16356-1-git-send-email-skori@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1563178677-16356-1-git-send-email-skori@marvell.com", "date": "2019-07-15T08:17:57", "name": "lib/librte_ip_frag: Remove PKT_TX_IP_CKSUM offload flags", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "6f30dd76bf8a8ccec5515e144f608dd7de5d5612", "submitter": { "id": 1318, "url": "http://patches.dpdk.org/api/people/1318/?format=api", "name": "Sunil Kumar Kori", "email": "skori@marvell.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1563178677-16356-1-git-send-email-skori@marvell.com/mbox/", "series": [ { "id": 5488, "url": "http://patches.dpdk.org/api/series/5488/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=5488", "date": "2019-07-15T08:17:57", "name": "lib/librte_ip_frag: Remove PKT_TX_IP_CKSUM offload flags", "version": 1, "mbox": "http://patches.dpdk.org/series/5488/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/56428/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/56428/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 5027A322C;\n\tMon, 15 Jul 2019 10:18:27 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n\t[67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 00AC12C60\n\tfor <dev@dpdk.org>; Mon, 15 Jul 2019 10:18:25 +0200 (CEST)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n\tby mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id\n\tx6F8F4NL007427; Mon, 15 Jul 2019 01:18:25 -0700", "from sc-exch03.marvell.com ([199.233.58.183])\n\tby mx0b-0016f401.pphosted.com with ESMTP id 2tqetmnrj0-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); \n\tMon, 15 Jul 2019 01:18:25 -0700", "from SC-EXCH03.marvell.com (10.93.176.83) by SC-EXCH03.marvell.com\n\t(10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1367.3;\n\tMon, 15 Jul 2019 01:18:23 -0700", "from maili.marvell.com (10.93.176.43) by SC-EXCH03.marvell.com\n\t(10.93.176.83) with Microsoft SMTP Server id 15.0.1367.3 via Frontend\n\tTransport; Mon, 15 Jul 2019 01:18:23 -0700", "from dc7-eodlnx05.marvell.com (dc7-eodlnx05.marvell.com\n\t[10.28.113.55])\n\tby maili.marvell.com (Postfix) with ESMTP id 2CC8C3F7040;\n\tMon, 15 Jul 2019 01:18:21 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n\th=from : to : cc :\n\tsubject : date : message-id : mime-version : content-type; s=pfpt0818;\n\tbh=PXDlDEyu5RbbuPdxaF3Wr4w9nd3Ze4KaxxG5zs345G0=;\n\tb=OsRPAd3LxZa0gu6fyjDahK+mftG74F9ZSwei+fX4NVWD+LAJ+2QtzzZUXV6vWjChPPtd\n\tRtp69BFLvUFErg6kI5Krdq+KaGkyxyyCCCfp4XvOgNgCWv93fdeiWR/A7H94RVg0/k8I\n\tyBF2tnI7Va3UwB3uCkrMVM1Z301JHRy6G0XFQ0vpI7KskzSxwIm5JpP2TsUVRdfg2STe\n\twluWhehIjGpycTLayq88PbPX8V4j7CIrEXSPTUy5wLzHUaIeN5UcJu2FEhrdNoXpPyuZ\n\toxA2ZmRzSmy7cR7NA7Y+NgSNl1RuJVkyb8/MA/FpblcOymj2gLqPGuvy373vF8BA/oWK\n\t1Q== ", "From": "Sunil Kumar Kori <skori@marvell.com>", "To": "Konstantin Ananyev <konstantin.ananyev@intel.com>", "CC": "<dev@dpdk.org>, Sunil Kumar Kori <skori@marvell.com>", "Date": "Mon, 15 Jul 2019 13:47:57 +0530", "Message-ID": "<1563178677-16356-1-git-send-email-skori@marvell.com>", "X-Mailer": "git-send-email 1.8.3.1", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10434:5.22.84,1.0.8\n\tdefinitions=2019-07-15_02:2019-07-12,2019-07-15 signatures=0", "Subject": "[dpdk-dev] [PATCH] lib/librte_ip_frag: Remove PKT_TX_IP_CKSUM\n\toffload flags", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Currently PKT_TX_IP_CKSUM is being set into mbuf->ol_flags\nduring fragmentation and reassemble operation implicitly.\nBecause of this, application is forced to use checksum offload\nwhether it is supported by platform or not.\n\nAlso documentation does not provide any expected value of ol_flags\nin returned mbuf (reassembled or fragmented) so application will never\ncome to know that which offloads are enabled. So transmission may be failed\nfor the platforms which does not support checksum offload.\n\nSo removing mentioned flag from the library.\n\nSigned-off-by: Sunil Kumar Kori <skori@marvell.com>\n---\n\nCurrent patch is part of following patchset\nhttp://patches.dpdk.org/patch/53475/\nwhich is missed to be merged into upstream because of accepted version of this\npatch does not contain this change.\n\nAccepted patchset is given below:\nhttp://patches.dpdk.org/patch/56202/\n\nPatchset is already reviewed and acked on maillist. Also corrersponding release\nnotes are updated.\n\n\n lib/librte_ip_frag/rte_ipv4_fragmentation.c | 1 -\n 1 file changed, 1 deletion(-)", "diff": "diff --git a/lib/librte_ip_frag/rte_ipv4_fragmentation.c b/lib/librte_ip_frag/rte_ipv4_fragmentation.c\nindex 221d74e..9e9f986 100644\n--- a/lib/librte_ip_frag/rte_ipv4_fragmentation.c\n+++ b/lib/librte_ip_frag/rte_ipv4_fragmentation.c\n@@ -173,7 +173,6 @@ static inline void __free_fragments(struct rte_mbuf *mb[], uint32_t num)\n \t\tfragment_offset = (uint16_t)(fragment_offset +\n \t\t out_pkt->pkt_len - sizeof(struct rte_ipv4_hdr));\n \n-\t\tout_pkt->ol_flags |= PKT_TX_IP_CKSUM;\n \t\tout_pkt->l3_len = sizeof(struct rte_ipv4_hdr);\n \n \t\t/* Write the fragment to the output list */\n", "prefixes": [] }