Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/56416/?format=api
{ "id": 56416, "url": "http://patches.dpdk.org/api/patches/56416/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190712205425.17781-2-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190712205425.17781-2-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20190712205425.17781-2-stephen@networkplumber.org", "date": "2019-07-12T20:54:24", "name": "[1/2] net/mlx4: fix crash in dev_info_get in secondary process", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "c5bdcdb976e5a30ddd5cf601cf135a998b65f5c1", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 3268, "url": "http://patches.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190712205425.17781-2-stephen@networkplumber.org/mbox/", "series": [ { "id": 5482, "url": "http://patches.dpdk.org/api/series/5482/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=5482", "date": "2019-07-12T20:54:23", "name": "fix dev_info_get in mlx secondary process", "version": 1, "mbox": "http://patches.dpdk.org/series/5482/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/56416/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/56416/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 5C0EB1B9C6;\n\tSat, 13 Jul 2019 00:15:36 +0200 (CEST)", "from mail-pf1-f194.google.com (mail-pf1-f194.google.com\n\t[209.85.210.194]) by dpdk.org (Postfix) with ESMTP id A7210493D\n\tfor <dev@dpdk.org>; Sat, 13 Jul 2019 00:15:33 +0200 (CEST)", "by mail-pf1-f194.google.com with SMTP id f17so901865pfn.6\n\tfor <dev@dpdk.org>; Fri, 12 Jul 2019 15:15:33 -0700 (PDT)", "from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])\n\tby smtp.gmail.com with ESMTPSA id\n\tq69sm16634170pjb.0.2019.07.12.15.15.31\n\t(version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256);\n\tFri, 12 Jul 2019 15:15:32 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=wHTA/UahFFiXRjhF6KAoNij6ilTyeDmN4umCwpXLCNk=;\n\tb=rL9DmUAJuxN7sjBb0eVw4vw50+gnrMRYjJrga7srZr7MKLsZSujYJ6LnBbPFa36oCW\n\tPg4u0+SckEoa9i2MolTTUBGfArNI3GKNQwUWjuEDN2BiYSNxOJixiWUX9Wrpfe6aLOBT\n\tj8RJMjd58xJjCwvV0t74nUsM3fW1+Br6tm9F/73SAdRKNVn702DavmoSeyarbUQn43g1\n\t/qckOR/7k+jXZ7of4a9DagqtJWgI9j32GdGmJApSI6kn0LH/AiPajde2zTVQGegiUsNP\n\t2GBAczCzWdc+DU5BdOwTxbIbZtTkDoB4bEeGzw4Kp6HRUxfzNTuDY6hK6Gh1IoP8IZTQ\n\tR3nQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=wHTA/UahFFiXRjhF6KAoNij6ilTyeDmN4umCwpXLCNk=;\n\tb=Yj/eWE0IYQbRd4HcxsxuKRa7PfA0K7J10+uTGuAJH9zf1xP3QfZrAl/svRY34U6noT\n\tNWBC5J/lnxVi8/qH8nRfaFNlWeBwJDRJmtJZ0b0L1ZETsQeDE9QKFDJ35jegcDg6oCjW\n\thIzQkN8Vm08c16AYzfL0ky+HW2Tx9j46QBJW51dloIT0L1vffRjt/taamzqwxoX5O7ie\n\tWnhp44XtoWrV6RlLEUQmZTrD1mZpOG4GBUj/RsW5h7GHZh5E4qYT1/SR8wleTYjhjYjF\n\t2YWLvTGRcYDe0QwzrgKVbW7SUEiaMuziH781ZJjbm3zbBG8C4i6MuPTdchW7rOnKiVDn\n\trRIw==", "X-Gm-Message-State": "APjAAAXHIln9yym3tsCL6Min+cLZCMHgaD8CEQuWAGqathMcNxMJc3EA\n\tIexmK2N1xh5iltH/KE4yPgY=", "X-Google-Smtp-Source": "APXvYqzrGF2R8/g6MTZ6/bqc/HjRmlWhOdJkWydxyOoQYCIxlUPM4J4aKFdTAIaCA/xKR7tBzGhP6Q==", "X-Received": "by 2002:a17:90a:2525:: with SMTP id\n\tj34mr15191994pje.11.1562969732840; \n\tFri, 12 Jul 2019 15:15:32 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "matan@mellanox.com, shahafs@mellanox.com, yskoh@mellanox.com,\n\tviacheslavo@mellanox.com", "Cc": "dev@dpdk.org, sju@paloaltonetworks.com,\n\tStephen Hemminger <stephen@networkplumber.org>, stable@dpdk.org", "Date": "Fri, 12 Jul 2019 13:54:24 -0700", "Message-Id": "<20190712205425.17781-2-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20190712205425.17781-1-stephen@networkplumber.org>", "References": "<20190712205425.17781-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 1/2] net/mlx4: fix crash in dev_info_get in\n\tsecondary process", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "mlx4_dev_info_get calls mlx4_get_ifname, but mlx4_get_ifname\nuses priv->ctx which is not a valid pointer in a secondary\nprocess. The fix is to cache the value in primary.\n\nIn the primary process, get and store the interface index of\nthe device so that secondary process can see it.\n\nBugzilla ID:320\nFixes: 61cbdd419478 (\"net/mlx4: separate device control functions\")\nCc: stable@dpdk.org\nReported-by: Suyang Ju <sju@paloaltonetworks.com>\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n drivers/net/mlx4/mlx4.c | 19 +++++++++----------\n drivers/net/mlx4/mlx4.h | 1 +\n drivers/net/mlx4/mlx4_ethdev.c | 4 +---\n 3 files changed, 11 insertions(+), 13 deletions(-)", "diff": "diff --git a/drivers/net/mlx4/mlx4.c b/drivers/net/mlx4/mlx4.c\nindex 2e169b0887a7..bab2cadbe519 100644\n--- a/drivers/net/mlx4/mlx4.c\n+++ b/drivers/net/mlx4/mlx4.c\n@@ -763,6 +763,7 @@ mlx4_pci_probe(struct rte_pci_driver *pci_drv, struct rte_pci_device *pci_dev)\n \t};\n \tunsigned int vf;\n \tint i;\n+\tchar ifname[IF_NAMESIZE];\n \n \t(void)pci_drv;\n \terr = mlx4_init_once();\n@@ -1002,17 +1003,15 @@ mlx4_pci_probe(struct rte_pci_driver *pci_drv, struct rte_pci_device *pci_dev)\n \t\t mac.addr_bytes[4], mac.addr_bytes[5]);\n \t\t/* Register MAC address. */\n \t\tpriv->mac[0] = mac;\n-#ifndef NDEBUG\n-\t\t{\n-\t\t\tchar ifname[IF_NAMESIZE];\n-\n-\t\t\tif (mlx4_get_ifname(priv, &ifname) == 0)\n-\t\t\t\tDEBUG(\"port %u ifname is \\\"%s\\\"\",\n-\t\t\t\t priv->port, ifname);\n-\t\t\telse\n-\t\t\t\tDEBUG(\"port %u ifname is unknown\", priv->port);\n+\n+\t\tif (mlx4_get_ifname(priv, &ifname) == 0) {\n+\t\t\tDEBUG(\"port %u ifname is \\\"%s\\\"\",\n+\t\t\t priv->port, ifname);\n+\t\t\tpriv->if_index = if_nametoindex(ifname);\n+\t\t} else {\n+\t\t\tDEBUG(\"port %u ifname is unknown\", priv->port);\n \t\t}\n-#endif\n+\n \t\t/* Get actual MTU if possible. */\n \t\tmlx4_mtu_get(priv, &priv->mtu);\n \t\tDEBUG(\"port %u MTU is %u\", priv->port, priv->mtu);\ndiff --git a/drivers/net/mlx4/mlx4.h b/drivers/net/mlx4/mlx4.h\nindex cd0d637ac2bf..81b529ee8030 100644\n--- a/drivers/net/mlx4/mlx4.h\n+++ b/drivers/net/mlx4/mlx4.h\n@@ -159,6 +159,7 @@ struct mlx4_priv {\n \tstruct ibv_device_attr device_attr; /**< Device properties. */\n \tstruct ibv_pd *pd; /**< Protection Domain. */\n \t/* Device properties. */\n+\tunsigned int if_index;\t/**< Associated network device index */\n \tuint16_t mtu; /**< Configured MTU. */\n \tuint8_t port; /**< Physical port number. */\n \tuint32_t started:1; /**< Device started, flows enabled. */\ndiff --git a/drivers/net/mlx4/mlx4_ethdev.c b/drivers/net/mlx4/mlx4_ethdev.c\nindex ceef921620a8..5d28c0116d21 100644\n--- a/drivers/net/mlx4/mlx4_ethdev.c\n+++ b/drivers/net/mlx4/mlx4_ethdev.c\n@@ -616,7 +616,6 @@ mlx4_dev_infos_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *info)\n {\n \tstruct mlx4_priv *priv = dev->data->dev_private;\n \tunsigned int max;\n-\tchar ifname[IF_NAMESIZE];\n \n \t/* FIXME: we should ask the device for these values. */\n \tinfo->min_rx_bufsize = 32;\n@@ -637,8 +636,7 @@ mlx4_dev_infos_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *info)\n \tinfo->rx_queue_offload_capa = mlx4_get_rx_queue_offloads(priv);\n \tinfo->rx_offload_capa = (mlx4_get_rx_port_offloads(priv) |\n \t\t\t\t info->rx_queue_offload_capa);\n-\tif (mlx4_get_ifname(priv, &ifname) == 0)\n-\t\tinfo->if_index = if_nametoindex(ifname);\n+\tinfo->if_index = priv->if_index;\n \tinfo->hash_key_size = MLX4_RSS_HASH_KEY_SIZE;\n \tinfo->speed_capa =\n \t\t\tETH_LINK_SPEED_1G |\n", "prefixes": [ "1/2" ] }