Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 56270,
    "url": "http://patches.dpdk.org/api/patches/56270/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/a7678616c14055fb2ed3d51aa48f25f1201ce930.1562680812.git.anatoly.burakov@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<a7678616c14055fb2ed3d51aa48f25f1201ce930.1562680812.git.anatoly.burakov@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/a7678616c14055fb2ed3d51aa48f25f1201ce930.1562680812.git.anatoly.burakov@intel.com",
    "date": "2019-07-09T14:00:27",
    "name": "fbarray: fix fbarray destruction",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "ad981e5c612df4189d1d0d90f4bf7d34380d6539",
    "submitter": {
        "id": 4,
        "url": "http://patches.dpdk.org/api/people/4/?format=api",
        "name": "Anatoly Burakov",
        "email": "anatoly.burakov@intel.com"
    },
    "delegate": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/users/1/?format=api",
        "username": "tmonjalo",
        "first_name": "Thomas",
        "last_name": "Monjalon",
        "email": "thomas@monjalon.net"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/a7678616c14055fb2ed3d51aa48f25f1201ce930.1562680812.git.anatoly.burakov@intel.com/mbox/",
    "series": [
        {
            "id": 5412,
            "url": "http://patches.dpdk.org/api/series/5412/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=5412",
            "date": "2019-07-09T14:00:27",
            "name": "fbarray: fix fbarray destruction",
            "version": 1,
            "mbox": "http://patches.dpdk.org/series/5412/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/56270/comments/",
    "check": "fail",
    "checks": "http://patches.dpdk.org/api/patches/56270/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id BDFFC1B95C;\n\tTue,  9 Jul 2019 16:00:32 +0200 (CEST)",
            "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n\tby dpdk.org (Postfix) with ESMTP id 034D01B95A;\n\tTue,  9 Jul 2019 16:00:30 +0200 (CEST)",
            "from orsmga007.jf.intel.com ([10.7.209.58])\n\tby fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t09 Jul 2019 07:00:30 -0700",
            "from silpixa00399498.ir.intel.com (HELO\n\tsilpixa00399498.ger.corp.intel.com) ([10.237.223.125])\n\tby orsmga007.jf.intel.com with ESMTP; 09 Jul 2019 07:00:28 -0700"
        ],
        "X-Amp-Result": "SKIPPED(no attachment in message)",
        "X-Amp-File-Uploaded": "False",
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.63,470,1557212400\"; d=\"scan'208\";a=\"156185773\"",
        "From": "Anatoly Burakov <anatoly.burakov@intel.com>",
        "To": "dev@dpdk.org",
        "Cc": "patrick.fu@intel.com,\n\tstable@dpdk.org",
        "Date": "Tue,  9 Jul 2019 15:00:27 +0100",
        "Message-Id": "<a7678616c14055fb2ed3d51aa48f25f1201ce930.1562680812.git.anatoly.burakov@intel.com>",
        "X-Mailer": "git-send-email 2.17.1",
        "Subject": "[dpdk-dev] [PATCH] fbarray: fix fbarray destruction",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Currently, when fbarray is destroyed, the fbarray structure is not\nzeroed out, which leads to stale data being there and confusing\nsecondary process init in legacy mem mode. Fix it by always\nmemsetting the fbarray to zero when destroying it.\n\nFixes: 5b61c62cfd76 (\"fbarray: add internal tailq for mapped areas\")\nCc: stable@dpdk.org\n\nSigned-off-by: Anatoly Burakov <anatoly.burakov@intel.com>\n---\n lib/librte_eal/common/eal_common_fbarray.c | 3 +++\n 1 file changed, 3 insertions(+)",
    "diff": "diff --git a/lib/librte_eal/common/eal_common_fbarray.c b/lib/librte_eal/common/eal_common_fbarray.c\nindex b7ddb66e9..1312f936b 100644\n--- a/lib/librte_eal/common/eal_common_fbarray.c\n+++ b/lib/librte_eal/common/eal_common_fbarray.c\n@@ -1055,6 +1055,9 @@ rte_fbarray_destroy(struct rte_fbarray *arr)\n \tTAILQ_REMOVE(&mem_area_tailq, tmp, next);\n \tfree(tmp);\n \tret = 0;\n+\n+\t/* reset the fbarray structure */\n+\tmemset(arr, 0, sizeof(*arr));\n out:\n \trte_spinlock_unlock(&mem_area_lock);\n \treturn ret;\n",
    "prefixes": []
}