Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 56065,
    "url": "http://patches.dpdk.org/api/patches/56065/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/1562218537-33583-1-git-send-email-wei.zhao1@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1562218537-33583-1-git-send-email-wei.zhao1@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1562218537-33583-1-git-send-email-wei.zhao1@intel.com",
    "date": "2019-07-04T05:35:37",
    "name": "[v2] app/testpmd: fix to add offloads confguration for queue",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "15e2177d20246c2384c85bebdb53f58eb071c5cb",
    "submitter": {
        "id": 495,
        "url": "http://patches.dpdk.org/api/people/495/?format=api",
        "name": "Zhao1, Wei",
        "email": "wei.zhao1@intel.com"
    },
    "delegate": {
        "id": 319,
        "url": "http://patches.dpdk.org/api/users/319/?format=api",
        "username": "fyigit",
        "first_name": "Ferruh",
        "last_name": "Yigit",
        "email": "ferruh.yigit@amd.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/1562218537-33583-1-git-send-email-wei.zhao1@intel.com/mbox/",
    "series": [
        {
            "id": 5329,
            "url": "http://patches.dpdk.org/api/series/5329/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=5329",
            "date": "2019-07-04T05:35:37",
            "name": "[v2] app/testpmd: fix to add offloads confguration for queue",
            "version": 2,
            "mbox": "http://patches.dpdk.org/series/5329/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/56065/comments/",
    "check": "fail",
    "checks": "http://patches.dpdk.org/api/patches/56065/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 685CC374C;\n\tThu,  4 Jul 2019 08:06:13 +0200 (CEST)",
            "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby dpdk.org (Postfix) with ESMTP id 17297160;\n\tThu,  4 Jul 2019 08:06:10 +0200 (CEST)",
            "from orsmga004.jf.intel.com ([10.7.209.38])\n\tby orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t03 Jul 2019 23:06:10 -0700",
            "from dpdk6.bj.intel.com ([172.16.182.192])\n\tby orsmga004.jf.intel.com with ESMTP; 03 Jul 2019 23:06:08 -0700"
        ],
        "X-Amp-Result": "SKIPPED(no attachment in message)",
        "X-Amp-File-Uploaded": "False",
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.63,449,1557212400\"; d=\"scan'208\";a=\"315779495\"",
        "From": "Wei Zhao <wei.zhao1@intel.com>",
        "To": "dev@dpdk.org",
        "Cc": "stable@dpdk.org, bernard.iremonger@intel.com,\n\twei zhao <wei.zhao1@intel.com>",
        "Date": "Thu,  4 Jul 2019 13:35:37 +0800",
        "Message-Id": "<1562218537-33583-1-git-send-email-wei.zhao1@intel.com>",
        "X-Mailer": "git-send-email 2.7.5",
        "In-Reply-To": "<1562131464-58732-1-git-send-email-wei.zhao1@intel.com>",
        "References": "<1562131464-58732-1-git-send-email-wei.zhao1@intel.com>",
        "Subject": "[dpdk-dev] [PATCH v2] app/testpmd: fix to add offloads confguration\n\tfor queue",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "When adding offloads from commandline, not only port\nrelated configuration bits should be set, but also queue\nrelated offloads configuration bits, or it will cause error.\nFor example, test in this process for ixgbe:\n(1)./x86_64-native-linuxapp-gcc/app/testpmd -c 0x6 -n 4\n-- -i --portmask=0x1 --port-topology=loop --disable-crc-strip\n(2)port stop all\n(3)port config all crc-strip on\n(4)port start all\nwe will see \"Fail to configure port 0 rx queues\" of warning info.\n\nFixes: 0074d02fca21 (\"app/testpmd: convert to new Rx offloads API\")\nCc: stable@dpdk.org\n\nSigned-off-by: wei zhao <wei.zhao1@intel.com>\n\n---\n\nv2:\n\nmerge to one function for apply offloads configguration\n---\n app/test-pmd/cmdline.c | 19 +++++++++++++++++++\n 1 file changed, 19 insertions(+)",
    "diff": "diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c\nindex d1e0d44..6a69f90 100644\n--- a/app/test-pmd/cmdline.c\n+++ b/app/test-pmd/cmdline.c\n@@ -2047,6 +2047,7 @@ cmd_config_rx_mode_flag_parsed(void *parsed_result,\n {\n \tstruct cmd_config_rx_mode_flag *res = parsed_result;\n \tportid_t pid;\n+\tint k;\n \n \tif (!all_ports_stopped()) {\n \t\tprintf(\"Please stop all ports first\\n\");\n@@ -2147,6 +2148,10 @@ cmd_config_rx_mode_flag_parsed(void *parsed_result,\n \t\t\treturn;\n \t\t}\n \t\tport->dev_conf.rxmode.offloads = rx_offloads;\n+\t\t/* Apply Rx offloads configuration */\n+\t\tfor (k = 0; k < port->dev_info.max_rx_queues; k++)\n+\t\t\tport->rx_conf[k].offloads =\n+\t\t\t\tport->dev_conf.rxmode.offloads;\n \t}\n \n \tinit_port_config();\n@@ -4360,6 +4365,17 @@ csum_show(int port_id)\n }\n \n static void\n+cmd_config_queue_tx_offloads(struct rte_port *port)\n+{\n+\tint k;\n+\n+\t/* Apply queue tx offloads configuration */\n+\tfor (k = 0; k < port->dev_info.max_rx_queues; k++)\n+\t\tport->tx_conf[k].offloads =\n+\t\t\tport->dev_conf.txmode.offloads;\n+}\n+\n+static void\n cmd_csum_parsed(void *parsed_result,\n \t\t       __attribute__((unused)) struct cmdline *cl,\n \t\t       __attribute__((unused)) void *data)\n@@ -4443,6 +4459,7 @@ cmd_csum_parsed(void *parsed_result,\n \t\t\tports[res->port_id].dev_conf.txmode.offloads &=\n \t\t\t\t\t\t\t(~csum_offloads);\n \t\t}\n+\t\tcmd_config_queue_tx_offloads(&ports[res->port_id]);\n \t}\n \tcsum_show(res->port_id);\n \n@@ -4594,6 +4611,7 @@ cmd_tso_set_parsed(void *parsed_result,\n \t\tprintf(\"TSO segment size for non-tunneled packets is %d\\n\",\n \t\t\tports[res->port_id].tso_segsz);\n \t}\n+\tcmd_config_queue_tx_offloads(&ports[res->port_id]);\n \n \t/* display warnings if configuration is not supported by the NIC */\n \trte_eth_dev_info_get(res->port_id, &dev_info);\n@@ -4749,6 +4767,7 @@ cmd_tunnel_tso_set_parsed(void *parsed_result,\n \t\t\t\t\"if outer L3 is IPv4; not necessary for IPv6\\n\");\n \t}\n \n+\tcmd_config_queue_tx_offloads(&ports[res->port_id]);\n \tcmd_reconfig_device_queue(res->port_id, 1, 1);\n }\n \n",
    "prefixes": [
        "v2"
    ]
}