Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/55409/?format=api
{ "id": 55409, "url": "http://patches.dpdk.org/api/patches/55409/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190626132617.10576-2-mariuszx.drost@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190626132617.10576-2-mariuszx.drost@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190626132617.10576-2-mariuszx.drost@intel.com", "date": "2019-06-26T13:26:16", "name": "[v2,1/2] net/ixgbe: fix lack of ip type for crypto session", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "aa0ba11d5582ed7a3af03d1d380dbcaa1ca426f0", "submitter": { "id": 1334, "url": "http://patches.dpdk.org/api/people/1334/?format=api", "name": "Mariusz Drost", "email": "mariuszx.drost@intel.com" }, "delegate": { "id": 6690, "url": "http://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190626132617.10576-2-mariuszx.drost@intel.com/mbox/", "series": [ { "id": 5177, "url": "http://patches.dpdk.org/api/series/5177/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=5177", "date": "2019-06-26T13:26:15", "name": "fixes for inline-crypto ipsec", "version": 2, "mbox": "http://patches.dpdk.org/series/5177/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/55409/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/55409/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id A4AF12C37;\n\tWed, 26 Jun 2019 15:29:20 +0200 (CEST)", "from mga06.intel.com (mga06.intel.com [134.134.136.31])\n\tby dpdk.org (Postfix) with ESMTP id 283CB2C37\n\tfor <dev@dpdk.org>; Wed, 26 Jun 2019 15:29:17 +0200 (CEST)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t26 Jun 2019 06:29:16 -0700", "from mdrostx-mobl.ger.corp.intel.com ([10.103.104.107])\n\tby fmsmga001.fm.intel.com with ESMTP; 26 Jun 2019 06:29:15 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.63,420,1557212400\"; d=\"scan'208\";a=\"183173209\"", "From": "Mariusz Drost <mariuszx.drost@intel.com>", "To": "dev@dpdk.org", "Cc": "akhil.goyal@nxp.com, Mariusz Drost <mariuszx.drost@intel.com>,\n\tKonstantin Ananyev <konstantin.ananyev@intel.com>", "Date": "Wed, 26 Jun 2019 15:26:16 +0200", "Message-Id": "<20190626132617.10576-2-mariuszx.drost@intel.com>", "X-Mailer": "git-send-email 2.21.0.windows.1", "In-Reply-To": "<20190626132617.10576-1-mariuszx.drost@intel.com>", "References": "<??20190604100644.13724-1-mariuszx.drost@intel.com>\n\t<20190626132617.10576-1-mariuszx.drost@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v2 1/2] net/ixgbe: fix lack of ip type for crypto\n\tsession", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "When ixgbe_crypto_add_sa() is called, it checks whether the ip type is\nIPv6 or IPv4 to write correct addresses to the registers. Type itself\nis never specified, and act as IPv4, which is the default value.\nIt causes lack of support for IPv6.\n\nTo fix that, ip type needs to be stored in device private data, based on\ncrypto session ip type field, before the checking is done.\n\nFixes: ec17993a145a (\"examples/ipsec-secgw: support security offload\")\nFixes: 9a0752f498d2 (\"net/ixgbe: enable inline IPsec\")\n\nSigned-off-by: Mariusz Drost <mariuszx.drost@intel.com>\nAcked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>\nTested-by: Konstantin Ananyev <konstantin.ananyev@intel.com>\n---\n drivers/net/ixgbe/ixgbe_ipsec.c | 6 +++++-\n 1 file changed, 5 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ixgbe/ixgbe_ipsec.c b/drivers/net/ixgbe/ixgbe_ipsec.c\nindex 5a416885f..1eea70716 100644\n--- a/drivers/net/ixgbe/ixgbe_ipsec.c\n+++ b/drivers/net/ixgbe/ixgbe_ipsec.c\n@@ -154,8 +154,12 @@ ixgbe_crypto_add_sa(struct ixgbe_crypto_session *ic_session)\n \t\tif (ic_session->op == IXGBE_OP_AUTHENTICATED_DECRYPTION)\n \t\t\tpriv->rx_sa_tbl[sa_index].mode |=\n \t\t\t\t\t(IPSRXMOD_PROTO | IPSRXMOD_DECRYPT);\n-\t\tif (ic_session->dst_ip.type == IPv6)\n+\t\tif (ic_session->dst_ip.type == IPv6) {\n \t\t\tpriv->rx_sa_tbl[sa_index].mode |= IPSRXMOD_IPV6;\n+\t\t\tpriv->rx_ip_tbl[ip_index].ip.type = IPv6;\n+\t\t} else if (ic_session->dst_ip.type == IPv4)\n+\t\t\tpriv->rx_ip_tbl[ip_index].ip.type = IPv4;\n+\n \t\tpriv->rx_sa_tbl[sa_index].used = 1;\n \n \t\t/* write IP table entry*/\n", "prefixes": [ "v2", "1/2" ] }