Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/55310/?format=api
{ "id": 55310, "url": "http://patches.dpdk.org/api/patches/55310/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1561469937-16077-1-git-send-email-david.marchand@redhat.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1561469937-16077-1-git-send-email-david.marchand@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1561469937-16077-1-git-send-email-david.marchand@redhat.com", "date": "2019-06-25T13:38:57", "name": "net/qede: remove interrupt reconfigure in handler", "commit_ref": null, "pull_url": null, "state": "rejected", "archived": true, "hash": "a1aba931231b521541ad1be89195042e53bbd15f", "submitter": { "id": 1173, "url": "http://patches.dpdk.org/api/people/1173/?format=api", "name": "David Marchand", "email": "david.marchand@redhat.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1561469937-16077-1-git-send-email-david.marchand@redhat.com/mbox/", "series": [ { "id": 5156, "url": "http://patches.dpdk.org/api/series/5156/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=5156", "date": "2019-06-25T13:38:57", "name": "net/qede: remove interrupt reconfigure in handler", "version": 1, "mbox": "http://patches.dpdk.org/series/5156/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/55310/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/55310/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 25B2D1BA5E;\n\tTue, 25 Jun 2019 15:39:16 +0200 (CEST)", "from mx1.redhat.com (mx1.redhat.com [209.132.183.28])\n\tby dpdk.org (Postfix) with ESMTP id E4FD41BA5D;\n\tTue, 25 Jun 2019 15:39:14 +0200 (CEST)", "from smtp.corp.redhat.com\n\t(int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id E872C356FF;\n\tTue, 25 Jun 2019 13:39:08 +0000 (UTC)", "from dmarchan.remote.csb (unknown [10.40.205.98])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 268B61972C;\n\tTue, 25 Jun 2019 13:39:05 +0000 (UTC)" ], "From": "David Marchand <david.marchand@redhat.com>", "To": "dev@dpdk.org", "Cc": "stable@dpdk.org, Rasesh Mody <rmody@marvell.com>,\n\tShahed Shaikh <shshaikh@marvell.com>", "Date": "Tue, 25 Jun 2019 15:38:57 +0200", "Message-Id": "<1561469937-16077-1-git-send-email-david.marchand@redhat.com>", "X-Scanned-By": "MIMEDefang 2.84 on 10.5.11.23", "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.30]); Tue, 25 Jun 2019 13:39:14 +0000 (UTC)", "Subject": "[dpdk-dev] [PATCH] net/qede: remove interrupt reconfigure in handler", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "rte_intr_enable/rte_intr_disable configure the interrupt context on the\nkernel side (either uio or vfio).\nIn VFIO case, calling it from the interrupt handlers triggers an\nunneeded interrupt handlers reconfiguration.\nDuring this reconfiguration window, the device can trigger interrupts\nwhich are left unserviced.\n\nReported-at: https://bugzilla.redhat.com/show_bug.cgi?id=1654824\nFixes: 245aec289338 (\"net/qede: fix legacy interrupt mode\")\nFixes: 2ea6f76aff40 (\"qede: add core driver\")\nCc: stable@dpdk.org\n\nSigned-off-by: David Marchand <david.marchand@redhat.com>\n---\n drivers/net/qede/qede_ethdev.c | 8 +-------\n 1 file changed, 1 insertion(+), 7 deletions(-)", "diff": "diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c\nindex 82363e6..807016a 100644\n--- a/drivers/net/qede/qede_ethdev.c\n+++ b/drivers/net/qede/qede_ethdev.c\n@@ -245,12 +245,8 @@ static void qede_interrupt_action(struct ecore_hwfn *p_hwfn)\n \n \t/* Check if our device actually raised an interrupt */\n \tstatus = ecore_int_igu_read_sisr_reg(ECORE_LEADING_HWFN(edev));\n-\tif (status & 0x1) {\n+\tif (status & 0x1)\n \t\tqede_interrupt_action(ECORE_LEADING_HWFN(edev));\n-\n-\t\tif (rte_intr_enable(eth_dev->intr_handle))\n-\t\t\tDP_ERR(edev, \"rte_intr_enable failed\\n\");\n-\t}\n }\n \n static void\n@@ -261,8 +257,6 @@ static void qede_interrupt_action(struct ecore_hwfn *p_hwfn)\n \tstruct ecore_dev *edev = &qdev->edev;\n \n \tqede_interrupt_action(ECORE_LEADING_HWFN(edev));\n-\tif (rte_intr_enable(eth_dev->intr_handle))\n-\t\tDP_ERR(edev, \"rte_intr_enable failed\\n\");\n }\n \n static void\n", "prefixes": [] }