Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/55079/?format=api
{ "id": 55079, "url": "http://patches.dpdk.org/api/patches/55079/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190619170802.7691-2-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190619170802.7691-2-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190619170802.7691-2-bruce.richardson@intel.com", "date": "2019-06-19T17:08:01", "name": "[1/2] raw/skeleton: fix failing test case", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "ed74d59531670f39038a7e5a5ebd2572660a3482", "submitter": { "id": 20, "url": "http://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190619170802.7691-2-bruce.richardson@intel.com/mbox/", "series": [ { "id": 5086, "url": "http://patches.dpdk.org/api/series/5086/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=5086", "date": "2019-06-19T17:08:00", "name": "rawdev autotest fixes", "version": 1, "mbox": "http://patches.dpdk.org/series/5086/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/55079/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/55079/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 975C41D0C9;\n\tWed, 19 Jun 2019 19:08:16 +0200 (CEST)", "from mga06.intel.com (mga06.intel.com [134.134.136.31])\n\tby dpdk.org (Postfix) with ESMTP id 1DF471D0C0;\n\tWed, 19 Jun 2019 19:08:13 +0200 (CEST)", "from orsmga006.jf.intel.com ([10.7.209.51])\n\tby orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t19 Jun 2019 10:08:13 -0700", "from silpixa00399126.ir.intel.com (HELO\n\tsilpixa00399126.ger.corp.intel.com) ([10.237.223.2])\n\tby orsmga006.jf.intel.com with ESMTP; 19 Jun 2019 10:08:12 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.63,393,1557212400\"; d=\"scan'208\";a=\"165076985\"", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "Bruce Richardson <bruce.richardson@intel.com>, shreyansh.jain@nxp.com,\n\tstable@dpdk.org", "Date": "Wed, 19 Jun 2019 18:08:01 +0100", "Message-Id": "<20190619170802.7691-2-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.21.0", "In-Reply-To": "<20190619170802.7691-1-bruce.richardson@intel.com>", "References": "<20190619170802.7691-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 1/2] raw/skeleton: fix failing test case", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The freeing of the malloced memory is difficult when using asserts to\ncause early abort of the test cases, since that can leak memory. The\noriginal placement of the free call caused a memory leak if the test\nfinished early, while a fix for that leak caused the test to fail at\ntimes due to the memory variable being referenced after free. For a case\nlike this, using stack rather than heap memory is just easier and avoids\nall issues.\n\nFixes: 55ca1b0f2151 (\"raw/skeleton: add test cases\")\nFixes: 88d0e47880ec (\"raw/skeleton: fix memory leak on test failure\")\nCc: shreyansh.jain@nxp.com\nCc: stable@dpdk.org\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n drivers/raw/skeleton_rawdev/skeleton_rawdev_test.c | 8 ++------\n 1 file changed, 2 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/raw/skeleton_rawdev/skeleton_rawdev_test.c b/drivers/raw/skeleton_rawdev/skeleton_rawdev_test.c\nindex 359c9e296..a0961c77b 100644\n--- a/drivers/raw/skeleton_rawdev/skeleton_rawdev_test.c\n+++ b/drivers/raw/skeleton_rawdev/skeleton_rawdev_test.c\n@@ -274,17 +274,14 @@ static int\n test_rawdev_attr_set_get(void)\n {\n \tint ret;\n-\tint *dummy_value;\n+\tint dummy_value_store;\n+\tint *dummy_value = &dummy_value_store;\n \tuint64_t ret_value;\n \n \t/* Set an attribute and fetch it */\n \tret = rte_rawdev_set_attr(TEST_DEV_ID, \"Test1\", 100);\n \tRTE_TEST_ASSERT(!ret, \"Unable to set an attribute (Test1)\");\n \n-\tdummy_value = malloc(sizeof(int));\n-\tif (!dummy_value)\n-\t\tRTE_TEST_ASSERT(1, \"Unable to allocate memory (dummy_value)\");\n-\n \t*dummy_value = 200;\n \tret = rte_rawdev_set_attr(TEST_DEV_ID, \"Test2\", (uintptr_t)dummy_value);\n \n@@ -294,7 +291,6 @@ test_rawdev_attr_set_get(void)\n \t\t\t \"Attribute (Test1) not set correctly (%\" PRIu64 \")\",\n \t\t\t ret_value);\n \n-\tfree(dummy_value);\n \n \tret_value = 0;\n \tret = rte_rawdev_get_attr(TEST_DEV_ID, \"Test2\", &ret_value);\n", "prefixes": [ "1/2" ] }