Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/54939/?format=api
{ "id": 54939, "url": "http://patches.dpdk.org/api/patches/54939/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1560924825-220648-2-git-send-email-noae@mellanox.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1560924825-220648-2-git-send-email-noae@mellanox.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1560924825-220648-2-git-send-email-noae@mellanox.com", "date": "2019-06-19T06:13:44", "name": "[1/2] net/vhost: support TSO disabling", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "83f0a28fe6c0084aabcb6505bd4de27810f366fc", "submitter": { "id": 1186, "url": "http://patches.dpdk.org/api/people/1186/?format=api", "name": "Noa Ezra", "email": "noae@mellanox.com" }, "delegate": { "id": 2642, "url": "http://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1560924825-220648-2-git-send-email-noae@mellanox.com/mbox/", "series": [ { "id": 5072, "url": "http://patches.dpdk.org/api/series/5072/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=5072", "date": "2019-06-19T06:13:45", "name": "support tso and mrg-rxbuf disabling", "version": 1, "mbox": "http://patches.dpdk.org/series/5072/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/54939/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/54939/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 8119F1C28B;\n\tWed, 19 Jun 2019 08:13:55 +0200 (CEST)", "from git-send-mailer.rdmz.labs.mlnx (unknown [37.142.13.130])\n\tby dpdk.org (Postfix) with ESMTP id C17261C1EC\n\tfor <dev@dpdk.org>; Wed, 19 Jun 2019 08:13:51 +0200 (CEST)" ], "From": "Noa Ezra <noae@mellanox.com>", "To": "maxime.coquelin@redhat.com", "Cc": "matan@mellanox.com,\n\tdev@dpdk.org,\n\tnoae@mellanox.com", "Date": "Wed, 19 Jun 2019 06:13:44 +0000", "Message-Id": "<1560924825-220648-2-git-send-email-noae@mellanox.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1560924825-220648-1-git-send-email-noae@mellanox.com>", "References": "<1560924825-220648-1-git-send-email-noae@mellanox.com>", "Subject": "[dpdk-dev] [PATCH 1/2] net/vhost: support TSO disabling", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "TSO (TCP Segmentation Offload) is enabled by default on vhost.\nAdd the ability to disable TSO on vhost.\nThe user should also disable the feature on the virtual machine's xml.\n\nSigned-off-by: Noa Ezra <noae@mellanox.com>\nReviewed-by: Matan Azrad <matan@mellanox.com>\n---\n doc/guides/nics/vhost.rst | 5 +++++\n drivers/net/vhost/rte_eth_vhost.c | 30 +++++++++++++++++++++++++++---\n 2 files changed, 32 insertions(+), 3 deletions(-)", "diff": "diff --git a/doc/guides/nics/vhost.rst b/doc/guides/nics/vhost.rst\nindex 23f2e87..8cfda4d 100644\n--- a/doc/guides/nics/vhost.rst\n+++ b/doc/guides/nics/vhost.rst\n@@ -76,6 +76,11 @@ The user can specify below arguments in `--vdev` option.\n It is used to enable postcopy live-migration support in vhost library.\n (Default: 0 (disabled))\n \n+#. ``tso``:\n+\n+ It is used to disable tso support in vhost library.\n+ (Default: 1 (enabled))\n+\n Vhost PMD event handling\n ------------------------\n \ndiff --git a/drivers/net/vhost/rte_eth_vhost.c b/drivers/net/vhost/rte_eth_vhost.c\nindex b2cda04..a38c235 100644\n--- a/drivers/net/vhost/rte_eth_vhost.c\n+++ b/drivers/net/vhost/rte_eth_vhost.c\n@@ -31,6 +31,7 @@\n #define ETH_VHOST_DEQUEUE_ZERO_COPY\t\"dequeue-zero-copy\"\n #define ETH_VHOST_IOMMU_SUPPORT\t\t\"iommu-support\"\n #define ETH_VHOST_POSTCOPY_SUPPORT\t\"postcopy-support\"\n+#define ETH_VHOST_VIRTIO_NET_F_HOST_TSO \"tso\"\n #define VHOST_MAX_PKT_BURST 32\n \n static const char *valid_arguments[] = {\n@@ -40,6 +41,7 @@\n \tETH_VHOST_DEQUEUE_ZERO_COPY,\n \tETH_VHOST_IOMMU_SUPPORT,\n \tETH_VHOST_POSTCOPY_SUPPORT,\n+\tETH_VHOST_VIRTIO_NET_F_HOST_TSO,\n \tNULL\n };\n \n@@ -1200,7 +1202,8 @@ struct vhost_xstats_name_off {\n \n static int\n eth_dev_vhost_create(struct rte_vdev_device *dev, char *iface_name,\n-\tint16_t queues, const unsigned int numa_node, uint64_t flags)\n+\tint16_t queues, const unsigned int numa_node, uint64_t flags,\n+\tuint64_t disable_flags)\n {\n \tconst char *name = rte_vdev_device_name(dev);\n \tstruct rte_eth_dev_data *data;\n@@ -1272,6 +1275,11 @@ struct vhost_xstats_name_off {\n \tif (rte_vhost_driver_register(iface_name, flags))\n \t\tgoto error;\n \n+\tif (disable_flags) {\n+\t\tif (rte_vhost_driver_disable_features(iface_name, disable_flags))\n+\t\t\tgoto error;\n+\t}\n+\n \tif (rte_vhost_driver_callback_register(iface_name, &vhost_ops) < 0) {\n \t\tVHOST_LOG(ERR, \"Can't register callbacks\\n\");\n \t\tgoto error;\n@@ -1334,10 +1342,12 @@ struct vhost_xstats_name_off {\n \tchar *iface_name;\n \tuint16_t queues;\n \tuint64_t flags = 0;\n+\tuint64_t disable_flags = 0;\n \tint client_mode = 0;\n \tint dequeue_zero_copy = 0;\n \tint iommu_support = 0;\n \tint postcopy_support = 0;\n+\tint tso = 1;\n \tstruct rte_eth_dev *eth_dev;\n \tconst char *name = rte_vdev_device_name(dev);\n \n@@ -1419,11 +1429,24 @@ struct vhost_xstats_name_off {\n \t\t\tflags |= RTE_VHOST_USER_POSTCOPY_SUPPORT;\n \t}\n \n+\tif (rte_kvargs_count(kvlist, ETH_VHOST_VIRTIO_NET_F_HOST_TSO) == 1) {\n+\t\tret = rte_kvargs_process(kvlist,\n+\t\t\t\tETH_VHOST_VIRTIO_NET_F_HOST_TSO,\n+\t\t\t\t&open_int, &tso);\n+\t\tif (ret < 0)\n+\t\t\tgoto out_free;\n+\n+\t\tif (tso == 0) {\n+\t\t\tdisable_flags |= (1ULL << VIRTIO_NET_F_HOST_TSO4);\n+\t\t\tdisable_flags |= (1ULL << VIRTIO_NET_F_HOST_TSO6);\n+\t\t}\n+\t}\n+\n \tif (dev->device.numa_node == SOCKET_ID_ANY)\n \t\tdev->device.numa_node = rte_socket_id();\n \n \teth_dev_vhost_create(dev, iface_name, queues, dev->device.numa_node,\n-\t\tflags);\n+\t\tflags, disable_flags);\n \n out_free:\n \trte_kvargs_free(kvlist);\n@@ -1470,7 +1493,8 @@ struct vhost_xstats_name_off {\n \t\"client=<0|1> \"\n \t\"dequeue-zero-copy=<0|1> \"\n \t\"iommu-support=<0|1> \"\n-\t\"postcopy-support=<0|1>\");\n+\t\"postcopy-support=<0|1> \"\n+\t\"tso=<0|1>\");\n \n RTE_INIT(vhost_init_log)\n {\n", "prefixes": [ "1/2" ] }