Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/54849/?format=api
{ "id": 54849, "url": "http://patches.dpdk.org/api/patches/54849/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1560783924-5355-4-git-send-email-david.marchand@redhat.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1560783924-5355-4-git-send-email-david.marchand@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1560783924-5355-4-git-send-email-david.marchand@redhat.com", "date": "2019-06-17T15:05:24", "name": "[3/3] drivers/net: fix double free on init failure cleanup", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "86cec9877fdc44b6f151b5463b04d191af5ca736", "submitter": { "id": 1173, "url": "http://patches.dpdk.org/api/people/1173/?format=api", "name": "David Marchand", "email": "david.marchand@redhat.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1560783924-5355-4-git-send-email-david.marchand@redhat.com/mbox/", "series": [ { "id": 5035, "url": "http://patches.dpdk.org/api/series/5035/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=5035", "date": "2019-06-17T15:05:21", "name": "ethdev mac_addrs cleanups", "version": 1, "mbox": "http://patches.dpdk.org/series/5035/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/54849/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/54849/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 3D7DE1BF4C;\n\tMon, 17 Jun 2019 17:06:17 +0200 (CEST)", "from mx1.redhat.com (mx1.redhat.com [209.132.183.28])\n\tby dpdk.org (Postfix) with ESMTP id CCFA41BF45;\n\tMon, 17 Jun 2019 17:06:14 +0200 (CEST)", "from smtp.corp.redhat.com\n\t(int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 29815821CB;\n\tMon, 17 Jun 2019 15:05:59 +0000 (UTC)", "from dmarchan.remote.csb (unknown [10.40.205.71])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id D900A68C62;\n\tMon, 17 Jun 2019 15:05:50 +0000 (UTC)" ], "From": "David Marchand <david.marchand@redhat.com>", "To": "dev@dpdk.org", "Cc": "thomas@monjalon.net, ferruh.yigit@intel.com, stable@dpdk.org,\n\tShepard Siegel <shepard.siegel@atomicrules.com>,\n\tEd Czeck <ed.czeck@atomicrules.com>,\n\tJohn Miller <john.miller@atomicrules.com>,\n\tRavi Kumar <ravi1.kumar@amd.com>, Beilei Xing <beilei.xing@intel.com>,\n\tQi Zhang <qi.z.zhang@intel.com>, Qiming Yang <qiming.yang@intel.com>, \n\tWenzhuo Lu <wenzhuo.lu@intel.com>, Jerin Jacob <jerinj@marvell.com>, \n\tMaciej Czekaj <mczekaj@marvell.com>", "Date": "Mon, 17 Jun 2019 17:05:24 +0200", "Message-Id": "<1560783924-5355-4-git-send-email-david.marchand@redhat.com>", "In-Reply-To": "<1560783924-5355-1-git-send-email-david.marchand@redhat.com>", "References": "<1560783924-5355-1-git-send-email-david.marchand@redhat.com>", "X-Scanned-By": "MIMEDefang 2.84 on 10.5.11.23", "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.28]); Mon, 17 Jun 2019 15:06:14 +0000 (UTC)", "Subject": "[dpdk-dev] [PATCH 3/3] drivers/net: fix double free on init failure\n\tcleanup", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "If we don't clear mac_addrs, ethdev will double free it on cleanup.\n\nFixes: e16adf08e54d (\"ethdev: free all common data when releasing port\")\nCc: stable@dpdk.org\n\nSigned-off-by: David Marchand <david.marchand@redhat.com>\n---\n drivers/net/ark/ark_ethdev.c | 6 +++---\n drivers/net/axgbe/axgbe_ethdev.c | 1 +\n drivers/net/i40e/i40e_ethdev.c | 1 +\n drivers/net/ice/ice_ethdev.c | 1 +\n drivers/net/thunderx/nicvf_ethdev.c | 1 +\n 5 files changed, 7 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/ark/ark_ethdev.c b/drivers/net/ark/ark_ethdev.c\nindex 7fd784c..86e500e 100644\n--- a/drivers/net/ark/ark_ethdev.c\n+++ b/drivers/net/ark/ark_ethdev.c\n@@ -403,9 +403,9 @@ static void eth_ark_macaddr_remove(struct rte_eth_dev *dev,\n \n \treturn ret;\n \n- error:\n-\tif (dev->data->mac_addrs)\n-\t\trte_free(dev->data->mac_addrs);\n+error:\n+\trte_free(dev->data->mac_addrs);\n+\tdev->data->mac_addrs = NULL;\n \treturn -1;\n }\n \ndiff --git a/drivers/net/axgbe/axgbe_ethdev.c b/drivers/net/axgbe/axgbe_ethdev.c\nindex 6b3bc3e..cfb1720 100644\n--- a/drivers/net/axgbe/axgbe_ethdev.c\n+++ b/drivers/net/axgbe/axgbe_ethdev.c\n@@ -700,6 +700,7 @@ static void axgbe_default_config(struct axgbe_port *pdata)\n \tret = pdata->phy_if.phy_init(pdata);\n \tif (ret) {\n \t\trte_free(eth_dev->data->mac_addrs);\n+\t\teth_dev->data->mac_addrs = NULL;\n \t\treturn ret;\n \t}\n \ndiff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c\nindex 3cf2c1b..69a9cff 100644\n--- a/drivers/net/i40e/i40e_ethdev.c\n+++ b/drivers/net/i40e/i40e_ethdev.c\n@@ -1600,6 +1600,7 @@ static inline void i40e_config_automask(struct i40e_pf *pf)\n \trte_free(pf->ethertype.hash_map);\n err_init_ethtype_filter_list:\n \trte_free(dev->data->mac_addrs);\n+\tdev->data->mac_addrs = NULL;\n err_mac_alloc:\n \ti40e_vsi_release(pf->main_vsi);\n err_setup_pf_switch:\ndiff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c\nindex bdbceb4..a7de455 100644\n--- a/drivers/net/ice/ice_ethdev.c\n+++ b/drivers/net/ice/ice_ethdev.c\n@@ -1466,6 +1466,7 @@ static int ice_load_pkg(struct rte_eth_dev *dev)\n \tice_res_pool_destroy(&pf->msix_pool);\n err_msix_pool_init:\n \trte_free(dev->data->mac_addrs);\n+\tdev->data->mac_addrs = NULL;\n err_init_mac:\n \tice_sched_cleanup_all(hw);\n \trte_free(hw->port_info);\ndiff --git a/drivers/net/thunderx/nicvf_ethdev.c b/drivers/net/thunderx/nicvf_ethdev.c\nindex eb2c11d..ec57692 100644\n--- a/drivers/net/thunderx/nicvf_ethdev.c\n+++ b/drivers/net/thunderx/nicvf_ethdev.c\n@@ -2206,6 +2206,7 @@ static void nicvf_vf_stop(struct rte_eth_dev *dev, struct nicvf *nic,\n \n malloc_fail:\n \trte_free(eth_dev->data->mac_addrs);\n+\teth_dev->data->mac_addrs = NULL;\n alarm_fail:\n \tnicvf_periodic_alarm_stop(nicvf_interrupt, eth_dev);\n fail:\n", "prefixes": [ "3/3" ] }