Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/54582/?format=api
{ "id": 54582, "url": "http://patches.dpdk.org/api/patches/54582/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1560146823-57155-1-git-send-email-wei.zhao1@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1560146823-57155-1-git-send-email-wei.zhao1@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1560146823-57155-1-git-send-email-wei.zhao1@intel.com", "date": "2019-06-10T06:07:03", "name": "[v3] app/testpmd: remove port stop check for macsec", "commit_ref": null, "pull_url": null, "state": "rejected", "archived": true, "hash": "37d58c201bd419dc1a487d80e0dffb0ff11c20f1", "submitter": { "id": 495, "url": "http://patches.dpdk.org/api/people/495/?format=api", "name": "Zhao1, Wei", "email": "wei.zhao1@intel.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1560146823-57155-1-git-send-email-wei.zhao1@intel.com/mbox/", "series": [ { "id": 4962, "url": "http://patches.dpdk.org/api/series/4962/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4962", "date": "2019-06-10T06:07:03", "name": "[v3] app/testpmd: remove port stop check for macsec", "version": 3, "mbox": "http://patches.dpdk.org/series/4962/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/54582/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/54582/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 6DC1A1BE4D;\n\tMon, 10 Jun 2019 08:36:44 +0200 (CEST)", "from mga12.intel.com (mga12.intel.com [192.55.52.136])\n\tby dpdk.org (Postfix) with ESMTP id 2A5511BE42;\n\tMon, 10 Jun 2019 08:36:42 +0200 (CEST)", "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t09 Jun 2019 23:36:42 -0700", "from dpdk6.bj.intel.com ([172.16.182.192])\n\tby orsmga001.jf.intel.com with ESMTP; 09 Jun 2019 23:36:40 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Wei Zhao <wei.zhao1@intel.com>", "To": "dev@dpdk.org", "Cc": "stable@dpdk.org, ferruh.yigit@intel.com, bernard.iremonger@intel.com,\n\tWei Zhao <wei.zhao1@intel.com>", "Date": "Mon, 10 Jun 2019 14:07:03 +0800", "Message-Id": "<1560146823-57155-1-git-send-email-wei.zhao1@intel.com>", "X-Mailer": "git-send-email 2.7.5", "In-Reply-To": "<1557477677-54876-1-git-send-email-wei.zhao1@intel.com>", "References": "<1557477677-54876-1-git-send-email-wei.zhao1@intel.com>", "Subject": "[dpdk-dev] [PATCH v3] app/testpmd: remove port stop check for macsec", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "There is no need to do such a check when set macsec for ixgbe, and\nreconfig_device_queueand is also useless. If we do not delete this\nunnessary code, users have to stop port before enable or disable\nmacsec, then restart this port after make configuration. All these\nprocess are useless. As this cmdline is a private API which is only\nused by ixgbe NIC, so remove it.\n\nFixes: 597f9fafe13b (\"app/testpmd: convert to new Tx offloads API\")\nCc: stable@dpdk.org\n\nSigned-off-by: Wei Zhao <wei.zhao1@intel.com>\nTested-by: Peng Yuan <yuan.peng@intel.com>\nAcked-by: Bernard Iremonger <bernard.iremonger@intel.com>\n\n---\n\nv2:\n -update log info and delete code in disable function\n\nv3:\n-update typo in log\n---\n app/test-pmd/cmdline.c | 10 ----------\n 1 file changed, 10 deletions(-)", "diff": "diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c\nindex d1e0d44..e7c4bee 100644\n--- a/app/test-pmd/cmdline.c\n+++ b/app/test-pmd/cmdline.c\n@@ -14044,10 +14044,6 @@ cmd_set_macsec_offload_on_parsed(\n \n \tif (port_id_is_invalid(port_id, ENABLED_WARN))\n \t\treturn;\n-\tif (!port_is_stopped(port_id)) {\n-\t\tprintf(\"Please stop port %d first\\n\", port_id);\n-\t\treturn;\n-\t}\n \n \trte_eth_dev_info_get(port_id, &dev_info);\n \tif (dev_info.tx_offload_capa & DEV_TX_OFFLOAD_MACSEC_INSERT) {\n@@ -14062,7 +14058,6 @@ cmd_set_macsec_offload_on_parsed(\n \tcase 0:\n \t\tports[port_id].dev_conf.txmode.offloads |=\n \t\t\t\t\t\tDEV_TX_OFFLOAD_MACSEC_INSERT;\n-\t\tcmd_reconfig_device_queue(port_id, 1, 1);\n \t\tbreak;\n \tcase -ENODEV:\n \t\tprintf(\"invalid port_id %d\\n\", port_id);\n@@ -14138,10 +14133,6 @@ cmd_set_macsec_offload_off_parsed(\n \n \tif (port_id_is_invalid(port_id, ENABLED_WARN))\n \t\treturn;\n-\tif (!port_is_stopped(port_id)) {\n-\t\tprintf(\"Please stop port %d first\\n\", port_id);\n-\t\treturn;\n-\t}\n \n \trte_eth_dev_info_get(port_id, &dev_info);\n \tif (dev_info.tx_offload_capa & DEV_TX_OFFLOAD_MACSEC_INSERT) {\n@@ -14153,7 +14144,6 @@ cmd_set_macsec_offload_off_parsed(\n \tcase 0:\n \t\tports[port_id].dev_conf.txmode.offloads &=\n \t\t\t\t\t\t~DEV_TX_OFFLOAD_MACSEC_INSERT;\n-\t\tcmd_reconfig_device_queue(port_id, 1, 1);\n \t\tbreak;\n \tcase -ENODEV:\n \t\tprintf(\"invalid port_id %d\\n\", port_id);\n", "prefixes": [ "v3" ] }