Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/54446/?format=api
{ "id": 54446, "url": "http://patches.dpdk.org/api/patches/54446/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190605202248.394-7-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190605202248.394-7-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190605202248.394-7-bruce.richardson@intel.com", "date": "2019-06-05T20:22:44", "name": "[06/10] drivers/crypto: add reasons for components being disabled", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "943b33c5b8204110de2e86376714a80abda0b3c3", "submitter": { "id": 20, "url": "http://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190605202248.394-7-bruce.richardson@intel.com/mbox/", "series": [ { "id": 4915, "url": "http://patches.dpdk.org/api/series/4915/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4915", "date": "2019-06-05T20:22:38", "name": "enhance meson summary - list disabled components", "version": 1, "mbox": "http://patches.dpdk.org/series/4915/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/54446/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/54446/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id DD5131B9DF;\n\tWed, 5 Jun 2019 22:23:20 +0200 (CEST)", "from mga18.intel.com (mga18.intel.com [134.134.136.126])\n\tby dpdk.org (Postfix) with ESMTP id 6B3251B9D3\n\tfor <dev@dpdk.org>; Wed, 5 Jun 2019 22:23:18 +0200 (CEST)", "from orsmga008.jf.intel.com ([10.7.209.65])\n\tby orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t05 Jun 2019 13:23:18 -0700", "from silpixa00399126.ir.intel.com (HELO\n\tsilpixa00399126.ger.corp.intel.com) ([10.237.223.2])\n\tby orsmga008.jf.intel.com with ESMTP; 05 Jun 2019 13:23:16 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "bluca@debian.org,\n\tthomas@monjalon.net", "Cc": "dev@dpdk.org, john.mcnamara@intel.com,\n\tBruce Richardson <bruce.richardson@intel.com>", "Date": "Wed, 5 Jun 2019 21:22:44 +0100", "Message-Id": "<20190605202248.394-7-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.21.0", "In-Reply-To": "<20190605202248.394-1-bruce.richardson@intel.com>", "References": "<20190605202248.394-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 06/10] drivers/crypto: add reasons for components\n\tbeing disabled", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "For each driver where we optionally disable it, add in the reason why it's\nbeing disabled, so the user knows how to fix it.\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n drivers/crypto/aesni_gcm/meson.build | 5 +++--\n drivers/crypto/aesni_mb/meson.build | 5 +++--\n drivers/crypto/caam_jr/meson.build | 3 ++-\n drivers/crypto/ccp/meson.build | 4 +++-\n drivers/crypto/dpaa2_sec/meson.build | 3 ++-\n drivers/crypto/dpaa_sec/meson.build | 3 ++-\n drivers/crypto/kasumi/meson.build | 1 +\n drivers/crypto/mvsam/meson.build | 1 +\n drivers/crypto/octeontx/meson.build | 1 +\n drivers/crypto/openssl/meson.build | 1 +\n drivers/crypto/qat/meson.build | 1 +\n drivers/crypto/snow3g/meson.build | 1 +\n drivers/crypto/zuc/meson.build | 1 +\n 13 files changed, 22 insertions(+), 8 deletions(-)", "diff": "diff --git a/drivers/crypto/aesni_gcm/meson.build b/drivers/crypto/aesni_gcm/meson.build\nindex 7183cfcba..3a6e332dc 100644\n--- a/drivers/crypto/aesni_gcm/meson.build\n+++ b/drivers/crypto/aesni_gcm/meson.build\n@@ -5,6 +5,7 @@ IMB_required_ver = '0.52.0'\n lib = cc.find_library('IPSec_MB', required: false)\n if not lib.found()\n \tbuild = false\n+\treason = 'missing dependency, \"libIPSec_MB\"'\n else\n \text_deps += lib\n \n@@ -13,8 +14,8 @@ else\n \t\tprefix : '#include<intel-ipsec-mb.h>').split('\"')[1]\n \n \tif (imb_ver == '') or (imb_ver.version_compare('<' + IMB_required_ver))\n-\t\tmessage('IPSec_MB version >= @0@ is required, found version @1@'.format(\n-\t\t\t\tIMB_required_ver, imb_ver))\n+\t\treason = 'IPSec_MB version >= @0@ is required, found version @1@'.format(\n+\t\t\t\tIMB_required_ver, imb_ver)\n \t\tbuild = false\n \tendif\n endif\ndiff --git a/drivers/crypto/aesni_mb/meson.build b/drivers/crypto/aesni_mb/meson.build\nindex 7c1eb3f86..3e1687416 100644\n--- a/drivers/crypto/aesni_mb/meson.build\n+++ b/drivers/crypto/aesni_mb/meson.build\n@@ -5,6 +5,7 @@ IMB_required_ver = '0.52.0'\n lib = cc.find_library('IPSec_MB', required: false)\n if not lib.found()\n \tbuild = false\n+\treason = 'missing dependency, \"libIPSec_MB\"'\n else\n \text_deps += lib\n \n@@ -13,8 +14,8 @@ else\n \t\tprefix : '#include<intel-ipsec-mb.h>').split('\"')[1]\n \n \tif (imb_ver == '') or (imb_ver.version_compare('<' + IMB_required_ver))\n-\t\tmessage('IPSec_MB version >= @0@ is required, found version @1@'.format(\n-\t\t\t\tIMB_required_ver, imb_ver))\n+\t\treason = 'IPSec_MB version >= @0@ is required, found version @1@'.format(\n+\t\t\t\tIMB_required_ver, imb_ver)\n \t\tbuild = false\n \tendif\n \ndiff --git a/drivers/crypto/caam_jr/meson.build b/drivers/crypto/caam_jr/meson.build\nindex e61a13c25..4c66dd844 100644\n--- a/drivers/crypto/caam_jr/meson.build\n+++ b/drivers/crypto/caam_jr/meson.build\n@@ -2,7 +2,8 @@\n # Copyright 2018 NXP\n \n if not is_linux\n- build = false\n+\tbuild = false\n+\treason = 'only supported on linux'\n endif\n \n deps += ['bus_vdev', 'bus_dpaa', 'security']\ndiff --git a/drivers/crypto/ccp/meson.build b/drivers/crypto/ccp/meson.build\nindex 071ccc5e7..6f7217adb 100644\n--- a/drivers/crypto/ccp/meson.build\n+++ b/drivers/crypto/ccp/meson.build\n@@ -2,11 +2,13 @@\n # Copyright(c) 2018 Advanced Micro Devices, Inc. All rights reserved.\n \n if not is_linux\n- build = false\n+\tbuild = false\n+\treason = 'only supported on linux'\n endif\n dep = dependency('libcrypto', required: false)\n if not dep.found()\n \tbuild = false\n+\treason = 'missing dependency, \"libcrypto\"'\n endif\n deps += 'bus_vdev'\n deps += 'bus_pci'\ndiff --git a/drivers/crypto/dpaa2_sec/meson.build b/drivers/crypto/dpaa2_sec/meson.build\nindex d197cda1a..23affa8a6 100644\n--- a/drivers/crypto/dpaa2_sec/meson.build\n+++ b/drivers/crypto/dpaa2_sec/meson.build\n@@ -4,7 +4,8 @@\n version = 2\n \n if not is_linux\n- build = false\n+\tbuild = false\n+\treason = 'only supported on linux'\n endif\n \n deps += ['security', 'mempool_dpaa2']\ndiff --git a/drivers/crypto/dpaa_sec/meson.build b/drivers/crypto/dpaa_sec/meson.build\nindex 134af88da..7b9a019b9 100644\n--- a/drivers/crypto/dpaa_sec/meson.build\n+++ b/drivers/crypto/dpaa_sec/meson.build\n@@ -2,7 +2,8 @@\n # Copyright 2018 NXP\n \n if not is_linux\n- build = false\n+\tbuild = false\n+\treason = 'only supported on linux'\n endif\n \n deps += ['bus_dpaa', 'security']\ndiff --git a/drivers/crypto/kasumi/meson.build b/drivers/crypto/kasumi/meson.build\nindex 0fa301740..90a3c4fe6 100644\n--- a/drivers/crypto/kasumi/meson.build\n+++ b/drivers/crypto/kasumi/meson.build\n@@ -4,6 +4,7 @@\n lib = cc.find_library('sso_kasumi', required: false)\n if not lib.found() or not cc.has_header('sso_kasumi.h')\n \tbuild = false\n+\treason = 'missing dependency, \"libsso_kasumi\"'\n \tsubdir_done()\n endif\n \ndiff --git a/drivers/crypto/mvsam/meson.build b/drivers/crypto/mvsam/meson.build\nindex f1c879663..6d97dc8a2 100644\n--- a/drivers/crypto/mvsam/meson.build\n+++ b/drivers/crypto/mvsam/meson.build\n@@ -10,6 +10,7 @@ inc_dir = path + '/include'\n lib = cc.find_library('libmusdk', dirs: [lib_dir], required: false)\n if not lib.found()\n \tbuild = false\n+\treason = 'missing dependency, \"libmusdk\"'\n else\n \text_deps += lib\n \tincludes += include_directories(inc_dir)\ndiff --git a/drivers/crypto/octeontx/meson.build b/drivers/crypto/octeontx/meson.build\nindex a9f2d3157..63a59c51a 100644\n--- a/drivers/crypto/octeontx/meson.build\n+++ b/drivers/crypto/octeontx/meson.build\n@@ -2,6 +2,7 @@\n # Copyright(c) 2018 Cavium, Inc\n if not is_linux\n \tbuild = false\n+\treason = 'only supported on linux'\n endif\n \n deps += ['bus_pci']\ndiff --git a/drivers/crypto/openssl/meson.build b/drivers/crypto/openssl/meson.build\nindex d56a32366..394e74c9e 100644\n--- a/drivers/crypto/openssl/meson.build\n+++ b/drivers/crypto/openssl/meson.build\n@@ -4,6 +4,7 @@\n dep = dependency('libcrypto', required: false)\n if not dep.found()\n \tbuild = false\n+\treason = 'missing dependency, \"libcrypto\"'\n endif\n allow_experimental_apis = true\n deps += 'bus_vdev'\ndiff --git a/drivers/crypto/qat/meson.build b/drivers/crypto/qat/meson.build\nindex 710b081ff..fc65923a7 100644\n--- a/drivers/crypto/qat/meson.build\n+++ b/drivers/crypto/qat/meson.build\n@@ -4,6 +4,7 @@\n # this does not build the QAT driver, instead that is done in the compression\n # driver which comes later. Here we just add our sources files to the list\n build = false\n+reason = '' # sentinal value to suppress printout\n dep = dependency('libcrypto', required: false)\n qat_includes += include_directories('.')\n qat_deps += 'cryptodev'\ndiff --git a/drivers/crypto/snow3g/meson.build b/drivers/crypto/snow3g/meson.build\nindex c566a5f67..0e8742ab9 100644\n--- a/drivers/crypto/snow3g/meson.build\n+++ b/drivers/crypto/snow3g/meson.build\n@@ -4,6 +4,7 @@\n lib = cc.find_library('sso_snow3g', required: false)\n if not lib.found() or not cc.has_header('sso_snow3g.h')\n \tbuild = false\n+\treason = 'missing dependency, \"libsso_snow3g\"'\n \tsubdir_done()\n endif\n \ndiff --git a/drivers/crypto/zuc/meson.build b/drivers/crypto/zuc/meson.build\nindex fc2900244..b231de0ba 100644\n--- a/drivers/crypto/zuc/meson.build\n+++ b/drivers/crypto/zuc/meson.build\n@@ -4,6 +4,7 @@\n lib = cc.find_library('sso_zuc', required: false)\n if not lib.found() or not cc.has_header('sso_zuc.h')\n \tbuild = false\n+\treason = 'missing dependency, \"libsso_zuc\"'\n \tsubdir_done()\n endif\n \n", "prefixes": [ "06/10" ] }