Patch Comment List
List patch comments
GET /api/patches/54380/comments/?format=api
[ { "id": 96730, "web_url": "http://patches.dpdk.org/comment/96730/", "msgid": "<CAJFAV8x1PiR_X1hK08uJ=+Gd0g3YSe2G_6cgoP0AmneTvA_ZWA@mail.gmail.com>", "list_archive_url": "https://inbox.dpdk.org/dev/CAJFAV8x1PiR_X1hK08uJ=+Gd0g3YSe2G_6cgoP0AmneTvA_ZWA@mail.gmail.com", "date": "2019-06-05T09:34:53", "subject": "Re: [dpdk-dev] [dpdk-stable] [PATCH v2 2/4] net/virtio: fix\n\tsegmented packet issue in mergeable Rx path", "submitter": { "id": 1173, "url": "http://patches.dpdk.org/api/people/1173/?format=api", "name": "David Marchand", "email": "david.marchand@redhat.com" }, "content": "On Wed, Jun 5, 2019 at 10:11 AM Maxime Coquelin <maxime.coquelin@redhat.com>\nwrote:\n\n> After having dequeued a burst of descriptors, there may be a\n> need to dequeue a few more if the last packet was segmented\n> and not complete. When it happens, the extra segments were\n> not properly attached to the mbuf chain, and so were lost.\n>\n> Also, head segment data_len field is wrongly summed with\n> the length of all the segments of the chain.\n>\n> This patch fixes both the mbuf chaining and head segment's\n> data_len field\n>\n> Fixes: bcac5aa207f8 (\"net/virtio: improve batching in mergeable path\")\n> Cc: stable@dpdk.org\n>\n> Reported-by: Yaroslav Brustinov <ybrustin@cisco.com>\n> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>\n> ---\n> drivers/net/virtio/virtio_rxtx.c | 4 +---\n> 1 file changed, 1 insertion(+), 3 deletions(-)\n>\n> diff --git a/drivers/net/virtio/virtio_rxtx.c\n> b/drivers/net/virtio/virtio_rxtx.c\n> index 6b3baf0423..9469ecb743 100644\n> --- a/drivers/net/virtio/virtio_rxtx.c\n> +++ b/drivers/net/virtio/virtio_rxtx.c\n> @@ -1614,7 +1614,7 @@ virtio_recv_mergeable_pkts(void *rx_queue,\n> struct virtqueue *vq = rxvq->vq;\n> struct virtio_hw *hw = vq->hw;\n> struct rte_mbuf *rxm;\n> - struct rte_mbuf *prev;\n> + struct rte_mbuf *prev = NULL;\n> uint16_t nb_used, num, nb_rx = 0;\n> uint32_t len[VIRTIO_MBUF_BURST_SZ];\n> struct rte_mbuf *rcv_pkts[VIRTIO_MBUF_BURST_SZ];\n> @@ -1721,7 +1721,6 @@ virtio_recv_mergeable_pkts(void *rx_queue,\n> uint16_t rcv_cnt = RTE_MIN((uint16_t)seg_res,\n> VIRTIO_MBUF_BURST_SZ);\n>\n> - prev = rcv_pkts[nb_rx];\n> if (likely(VIRTQUEUE_NUSED(vq) >= rcv_cnt)) {\n> virtio_rmb(hw->weak_barriers);\n> num = virtqueue_dequeue_burst_rx(vq, rcv_pkts, len,\n> @@ -1738,7 +1737,6 @@ virtio_recv_mergeable_pkts(void *rx_queue,\n> prev->next = rxm;\n> prev = rxm;\n> rx_pkts[nb_rx]->pkt_len += len[extra_idx];\n> - rx_pkts[nb_rx]->data_len += len[extra_idx];\n> extra_idx += 1;\n> };\n> seg_res -= rcv_cnt;\n> --\n> 2.21.0\n>\n>\nIdem previous patch, you have missed a data_len line 1704.\nReviewed-by: David Marchand <david.marchand@redhat.com>", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 1DC761B9F9;\n\tWed, 5 Jun 2019 11:35:07 +0200 (CEST)", "from mail-vs1-f67.google.com (mail-vs1-f67.google.com\n\t[209.85.217.67]) by dpdk.org (Postfix) with ESMTP id 179761B9F9\n\tfor <dev@dpdk.org>; Wed, 5 Jun 2019 11:35:05 +0200 (CEST)", "by mail-vs1-f67.google.com with SMTP id n21so9549568vsp.12\n\tfor <dev@dpdk.org>; Wed, 05 Jun 2019 02:35:05 -0700 (PDT)" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=cplO6t0n14e8EwmnOr08tI4fHy7qI41ztorsYUBWpoA=;\n\tb=Nh7zbOumqCsnk4pYJHjBo5UE9Y5XFyRM+7YaWjPvWhIBKDt1A8jnmWndicFzMzj/wU\n\tprc7h9sDJUKoRWwqfMaa0yDAx8MmNuamw/VxEIr4tYde+uj1DIFhMrC38hpXS9APpspA\n\tzRhCoI0CQWdI2llnWLK9m3Lcp05eytW9LOKthoUON8StVZ8Zp6d8IL7YUMpRg5anO0y2\n\tWiQuaSLu8L8m7jRocEEg89WHxgfsoOC75BGzW58Li0n432O7xrlyc5LJdCAayfAFSSmE\n\tyztqJ6rtoqOzJhd0qTZitGk1B3R2WoNS0jRh3SasZmaZnxtIMc2DVdQuLggn6vwAeHFO\n\tYmWw==", "X-Gm-Message-State": "APjAAAUNt2lhSBCFbukLJMWu4ootzlxcYVwsa4xQ+3eOnhpC3aFuJqMc\n\t2BL0w0comq1uXD+EomN1jfpvVB0zw+kQAnnpO8LbHQ==", "X-Google-Smtp-Source": "APXvYqwqAstquXrGFs5D3KlSZo3U4NqXEzDNBP5dWw/56hEpq1YCZ9pUDjly+5etnyXp+vAR07KSuqV5yFVxqN8SVq4=", "X-Received": "by 2002:a67:688f:: with SMTP id\n\td137mr10877410vsc.198.1559727304515; \n\tWed, 05 Jun 2019 02:35:04 -0700 (PDT)", "MIME-Version": "1.0", "References": "<20190605081005.15716-1-maxime.coquelin@redhat.com>\n\t<20190605081005.15716-3-maxime.coquelin@redhat.com>", "In-Reply-To": "<20190605081005.15716-3-maxime.coquelin@redhat.com>", "From": "David Marchand <david.marchand@redhat.com>", "Date": "Wed, 5 Jun 2019 11:34:53 +0200", "Message-ID": "<CAJFAV8x1PiR_X1hK08uJ=+Gd0g3YSe2G_6cgoP0AmneTvA_ZWA@mail.gmail.com>", "To": "Maxime Coquelin <maxime.coquelin@redhat.com>", "Cc": "dev <dev@dpdk.org>, ybrustin@cisco.com, Tiwei Bie <tiwei.bie@intel.com>, \n\tJens Freimann <jfreimann@redhat.com>, dpdk stable <stable@dpdk.org>", "Content-Type": "text/plain; charset=\"UTF-8\"", "X-Content-Filtered-By": "Mailman/MimeDel 2.1.15", "Subject": "Re: [dpdk-dev] [dpdk-stable] [PATCH v2 2/4] net/virtio: fix\n\tsegmented packet issue in mergeable Rx path", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null } ]