Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/53869/?format=api
{ "id": 53869, "url": "http://patches.dpdk.org/api/patches/53869/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190529191501.19053-12-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190529191501.19053-12-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20190529191501.19053-12-stephen@networkplumber.org", "date": "2019-05-29T19:15:00", "name": "[11/12] net/ixgbe: remove unnecessary cast", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "49c3ba60f8a2440e9a465001160c1b011b969f3c", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190529191501.19053-12-stephen@networkplumber.org/mbox/", "series": [ { "id": 4816, "url": "http://patches.dpdk.org/api/series/4816/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4816", "date": "2019-05-29T19:14:49", "name": "cleanup useless casts of void *", "version": 1, "mbox": "http://patches.dpdk.org/series/4816/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/53869/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/53869/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 2667B1B9CE;\n\tWed, 29 May 2019 21:15:38 +0200 (CEST)", "from mail-pf1-f193.google.com (mail-pf1-f193.google.com\n\t[209.85.210.193]) by dpdk.org (Postfix) with ESMTP id 39AF61B998\n\tfor <dev@dpdk.org>; Wed, 29 May 2019 21:15:15 +0200 (CEST)", "by mail-pf1-f193.google.com with SMTP id n19so2268340pfa.1\n\tfor <dev@dpdk.org>; Wed, 29 May 2019 12:15:15 -0700 (PDT)", "from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])\n\tby smtp.gmail.com with ESMTPSA id\n\tt18sm142943pgm.69.2019.05.29.12.15.13\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 29 May 2019 12:15:13 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=475ENe+WPnkhXRdtsY6ckeEEVkkJo4N2L3u7Y4IwC+Q=;\n\tb=KrudJho6/WiYZL/Ve77e/kfxB5mi//5hC05t3bVgyfYPnJQSpx8eysPj5j5CsFBfoz\n\tTt3t4ieDnUEHkte+Z7NMk2xAcBa5pt3YxAY6FbEj7CNrKlenDfnYXEsaUL1B0IdyCKzi\n\tmcVfg9NmIo7RWYDVr5wcox8qkbbKfLPm92ZniBH8/6xRWGlrZ+yoKbBzR0uwQd53aK2i\n\tmC+jQ0mAfmL+CB91+ZaAoByEyIPD7gO+WNELHDCJzCCoWZvMjk+roIJjnlBCGL09FcDx\n\teIeifA4WCfU0tutkj0ipRwlAEW5qcqRVaFfyJdgD8S+a8uXd4gGIee5dc0axX1alId8U\n\tN5wg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=475ENe+WPnkhXRdtsY6ckeEEVkkJo4N2L3u7Y4IwC+Q=;\n\tb=ssxOU3V3XLG6Vf5vfDE1D5T6w8tmXDxhyosI0RBNHIA8FWxqrDpt6q57dvvA9OZTVd\n\tKWqMoD9GK67WvChC0M0Q7o67dIBfP7qWrgyy4aYgbxmNVdhQI8L2EjoBhPKJdDfLHsCk\n\t5kQRoqU8BxVPqUivScuHE2pLpAwu40bJPx8HxU/ztvW7ulXYTbT01XBPBL/KbLiBM9PR\n\tAlNQkQtqmOsvkVlvlV0Xng7stG8s7k++wW32vRhhy4JRHqblbX57OUiD+15wRdTDhW10\n\tl2QbtDdoA/XZJ2Ex6YtU3iIDoVUCztGu+6QbsKL5pkzOwuL30yhkwdKH5nP9f0ES6RO/\n\tMMCQ==", "X-Gm-Message-State": "APjAAAXaVGJ1Lur3ceaM8oN5ARyvIYMVx65gyIgXm1mEO8HXOiO2t8md\n\tpBobmh76I4QrGgZTZiAZFDse4Sf+oaI=", "X-Google-Smtp-Source": "APXvYqywZ5tB3bMRwTcOx/CN3fz7CvwPUaGln6w2COI/wod5lxYJTOX+M/4iD6YCg0O7ow1OY+w3cg==", "X-Received": "by 2002:a63:1212:: with SMTP id\n\th18mr51910329pgl.266.1559157314054; \n\tWed, 29 May 2019 12:15:14 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>", "Date": "Wed, 29 May 2019 12:15:00 -0700", "Message-Id": "<20190529191501.19053-12-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20190529191501.19053-1-stephen@networkplumber.org>", "References": "<20190529191501.19053-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 11/12] net/ixgbe: remove unnecessary cast", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The device private pointer (dev_private) is of type void *\ntherefore no cast is necessary in C.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n drivers/net/ixgbe/ixgbe_ethdev.c | 33 +++++++++++---------------------\n drivers/net/ixgbe/ixgbe_rxtx.c | 14 +++++---------\n 2 files changed, 16 insertions(+), 31 deletions(-)", "diff": "diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c\nindex fae93bb29ffd..1d78085a9159 100644\n--- a/drivers/net/ixgbe/ixgbe_ethdev.c\n+++ b/drivers/net/ixgbe/ixgbe_ethdev.c\n@@ -2408,8 +2408,7 @@ ixgbe_dev_configure(struct rte_eth_dev *dev)\n {\n \tstruct ixgbe_interrupt *intr =\n \t\tIXGBE_DEV_PRIVATE_TO_INTR(dev->data->dev_private);\n-\tstruct ixgbe_adapter *adapter =\n-\t\t(struct ixgbe_adapter *)dev->data->dev_private;\n+\tstruct ixgbe_adapter *adapter =dev->data->dev_private;\n \tint ret;\n \n \tPMD_INIT_FUNC_TRACE();\n@@ -2817,8 +2816,7 @@ static void\n ixgbe_dev_stop(struct rte_eth_dev *dev)\n {\n \tstruct rte_eth_link link;\n-\tstruct ixgbe_adapter *adapter =\n-\t\t(struct ixgbe_adapter *)dev->data->dev_private;\n+\tstruct ixgbe_adapter *adapter =dev->data->dev_private;\n \tstruct ixgbe_hw *hw =\n \t\tIXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private);\n \tstruct ixgbe_vf_info *vfinfo =\n@@ -4815,8 +4813,7 @@ ixgbe_dev_rss_reta_update(struct rte_eth_dev *dev,\n \tuint8_t j, mask;\n \tuint32_t reta, r;\n \tuint16_t idx, shift;\n-\tstruct ixgbe_adapter *adapter =\n-\t\t(struct ixgbe_adapter *)dev->data->dev_private;\n+\tstruct ixgbe_adapter *adapter =dev->data->dev_private;\n \tstruct ixgbe_hw *hw = IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private);\n \tuint32_t reta_reg;\n \n@@ -5049,8 +5046,7 @@ static int\n ixgbevf_dev_configure(struct rte_eth_dev *dev)\n {\n \tstruct rte_eth_conf *conf = &dev->data->dev_conf;\n-\tstruct ixgbe_adapter *adapter =\n-\t\t\t(struct ixgbe_adapter *)dev->data->dev_private;\n+\tstruct ixgbe_adapter *adapter = dev->data->dev_private;\n \n \tPMD_INIT_LOG(DEBUG, \"Configured Virtual Function port id: %d\",\n \t\t dev->data->port_id);\n@@ -5182,8 +5178,7 @@ static void\n ixgbevf_dev_stop(struct rte_eth_dev *dev)\n {\n \tstruct ixgbe_hw *hw = IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private);\n-\tstruct ixgbe_adapter *adapter =\n-\t\t(struct ixgbe_adapter *)dev->data->dev_private;\n+\tstruct ixgbe_adapter *adapter =dev->data->dev_private;\n \tstruct rte_pci_device *pci_dev = RTE_ETH_DEV_TO_PCI(dev);\n \tstruct rte_intr_handle *intr_handle = &pci_dev->intr_handle;\n \n@@ -6945,8 +6940,7 @@ static void\n ixgbe_start_timecounters(struct rte_eth_dev *dev)\n {\n \tstruct ixgbe_hw *hw = IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private);\n-\tstruct ixgbe_adapter *adapter =\n-\t\t(struct ixgbe_adapter *)dev->data->dev_private;\n+\tstruct ixgbe_adapter *adapter =dev->data->dev_private;\n \tstruct rte_eth_link link;\n \tuint32_t incval = 0;\n \tuint32_t shift = 0;\n@@ -7014,8 +7008,7 @@ ixgbe_start_timecounters(struct rte_eth_dev *dev)\n static int\n ixgbe_timesync_adjust_time(struct rte_eth_dev *dev, int64_t delta)\n {\n-\tstruct ixgbe_adapter *adapter =\n-\t\t\t(struct ixgbe_adapter *)dev->data->dev_private;\n+\tstruct ixgbe_adapter *adapter = dev->data->dev_private;\n \n \tadapter->systime_tc.nsec += delta;\n \tadapter->rx_tstamp_tc.nsec += delta;\n@@ -7028,8 +7021,7 @@ static int\n ixgbe_timesync_write_time(struct rte_eth_dev *dev, const struct timespec *ts)\n {\n \tuint64_t ns;\n-\tstruct ixgbe_adapter *adapter =\n-\t\t\t(struct ixgbe_adapter *)dev->data->dev_private;\n+\tstruct ixgbe_adapter *adapter = dev->data->dev_private;\n \n \tns = rte_timespec_to_ns(ts);\n \t/* Set the timecounters to a new value. */\n@@ -7044,8 +7036,7 @@ static int\n ixgbe_timesync_read_time(struct rte_eth_dev *dev, struct timespec *ts)\n {\n \tuint64_t ns, systime_cycles;\n-\tstruct ixgbe_adapter *adapter =\n-\t\t\t(struct ixgbe_adapter *)dev->data->dev_private;\n+\tstruct ixgbe_adapter *adapter = dev->data->dev_private;\n \n \tsystime_cycles = ixgbe_read_systime_cyclecounter(dev);\n \tns = rte_timecounter_update(&adapter->systime_tc, systime_cycles);\n@@ -7126,8 +7117,7 @@ ixgbe_timesync_read_rx_timestamp(struct rte_eth_dev *dev,\n \t\t\t\t uint32_t flags __rte_unused)\n {\n \tstruct ixgbe_hw *hw = IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private);\n-\tstruct ixgbe_adapter *adapter =\n-\t\t(struct ixgbe_adapter *)dev->data->dev_private;\n+\tstruct ixgbe_adapter *adapter =dev->data->dev_private;\n \tuint32_t tsync_rxctl;\n \tuint64_t rx_tstamp_cycles;\n \tuint64_t ns;\n@@ -7148,8 +7138,7 @@ ixgbe_timesync_read_tx_timestamp(struct rte_eth_dev *dev,\n \t\t\t\t struct timespec *timestamp)\n {\n \tstruct ixgbe_hw *hw = IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private);\n-\tstruct ixgbe_adapter *adapter =\n-\t\t(struct ixgbe_adapter *)dev->data->dev_private;\n+\tstruct ixgbe_adapter *adapter =dev->data->dev_private;\n \tuint32_t tsync_txctl;\n \tuint64_t tx_tstamp_cycles;\n \tuint64_t ns;\ndiff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxtx.c\nindex 4be7f72ab838..a8ce561e239a 100644\n--- a/drivers/net/ixgbe/ixgbe_rxtx.c\n+++ b/drivers/net/ixgbe/ixgbe_rxtx.c\n@@ -2919,8 +2919,7 @@ ixgbe_dev_rx_queue_setup(struct rte_eth_dev *dev,\n \tstruct ixgbe_rx_queue *rxq;\n \tstruct ixgbe_hw *hw;\n \tuint16_t len;\n-\tstruct ixgbe_adapter *adapter =\n-\t\t(struct ixgbe_adapter *)dev->data->dev_private;\n+\tstruct ixgbe_adapter *adapter = dev->data->dev_private;\n \tuint64_t offloads;\n \n \tPMD_INIT_FUNC_TRACE();\n@@ -3221,8 +3220,7 @@ void __attribute__((cold))\n ixgbe_dev_clear_queues(struct rte_eth_dev *dev)\n {\n \tunsigned i;\n-\tstruct ixgbe_adapter *adapter =\n-\t\t(struct ixgbe_adapter *)dev->data->dev_private;\n+\tstruct ixgbe_adapter *adapter = dev->data->dev_private;\n \tstruct ixgbe_hw *hw = IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private);\n \n \tPMD_INIT_FUNC_TRACE();\n@@ -3485,7 +3483,7 @@ ixgbe_rss_configure(struct rte_eth_dev *dev)\n \tuint32_t reta_reg;\n \n \tPMD_INIT_FUNC_TRACE();\n-\tadapter = (struct ixgbe_adapter *)dev->data->dev_private;\n+\tadapter = dev->data->dev_private;\n \thw = IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private);\n \n \tsp_reta_size = ixgbe_reta_size_get(hw->mac.type);\n@@ -4630,8 +4628,7 @@ void __attribute__((cold))\n ixgbe_set_rx_function(struct rte_eth_dev *dev)\n {\n \tuint16_t i, rx_using_sse;\n-\tstruct ixgbe_adapter *adapter =\n-\t\t(struct ixgbe_adapter *)dev->data->dev_private;\n+\tstruct ixgbe_adapter *adapter = dev->data->dev_private;\n \n \t/*\n \t * In order to allow Vector Rx there are a few configuration\n@@ -5309,8 +5306,7 @@ int __attribute__((cold))\n ixgbe_dev_rx_queue_stop(struct rte_eth_dev *dev, uint16_t rx_queue_id)\n {\n \tstruct ixgbe_hw *hw;\n-\tstruct ixgbe_adapter *adapter =\n-\t\t(struct ixgbe_adapter *)dev->data->dev_private;\n+\tstruct ixgbe_adapter *adapter = dev->data->dev_private;\n \tstruct ixgbe_rx_queue *rxq;\n \tuint32_t rxdctl;\n \tint poll_ms;\n", "prefixes": [ "11/12" ] }