Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/53864/?format=api
{ "id": 53864, "url": "http://patches.dpdk.org/api/patches/53864/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190529191501.19053-7-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190529191501.19053-7-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20190529191501.19053-7-stephen@networkplumber.org", "date": "2019-05-29T19:14:55", "name": "[06/12] net/cxgbe: remove unnecessary cast", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "fae40232408cb293934e0e2d62b40736d4956208", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190529191501.19053-7-stephen@networkplumber.org/mbox/", "series": [ { "id": 4816, "url": "http://patches.dpdk.org/api/series/4816/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4816", "date": "2019-05-29T19:14:49", "name": "cleanup useless casts of void *", "version": 1, "mbox": "http://patches.dpdk.org/series/4816/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/53864/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/53864/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id BBE081B9B0;\n\tWed, 29 May 2019 21:15:25 +0200 (CEST)", "from mail-pf1-f196.google.com (mail-pf1-f196.google.com\n\t[209.85.210.196]) by dpdk.org (Postfix) with ESMTP id DA4391B95C\n\tfor <dev@dpdk.org>; Wed, 29 May 2019 21:15:10 +0200 (CEST)", "by mail-pf1-f196.google.com with SMTP id g9so2234217pfo.11\n\tfor <dev@dpdk.org>; Wed, 29 May 2019 12:15:10 -0700 (PDT)", "from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])\n\tby smtp.gmail.com with ESMTPSA id\n\tt18sm142943pgm.69.2019.05.29.12.15.08\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 29 May 2019 12:15:08 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=omXSdGA2XJghDukVVSYrgLIpBHf0rBYvmGZLpht6JCg=;\n\tb=PEOcIg4JCJcpZCyIwOGAeB+Pxs1TNx/pnn5W0qmDxC5UP++6NsiO33lJnY22nV4B86\n\tQxBOJk8RHdu9Mbm4loB2I4sGQmsRRzhwMrXBM0OP2Y/P1A8xu5Z/ilu/eVB6SpTmZKXO\n\tU5vERSZE1kQJ6KbmAMBLBmBUIzpzghSfVrwHbmjnEgbnnquYpgaRDaXxrWLHZp7kSy9u\n\ta0YAt840MxTKTr+B1/wXyYHosvnCd4uOXNm5P/SN8Av/aG13wk6F9n8+vJmukIuCW7ni\n\tCM1bHFnsjjUJZC6QfyrRJyohMvAjAClJolSPh3gYkmM1l0Hz8WRv1ttgYnEUp7JVSBzI\n\tLLJQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=omXSdGA2XJghDukVVSYrgLIpBHf0rBYvmGZLpht6JCg=;\n\tb=PANM/aWnBxGS6tnDYasBWG4hebBGICjo+Q1AZFwyRZR2qtyrtAN9KxZw8qA0DLP+Ok\n\tN5ppZOmuao8NuU5KEdid9vpcpJmXBIvAOIQA4A4bQf3rlZBbXy+s2QaDhWhbibrgZH7f\n\tFqtwHmYP1ovEhwjBNLEYnmlHG65pdIEHDe36oUF3nlPVXB/7UFWW44TZVvVuHT4Wr24/\n\tHElyjZMTg7OSSkHlzTY9g3Bqp6GdiZqaEnzvMZzjKmZSXFOVVOczT/S7Qnoxga3d6Ohq\n\t/Q5h5BJlVqvA1HImj1he9FgQynXZ6frDpEP7NZGbW3v1TBbRPFHYjNlzkSCAncoqIDKf\n\tSnsQ==", "X-Gm-Message-State": "APjAAAXbo1U3n62CMfHsnZWE06PwCtwp6wL2mK8YUl4OEOAcI7vxgS26\n\ta/Ej/OANgFRxIM2x53BsFW06m6iamj8=", "X-Google-Smtp-Source": "APXvYqwogZZ0sCDUWXnf6hqz8or0tYVR6TetPw87ntV+er+PeZ0R2N/xdh1J/R0YiefYsinNUJcl5w==", "X-Received": "by 2002:a63:246:: with SMTP id\n\t67mr142570740pgc.145.1559157309505; \n\tWed, 29 May 2019 12:15:09 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>", "Date": "Wed, 29 May 2019 12:14:55 -0700", "Message-Id": "<20190529191501.19053-7-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20190529191501.19053-1-stephen@networkplumber.org>", "References": "<20190529191501.19053-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 06/12] net/cxgbe: remove unnecessary cast", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The device private pointer (dev_private) is of type void *\ntherefore no cast is necessary in C.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n drivers/net/cxgbe/base/adapter.h | 2 +-\n drivers/net/cxgbe/cxgbe_ethdev.c | 60 +++++++++++++++---------------\n drivers/net/cxgbe/cxgbe_filter.c | 2 +-\n drivers/net/cxgbe/cxgbe_main.c | 6 +--\n drivers/net/cxgbe/cxgbevf_ethdev.c | 6 +--\n drivers/net/cxgbe/cxgbevf_main.c | 2 +-\n drivers/net/cxgbe/sge.c | 8 ++--\n 7 files changed, 43 insertions(+), 43 deletions(-)", "diff": "diff --git a/drivers/net/cxgbe/base/adapter.h b/drivers/net/cxgbe/base/adapter.h\nindex 122166410a60..e548f9f63a10 100644\n--- a/drivers/net/cxgbe/base/adapter.h\n+++ b/drivers/net/cxgbe/base/adapter.h\n@@ -368,7 +368,7 @@ static inline void t4_os_write_unlock(rte_rwlock_t *lock)\n */\n static inline struct port_info *ethdev2pinfo(const struct rte_eth_dev *dev)\n {\n-\treturn (struct port_info *)dev->data->dev_private;\n+\treturn dev->data->dev_private;\n }\n \n /**\ndiff --git a/drivers/net/cxgbe/cxgbe_ethdev.c b/drivers/net/cxgbe/cxgbe_ethdev.c\nindex c03559640a49..2a8e61b9f6e1 100644\n--- a/drivers/net/cxgbe/cxgbe_ethdev.c\n+++ b/drivers/net/cxgbe/cxgbe_ethdev.c\n@@ -112,7 +112,7 @@ uint16_t cxgbe_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts,\n void cxgbe_dev_info_get(struct rte_eth_dev *eth_dev,\n \t\t\tstruct rte_eth_dev_info *device_info)\n {\n-\tstruct port_info *pi = (struct port_info *)(eth_dev->data->dev_private);\n+\tstruct port_info *pi = eth_dev->data->dev_private;\n \tstruct adapter *adapter = pi->adapter;\n \tint max_queues = adapter->sge.max_ethqsets / adapter->params.nports;\n \n@@ -148,7 +148,7 @@ void cxgbe_dev_info_get(struct rte_eth_dev *eth_dev,\n \n void cxgbe_dev_promiscuous_enable(struct rte_eth_dev *eth_dev)\n {\n-\tstruct port_info *pi = (struct port_info *)(eth_dev->data->dev_private);\n+\tstruct port_info *pi = eth_dev->data->dev_private;\n \tstruct adapter *adapter = pi->adapter;\n \n \tt4_set_rxmode(adapter, adapter->mbox, pi->viid, -1,\n@@ -157,7 +157,7 @@ void cxgbe_dev_promiscuous_enable(struct rte_eth_dev *eth_dev)\n \n void cxgbe_dev_promiscuous_disable(struct rte_eth_dev *eth_dev)\n {\n-\tstruct port_info *pi = (struct port_info *)(eth_dev->data->dev_private);\n+\tstruct port_info *pi = eth_dev->data->dev_private;\n \tstruct adapter *adapter = pi->adapter;\n \n \tt4_set_rxmode(adapter, adapter->mbox, pi->viid, -1,\n@@ -166,7 +166,7 @@ void cxgbe_dev_promiscuous_disable(struct rte_eth_dev *eth_dev)\n \n void cxgbe_dev_allmulticast_enable(struct rte_eth_dev *eth_dev)\n {\n-\tstruct port_info *pi = (struct port_info *)(eth_dev->data->dev_private);\n+\tstruct port_info *pi = eth_dev->data->dev_private;\n \tstruct adapter *adapter = pi->adapter;\n \n \t/* TODO: address filters ?? */\n@@ -177,7 +177,7 @@ void cxgbe_dev_allmulticast_enable(struct rte_eth_dev *eth_dev)\n \n void cxgbe_dev_allmulticast_disable(struct rte_eth_dev *eth_dev)\n {\n-\tstruct port_info *pi = (struct port_info *)(eth_dev->data->dev_private);\n+\tstruct port_info *pi = eth_dev->data->dev_private;\n \tstruct adapter *adapter = pi->adapter;\n \n \t/* TODO: address filters ?? */\n@@ -189,7 +189,7 @@ void cxgbe_dev_allmulticast_disable(struct rte_eth_dev *eth_dev)\n int cxgbe_dev_link_update(struct rte_eth_dev *eth_dev,\n \t\t\t int wait_to_complete)\n {\n-\tstruct port_info *pi = (struct port_info *)(eth_dev->data->dev_private);\n+\tstruct port_info *pi = eth_dev->data->dev_private;\n \tstruct adapter *adapter = pi->adapter;\n \tstruct sge *s = &adapter->sge;\n \tstruct rte_eth_link new_link = { 0 };\n@@ -224,7 +224,7 @@ int cxgbe_dev_link_update(struct rte_eth_dev *eth_dev,\n */\n int cxgbe_dev_set_link_up(struct rte_eth_dev *dev)\n {\n-\tstruct port_info *pi = (struct port_info *)(dev->data->dev_private);\n+\tstruct port_info *pi = dev->data->dev_private;\n \tstruct adapter *adapter = pi->adapter;\n \tunsigned int work_done, budget = 32;\n \tstruct sge *s = &adapter->sge;\n@@ -250,7 +250,7 @@ int cxgbe_dev_set_link_up(struct rte_eth_dev *dev)\n */\n int cxgbe_dev_set_link_down(struct rte_eth_dev *dev)\n {\n-\tstruct port_info *pi = (struct port_info *)(dev->data->dev_private);\n+\tstruct port_info *pi = dev->data->dev_private;\n \tstruct adapter *adapter = pi->adapter;\n \tunsigned int work_done, budget = 32;\n \tstruct sge *s = &adapter->sge;\n@@ -273,7 +273,7 @@ int cxgbe_dev_set_link_down(struct rte_eth_dev *dev)\n \n int cxgbe_dev_mtu_set(struct rte_eth_dev *eth_dev, uint16_t mtu)\n {\n-\tstruct port_info *pi = (struct port_info *)(eth_dev->data->dev_private);\n+\tstruct port_info *pi = eth_dev->data->dev_private;\n \tstruct adapter *adapter = pi->adapter;\n \tstruct rte_eth_dev_info dev_info;\n \tint err;\n@@ -306,7 +306,7 @@ int cxgbe_dev_mtu_set(struct rte_eth_dev *eth_dev, uint16_t mtu)\n */\n void cxgbe_dev_close(struct rte_eth_dev *eth_dev)\n {\n-\tstruct port_info *pi = (struct port_info *)(eth_dev->data->dev_private);\n+\tstruct port_info *pi = eth_dev->data->dev_private;\n \tstruct adapter *adapter = pi->adapter;\n \n \tCXGBE_FUNC_TRACE();\n@@ -328,7 +328,7 @@ void cxgbe_dev_close(struct rte_eth_dev *eth_dev)\n */\n int cxgbe_dev_start(struct rte_eth_dev *eth_dev)\n {\n-\tstruct port_info *pi = (struct port_info *)(eth_dev->data->dev_private);\n+\tstruct port_info *pi = eth_dev->data->dev_private;\n \tstruct rte_eth_rxmode *rx_conf = ð_dev->data->dev_conf.rxmode;\n \tstruct adapter *adapter = pi->adapter;\n \tint err = 0, i;\n@@ -386,7 +386,7 @@ int cxgbe_dev_start(struct rte_eth_dev *eth_dev)\n */\n void cxgbe_dev_stop(struct rte_eth_dev *eth_dev)\n {\n-\tstruct port_info *pi = (struct port_info *)(eth_dev->data->dev_private);\n+\tstruct port_info *pi = eth_dev->data->dev_private;\n \tstruct adapter *adapter = pi->adapter;\n \n \tCXGBE_FUNC_TRACE();\n@@ -406,7 +406,7 @@ void cxgbe_dev_stop(struct rte_eth_dev *eth_dev)\n \n int cxgbe_dev_configure(struct rte_eth_dev *eth_dev)\n {\n-\tstruct port_info *pi = (struct port_info *)(eth_dev->data->dev_private);\n+\tstruct port_info *pi = eth_dev->data->dev_private;\n \tstruct adapter *adapter = pi->adapter;\n \tint err;\n \n@@ -466,7 +466,7 @@ int cxgbe_dev_tx_queue_setup(struct rte_eth_dev *eth_dev,\n \t\t\t unsigned int socket_id,\n \t\t\t const struct rte_eth_txconf *tx_conf __rte_unused)\n {\n-\tstruct port_info *pi = (struct port_info *)(eth_dev->data->dev_private);\n+\tstruct port_info *pi = eth_dev->data->dev_private;\n \tstruct adapter *adapter = pi->adapter;\n \tstruct sge *s = &adapter->sge;\n \tstruct sge_eth_txq *txq = &s->ethtxq[pi->first_qset + queue_idx];\n@@ -531,7 +531,7 @@ void cxgbe_dev_tx_queue_release(void *q)\n int cxgbe_dev_rx_queue_start(struct rte_eth_dev *eth_dev, uint16_t rx_queue_id)\n {\n \tint ret;\n-\tstruct port_info *pi = (struct port_info *)(eth_dev->data->dev_private);\n+\tstruct port_info *pi = eth_dev->data->dev_private;\n \tstruct adapter *adap = pi->adapter;\n \tstruct sge_rspq *q;\n \n@@ -550,7 +550,7 @@ int cxgbe_dev_rx_queue_start(struct rte_eth_dev *eth_dev, uint16_t rx_queue_id)\n int cxgbe_dev_rx_queue_stop(struct rte_eth_dev *eth_dev, uint16_t rx_queue_id)\n {\n \tint ret;\n-\tstruct port_info *pi = (struct port_info *)(eth_dev->data->dev_private);\n+\tstruct port_info *pi = eth_dev->data->dev_private;\n \tstruct adapter *adap = pi->adapter;\n \tstruct sge_rspq *q;\n \n@@ -571,7 +571,7 @@ int cxgbe_dev_rx_queue_setup(struct rte_eth_dev *eth_dev,\n \t\t\t const struct rte_eth_rxconf *rx_conf __rte_unused,\n \t\t\t struct rte_mempool *mp)\n {\n-\tstruct port_info *pi = (struct port_info *)(eth_dev->data->dev_private);\n+\tstruct port_info *pi = eth_dev->data->dev_private;\n \tstruct adapter *adapter = pi->adapter;\n \tstruct sge *s = &adapter->sge;\n \tstruct sge_eth_rxq *rxq = &s->ethrxq[pi->first_qset + queue_idx];\n@@ -668,7 +668,7 @@ void cxgbe_dev_rx_queue_release(void *q)\n static int cxgbe_dev_stats_get(struct rte_eth_dev *eth_dev,\n \t\t\t\tstruct rte_eth_stats *eth_stats)\n {\n-\tstruct port_info *pi = (struct port_info *)(eth_dev->data->dev_private);\n+\tstruct port_info *pi = eth_dev->data->dev_private;\n \tstruct adapter *adapter = pi->adapter;\n \tstruct sge *s = &adapter->sge;\n \tstruct port_stats ps;\n@@ -716,7 +716,7 @@ static int cxgbe_dev_stats_get(struct rte_eth_dev *eth_dev,\n */\n static void cxgbe_dev_stats_reset(struct rte_eth_dev *eth_dev)\n {\n-\tstruct port_info *pi = (struct port_info *)(eth_dev->data->dev_private);\n+\tstruct port_info *pi = eth_dev->data->dev_private;\n \tstruct adapter *adapter = pi->adapter;\n \tstruct sge *s = &adapter->sge;\n \tunsigned int i;\n@@ -742,7 +742,7 @@ static void cxgbe_dev_stats_reset(struct rte_eth_dev *eth_dev)\n static int cxgbe_flow_ctrl_get(struct rte_eth_dev *eth_dev,\n \t\t\t struct rte_eth_fc_conf *fc_conf)\n {\n-\tstruct port_info *pi = (struct port_info *)(eth_dev->data->dev_private);\n+\tstruct port_info *pi = eth_dev->data->dev_private;\n \tstruct link_config *lc = &pi->link_cfg;\n \tint rx_pause, tx_pause;\n \n@@ -764,7 +764,7 @@ static int cxgbe_flow_ctrl_get(struct rte_eth_dev *eth_dev,\n static int cxgbe_flow_ctrl_set(struct rte_eth_dev *eth_dev,\n \t\t\t struct rte_eth_fc_conf *fc_conf)\n {\n-\tstruct port_info *pi = (struct port_info *)(eth_dev->data->dev_private);\n+\tstruct port_info *pi = eth_dev->data->dev_private;\n \tstruct adapter *adapter = pi->adapter;\n \tstruct link_config *lc = &pi->link_cfg;\n \n@@ -810,7 +810,7 @@ cxgbe_dev_supported_ptypes_get(struct rte_eth_dev *eth_dev)\n static int cxgbe_dev_rss_hash_update(struct rte_eth_dev *dev,\n \t\t\t\t struct rte_eth_rss_conf *rss_conf)\n {\n-\tstruct port_info *pi = (struct port_info *)(dev->data->dev_private);\n+\tstruct port_info *pi = dev->data->dev_private;\n \tstruct adapter *adapter = pi->adapter;\n \tint err;\n \n@@ -840,7 +840,7 @@ static int cxgbe_dev_rss_hash_update(struct rte_eth_dev *dev,\n static int cxgbe_dev_rss_hash_conf_get(struct rte_eth_dev *dev,\n \t\t\t\t struct rte_eth_rss_conf *rss_conf)\n {\n-\tstruct port_info *pi = (struct port_info *)(dev->data->dev_private);\n+\tstruct port_info *pi = dev->data->dev_private;\n \tstruct adapter *adapter = pi->adapter;\n \tu64 rss_hf = 0;\n \tu64 flags = 0;\n@@ -949,7 +949,7 @@ static int eeprom_wr_phys(struct adapter *adap, unsigned int phys_addr, u32 v)\n static int cxgbe_get_eeprom(struct rte_eth_dev *dev,\n \t\t\t struct rte_dev_eeprom_info *e)\n {\n-\tstruct port_info *pi = (struct port_info *)(dev->data->dev_private);\n+\tstruct port_info *pi = dev->data->dev_private;\n \tstruct adapter *adapter = pi->adapter;\n \tu32 i, err = 0;\n \tu8 *buf = rte_zmalloc(NULL, EEPROMSIZE, 0);\n@@ -970,7 +970,7 @@ static int cxgbe_get_eeprom(struct rte_eth_dev *dev,\n static int cxgbe_set_eeprom(struct rte_eth_dev *dev,\n \t\t\t struct rte_dev_eeprom_info *eeprom)\n {\n-\tstruct port_info *pi = (struct port_info *)(dev->data->dev_private);\n+\tstruct port_info *pi = dev->data->dev_private;\n \tstruct adapter *adapter = pi->adapter;\n \tu8 *buf;\n \tint err = 0;\n@@ -1028,7 +1028,7 @@ static int cxgbe_set_eeprom(struct rte_eth_dev *dev,\n \n static int cxgbe_get_regs_len(struct rte_eth_dev *eth_dev)\n {\n-\tstruct port_info *pi = (struct port_info *)(eth_dev->data->dev_private);\n+\tstruct port_info *pi = eth_dev->data->dev_private;\n \tstruct adapter *adapter = pi->adapter;\n \n \treturn t4_get_regs_len(adapter) / sizeof(uint32_t);\n@@ -1037,7 +1037,7 @@ static int cxgbe_get_regs_len(struct rte_eth_dev *eth_dev)\n static int cxgbe_get_regs(struct rte_eth_dev *eth_dev,\n \t\t\t struct rte_dev_reg_info *regs)\n {\n-\tstruct port_info *pi = (struct port_info *)(eth_dev->data->dev_private);\n+\tstruct port_info *pi = eth_dev->data->dev_private;\n \tstruct adapter *adapter = pi->adapter;\n \n \tregs->version = CHELSIO_CHIP_VERSION(adapter->params.chip) |\n@@ -1058,7 +1058,7 @@ static int cxgbe_get_regs(struct rte_eth_dev *eth_dev,\n \n int cxgbe_mac_addr_set(struct rte_eth_dev *dev, struct rte_ether_addr *addr)\n {\n-\tstruct port_info *pi = (struct port_info *)(dev->data->dev_private);\n+\tstruct port_info *pi = dev->data->dev_private;\n \tint ret;\n \n \tret = cxgbe_mpstcam_modify(pi, (int)pi->xact_addr_filt, (u8 *)addr);\n@@ -1115,7 +1115,7 @@ static const struct eth_dev_ops cxgbe_eth_dev_ops = {\n static int eth_cxgbe_dev_init(struct rte_eth_dev *eth_dev)\n {\n \tstruct rte_pci_device *pci_dev;\n-\tstruct port_info *pi = (struct port_info *)(eth_dev->data->dev_private);\n+\tstruct port_info *pi = eth_dev->data->dev_private;\n \tstruct adapter *adapter = NULL;\n \tchar name[RTE_ETH_NAME_MAX_LEN];\n \tint err = 0;\n@@ -1186,7 +1186,7 @@ static int eth_cxgbe_dev_init(struct rte_eth_dev *eth_dev)\n \n static int eth_cxgbe_dev_uninit(struct rte_eth_dev *eth_dev)\n {\n-\tstruct port_info *pi = (struct port_info *)(eth_dev->data->dev_private);\n+\tstruct port_info *pi = eth_dev->data->dev_private;\n \tstruct adapter *adap = pi->adapter;\n \n \t/* Free up other ports and all resources */\ndiff --git a/drivers/net/cxgbe/cxgbe_filter.c b/drivers/net/cxgbe/cxgbe_filter.c\nindex a77935a65732..7fcee5c0ad26 100644\n--- a/drivers/net/cxgbe/cxgbe_filter.c\n+++ b/drivers/net/cxgbe/cxgbe_filter.c\n@@ -854,7 +854,7 @@ int cxgbe_del_filter(struct rte_eth_dev *dev, unsigned int filter_id,\n \t\t struct ch_filter_specification *fs,\n \t\t struct filter_ctx *ctx)\n {\n-\tstruct port_info *pi = (struct port_info *)(dev->data->dev_private);\n+\tstruct port_info *pi = dev->data->dev_private;\n \tstruct adapter *adapter = pi->adapter;\n \tstruct filter_entry *f;\n \tunsigned int chip_ver;\ndiff --git a/drivers/net/cxgbe/cxgbe_main.c b/drivers/net/cxgbe/cxgbe_main.c\nindex b5d5cd081ace..4e24fedc735b 100644\n--- a/drivers/net/cxgbe/cxgbe_main.c\n+++ b/drivers/net/cxgbe/cxgbe_main.c\n@@ -477,7 +477,7 @@ static inline void init_rspq(struct adapter *adap, struct sge_rspq *q,\n \n int cxgbe_cfg_queue_count(struct rte_eth_dev *eth_dev)\n {\n-\tstruct port_info *pi = (struct port_info *)(eth_dev->data->dev_private);\n+\tstruct port_info *pi = eth_dev->data->dev_private;\n \tstruct adapter *adap = pi->adapter;\n \tstruct sge *s = &adap->sge;\n \tunsigned int max_queues = s->max_ethqsets / adap->params.nports;\n@@ -505,7 +505,7 @@ int cxgbe_cfg_queue_count(struct rte_eth_dev *eth_dev)\n void cxgbe_cfg_queues(struct rte_eth_dev *eth_dev)\n {\n \tstruct rte_config *config = rte_eal_get_configuration();\n-\tstruct port_info *pi = (struct port_info *)(eth_dev->data->dev_private);\n+\tstruct port_info *pi = eth_dev->data->dev_private;\n \tstruct adapter *adap = pi->adapter;\n \tstruct sge *s = &adap->sge;\n \tunsigned int i, nb_ports = 0, qidx = 0;\n@@ -1825,7 +1825,7 @@ int cxgbe_probe(struct adapter *adapter)\n \t\t\tgoto out_free;\n \n allocate_mac:\n-\t\tpi = (struct port_info *)eth_dev->data->dev_private;\n+\t\tpi = eth_dev->data->dev_private;\n \t\tadapter->port[i] = pi;\n \t\tpi->eth_dev = eth_dev;\n \t\tpi->adapter = adapter;\ndiff --git a/drivers/net/cxgbe/cxgbevf_ethdev.c b/drivers/net/cxgbe/cxgbevf_ethdev.c\nindex 0e93d99e6e4d..c5f03434ee44 100644\n--- a/drivers/net/cxgbe/cxgbevf_ethdev.c\n+++ b/drivers/net/cxgbe/cxgbevf_ethdev.c\n@@ -36,7 +36,7 @@\n static int cxgbevf_dev_stats_get(struct rte_eth_dev *eth_dev,\n \t\t\t\t struct rte_eth_stats *eth_stats)\n {\n-\tstruct port_info *pi = (struct port_info *)(eth_dev->data->dev_private);\n+\tstruct port_info *pi = eth_dev->data->dev_private;\n \tstruct adapter *adapter = pi->adapter;\n \tstruct sge *s = &adapter->sge;\n \tstruct port_stats ps;\n@@ -107,7 +107,7 @@ static const struct eth_dev_ops cxgbevf_eth_dev_ops = {\n */\n static int eth_cxgbevf_dev_init(struct rte_eth_dev *eth_dev)\n {\n-\tstruct port_info *pi = (struct port_info *)(eth_dev->data->dev_private);\n+\tstruct port_info *pi = eth_dev->data->dev_private;\n \tstruct rte_pci_device *pci_dev;\n \tchar name[RTE_ETH_NAME_MAX_LEN];\n \tstruct adapter *adapter = NULL;\n@@ -179,7 +179,7 @@ static int eth_cxgbevf_dev_init(struct rte_eth_dev *eth_dev)\n \n static int eth_cxgbevf_dev_uninit(struct rte_eth_dev *eth_dev)\n {\n-\tstruct port_info *pi = (struct port_info *)(eth_dev->data->dev_private);\n+\tstruct port_info *pi = eth_dev->data->dev_private;\n \tstruct adapter *adap = pi->adapter;\n \n \t/* Free up other ports and all resources */\ndiff --git a/drivers/net/cxgbe/cxgbevf_main.c b/drivers/net/cxgbe/cxgbevf_main.c\nindex d3345508f491..82f40f358096 100644\n--- a/drivers/net/cxgbe/cxgbevf_main.c\n+++ b/drivers/net/cxgbe/cxgbevf_main.c\n@@ -230,7 +230,7 @@ int cxgbevf_probe(struct adapter *adapter)\n \t\t\tgoto out_free;\n \n allocate_mac:\n-\t\tpi = (struct port_info *)eth_dev->data->dev_private;\n+\t\tpi = eth_dev->data->dev_private;\n \t\tadapter->port[i] = pi;\n \t\tpi->eth_dev = eth_dev;\n \t\tpi->adapter = adapter;\ndiff --git a/drivers/net/cxgbe/sge.c b/drivers/net/cxgbe/sge.c\nindex b3c4ec2ebf9f..641be96578d9 100644\n--- a/drivers/net/cxgbe/sge.c\n+++ b/drivers/net/cxgbe/sge.c\n@@ -1138,7 +1138,7 @@ int t4_eth_xmit(struct sge_eth_txq *txq, struct rte_mbuf *mbuf,\n \t (unlikely(m->pkt_len > max_pkt_len)))\n \t\tgoto out_free;\n \n-\tpi = (struct port_info *)txq->data->dev_private;\n+\tpi = txq->data->dev_private;\n \tadap = pi->adapter;\n \n \tcntrl = F_TXPKT_L4CSUM_DIS | F_TXPKT_IPCSUM_DIS;\n@@ -1792,7 +1792,7 @@ int t4_sge_alloc_rxq(struct adapter *adap, struct sge_rspq *iq, bool fwevtq,\n \tint ret, flsz = 0;\n \tstruct fw_iq_cmd c;\n \tstruct sge *s = &adap->sge;\n-\tstruct port_info *pi = (struct port_info *)(eth_dev->data->dev_private);\n+\tstruct port_info *pi = eth_dev->data->dev_private;\n \tchar z_name[RTE_MEMZONE_NAMESIZE];\n \tchar z_name_sw[RTE_MEMZONE_NAMESIZE];\n \tunsigned int nb_refill;\n@@ -2062,7 +2062,7 @@ int t4_sge_alloc_eth_txq(struct adapter *adap, struct sge_eth_txq *txq,\n \tint ret, nentries;\n \tstruct fw_eq_eth_cmd c;\n \tstruct sge *s = &adap->sge;\n-\tstruct port_info *pi = (struct port_info *)(eth_dev->data->dev_private);\n+\tstruct port_info *pi = eth_dev->data->dev_private;\n \tchar z_name[RTE_MEMZONE_NAMESIZE];\n \tchar z_name_sw[RTE_MEMZONE_NAMESIZE];\n \tu8 pciechan;\n@@ -2141,7 +2141,7 @@ int t4_sge_alloc_ctrl_txq(struct adapter *adap, struct sge_ctrl_txq *txq,\n \tint ret, nentries;\n \tstruct fw_eq_ctrl_cmd c;\n \tstruct sge *s = &adap->sge;\n-\tstruct port_info *pi = (struct port_info *)(eth_dev->data->dev_private);\n+\tstruct port_info *pi = eth_dev->data->dev_private;\n \tchar z_name[RTE_MEMZONE_NAMESIZE];\n \tchar z_name_sw[RTE_MEMZONE_NAMESIZE];\n \n", "prefixes": [ "06/12" ] }