Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/53843/?format=api
{ "id": 53843, "url": "http://patches.dpdk.org/api/patches/53843/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/d3fbc63947e84c79085e22971acf0c38ba869856.1559147228.git.anatoly.burakov@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<d3fbc63947e84c79085e22971acf0c38ba869856.1559147228.git.anatoly.burakov@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/d3fbc63947e84c79085e22971acf0c38ba869856.1559147228.git.anatoly.burakov@intel.com", "date": "2019-05-29T16:31:01", "name": "[15/25] lpm: use new tailq locking API", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "fd26f70178ae3e44d46fed0a0b00e6658414149b", "submitter": { "id": 4, "url": "http://patches.dpdk.org/api/people/4/?format=api", "name": "Anatoly Burakov", "email": "anatoly.burakov@intel.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/d3fbc63947e84c79085e22971acf0c38ba869856.1559147228.git.anatoly.burakov@intel.com/mbox/", "series": [ { "id": 4813, "url": "http://patches.dpdk.org/api/series/4813/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4813", "date": "2019-05-29T16:30:46", "name": "Make shared memory config non-public", "version": 1, "mbox": "http://patches.dpdk.org/series/4813/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/53843/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/53843/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id B499D1B9E2;\n\tWed, 29 May 2019 18:31:48 +0200 (CEST)", "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n\tby dpdk.org (Postfix) with ESMTP id 7D42E1B9C9\n\tfor <dev@dpdk.org>; Wed, 29 May 2019 18:31:41 +0200 (CEST)", "from orsmga005.jf.intel.com ([10.7.209.41])\n\tby fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t29 May 2019 09:31:41 -0700", "from silpixa00399498.ir.intel.com (HELO\n\tsilpixa00399498.ger.corp.intel.com) ([10.237.223.125])\n\tby orsmga005.jf.intel.com with ESMTP; 29 May 2019 09:31:38 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Anatoly Burakov <anatoly.burakov@intel.com>", "To": "dev@dpdk.org", "Cc": "Bruce Richardson <bruce.richardson@intel.com>,\n\tVladimir Medvedkin <vladimir.medvedkin@intel.com>,\n\tstephen@networkplumber.org, thomas@monjalon.net,\n\tdavid.marchand@redhat.com", "Date": "Wed, 29 May 2019 17:31:01 +0100", "Message-Id": "<d3fbc63947e84c79085e22971acf0c38ba869856.1559147228.git.anatoly.burakov@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": [ "<cover.1559147228.git.anatoly.burakov@intel.com>", "<cover.1559147228.git.anatoly.burakov@intel.com>" ], "References": [ "<cover.1559147228.git.anatoly.burakov@intel.com>", "<cover.1559147228.git.anatoly.burakov@intel.com>" ], "Subject": "[dpdk-dev] [PATCH 15/25] lpm: use new tailq locking API", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Replace usages of direct access to shared memory config with\ncalls to the new API.\n\nSigned-off-by: Anatoly Burakov <anatoly.burakov@intel.com>\n---\n lib/librte_lpm/rte_lpm.c | 24 ++++++++++++------------\n lib/librte_lpm/rte_lpm6.c | 14 +++++++-------\n 2 files changed, 19 insertions(+), 19 deletions(-)", "diff": "diff --git a/lib/librte_lpm/rte_lpm.c b/lib/librte_lpm/rte_lpm.c\nindex 6b7b28a2e..bb1c5b197 100644\n--- a/lib/librte_lpm/rte_lpm.c\n+++ b/lib/librte_lpm/rte_lpm.c\n@@ -97,13 +97,13 @@ rte_lpm_find_existing_v20(const char *name)\n \n \tlpm_list = RTE_TAILQ_CAST(rte_lpm_tailq.head, rte_lpm_list);\n \n-\trte_rwlock_read_lock(RTE_EAL_TAILQ_RWLOCK);\n+\trte_eal_mcfg_tailq_read_lock();\n \tTAILQ_FOREACH(te, lpm_list, next) {\n \t\tl = te->data;\n \t\tif (strncmp(name, l->name, RTE_LPM_NAMESIZE) == 0)\n \t\t\tbreak;\n \t}\n-\trte_rwlock_read_unlock(RTE_EAL_TAILQ_RWLOCK);\n+\trte_eal_mcfg_tailq_read_unlock();\n \n \tif (te == NULL) {\n \t\trte_errno = ENOENT;\n@@ -123,13 +123,13 @@ rte_lpm_find_existing_v1604(const char *name)\n \n \tlpm_list = RTE_TAILQ_CAST(rte_lpm_tailq.head, rte_lpm_list);\n \n-\trte_rwlock_read_lock(RTE_EAL_TAILQ_RWLOCK);\n+\trte_eal_mcfg_tailq_read_lock();\n \tTAILQ_FOREACH(te, lpm_list, next) {\n \t\tl = te->data;\n \t\tif (strncmp(name, l->name, RTE_LPM_NAMESIZE) == 0)\n \t\t\tbreak;\n \t}\n-\trte_rwlock_read_unlock(RTE_EAL_TAILQ_RWLOCK);\n+\trte_eal_mcfg_tailq_read_unlock();\n \n \tif (te == NULL) {\n \t\trte_errno = ENOENT;\n@@ -170,7 +170,7 @@ rte_lpm_create_v20(const char *name, int socket_id, int max_rules,\n \t/* Determine the amount of memory to allocate. */\n \tmem_size = sizeof(*lpm) + (sizeof(lpm->rules_tbl[0]) * max_rules);\n \n-\trte_rwlock_write_lock(RTE_EAL_TAILQ_RWLOCK);\n+\trte_eal_mcfg_tailq_write_lock();\n \n \t/* guarantee there's no existing */\n \tTAILQ_FOREACH(te, lpm_list, next) {\n@@ -212,7 +212,7 @@ rte_lpm_create_v20(const char *name, int socket_id, int max_rules,\n \tTAILQ_INSERT_TAIL(lpm_list, te, next);\n \n exit:\n-\trte_rwlock_write_unlock(RTE_EAL_TAILQ_RWLOCK);\n+\trte_eal_mcfg_tailq_write_unlock();\n \n \treturn lpm;\n }\n@@ -247,7 +247,7 @@ rte_lpm_create_v1604(const char *name, int socket_id,\n \ttbl8s_size = (sizeof(struct rte_lpm_tbl_entry) *\n \t\t\tRTE_LPM_TBL8_GROUP_NUM_ENTRIES * config->number_tbl8s);\n \n-\trte_rwlock_write_lock(RTE_EAL_TAILQ_RWLOCK);\n+\trte_eal_mcfg_tailq_write_lock();\n \n \t/* guarantee there's no existing */\n \tTAILQ_FOREACH(te, lpm_list, next) {\n@@ -315,7 +315,7 @@ rte_lpm_create_v1604(const char *name, int socket_id,\n \tTAILQ_INSERT_TAIL(lpm_list, te, next);\n \n exit:\n-\trte_rwlock_write_unlock(RTE_EAL_TAILQ_RWLOCK);\n+\trte_eal_mcfg_tailq_write_unlock();\n \n \treturn lpm;\n }\n@@ -339,7 +339,7 @@ rte_lpm_free_v20(struct rte_lpm_v20 *lpm)\n \n \tlpm_list = RTE_TAILQ_CAST(rte_lpm_tailq.head, rte_lpm_list);\n \n-\trte_rwlock_write_lock(RTE_EAL_TAILQ_RWLOCK);\n+\trte_eal_mcfg_tailq_write_lock();\n \n \t/* find our tailq entry */\n \tTAILQ_FOREACH(te, lpm_list, next) {\n@@ -349,7 +349,7 @@ rte_lpm_free_v20(struct rte_lpm_v20 *lpm)\n \tif (te != NULL)\n \t\tTAILQ_REMOVE(lpm_list, te, next);\n \n-\trte_rwlock_write_unlock(RTE_EAL_TAILQ_RWLOCK);\n+\trte_eal_mcfg_tailq_write_unlock();\n \n \trte_free(lpm);\n \trte_free(te);\n@@ -368,7 +368,7 @@ rte_lpm_free_v1604(struct rte_lpm *lpm)\n \n \tlpm_list = RTE_TAILQ_CAST(rte_lpm_tailq.head, rte_lpm_list);\n \n-\trte_rwlock_write_lock(RTE_EAL_TAILQ_RWLOCK);\n+\trte_eal_mcfg_tailq_write_lock();\n \n \t/* find our tailq entry */\n \tTAILQ_FOREACH(te, lpm_list, next) {\n@@ -378,7 +378,7 @@ rte_lpm_free_v1604(struct rte_lpm *lpm)\n \tif (te != NULL)\n \t\tTAILQ_REMOVE(lpm_list, te, next);\n \n-\trte_rwlock_write_unlock(RTE_EAL_TAILQ_RWLOCK);\n+\trte_eal_mcfg_tailq_write_unlock();\n \n \trte_free(lpm->tbl8);\n \trte_free(lpm->rules_tbl);\ndiff --git a/lib/librte_lpm/rte_lpm6.c b/lib/librte_lpm/rte_lpm6.c\nindex a91803113..5fabfa3d4 100644\n--- a/lib/librte_lpm/rte_lpm6.c\n+++ b/lib/librte_lpm/rte_lpm6.c\n@@ -316,7 +316,7 @@ rte_lpm6_create(const char *name, int socket_id,\n \tmem_size = sizeof(*lpm) + (sizeof(lpm->tbl8[0]) *\n \t\t\tRTE_LPM6_TBL8_GROUP_NUM_ENTRIES * config->number_tbl8s);\n \n-\trte_rwlock_write_lock(RTE_EAL_TAILQ_RWLOCK);\n+\trte_eal_mcfg_tailq_write_lock();\n \n \t/* Guarantee there's no existing */\n \tTAILQ_FOREACH(te, lpm_list, next) {\n@@ -363,11 +363,11 @@ rte_lpm6_create(const char *name, int socket_id,\n \tte->data = (void *) lpm;\n \n \tTAILQ_INSERT_TAIL(lpm_list, te, next);\n-\trte_rwlock_write_unlock(RTE_EAL_TAILQ_RWLOCK);\n+\trte_eal_mcfg_tailq_write_unlock();\n \treturn lpm;\n \n fail:\n-\trte_rwlock_write_unlock(RTE_EAL_TAILQ_RWLOCK);\n+\trte_eal_mcfg_tailq_write_unlock();\n \n fail_wo_unlock:\n \trte_free(tbl8_hdrs);\n@@ -389,13 +389,13 @@ rte_lpm6_find_existing(const char *name)\n \n \tlpm_list = RTE_TAILQ_CAST(rte_lpm6_tailq.head, rte_lpm6_list);\n \n-\trte_rwlock_read_lock(RTE_EAL_TAILQ_RWLOCK);\n+\trte_eal_mcfg_tailq_read_lock();\n \tTAILQ_FOREACH(te, lpm_list, next) {\n \t\tl = (struct rte_lpm6 *) te->data;\n \t\tif (strncmp(name, l->name, RTE_LPM6_NAMESIZE) == 0)\n \t\t\tbreak;\n \t}\n-\trte_rwlock_read_unlock(RTE_EAL_TAILQ_RWLOCK);\n+\trte_eal_mcfg_tailq_read_unlock();\n \n \tif (te == NULL) {\n \t\trte_errno = ENOENT;\n@@ -420,7 +420,7 @@ rte_lpm6_free(struct rte_lpm6 *lpm)\n \n \tlpm_list = RTE_TAILQ_CAST(rte_lpm6_tailq.head, rte_lpm6_list);\n \n-\trte_rwlock_write_lock(RTE_EAL_TAILQ_RWLOCK);\n+\trte_eal_mcfg_tailq_write_lock();\n \n \t/* find our tailq entry */\n \tTAILQ_FOREACH(te, lpm_list, next) {\n@@ -431,7 +431,7 @@ rte_lpm6_free(struct rte_lpm6 *lpm)\n \tif (te != NULL)\n \t\tTAILQ_REMOVE(lpm_list, te, next);\n \n-\trte_rwlock_write_unlock(RTE_EAL_TAILQ_RWLOCK);\n+\trte_eal_mcfg_tailq_write_unlock();\n \n \trte_free(lpm->tbl8_hdrs);\n \trte_free(lpm->tbl8_pool);\n", "prefixes": [ "15/25" ] }